diff options
| author | Po Lu | 2023-10-27 18:44:15 +0800 |
|---|---|---|
| committer | Po Lu | 2023-10-27 18:44:15 +0800 |
| commit | bbd4385a631d0b1127a17919e767bbbb513e1dcc (patch) | |
| tree | 4db7683dbdb2017cb6349e7f07529c33b84f8b45 /src | |
| parent | fe2761cf3e3f21a9c5a73686a8e21aceb13daa78 (diff) | |
| download | emacs-bbd4385a631d0b1127a17919e767bbbb513e1dcc.tar.gz emacs-bbd4385a631d0b1127a17919e767bbbb513e1dcc.zip | |
Substitute eassert for assert throughout Android code
* src/android.c (android_init_emacs_service)
(android_init_emacs_pixmap, android_init_graphics_point)
(android_init_emacs_drawable, android_init_emacs_window)
(android_init_emacs_cursor, android_destroy_handle)
(android_create_window, android_init_android_rect_class)
(android_init_emacs_gc_class, android_begin_query):
* src/androidselect.c (android_init_emacs_clipboard)
(android_init_emacs_desktop_notification):
* src/androidterm.c (getExtractedText)
(android_get_surrounding_text_internal):
* src/androidvfs.c (android_vfs_init): Replace assert with
eassert.
Diffstat (limited to 'src')
| -rw-r--r-- | src/android.c | 32 | ||||
| -rw-r--r-- | src/androidselect.c | 6 | ||||
| -rw-r--r-- | src/androidterm.c | 19 | ||||
| -rw-r--r-- | src/androidvfs.c | 4 |
4 files changed, 30 insertions, 31 deletions
diff --git a/src/android.c b/src/android.c index 9f0e966a602..3344a773d5f 100644 --- a/src/android.c +++ b/src/android.c | |||
| @@ -1531,7 +1531,7 @@ android_init_emacs_service (void) | |||
| 1531 | = (*android_java_env)->GetMethodID (android_java_env, \ | 1531 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 1532 | service_class.class, \ | 1532 | service_class.class, \ |
| 1533 | name, signature); \ | 1533 | name, signature); \ |
| 1534 | assert (service_class.c_name); | 1534 | eassert (service_class.c_name); |
| 1535 | 1535 | ||
| 1536 | FIND_METHOD (fill_rectangle, "fillRectangle", | 1536 | FIND_METHOD (fill_rectangle, "fillRectangle", |
| 1537 | "(Lorg/gnu/emacs/EmacsDrawable;" | 1537 | "(Lorg/gnu/emacs/EmacsDrawable;" |
| @@ -1647,7 +1647,7 @@ android_init_emacs_pixmap (void) | |||
| 1647 | = (*android_java_env)->GetMethodID (android_java_env, \ | 1647 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 1648 | pixmap_class.class, \ | 1648 | pixmap_class.class, \ |
| 1649 | name, signature); \ | 1649 | name, signature); \ |
| 1650 | assert (pixmap_class.c_name); | 1650 | eassert (pixmap_class.c_name); |
| 1651 | 1651 | ||
| 1652 | FIND_METHOD (constructor_mutable, "<init>", "(SIII)V"); | 1652 | FIND_METHOD (constructor_mutable, "<init>", "(SIII)V"); |
| 1653 | 1653 | ||
| @@ -1678,7 +1678,7 @@ android_init_graphics_point (void) | |||
| 1678 | = (*android_java_env)->GetMethodID (android_java_env, \ | 1678 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 1679 | point_class.class, \ | 1679 | point_class.class, \ |
| 1680 | name, signature); \ | 1680 | name, signature); \ |
| 1681 | assert (point_class.c_name); | 1681 | eassert (point_class.c_name); |
| 1682 | 1682 | ||
| 1683 | FIND_METHOD (constructor, "<init>", "(II)V"); | 1683 | FIND_METHOD (constructor, "<init>", "(II)V"); |
| 1684 | #undef FIND_METHOD | 1684 | #undef FIND_METHOD |
| @@ -1708,7 +1708,7 @@ android_init_emacs_drawable (void) | |||
| 1708 | = (*android_java_env)->GetMethodID (android_java_env, \ | 1708 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 1709 | drawable_class.class, \ | 1709 | drawable_class.class, \ |
| 1710 | name, signature); \ | 1710 | name, signature); \ |
| 1711 | assert (drawable_class.c_name); | 1711 | eassert (drawable_class.c_name); |
| 1712 | 1712 | ||
| 1713 | FIND_METHOD (get_bitmap, "getBitmap", "()Landroid/graphics/Bitmap;"); | 1713 | FIND_METHOD (get_bitmap, "getBitmap", "()Landroid/graphics/Bitmap;"); |
| 1714 | #undef FIND_METHOD | 1714 | #undef FIND_METHOD |
| @@ -1738,7 +1738,7 @@ android_init_emacs_window (void) | |||
| 1738 | = (*android_java_env)->GetMethodID (android_java_env, \ | 1738 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 1739 | window_class.class, \ | 1739 | window_class.class, \ |
| 1740 | name, signature); \ | 1740 | name, signature); \ |
| 1741 | assert (window_class.c_name); | 1741 | eassert (window_class.c_name); |
| 1742 | 1742 | ||
| 1743 | FIND_METHOD (swap_buffers, "swapBuffers", "()V"); | 1743 | FIND_METHOD (swap_buffers, "swapBuffers", "()V"); |
| 1744 | FIND_METHOD (toggle_on_screen_keyboard, | 1744 | FIND_METHOD (toggle_on_screen_keyboard, |
| @@ -1798,7 +1798,7 @@ android_init_emacs_cursor (void) | |||
| 1798 | = (*android_java_env)->GetMethodID (android_java_env, \ | 1798 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 1799 | cursor_class.class, \ | 1799 | cursor_class.class, \ |
| 1800 | name, signature); \ | 1800 | name, signature); \ |
| 1801 | assert (cursor_class.c_name); | 1801 | eassert (cursor_class.c_name); |
| 1802 | 1802 | ||
| 1803 | FIND_METHOD (constructor, "<init>", "(SI)V"); | 1803 | FIND_METHOD (constructor, "<init>", "(SI)V"); |
| 1804 | #undef FIND_METHOD | 1804 | #undef FIND_METHOD |
| @@ -2695,12 +2695,12 @@ android_destroy_handle (android_handle handle) | |||
| 2695 | class | 2695 | class |
| 2696 | = (*android_java_env)->FindClass (android_java_env, | 2696 | = (*android_java_env)->FindClass (android_java_env, |
| 2697 | "org/gnu/emacs/EmacsHandleObject"); | 2697 | "org/gnu/emacs/EmacsHandleObject"); |
| 2698 | assert (class != NULL); | 2698 | eassert (class != NULL); |
| 2699 | 2699 | ||
| 2700 | method | 2700 | method |
| 2701 | = (*android_java_env)->GetMethodID (android_java_env, class, | 2701 | = (*android_java_env)->GetMethodID (android_java_env, class, |
| 2702 | "destroyHandle", "()V"); | 2702 | "destroyHandle", "()V"); |
| 2703 | assert (method != NULL); | 2703 | eassert (method != NULL); |
| 2704 | 2704 | ||
| 2705 | old = class; | 2705 | old = class; |
| 2706 | class | 2706 | class |
| @@ -2843,13 +2843,13 @@ android_create_window (android_window parent, int x, int y, | |||
| 2843 | { | 2843 | { |
| 2844 | class = (*android_java_env)->FindClass (android_java_env, | 2844 | class = (*android_java_env)->FindClass (android_java_env, |
| 2845 | "org/gnu/emacs/EmacsWindow"); | 2845 | "org/gnu/emacs/EmacsWindow"); |
| 2846 | assert (class != NULL); | 2846 | eassert (class != NULL); |
| 2847 | 2847 | ||
| 2848 | constructor | 2848 | constructor |
| 2849 | = (*android_java_env)->GetMethodID (android_java_env, class, "<init>", | 2849 | = (*android_java_env)->GetMethodID (android_java_env, class, "<init>", |
| 2850 | "(SLorg/gnu/emacs/EmacsWindow;" | 2850 | "(SLorg/gnu/emacs/EmacsWindow;" |
| 2851 | "IIIIZ)V"); | 2851 | "IIIIZ)V"); |
| 2852 | assert (constructor != NULL); | 2852 | eassert (constructor != NULL); |
| 2853 | 2853 | ||
| 2854 | old = class; | 2854 | old = class; |
| 2855 | class = (*android_java_env)->NewGlobalRef (android_java_env, class); | 2855 | class = (*android_java_env)->NewGlobalRef (android_java_env, class); |
| @@ -2925,12 +2925,12 @@ android_init_android_rect_class (void) | |||
| 2925 | android_rect_class | 2925 | android_rect_class |
| 2926 | = (*android_java_env)->FindClass (android_java_env, | 2926 | = (*android_java_env)->FindClass (android_java_env, |
| 2927 | "android/graphics/Rect"); | 2927 | "android/graphics/Rect"); |
| 2928 | assert (android_rect_class); | 2928 | eassert (android_rect_class); |
| 2929 | 2929 | ||
| 2930 | android_rect_constructor | 2930 | android_rect_constructor |
| 2931 | = (*android_java_env)->GetMethodID (android_java_env, android_rect_class, | 2931 | = (*android_java_env)->GetMethodID (android_java_env, android_rect_class, |
| 2932 | "<init>", "(IIII)V"); | 2932 | "<init>", "(IIII)V"); |
| 2933 | assert (emacs_gc_constructor); | 2933 | eassert (emacs_gc_constructor); |
| 2934 | 2934 | ||
| 2935 | old = android_rect_class; | 2935 | old = android_rect_class; |
| 2936 | android_rect_class | 2936 | android_rect_class |
| @@ -2952,19 +2952,19 @@ android_init_emacs_gc_class (void) | |||
| 2952 | emacs_gc_class | 2952 | emacs_gc_class |
| 2953 | = (*android_java_env)->FindClass (android_java_env, | 2953 | = (*android_java_env)->FindClass (android_java_env, |
| 2954 | "org/gnu/emacs/EmacsGC"); | 2954 | "org/gnu/emacs/EmacsGC"); |
| 2955 | assert (emacs_gc_class); | 2955 | eassert (emacs_gc_class); |
| 2956 | 2956 | ||
| 2957 | emacs_gc_constructor | 2957 | emacs_gc_constructor |
| 2958 | = (*android_java_env)->GetMethodID (android_java_env, | 2958 | = (*android_java_env)->GetMethodID (android_java_env, |
| 2959 | emacs_gc_class, | 2959 | emacs_gc_class, |
| 2960 | "<init>", "(S)V"); | 2960 | "<init>", "(S)V"); |
| 2961 | assert (emacs_gc_constructor); | 2961 | eassert (emacs_gc_constructor); |
| 2962 | 2962 | ||
| 2963 | emacs_gc_mark_dirty | 2963 | emacs_gc_mark_dirty |
| 2964 | = (*android_java_env)->GetMethodID (android_java_env, | 2964 | = (*android_java_env)->GetMethodID (android_java_env, |
| 2965 | emacs_gc_class, | 2965 | emacs_gc_class, |
| 2966 | "markDirty", "(Z)V"); | 2966 | "markDirty", "(Z)V"); |
| 2967 | assert (emacs_gc_mark_dirty); | 2967 | eassert (emacs_gc_mark_dirty); |
| 2968 | 2968 | ||
| 2969 | old = emacs_gc_class; | 2969 | old = emacs_gc_class; |
| 2970 | emacs_gc_class | 2970 | emacs_gc_class |
| @@ -6667,7 +6667,7 @@ android_begin_query (void) | |||
| 6667 | if (old == 1) | 6667 | if (old == 1) |
| 6668 | { | 6668 | { |
| 6669 | /* Answer the query that is currently being made. */ | 6669 | /* Answer the query that is currently being made. */ |
| 6670 | assert (android_query_function != NULL); | 6670 | eassert (android_query_function != NULL); |
| 6671 | android_answer_query (); | 6671 | android_answer_query (); |
| 6672 | } | 6672 | } |
| 6673 | 6673 | ||
diff --git a/src/androidselect.c b/src/androidselect.c index 3f025351093..f7988db0520 100644 --- a/src/androidselect.c +++ b/src/androidselect.c | |||
| @@ -90,7 +90,7 @@ android_init_emacs_clipboard (void) | |||
| 90 | = (*android_java_env)->GetMethodID (android_java_env, \ | 90 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 91 | clipboard_class.class, \ | 91 | clipboard_class.class, \ |
| 92 | name, signature); \ | 92 | name, signature); \ |
| 93 | assert (clipboard_class.c_name); | 93 | eassert (clipboard_class.c_name); |
| 94 | 94 | ||
| 95 | FIND_METHOD (set_clipboard, "setClipboard", "([B)V"); | 95 | FIND_METHOD (set_clipboard, "setClipboard", "([B)V"); |
| 96 | FIND_METHOD (owns_clipboard, "ownsClipboard", "()I"); | 96 | FIND_METHOD (owns_clipboard, "ownsClipboard", "()I"); |
| @@ -107,7 +107,7 @@ android_init_emacs_clipboard (void) | |||
| 107 | "makeClipboard", | 107 | "makeClipboard", |
| 108 | "()Lorg/gnu/emacs/" | 108 | "()Lorg/gnu/emacs/" |
| 109 | "EmacsClipboard;"); | 109 | "EmacsClipboard;"); |
| 110 | assert (clipboard_class.make_clipboard); | 110 | eassert (clipboard_class.make_clipboard); |
| 111 | 111 | ||
| 112 | #undef FIND_METHOD | 112 | #undef FIND_METHOD |
| 113 | } | 113 | } |
| @@ -511,7 +511,7 @@ android_init_emacs_desktop_notification (void) | |||
| 511 | = (*android_java_env)->GetMethodID (android_java_env, \ | 511 | = (*android_java_env)->GetMethodID (android_java_env, \ |
| 512 | notification_class.class, \ | 512 | notification_class.class, \ |
| 513 | name, signature); \ | 513 | name, signature); \ |
| 514 | assert (notification_class.c_name); | 514 | eassert (notification_class.c_name); |
| 515 | 515 | ||
| 516 | FIND_METHOD (init, "<init>", "(Ljava/lang/String;" | 516 | FIND_METHOD (init, "<init>", "(Ljava/lang/String;" |
| 517 | "Ljava/lang/String;Ljava/lang/String;" | 517 | "Ljava/lang/String;Ljava/lang/String;" |
diff --git a/src/androidterm.c b/src/androidterm.c index 9d6517cce2b..e87f7ca2d14 100644 --- a/src/androidterm.c +++ b/src/androidterm.c | |||
| @@ -21,7 +21,6 @@ along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. */ | |||
| 21 | #include <stdio.h> | 21 | #include <stdio.h> |
| 22 | #include <math.h> | 22 | #include <math.h> |
| 23 | #include <stdlib.h> | 23 | #include <stdlib.h> |
| 24 | #include <assert.h> | ||
| 25 | #include <semaphore.h> | 24 | #include <semaphore.h> |
| 26 | 25 | ||
| 27 | #include "lisp.h" | 26 | #include "lisp.h" |
| @@ -5602,15 +5601,15 @@ NATIVE_NAME (getExtractedText) (JNIEnv *env, jobject ignored_object, | |||
| 5602 | class | 5601 | class |
| 5603 | = (*env)->FindClass (env, ("android/view/inputmethod" | 5602 | = (*env)->FindClass (env, ("android/view/inputmethod" |
| 5604 | "/ExtractedTextRequest")); | 5603 | "/ExtractedTextRequest")); |
| 5605 | assert (class); | 5604 | eassert (class); |
| 5606 | 5605 | ||
| 5607 | request_class.hint_max_chars | 5606 | request_class.hint_max_chars |
| 5608 | = (*env)->GetFieldID (env, class, "hintMaxChars", "I"); | 5607 | = (*env)->GetFieldID (env, class, "hintMaxChars", "I"); |
| 5609 | assert (request_class.hint_max_chars); | 5608 | eassert (request_class.hint_max_chars); |
| 5610 | 5609 | ||
| 5611 | request_class.token | 5610 | request_class.token |
| 5612 | = (*env)->GetFieldID (env, class, "token", "I"); | 5611 | = (*env)->GetFieldID (env, class, "token", "I"); |
| 5613 | assert (request_class.token); | 5612 | eassert (request_class.token); |
| 5614 | 5613 | ||
| 5615 | request_class.initialized = true; | 5614 | request_class.initialized = true; |
| 5616 | } | 5615 | } |
| @@ -5620,12 +5619,12 @@ NATIVE_NAME (getExtractedText) (JNIEnv *env, jobject ignored_object, | |||
| 5620 | text_class.class | 5619 | text_class.class |
| 5621 | = (*env)->FindClass (env, ("android/view/inputmethod" | 5620 | = (*env)->FindClass (env, ("android/view/inputmethod" |
| 5622 | "/ExtractedText")); | 5621 | "/ExtractedText")); |
| 5623 | assert (text_class.class); | 5622 | eassert (text_class.class); |
| 5624 | 5623 | ||
| 5625 | class | 5624 | class |
| 5626 | = text_class.class | 5625 | = text_class.class |
| 5627 | = (*env)->NewGlobalRef (env, text_class.class); | 5626 | = (*env)->NewGlobalRef (env, text_class.class); |
| 5628 | assert (text_class.class); | 5627 | eassert (text_class.class); |
| 5629 | 5628 | ||
| 5630 | text_class.flags | 5629 | text_class.flags |
| 5631 | = (*env)->GetFieldID (env, class, "flags", "I"); | 5630 | = (*env)->GetFieldID (env, class, "flags", "I"); |
| @@ -5924,7 +5923,7 @@ android_get_surrounding_text_internal (JNIEnv *env, jshort window, | |||
| 5924 | return NULL; | 5923 | return NULL; |
| 5925 | } | 5924 | } |
| 5926 | #else /* __ANDROID_API__ >= 31 */ | 5925 | #else /* __ANDROID_API__ >= 31 */ |
| 5927 | assert (class); | 5926 | eassert (class); |
| 5928 | #endif /* __ANDROID_API__ < 31 */ | 5927 | #endif /* __ANDROID_API__ < 31 */ |
| 5929 | 5928 | ||
| 5930 | class = (*env)->NewGlobalRef (env, class); | 5929 | class = (*env)->NewGlobalRef (env, class); |
| @@ -5936,7 +5935,7 @@ android_get_surrounding_text_internal (JNIEnv *env, jshort window, | |||
| 5936 | /* Now look for its constructor. */ | 5935 | /* Now look for its constructor. */ |
| 5937 | constructor = (*env)->GetMethodID (env, class, "<init>", | 5936 | constructor = (*env)->GetMethodID (env, class, "<init>", |
| 5938 | "(Ljava/lang/CharSequence;III)V"); | 5937 | "(Ljava/lang/CharSequence;III)V"); |
| 5939 | assert (constructor); | 5938 | eassert (constructor); |
| 5940 | } | 5939 | } |
| 5941 | 5940 | ||
| 5942 | context.before_length = before_length; | 5941 | context.before_length = before_length; |
| @@ -6032,7 +6031,7 @@ NATIVE_NAME (takeSnapshot) (JNIEnv *env, jobject object, jshort window) | |||
| 6032 | return NULL; | 6031 | return NULL; |
| 6033 | } | 6032 | } |
| 6034 | #else /* __ANDROID_API__ >= 33 */ | 6033 | #else /* __ANDROID_API__ >= 33 */ |
| 6035 | assert (class); | 6034 | eassert (class); |
| 6036 | #endif /* __ANDROID_API__ < 33 */ | 6035 | #endif /* __ANDROID_API__ < 33 */ |
| 6037 | 6036 | ||
| 6038 | class = (*env)->NewGlobalRef (env, class); | 6037 | class = (*env)->NewGlobalRef (env, class); |
| @@ -6044,7 +6043,7 @@ NATIVE_NAME (takeSnapshot) (JNIEnv *env, jobject object, jshort window) | |||
| 6044 | constructor = (*env)->GetMethodID (env, class, "<init>", | 6043 | constructor = (*env)->GetMethodID (env, class, "<init>", |
| 6045 | "(Landroid/view/inputmethod" | 6044 | "(Landroid/view/inputmethod" |
| 6046 | "/SurroundingText;III)V"); | 6045 | "/SurroundingText;III)V"); |
| 6047 | assert (constructor); | 6046 | eassert (constructor); |
| 6048 | } | 6047 | } |
| 6049 | 6048 | ||
| 6050 | /* Try to create a TextSnapshot object. */ | 6049 | /* Try to create a TextSnapshot object. */ |
diff --git a/src/androidvfs.c b/src/androidvfs.c index f89a82cfcc6..b3d644e21a2 100644 --- a/src/androidvfs.c +++ b/src/androidvfs.c | |||
| @@ -6557,12 +6557,12 @@ android_vfs_init (JNIEnv *env, jobject manager) | |||
| 6557 | 6557 | ||
| 6558 | /* Initialize some required classes. */ | 6558 | /* Initialize some required classes. */ |
| 6559 | java_string_class = (*env)->FindClass (env, "java/lang/String"); | 6559 | java_string_class = (*env)->FindClass (env, "java/lang/String"); |
| 6560 | assert (java_string_class); | 6560 | eassert (java_string_class); |
| 6561 | 6561 | ||
| 6562 | old = java_string_class; | 6562 | old = java_string_class; |
| 6563 | java_string_class = (jclass) (*env)->NewGlobalRef (env, | 6563 | java_string_class = (jclass) (*env)->NewGlobalRef (env, |
| 6564 | java_string_class); | 6564 | java_string_class); |
| 6565 | assert (java_string_class); | 6565 | eassert (java_string_class); |
| 6566 | (*env)->DeleteLocalRef (env, old); | 6566 | (*env)->DeleteLocalRef (env, old); |
| 6567 | 6567 | ||
| 6568 | /* And initialize those used on Android 5.0 and later. */ | 6568 | /* And initialize those used on Android 5.0 and later. */ |