diff options
| author | Po Lu | 2024-05-09 14:58:45 +0800 |
|---|---|---|
| committer | Po Lu | 2024-05-09 15:07:22 +0800 |
| commit | 67ab6bcdbac572a6266d7c9d15833bd2ddd049fa (patch) | |
| tree | 3469eaa3f625da33e3c5c5e0e91cc5c202552c81 /src/pgtkfns.c | |
| parent | 9b7dd30807ed4be9afe4f66cfa5130aa7d178989 (diff) | |
| download | emacs-67ab6bcdbac572a6266d7c9d15833bd2ddd049fa.tar.gz emacs-67ab6bcdbac572a6266d7c9d15833bd2ddd049fa.zip | |
Replace calls to intern with a constant string with DEFSYMs
* src/alloc.c (display_malloc_warning, syms_of_alloc):
* src/buffer.c (Fmake_indirect_buffer, Fbuffer_local_variables)
(Frename_buffer, Fkill_buffer, Fset_buffer_major_mode)
(Fset_buffer_multibyte, syms_of_buffer):
* src/callint.c (read_file_name, Fcall_interactively)
(syms_of_callint):
* src/callproc.c (call_process, create_temp_file)
(syms_of_callproc):
* src/charset.c (Fdefine_charset_internal, syms_of_charset):
* src/cmds.c (internal_self_insert, syms_of_cmds):
* src/coding.c (record_conversion_result)
(Fdefine_coding_system_internal, syms_of_coding):
* src/dbusbind.c (xd_signature, Fdbus_message_internal)
(syms_of_dbusbind):
* src/dispnew.c (init_faces_initial):
* src/doc.c (Fsnarf_documentation, syms_of_doc):
* src/dosfns.c (system_process_attributes, syms_of_dosfns):
* src/emacs.c (init_cmdargs, Fdump_emacs, decode_env_path)
(syms_of_emacs):
* src/eval.c (call_debugger, Fdefvaralias, syms_of_eval):
* src/fileio.c (barf_or_query_if_file_exists)
(Finsert_file_contents, auto_save_error, Fdo_auto_save)
(syms_of_fileio):
* src/filelock.c (lock_file_1, syms_of_filelock):
* src/fontset.c (fontset_from_font, syms_of_fontset):
* src/frame.c (make_frame_without_minibuffer, syms_of_frame):
* src/gnutls.c (emacs_gnutls_certificate_details)
(Fgnutls_peer_status_warning_describe, Fgnutls_peer_status)
(gnutls_verify_boot, syms_of_gnutls):
* src/gtkutil.c (style_changed_cb, find_rtl_image):
* src/image.c (imagemagick_filename_hint, gs_load)
(syms_of_image):
* src/keyboard.c (command_loop_1, read_char, timer_start_idle)
(read_char_minibuf_menu_prompt, Fsuspend_emacs)
(syms_of_keyboard):
* src/keymap.c (Fmap_keymap, Flookup_key, Fdescribe_vector)
(describe_vector, syms_of_keymap):
* src/lread.c (Fread, Fread_positioning_symbols, syms_of_lread):
* src/minibuf.c (Fabort_minibuffers, Fread_buffer)
(Fcompleting_read, syms_of_minibuf):
* src/msdos.c (XMenuActivate, run_msdos_command, syms_of_msdos):
* src/nsfns.m (Fx_display_backing_store, Fx_display_visual_class)
(Fns_hide_emacs, Fsystem_move_file_to_trash, ns_create_tip_frame)
(x_hide_tip, Fx_show_tip, syms_of_nsfns):
* src/nsfont.m (ns_spec_to_descriptor, ns_descriptor_to_entity)
(syms_of_nsfont):
* src/pdumper.c (Fdump_emacs_portable):
* src/pgtkfns.c (Fx_display_visual_class, x_create_tip_frame)
(Fx_show_tip, syms_of_pgtkfns):
* src/pgtkterm.c (syms_of_pgtkterm, pgtk_cr_export_frames):
* src/term.c (term_get_fkeys_1, set_tty_color_mode, Fsuspend_tty)
(Fresume_tty, tty_menu_activate, syms_of_term):
* src/terminal.c (create_terminal, syms_of_terminal):
* src/w32fns.c (Fx_display_backing_store)
(Fx_display_visual_class, Fset_message_beep, Fx_open_connection)
(Fx_show_tip, Fx_file_dialog, Fsystem_move_file_to_trash)
(Fw32_toggle_lock_key, syms_of_w32fns):
* src/w32font.c (w32_enumfont_pattern_entity, syms_of_w32font):
* src/w32term.c (w32_bitmap_icon, syms_of_w32term):
* src/xdisp.c (message_dolog, define_frame_cursor1)
(syms_of_xdisp):
* src/xfaces.c (tty_lookup_color, syms_of_xfaces):
* src/xml.c (make_dom, syms_of_xml):
* src/xterm.c (syms_of_xterm):
* src/xwidget.c (store_xwidget_download_callback_event)
(store_xwidget_js_callback_event, syms_of_xwidget): Define
symbols for symbols interned with `intern' from a constant
string, delete duplicate DEFSYM directives, and substitute them
for such calls to intern. This excludes only those symbols
which are interned and referenced only once during Emacs's
initialization, the timing of whose interning is
inconsequential, and symbols in w32.c, which would need to be
transferred to a new syms_of_w32 function that I cannot test.
Diffstat (limited to 'src/pgtkfns.c')
| -rw-r--r-- | src/pgtkfns.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/pgtkfns.c b/src/pgtkfns.c index f43eed6ad23..6a8efb6d0bf 100644 --- a/src/pgtkfns.c +++ b/src/pgtkfns.c | |||
| @@ -2148,7 +2148,7 @@ If omitted or nil, that stands for the selected frame's display. | |||
| 2148 | On PGTK, always return true-color. */) | 2148 | On PGTK, always return true-color. */) |
| 2149 | (Lisp_Object terminal) | 2149 | (Lisp_Object terminal) |
| 2150 | { | 2150 | { |
| 2151 | return intern ("true-color"); | 2151 | return Qtrue_color; |
| 2152 | } | 2152 | } |
| 2153 | 2153 | ||
| 2154 | 2154 | ||
| @@ -2844,7 +2844,7 @@ x_create_tip_frame (struct pgtk_display_info *dpyinfo, Lisp_Object parms, struct | |||
| 2844 | { | 2844 | { |
| 2845 | Lisp_Object disptype; | 2845 | Lisp_Object disptype; |
| 2846 | 2846 | ||
| 2847 | disptype = intern ("color"); | 2847 | disptype = Qcolor; |
| 2848 | 2848 | ||
| 2849 | if (NILP (Fframe_parameter (frame, Qdisplay_type))) | 2849 | if (NILP (Fframe_parameter (frame, Qdisplay_type))) |
| 2850 | { | 2850 | { |
| @@ -3391,8 +3391,7 @@ Text larger than the specified size is clipped. */) | |||
| 3391 | 3391 | ||
| 3392 | start_timer: | 3392 | start_timer: |
| 3393 | /* Let the tip disappear after timeout seconds. */ | 3393 | /* Let the tip disappear after timeout seconds. */ |
| 3394 | tip_timer = call3 (intern ("run-at-time"), timeout, Qnil, | 3394 | tip_timer = call3 (Qrun_at_time, timeout, Qnil, Qx_hide_tip); |
| 3395 | intern ("x-hide-tip")); | ||
| 3396 | 3395 | ||
| 3397 | return unbind_to (count, Qnil); | 3396 | return unbind_to (count, Qnil); |
| 3398 | } | 3397 | } |
| @@ -3967,4 +3966,8 @@ syms_of_pgtkfns (void) | |||
| 3967 | DEFSYM (Qlandscape, "landscape"); | 3966 | DEFSYM (Qlandscape, "landscape"); |
| 3968 | DEFSYM (Qreverse_portrait, "reverse-portrait"); | 3967 | DEFSYM (Qreverse_portrait, "reverse-portrait"); |
| 3969 | DEFSYM (Qreverse_landscape, "reverse-landscape"); | 3968 | DEFSYM (Qreverse_landscape, "reverse-landscape"); |
| 3969 | DEFSYM (Qtrue_color, "true-color"); | ||
| 3970 | DEFSYM (Qcolor, "color"); | ||
| 3971 | DEFSYM (Qrun_at_time, "run-at-time"); | ||
| 3972 | DEFSYM (Qx_hide_tip, "x-hide-tip"); | ||
| 3970 | } | 3973 | } |