Correct local reference leaks

* src/android.c (android_build_string): Accept a list of local
references to destroy upon an allocation failure, facilitating
the proper deallocation of local references in such situations.
(android_browse_url): Revise for new calling convention.

* src/android.h (android_build_string): Update declaration
correspondingly.

* src/androidmenu.c (android_menu_show, android_dialog_show):
Revise for new calling convention.

* src/androidselect.c (android_notifications_notify_1): Supply
each successive local reference to android_build_string as
notification text is being encoded.

* src/androidvfs.c (android_saf_exception_check): Introduce
absent va_end.

1 files changed, 8 insertions, 8 deletions

diff --git a/src/androidmenu.c b/src/androidmenu.c
index ed26bdafa85..1f4d91b527d 100644
--- a/src/androidmenu.c
+++ b/src/androidmenu.c
@@ -278,7 +278,7 @@ android_menu_show (struct frame *f, int x, int y, int menuflags,
 
   title_string = NULL;
   if (STRINGP (title) && menu_items_n_panes < 2)
-    title_string = android_build_string (title);
+    title_string = android_build_string (title, NULL);
 
   /* Push the first local frame for the context menu.  */
   method = menu_class.create_context_menu;
@@ -370,7 +370,7 @@ android_menu_show (struct frame *f, int x, int y, int menuflags,
             pane_name = Fsubstring (pane_name, make_fixnum (1), Qnil);
 
           /* Add the pane.  */
-          temp = android_build_string (pane_name);
+          temp = android_build_string (pane_name, NULL);
           android_exception_check ();
 
           (*env)->CallNonvirtualVoidMethod (env, current_context_menu,
@@ -399,7 +399,7 @@ android_menu_show (struct frame *f, int x, int y, int menuflags,
             {
               /* This is a submenu.  Add it.  */
               title_string = (!NILP (item_name)
-                              ? android_build_string (item_name)
+                              ? android_build_string (item_name, NULL)
                               : NULL);
               help_string = NULL;
 
@@ -408,7 +408,7 @@ android_menu_show (struct frame *f, int x, int y, int menuflags,
 
               if (android_get_current_api_level () >= 26
                   && STRINGP (help))
-                help_string = android_build_string (help);
+                help_string = android_build_string (help, NULL);
 
               store = current_context_menu;
               current_context_menu
@@ -443,7 +443,7 @@ android_menu_show (struct frame *f, int x, int y, int menuflags,
               /* Add this menu item with the appropriate state.  */
 
               title_string = (!NILP (item_name)
-                              ? android_build_string (item_name)
+                              ? android_build_string (item_name, NULL)
                               : NULL);
               help_string = NULL;
 
@@ -452,7 +452,7 @@ android_menu_show (struct frame *f, int x, int y, int menuflags,
 
               if (android_get_current_api_level () >= 26
                   && STRINGP (help))
-                help_string = android_build_string (help);
+                help_string = android_build_string (help, NULL);
 
               /* Determine whether or not to display a check box.  */
 
@@ -686,7 +686,7 @@ android_dialog_show (struct frame *f, Lisp_Object title,
                  : android_build_jstring ("Question"));
 
   /* And the title.  */
-  java_title = android_build_string (title);
+  java_title = android_build_string (title, NULL);
 
   /* Now create the dialog.  */
   method = dialog_class.create_dialog;
@@ -738,7 +738,7 @@ android_dialog_show (struct frame *f, Lisp_Object title,
             }
 
           /* Add the button.  */
-          temp = android_build_string (item_name);
+          temp = android_build_string (item_name, NULL);
           (*env)->CallNonvirtualVoidMethod (env, dialog,
                                             dialog_class.class,
                                             dialog_class.add_button,