Mps branch unfixed-summary: if poolfix fails, aver that *refio is unchanged.

Copied from Perforce
 Change: 161966
 ServerID: perforce.ravenbrook.com

1 files changed, 10 insertions, 1 deletions

diff --git a/mps/code/trace.c b/mps/code/trace.c
index b732a5d8075..ff76600689b 100644
--- a/mps/code/trace.c
+++ b/mps/code/trace.c
@@ -1285,8 +1285,17 @@ Res TraceFix(ScanState ss, Ref *refIO)
         /* Could move the rank switch here from the class-specific */
         /* fix methods. */
         res = PoolFix(pool, ss, seg, refIO);
-        if (res != ResOK)
+        if (res != ResOK) {
+          /* Fix protocol (de facto): if Fix fails, ref must be unchanged */
+          /* Justification for this restriction:
+           * A: it simplifies;
+           * B: it's reasonable (given what may cause Fix to fail);
+           * C: the code (here) already assumes this: it returns without 
+           *    updating ss->fixedSummary.  RHSK 2007-03-21.
+           */
+          AVER(*refIO == ref);
           return res;
+        }
       }
     } else {
       /* Tract isn't white. Don't compute seg for non-statistical */