diff options
| author | Richard Kistruck | 2008-11-24 16:53:12 +0000 |
|---|---|---|
| committer | Richard Kistruck | 2008-11-24 16:53:12 +0000 |
| commit | b08941eb4f592b1b661b0719b6087d79cb801275 (patch) | |
| tree | 57fafb92305259868d072237a7ca0d7339a46067 /mps/code | |
| parent | 4b6cb1e9f61a4f2810f0bdc4582e410865566c3d (diff) | |
| download | emacs-b08941eb4f592b1b661b0719b6087d79cb801275.tar.gz emacs-b08941eb4f592b1b661b0719b6087d79cb801275.zip | |
Mps br/timing: (cosmetic):
message.c: rename MessageClocked() as MessageIsClocked()
check.h: better name in future improvement comments
Copied from Perforce
Change: 166801
ServerID: perforce.ravenbrook.com
Diffstat (limited to 'mps/code')
| -rw-r--r-- | mps/code/check.h | 4 | ||||
| -rw-r--r-- | mps/code/message.c | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/mps/code/check.h b/mps/code/check.h index f5681e0bb71..e58a9d04ced 100644 --- a/mps/code/check.h +++ b/mps/code/check.h | |||
| @@ -107,7 +107,7 @@ enum { | |||
| 107 | * and <design/interface-c/#check.space>. | 107 | * and <design/interface-c/#check.space>. |
| 108 | * | 108 | * |
| 109 | * @@@@ This is a test, not a CHECK macro -- it does not assert. | 109 | * @@@@ This is a test, not a CHECK macro -- it does not assert. |
| 110 | * It should be renamed MATCHSIG. RHSK 2006-12-13. | 110 | * It should be renamed TESTSIG. RHSK 2006-12-13. |
| 111 | */ | 111 | */ |
| 112 | 112 | ||
| 113 | #define CHECKT(type, val) ((val) != NULL && (val)->sig == type ## Sig) | 113 | #define CHECKT(type, val) ((val) != NULL && (val)->sig == type ## Sig) |
| @@ -240,7 +240,7 @@ enum { | |||
| 240 | * satisfy rule.impl.trick.] | 240 | * satisfy rule.impl.trick.] |
| 241 | * | 241 | * |
| 242 | * @@@@ These are tests, not CHECK macros -- they do not assert. | 242 | * @@@@ These are tests, not CHECK macros -- they do not assert. |
| 243 | * They should be renamed MATCHTYPE etc. RHSK 2006-12-13. | 243 | * They should be renamed TESTTYPE etc. RHSK 2006-12-13. |
| 244 | */ | 244 | */ |
| 245 | 245 | ||
| 246 | /* compile-time check */ | 246 | /* compile-time check */ |
diff --git a/mps/code/message.c b/mps/code/message.c index 424b0d7ed90..75b01d328d8 100644 --- a/mps/code/message.c +++ b/mps/code/message.c | |||
| @@ -45,7 +45,7 @@ Bool MessageTypeCheck(MessageType type) | |||
| 45 | 45 | ||
| 46 | /* See .message.clocked. Currently finalization messages are the */ | 46 | /* See .message.clocked. Currently finalization messages are the */ |
| 47 | /* only ones that can be numerous. */ | 47 | /* only ones that can be numerous. */ |
| 48 | #define MessageClocked(message) ((message)->class->type \ | 48 | #define MessageIsClocked(message) ((message)->class->type \ |
| 49 | != MessageTypeFINALIZATION) | 49 | != MessageTypeFINALIZATION) |
| 50 | 50 | ||
| 51 | Bool MessageCheck(Message message) | 51 | Bool MessageCheck(Message message) |
| @@ -56,7 +56,7 @@ Bool MessageCheck(Message message) | |||
| 56 | CHECKL(RingCheck(&message->queueRing)); | 56 | CHECKL(RingCheck(&message->queueRing)); |
| 57 | /* postedClock is uncheckable for clocked message types, */ | 57 | /* postedClock is uncheckable for clocked message types, */ |
| 58 | /* but must be 0 for unclocked message types: */ | 58 | /* but must be 0 for unclocked message types: */ |
| 59 | CHECKL(MessageClocked(message) || (message->postedClock == 0)); | 59 | CHECKL(MessageIsClocked(message) || (message->postedClock == 0)); |
| 60 | 60 | ||
| 61 | return TRUE; | 61 | return TRUE; |
| 62 | } | 62 | } |
| @@ -132,7 +132,7 @@ void MessagePost(Arena arena, Message message) | |||
| 132 | /* .message.clocked: Reading the clock with ClockNow() */ | 132 | /* .message.clocked: Reading the clock with ClockNow() */ |
| 133 | /* involves an mpslib call, so we avoid it for message */ | 133 | /* involves an mpslib call, so we avoid it for message */ |
| 134 | /* types that may be numerous. */ | 134 | /* types that may be numerous. */ |
| 135 | if(MessageClocked(message)) { | 135 | if(MessageIsClocked(message)) { |
| 136 | message->postedClock = ClockNow(); | 136 | message->postedClock = ClockNow(); |
| 137 | } | 137 | } |
| 138 | RingAppend(&arena->messageRing, &message->queueRing); | 138 | RingAppend(&arena->messageRing, &message->queueRing); |