Fix review comments from <https://info.ravenbrook.com/mail/2013/05/28/22-21-11/0/>:

* Rename RangeOverlap to RangesOverlap.
* MVFF shouldn't assume that CBSInsert and CBSDelete can't fail.
* Remove unused function mps_mvff_stat.
* Don't call range methods in RangeCheck.
* RangeInit can't fail, so return void.

Copied from Perforce
 Change: 182297
 ServerID: perforce.ravenbrook.com

1 files changed, 4 insertions, 6 deletions

diff --git a/mps/code/range.c b/mps/code/range.c
index 739b11f5b5e..60a8b0da367 100644
--- a/mps/code/range.c
+++ b/mps/code/range.c
@@ -16,14 +16,13 @@ SRCID(range, "$Id$");
 Bool RangeCheck(Range range)
 {
   CHECKS(Range, range);
-  CHECKL(range != NULL);
-  CHECKL(RangeBase(range) != NULL);
-  CHECKL(RangeBase(range) <= RangeLimit(range));
+  CHECKL(range->base != NULL);
+  CHECKL(range->base <= range->limit);
 
   return TRUE;
 }
 
-Res RangeInit(Range range, Addr base, Addr limit)
+void RangeInit(Range range, Addr base, Addr limit)
 {
   AVER(range != NULL);
   AVER(base != NULL);
@@ -34,7 +33,6 @@ Res RangeInit(Range range, Addr base, Addr limit)
 
   range->sig = RangeSig;
   AVERT(Range, range);
-  return ResOK;
 }
 
 void RangeFinish(Range range)
@@ -64,7 +62,7 @@ Res RangeDescribe(Range range, mps_lib_FILE *stream)
   return ResOK;
 }
 
-Bool RangeOverlap(Range range1, Range range2)
+Bool RangesOverlap(Range range1, Range range2)
 {
   AVERT(Range, range1);
   AVERT(Range, range2);