Fixing bugs introduced by type puns passed through scanning methods, discovered by offsetting mps_ss_s from the beginning of scanstatestruct.

Adding a pseudo-target "find-puns" which, on FreeBSD mostly, prints useful warnings about strict aliasing rule violations.
Fixing more strict aliasing rule violations found by the above.

Copied from Perforce
 Change: 179358
 ServerID: perforce.ravenbrook.com

1 files changed, 3 insertions, 3 deletions

diff --git a/mps/code/mpmtypes.h b/mps/code/mpmtypes.h
index a15098c53ee..b1853178cbb 100644
--- a/mps/code/mpmtypes.h
+++ b/mps/code/mpmtypes.h
@@ -246,7 +246,7 @@ typedef struct TraceMessageStruct *TraceMessage;  /* trace end */
 /* .fmt-methods: These methods must match those defined in the */
 /* MPS C Interface.  (See <code/mps.h#fmt-methods>.) */
 
-typedef Res  (*FormatScanMethod)(ScanState ss, Addr base, Addr limit);
+typedef Res  (*FormatScanMethod)(mps_ss_t ss, Addr base, Addr limit);
 typedef Addr (*FormatSkipMethod)(Addr object);
 typedef void (*FormatMoveMethod)(Addr object, Addr to);
 typedef Addr (*FormatIsMovedMethod)(Addr object);
@@ -259,8 +259,8 @@ typedef Addr (*FormatClassMethod)(Addr object);
 /* .root-methods: These methods must match those defined in the */
 /* MPS C Interface.  (See <code/mps.h#root-methods>.) */
 
-typedef Res (*RootScanMethod)(ScanState ss, void *p, size_t s);
-typedef Res (*RootScanRegMethod)(ScanState ss, Thread thread, void *p, size_t s);
+typedef Res (*RootScanMethod)(mps_ss_t ss, void *p, size_t s);
+typedef Res (*RootScanRegMethod)(mps_ss_t ss, Thread thread, void *p, size_t s);
 
 
 /* CONSTANTS */