mps br/diag finalcv: (clarify only) improve hash-def names and comments.

Copied from Perforce
 Change: 162627
 ServerID: perforce.ravenbrook.com

1 files changed, 15 insertions, 13 deletions

diff --git a/mps/code/finalcv.c b/mps/code/finalcv.c
index cc7af27f9ac..8e5deaf0030 100644
--- a/mps/code/finalcv.c
+++ b/mps/code/finalcv.c
@@ -37,7 +37,11 @@
 #define finalizationRATE 6
 #define gcINTERVAL ((size_t)150 * 1024)
 #define collectionCOUNT 3
-#define slotSIZE (3*sizeof(mps_word_t))
+
+/* 3 words:  wrapper  |  vector-len  |  first-slot */
+#define vectorSIZE (3*sizeof(mps_word_t))
+#define vectorSLOT 2
+
 #define genCOUNT 2
 
 /* testChain -- generation parameters for the test */
@@ -100,6 +104,7 @@ static void *test(void *arg, size_t s)
   mps_pool_t amc;
   mps_res_t e;
   mps_root_t mps_root[2];
+  mps_addr_t nullref = NULL;
   int state[rootCOUNT];
   mps_arena_t arena;
   void *p = NULL;
@@ -121,18 +126,17 @@ static void *test(void *arg, size_t s)
   die(mps_ap_create(&ap, amc, MPS_RANK_EXACT), "ap_create\n");
 
   /* Make registered-for-finalization objects. */
-  /* .references-to-obj-0: Note that the first root ref (root[0]) is */
-  /* passed to dylan_init each time, so the root[0] object (only) */
-  /* may be referred to by other registered-for-finalization */
-  /* objects. */
   /* <design/poolmrg/#test.promise.ut.alloc> */
   for(i = 0; i < rootCOUNT; ++i) {
     do {
-      MPS_RESERVE_BLOCK(e, p, ap, slotSIZE);
+      MPS_RESERVE_BLOCK(e, p, ap, vectorSIZE);
       die(e, "MPS_RES_OK");
-      die(dylan_init(p, slotSIZE, root, 1), "dylan_init");
-    } while (!mps_commit(ap, p, slotSIZE));
-    ((mps_word_t *)p)[2] = dylan_int(i);
+      die(dylan_init(p, vectorSIZE, &nullref, 1), "dylan_init");
+    } while (!mps_commit(ap, p, vectorSIZE));
+
+    /* store index in vector's slot */
+    ((mps_word_t *)p)[vectorSLOT] = dylan_int(i);
+
     die(mps_finalize(arena, &p), "finalize\n");
     root[i] = p; state[i] = rootSTATE;
   }
@@ -160,10 +164,8 @@ static void *test(void *arg, size_t s)
             /* ...expect it to be finalized soon */
             state[i] = finalizableSTATE;
           }
-          /* Drop the root reference to it; this probably* makes it */
+          /* Drop the root reference to it; this makes it */
           /* non-E-reachable: so either dead, or ready-to-finalize. */
-          /* (*: the exception is the root[0] object, see  */
-          /* .references-to-obj-0.) */
           root[i] = NULL;
         }
       }
@@ -180,7 +182,7 @@ static void *test(void *arg, size_t s)
            "get");
       mps_message_finalization_ref(&objaddr, arena, message);
       obj = objaddr;
-      objind = dylan_int_int(obj[2]);
+      objind = dylan_int_int(obj[vectorSLOT]);
       printf("Finalizing: object %lu at %p\n", objind, objaddr);
       /* <design/poolmrg/#test.promise.ut.final.check> */
       cdie(root[objind] == NULL, "finalized live");