[Nate]: open() now saves the file data into a StringIO object, w/ added open() method.

1 files changed, 21 insertions, 1 deletions

diff --git a/django/__init__.py b/django/__init__.py
index 7386594..2ae3040 100644
--- a/django/__init__.py
+++ b/django/__init__.py
@@ -1,9 +1,21 @@
 import os
+from StringIO import StringIO
 from django.conf import settings
 from amazons3 import S3
 
 from django.core.files.storage import Storage
 
+class S3OpenFile(StringIO):
+    """
+    Wrapper for StringIO which allows open() to be called on it.
+    
+    This is for FileField form fields, which expect to be able to call open()
+    and then retrieve data from the file.
+    ** NOTE: The behavior of calling open() and then writing to the file is
+    currently unknown. **
+    """
+    def open(self, *args, **kwargs):
+        self.seek(0)
 
 class S3Error(Exception):
     "Misc. S3 Service Error"
@@ -119,7 +131,15 @@ class S3Storage(Storage):
 
     def open(self, filename, mode):
         from urllib import urlopen
-        return urlopen(self.url(filename))
+        # Download data from S3 and save 
+        # into a file wrapper, which allows its
+        # use as normal in FileFields.
+        #
+        # Note: This saves the file data into memory.
+        data = urlopen(self.url(filename))
+        openfile = S3OpenFile()
+        openfile.write(data.read())
+        return openfile 
 
     def get_available_name(self, filename):
         import os