From 89e1236e4752bd100a6e9b6fbb652c5ba0ee913a Mon Sep 17 00:00:00 2001 From: Richard Brooksby Date: Mon, 3 Sep 2012 15:32:22 +0100 Subject: Explaining why commented-out events exist in the list. Copied from Perforce Change: 179204 ServerID: perforce.ravenbrook.com --- mps/code/eventdef.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'mps/code') diff --git a/mps/code/eventdef.h b/mps/code/eventdef.h index d8edc6a2bee..346b61df5ad 100644 --- a/mps/code/eventdef.h +++ b/mps/code/eventdef.h @@ -47,6 +47,11 @@ * - Kind: Category into which this event falls, without the * leading "EventKind"; * + * When you retire an event type, don't delete it from the list -- comment + * it out. This serves as documentation for what the event code means + * in older logs, and prevents the codes being re-used. See + * . + * * TODO: Add a doc string to each event type. * * See also EVENT_*_PARAMS for definition of event parameters. @@ -55,8 +60,6 @@ #define EventNameMAX ((size_t)19) #define EventCodeMAX ((EventCode)0x0071) -/* TODO: Work out why not-in-use events were not in use and restore or delete them. */ - #define EVENT_LIST(EVENT, X) \ /* 0123456789012345678 <- don't exceed without changing EventNameMAX */ \ EVENT(X, AMCGenCreate , 0x0001, TRUE, Pool) \ -- cgit v1.2.1