From 2a65ff579e44f25e62db8a1618494f2fd5f67b32 Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Tue, 12 Mar 2013 15:15:57 +0000 Subject: Comment out all calls to mps_arena_commit_limit_set in test case amcsshe. (this test case formerly set the commit limit "in the hope of getting one dynamic collection", but this was unreliable: see job003440 for details.) Copied from Perforce Change: 181122 ServerID: perforce.ravenbrook.com --- mps/code/amcss.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'mps/code') diff --git a/mps/code/amcss.c b/mps/code/amcss.c index d51756dc24e..ee91223660f 100644 --- a/mps/code/amcss.c +++ b/mps/code/amcss.c @@ -83,9 +83,13 @@ static void report(mps_arena_t arena) if(condemned > (gen1SIZE + gen2SIZE + (size_t)128) * 1024) { /* When condemned size is larger than could happen in a gen 2 * collection (discounting ramps, natch), guess that was a dynamic - * collection, and reset the commit limit, so it doesn't run out. */ - die(mps_arena_commit_limit_set(arena, 2 * testArenaSIZE), - "set limit"); + * collection, and reset the commit limit, so it doesn't run out. + * + * GDR 2013-03-12: Fiddling with the commit limit was causing + * the test to fail sometimes (see job003440), so I've commented + * out this feature. + */ + /* die(mps_arena_commit_limit_set(arena, 2 * testArenaSIZE), "set limit"); */ } } else { @@ -306,7 +310,11 @@ int main(int argc, char *argv[]) "arena_create"); mps_message_type_enable(arena, mps_message_type_gc()); mps_message_type_enable(arena, mps_message_type_gc_start()); - die(mps_arena_commit_limit_set(arena, testArenaSIZE), "set limit"); + /* GDR 2013-03-12: Fiddling with the commit limit was causing + * the test to fail sometimes (see job003440), so I've commented + * out this feature. + */ + /*die(mps_arena_commit_limit_set(arena, testArenaSIZE), "set limit");*/ die(mps_thread_reg(&thread, arena), "thread_reg"); test(arena); mps_thread_dereg(thread); -- cgit v1.2.1