From 1712311f0084af850925f4c472f6ca186ab09c54 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Thu, 13 Aug 2020 17:13:11 +0200 Subject: * src/pdumper.c (dump_do_dump_relocation): Improve error messages. --- src/pdumper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pdumper.c b/src/pdumper.c index 83410e36774..629d0969346 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -5281,12 +5281,13 @@ dump_do_dump_relocation (const uintptr_t dump_base, struct Lisp_Native_Comp_Unit *comp_u = XNATIVE_COMP_UNIT (subr->native_comp_u[0]); if (!comp_u->handle) - error ("can't relocate native subr with not loaded compilation unit"); + error ("NULL handle in compilation unit %s", SSDATA (comp_u->file)); const char *c_name = subr->native_c_name[0]; eassert (c_name); void *func = dynlib_sym (comp_u->handle, c_name); if (!func) - error ("can't find function in compilation unit"); + error ("can't find function \"%s\" in compilation unit %s", c_name, + SSDATA (comp_u->file)); subr->function.a0 = func; Lisp_Object lambda_data_idx = Fgethash (build_string (c_name), comp_u->lambda_c_name_idx_h, Qnil); -- cgit v1.2.1 From 3882e8fd244a66edb6ba60f40182a4d0772cfcb1 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Fri, 14 Aug 2020 08:29:28 +0200 Subject: * Fix excessive echo area usage * lisp/emacs-lisp/comp.el (comp-run-async-workers): Use `with-temp-file' to fill temp-file. --- lisp/emacs-lisp/comp.el | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 599d35b61c5..a92392f63ac 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -2608,13 +2608,16 @@ display a message." (message "Compiling %s..." ,source-file) (native-compile ,source-file ,(and load t)))) (source-file1 source-file) ;; Make the closure works :/ - (_ (progn - (comp-log "\n") - (comp-log (prin1-to-string expr)))) (temp-file (make-temp-file (concat "emacs-async-comp-" (file-name-base source-file) "-") - nil ".el" (prin1-to-string expr))) + nil ".el")) + (expr-string (prin1-to-string expr)) + (_ (progn + (with-temp-file temp-file + (insert expr-string)) + (comp-log "\n") + (comp-log expr-string))) (load1 load) (process (make-process :name (concat "Compiling: " source-file) -- cgit v1.2.1