aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use a dedicated type to represent interpreted-function valuesscratch/interpreted-functionStefan Monnier2024-04-1831-275/+437
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change `function` so that when evaluating #'(lambda ...) we return an object of type `interpreted-function` rather than a list starting with one of `lambda` or `closure`. The new type reuses the existing PVEC_CLOSURE (nee PVEC_COMPILED) tag and tries to align the corresponding elements: - the arglist, the docstring, and the interactive-form go in the same slots as for byte-code functions. - the body of the function goes in the slot used for the bytecode string. - the lexical context goes in the slot used for the constants of bytecoded functions. The first point above means that `help-function-arglist`, `documentation`, and `interactive-form`s don't need to distinguish interpreted and bytecode functions any more. Main benefits of the change: - We can now reliably distinguish a list from a function value. - `cl-defmethod` can dispatch on `interactive-function` and `closure`. Dispatch on `function` also works now for interpreted functions but still won't work for functions represented as lists or as symbols, of course. - Function values are now self-evaluating. That was alrready the case when byte-compiled, but not when interpreted since (eval '(closure ...)) signals a void-function error. That also avoids false-positive warnings about "don't quote your lambdas" when doing things like `(mapcar ',func ...)`. * src/eval.c (Fmake_interpreted_closure): New function. (Ffunction): Use it and change calling convention of `Vinternal_make_interpreted_closure_function`. (FUNCTIONP, Fcommandp, eval_sub, funcall_general, funcall_lambda) (Ffunc_arity, lambda_arity): Simplify. (funcall_lambda): Adjust to new representation. (syms_of_eval): `defsubr` the new function. Remove definition of `Qclosure`. * lisp/emacs-lisp/cconv.el (cconv-make-interpreted-closure): Change calling convention and use `make-interpreted-closure`. * src/data.c (Fcl_type_of): Distinguish `byte-code-function`s from `interpreted-function`s. (Fclosurep, finterpreted_function_p): New functions. (Fbyte_code_function_p): Don't be confused by `interpreted-function`s. (Finteractive_form, Fcommand_modes): Simplify. (syms_of_data): Define new type symbols and `defsubr` the two new functions. * lisp/emacs-lisp/cl-print.el (cl-print-object) <interpreted-function>: New method. * lisp/emacs-lisp/oclosure.el (oclosure): Refine the parent to be `closure`. (oclosure--fix-type, oclosure-type): Simplify. (oclosure--copy, oclosure--get, oclosure--set): Adjust to new representation. * src/callint.c (Fcall_interactively): Adjust to new representation. * src/lread.c (bytecode_from_rev_list): * lisp/simple.el (function-documentation): * lisp/help.el (help-function-arglist): Remove the old `closure` case and adjust the byte-code case so it handles `interpreted-function`s. * lisp/emacs-lisp/cl-preloaded.el (closure): New type. (byte-code-function): Add it as a parent. (interpreted-function): Adjust parent (the type itself was already added earlier by accident). * lisp/emacs-lisp/bytecomp.el (byte-compile--reify-function): Adjust to new representation. (byte-compile): Use `interpreted-function-p`. * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Adjust to new representation. (side-effect-free-fns): Add `interpreted-function-p` and `closurep`. * src/profiler.c (trace_hash, ffunction_equal): Simplify. * lisp/profiler.el (profiler-function-equal): Simplify. * lisp/emacs-lisp/nadvice.el (advice--interactive-form-1): Use `interpreted-function-p`; adjust to new representation; and take advantage of the fact that function values are now self-evaluating. * lisp/emacs-lisp/lisp-mode.el (closure): Remove `lisp-indent-function` property. * lisp/emacs-lisp/disass.el (disassemble-internal): Adjust to new representation. * lisp/emacs-lisp/edebug.el (edebug--strip-instrumentation): Use `interpreted-function-p`. * lisp/emacs-lisp/comp-common.el (comp-known-type-specifiers): Add `closurep` and `interpreted-function-p`. * test/lisp/help-fns-tests.el (help-fns-test-lisp-defun): Adjust to more precise type info in `describe-function`. * test/lisp/erc/resources/erc-d/erc-d-tests.el (erc-d--render-entries): Use `interpreted-function-p`. * test/lisp/emacs-lisp/macroexp-resources/vk.el (vk-f4, vk-f5): Don't hardcode function values. * doc/lispref/functions.texi (Anonymous Functions): Don't suggest that function values are lists. Reword "self-quoting" to reflect the fact that #' doesn't return the exact same object. Update examples with the new shape of the return value. * doc/lispref/variables.texi (Lexical Binding): * doc/lispref/lists.texi (Rearrangement): * doc/lispref/control.texi (Handling Errors): Update examples to reflect new representation of function values.
* (COMPILED): Rename to CLOSUREStefan Monnier2024-04-1812-105/+112
| | | | | | | | | | | | | | | | | | In preparation for the use of `PVEC_COMPILED` objects for interpreted functions, rename them to use a more neutral name. * src/lisp.h (enum pvec_type): Rename `PVEC_COMPILED` to `PVEC_CLOSURE`. (enum Lisp_Compiled): Use `CLOSURE_` prefix i.s.o `COMPILED_`. Also use `CODE` rather than `BYTECODE`. (CLOSUREP): Rename from `COMPILEDP`. (enum Lisp_Closure): Rename from `Lisp_Compiled`. * src/alloc.c, src/bytecode.c, src/comp.c, src/data.c, src/eval.c, * src/fns.c, src/lisp.h, src/lread.c, src/pdumper.c, src/print.c, * src/profiler.c: Rename all uses accordingly. * src/.gdbinit (xclosure): Rename from `xcompiled`. (xcompiled): New obsolete alias. (xpr): Adjust accordingly. Also adjust to new PVEC_CLOSURE tag name.
* Better way to fix bug#70036João Távora2024-04-181-5/+12
| | | | | | | | | | | | | | Cache a new eglot--cached-tdi var per buffer, which contains value to return from eglot--TextDocumentIdentifier. This avoids frequent expensive recomputation of a value that requires potentially many 'file-truename' calls. This technique is used in a number of other cases already, like eglot--recent-changes or eglot--versioned-identifier. * lisp/progmodes/eglot.el (eglot--cached-tdi): New variable. (eglot--TextDocumentIdentifier): Tweak. (eglot--signal-textDocument/didOpen): Clear eglot--cached-tdi.
* Revert "Don't use file-truepath in Eglot (bug#70036)"João Távora2024-04-181-24/+18
| | | | | | | | | | | | | | | | | This reverts commit 08c80c45ddea17df87fc768a39dff353ccc13d3b. It introduces bugs when a project contains symlinked files. The server will be informed of duplicate documents which are really the same and it frequently has no means to deduplicate such information. This leads to bugs such as excessive textDocument/references to a function. * lisp/progmodes/eglot.el (eglot-lsp-server): Revert change. (eglot-uri-to-path): Revert change. (eglot--on-shutdown): Revert change. (eglot--managed-mode): Revert change. (eglot-handle-notification textDocument/publishDiagnostics): Revert change.
* ; Alphabetize go-ts-mode's treesit-font-lock-feature-listRandy Taylor2024-04-181-1/+1
| | | | | * lisp/progmodes/go-ts-mode.el (go-ts-mode): Rearrange features to keep alphabetical order. (Bug#70362)
* Don't error on tabbing to a widget at BOB (bug#69943)Stephen Berman2024-04-182-3/+9
| | | | | | | | | * lisp/wid-edit.el (widget-move): Don't move backward when at beginning of buffer, and keep point on widget's left side. * test/lisp/wid-edit-tests.el (widget-test-widget-move): Test that moving to a widget at beginning of buffer does not signal a beginning-of-buffer error.
* Ensure that specbind arg is always bare symbol, and drop checkMattias Engdegård2024-04-181-10/+9
| | | | | | | * src/eval.c (FletX, Flet, internal_lisp_condition_case) (funcall_lambda): Ensure that the first argument to `specbind` is a bare symbol in the few cases where this isn't statically guaranteed. (specbind): Drop the symbol argument type check on the fast path.
* Drop unnecessary type check in varref and varset byte opsMattias Engdegård2024-04-181-4/+2
| | | | | | * src/bytecode.c (exec_byte_code): We can safely assume that the immediate argument to varref and varset is a bare symbol; the byte-compiler should guarantee that.
* ; * lisp/comint.el: Fix wording of last change.Eli Zaretskii2024-04-181-1/+1
|
* Obsolete comint-osc symbols moved to ansi-osc.elAugusto Stoffel2024-04-181-11/+15
| | | | | | | * lisp/comint.el (comint-osc-handlers) (comint-osc-directory-tracker, comint-osc-hyperlink-handler) (comint-osc-hyperlink, comint-osc-hyperlink-map): Mark as obsolete. (Bug#70375)
* Add YANG LSP support to EglotSiddharth Sharma2024-04-181-1/+2
| | | | | | | * lisp/progmodes/eglot.el (eglot-server-programs): Add 'yang-language-server' and 'json-ts-mode'. (Bug#70364) Copyright-paperwork-exempt: yes
* ; Minor change in last commitEli Zaretskii2024-04-181-10/+10
| | | | | * lisp/progmodes/go-ts-mode.el (go-ts-mode--font-lock-settings): Rearrange features to keep alphabetical order. (Bug#70362)
* Add font-locking for Go built-in functions in go-ts-modeNoah Peart2024-04-181-1/+16
| | | | | | * lisp/progmodes/go-ts-mode.el (go-ts-mode--font-lock-settings): Add font-locking for Go built-in functions to 'go-ts-mode'. (Bug#70362)
* ; Fix last changeEli Zaretskii2024-04-181-40/+41
| | | | | * lisp/url/url-util.el (url-build-query-string): Move to after the definition of 'url-query-key-value-allowed-chars'.
* Avoid unnecessary escaping in 'url-build-query-string'Dagfinn Ilmari Mannsåker2024-04-182-2/+16
| | | | | | | | | * lisp/url/url-util.el (url-query-key-value-allowed-chars): New defconst. (url-build-query-string): Use it to escape only those characters that need it in keys and values. * test/lisp/url/url-util-tests.el (url-util-tests): Add new test cases. (Bug#70312)
* Flymake support for indicating errors in marginElias G. B. Perez2024-04-183-15/+167
| | | | | | | | | | | | | | | | | | | | | | Add optional support for display flymake error in margin, this allow displaying error indicators in both graphical and terminal frames. * doc/misc/flymake.texi (Customizable variables) (Flymake error types): Document new margin indicator. * etc/NEWS: Announce the new Flymake user option for margin indicators. * lisp/progmodes/flymake.el (flymake-indicator-type) (flymake-margin-indicators-string, flymake-autoresize-margins) (flymake-margin-indicator-position): New user options. (flymake--original-margin-width): Add buffer-local variable for store original buffer margin width. (flymake-error, flymake-warning, flymake-note): Use new margin value. (flymake--indicator-overlay-spec): Rework and Rename from flymake--fringe-overlay-spec. (flymake--resize-margins): Add new function for resize margin width. (flymake--highlight-line, flymake-mode): Rework.
* Fix sending input to SQL when point is not at EOBEli Zaretskii2024-04-181-0/+2
| | | | | | * lisp/progmodes/sql.el (sql-send-string): Move point to EOB before sending input to the SQL process. Suggested by Gary Hollis <ghollisjr@gmail.com>. (Bug#69420)
* ; * etc/NEWS: Reindent and refill recently added entries.Eli Zaretskii2024-04-181-25/+24
|
* * lisp/tab-line.el: Use the new keyword :key for 'sort'.Juri Linkov2024-04-181-7/+7
| | | | | | | (tab-line-tabs-fixed-window-buffers): Use :key for 'sort'. Rename the window parameter 'tab-line-fixed-window-buffers' to shorter 'tab-line-buffers'. Add '(tab-line-buffers . writable) to window-persistent-parameters.
* Correctly verify availability of Android content URIsPo Lu2024-04-181-41/+13
| | | | | | | * java/org/gnu/emacs/EmacsService.java (checkContentUri): Call checkUriPermission with IPC-effective PID and UID rather than checkCallingUriPermission, which never considers permissions of Emacs itself, and delete the now-redundant workaround.
* Propagate 'lexical-binding' value to pp buffersAugusto Stoffel2024-04-171-1/+3
| | | | | | | See bug#70137. * lisp/emacs-lisp/pp.el (pp-display-expression): Set lexical-binding to match the value in the calling buffer.
* Document earlier change in eglot-report-progressTheodor Thornhill2024-04-172-1/+10
| | | | | | * lisp/progmodes/eglot.el (eglot-report-progress): Document the changed behavior. * etc/EGLOT-NEWS (https): Mention the change.
* (conf-toml-recognize-section): Fix bug#70383Stefan Monnier2024-04-171-21/+20
| | | | | * lisp/textmodes/conf-mode.el (conf-toml-recognize-section): Move point, like font-lock matchers are expected to do.
* eglot.el: Remove accidentally included debugging codeStefan Monnier2024-04-171-3/+0
| | | | | * lisp/progmodes/eglot.el (eglot--signal-textDocument/didChange): Remove leftover debug message.
* * lisp/emacs-lisp/icons.el (define-icon): Add 'doc-string' to 'declare'.Juri Linkov2024-04-171-1/+1
|
* New keymap tab-line-mode-map and new tab order on tab-line (bug#69993)Juri Linkov2024-04-172-6/+68
| | | | | | | | | | | | | * lisp/tab-line.el (tab-line-new-button-functions): New variable. (tab-line-tabs-function): Change the default value from 'tab-line-tabs-window-buffers' to the new option 'tab-line-tabs-fixed-window-buffers'. (tab-line-tabs-buffer-group-sort-function): Change the default value from nil to 'tab-line-tabs-buffer-group-sort-by-name'. (tab-line-tabs-buffer-group-sort-by-name): New function. (tab-line-tabs-fixed-window-buffers): New function. (tab-line-format-template): Use 'tab-line-new-button-functions'. (tab-line-mode-map, tab-line-switch-repeat-map): New keymaps.
* Allow tabbing between widgets to skip inactive widgets (bug#70413)Stephen Berman2024-04-173-2/+32
| | | | | | | | | | * doc/misc/widget.texi (Widgets and the Buffer, Customization): Document it. * etc/NEWS: Announce it. * lisp/wid-edit.el (widget-skip-inactive): New user option. (widget-tabable-at): Use it.
* * lisp/emacs-lisp/track-changes.el: Fix trailerStefan Monnier2024-04-171-2/+2
|
* track-changes.el: Fix last change for early useStefan Monnier2024-04-171-1/+1
| | | | | * lisp/emacs-lisp/track-changes.el (track-changes--recover-from-error): Don't burp if there have been fewer than 20 keystrokes since Emacs start.
* Another fix for bug#70385Eli Zaretskii2024-04-171-1/+2
| | | | * src/xdisp.c (note_fringe_highlight): Check value of x_y_to_hpos_vpos.
* ; * src/xdisp.c (redisplay_internal): Typo fix in commentRobert Pluim2024-04-171-1/+1
|
* * lisp/emacs-lisp/lisp.el (forward-sexp-function): Set back to nil.Juri Linkov2024-04-173-9/+5
| | | | | (forward-sexp): Revert back to checking 'forward-sexp-function' for nil (bug#70426).
* track-changes.el: Minor changes for version 1.0Stefan Monnier2024-04-162-16/+34
| | | | | | | | | | | | | | | | | | | | | | | Arrange for the library to be usable on older Emacsen, which includes reducing the noise when `before/after-change-functions` are badly paired or missing. Also, since the signal function receives the distance (for `:disjoint`), we don't need `track-changes--disjoint-threshold`: the signal function can simply do nothing when the distance is smaller than the threshold it wants to use. * lisp/emacs-lisp/track-changes.el: Prepare header for ELPA. (track-changes--tracker, track-changes--state): Don't use `:noinline`, so as to be compatible with Emacs<27. (track-changes-record-errors): New variable. (track-changes--recover-from-error): Use it. Record only the last 20 keys and the last 50 stack frames in the error log. (track-changes--disjoint-threshold): Delete variable. (track-changes--before): Don't use it any more. * lisp/progmodes/eglot.el (eglot--track-changes-signal): Coalesce disjoint changes nearer than what used to be coalesced because of `track-changes--disjoint-threshold`.
* (cl-defstruct): Improve handling of unknown optionsStefan Monnier2024-04-161-1/+6
| | | | | | | | | | | Until now `cl-defstruct` signaled an error when encountering an unknown option. It's easy to code and it does the job, but it doesn't give good location info in the compiler's output, and it makes it more painful to use not-yet-supported options. So just signal a warning instead. * lisp/emacs-lisp/cl-macs.el (cl-defstruct): Warn about unknown options, instead of signaling an error.
* ; Improvements to PEG documentation (second attempt)Eric Abrahamsen2024-04-162-33/+64
| | | | | | | * doc/lispref/peg.texi: Make more use of defmac/defmacro, and try to clarify the relationships between the various macros and functions. * lisp/progmodes/peg.el (peg-parse): Remove claim that PEXS can also be a single list of rules.
* * src/xdisp.c (note_fringe_highlight): Another attempt to fix bug#70385.Eli Zaretskii2024-04-161-1/+2
|
* Minor fix in detecting recursive redisplay invocationsEli Zaretskii2024-04-161-4/+7
| | | | | * src/xdisp.c (redisplay_internal): Detect recursive invocations earlier. (Bug#66416)
* Revert "; Improvements to PEG documentation"Mattias Engdegård2024-04-162-48/+87
| | | | | This reverts commit 930c578c1042e6372e5433e31b2ea801315c01c9. Looks like an editing mistake ate a large part of the text.
* Adapt tree-sitter job on EMBAMichael Albinus2024-04-161-1/+7
| | | | | * test/infra/gitlab-ci.yml (.tree-sitter-template) (test-tree-sitter): Adapt tree-sitter job.
* Fix touch screen hscroll when initiated from widgetsPo Lu2024-04-161-71/+86
| | | | | | * lisp/wid-edit.el (widget-button--check-and-call-button): Return to the position of point during the tracking loop if a touch event is canceled.
* Another fix for bug#70385Po Lu2024-04-161-2/+4
| | | | | * src/xdisp.c (note_fringe_highlight): Test that vpos falls within W->current_matrix. (bug#70385)
* Support prefix argument for switching tabs in tab-line-modeJuri Linkov2024-04-161-50/+63
| | | | | | | | * lisp/tab-line.el (tab-line-select-tab-buffer): Optimize. (tab-line-switch-cycling): Enable by default like in tab-bar-mode. (tab-line-switch-to-prev-tab, tab-line-switch-to-next-tab): Add a prefix argument ARG and support it for switching tabs. Improve docstring.
* Add font-locking for operators in go-ts-mode (bug#70361)Noah Peart2024-04-151-0/+4
| | | | | * lisp/progmodes/go-ts-mode.el (go-ts-mode--font-lock-settings): Add font-locking rule for Go operators.
* ; Improvements to PEG documentationEric Abrahamsen2024-04-152-87/+48
| | | | | | | * doc/lispref/peg.texi: Make more use of defmac/defmacro, and try to clarify the relationships between the various macros and functions. * lisp/progmodes/peg.el (peg-parse): Remove claim that PEXS can also be a single list of rules.
* ; Fix last change to secrets-tests.el.Basil L. Contovounesios2024-04-151-1/+1
|
* (track-changes-fetch): Fix nested use caseStefan Monnier2024-04-151-17/+21
| | | | | | * lisp/emacs-lisp/track-changes.el (track-changes-fetch): Don't presume that if there's nothing to do we're on `track-changes--clean-trackers`.
* (track-changes--before): Fix bug#70396Stefan Monnier2024-04-151-34/+34
| | | | | | * lisp/emacs-lisp/track-changes.el (track-changes--before): Widen the buffer before accessing it with positions potentially outside the beg..end region.
* Fix resetting the frame's 'frozen_window_starts' flagEli Zaretskii2024-04-151-2/+4
| | | | | | | | * src/window.c (grow_mini_window, shrink_mini_window): Reimplement how the frame's 'frozen_window_starts' flag is set and reset, to make sure it is always reset when the mini-window gets to its normal one-line height. Patch by Martin Rudalics <rudalics@gmx.at> (Bug#70038)
* Fix display of @xref documentation in InfoEli Zaretskii2024-04-151-0/+23
| | | | | | | * lisp/info.el (Info--dont-hide-references): New variable. (Info-fontify-node): Use 'Info--dont-hide-references' to disable hiding "*Note" or showing "See" instead of it in select nodes. (Bug#70382)
* Rewrite Android description of Android window managementPo Lu2024-04-151-58/+62
| | | | | | * doc/emacs/android.texi (Android Environment): Rewrite several paragraphs to better reflect recent changes and emphasize behavior on modern OS releases.
generated by cgit v1.2.1 (git 2.18.0) at 2026-03-06 23:51:31 +0000