diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 6 | ||||
| -rw-r--r-- | src/widget.c | 12 | ||||
| -rw-r--r-- | src/xfns.c | 3 | ||||
| -rw-r--r-- | src/xterm.c | 2 |
4 files changed, 12 insertions, 11 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 686c728f0a3..ff6945d8656 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,11 @@ | |||
| 1 | 2011-06-13 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-06-13 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | Remove unnecessary casts. | ||
| 4 | * xterm.c (x_term_init): | ||
| 5 | * xfns.c (x_set_border_pixel): | ||
| 6 | * widget.c (create_frame_gcs): Remove casts to unsigned long etc. | ||
| 7 | These aren't needed now that we assume ANSI C. | ||
| 8 | |||
| 3 | * sound.c (Fplay_sound_internal): Remove cast to unsigned long. | 9 | * sound.c (Fplay_sound_internal): Remove cast to unsigned long. |
| 4 | It's more likely to cause problems (due to unsigned overflow) | 10 | It's more likely to cause problems (due to unsigned overflow) |
| 5 | than to cure them. | 11 | than to cure them. |
diff --git a/src/widget.c b/src/widget.c index 3053ceaea13..daea382d654 100644 --- a/src/widget.c +++ b/src/widget.c | |||
| @@ -523,14 +523,11 @@ create_frame_gcs (ew) | |||
| 523 | struct frame *s = ew->emacs_frame.frame; | 523 | struct frame *s = ew->emacs_frame.frame; |
| 524 | 524 | ||
| 525 | s->output_data.x->normal_gc | 525 | s->output_data.x->normal_gc |
| 526 | = XCreateGC (XtDisplay (ew), RootWindowOfScreen (XtScreen (ew)), | 526 | = XCreateGC (XtDisplay (ew), RootWindowOfScreen (XtScreen (ew)), 0, 0); |
| 527 | (unsigned long)0, (XGCValues *)0); | ||
| 528 | s->output_data.x->reverse_gc | 527 | s->output_data.x->reverse_gc |
| 529 | = XCreateGC (XtDisplay (ew), RootWindowOfScreen (XtScreen (ew)), | 528 | = XCreateGC (XtDisplay (ew), RootWindowOfScreen (XtScreen (ew)), 0, 0); |
| 530 | (unsigned long)0, (XGCValues *)0); | ||
| 531 | s->output_data.x->cursor_gc | 529 | s->output_data.x->cursor_gc |
| 532 | = XCreateGC (XtDisplay (ew), RootWindowOfScreen (XtScreen (ew)), | 530 | = XCreateGC (XtDisplay (ew), RootWindowOfScreen (XtScreen (ew)), 0, 0); |
| 533 | (unsigned long)0, (XGCValues *)0); | ||
| 534 | s->output_data.x->black_relief.gc = 0; | 531 | s->output_data.x->black_relief.gc = 0; |
| 535 | s->output_data.x->white_relief.gc = 0; | 532 | s->output_data.x->white_relief.gc = 0; |
| 536 | } | 533 | } |
| @@ -589,8 +586,7 @@ setup_frame_gcs (EmacsFrame ew) | |||
| 589 | = XCreatePixmapFromBitmapData (XtDisplay(ew), | 586 | = XCreatePixmapFromBitmapData (XtDisplay(ew), |
| 590 | RootWindowOfScreen (XtScreen (ew)), | 587 | RootWindowOfScreen (XtScreen (ew)), |
| 591 | setup_frame_cursor_bits, 2, 2, | 588 | setup_frame_cursor_bits, 2, 2, |
| 592 | (unsigned long)0, (unsigned long)1, | 589 | 0, 1, ew->core.depth); |
| 593 | ew->core.depth); | ||
| 594 | 590 | ||
| 595 | /* Normal video */ | 591 | /* Normal video */ |
| 596 | gc_values.foreground = ew->emacs_frame.foreground_pixel; | 592 | gc_values.foreground = ew->emacs_frame.foreground_pixel; |
diff --git a/src/xfns.c b/src/xfns.c index 8417db7d6e5..f847e41855e 100644 --- a/src/xfns.c +++ b/src/xfns.c | |||
| @@ -1074,8 +1074,7 @@ x_set_border_pixel (struct frame *f, int pix) | |||
| 1074 | if (FRAME_X_WINDOW (f) != 0 && f->border_width > 0) | 1074 | if (FRAME_X_WINDOW (f) != 0 && f->border_width > 0) |
| 1075 | { | 1075 | { |
| 1076 | BLOCK_INPUT; | 1076 | BLOCK_INPUT; |
| 1077 | XSetWindowBorder (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), | 1077 | XSetWindowBorder (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), pix); |
| 1078 | (unsigned long)pix); | ||
| 1079 | UNBLOCK_INPUT; | 1078 | UNBLOCK_INPUT; |
| 1080 | 1079 | ||
| 1081 | if (FRAME_VISIBLE_P (f)) | 1080 | if (FRAME_VISIBLE_P (f)) |
diff --git a/src/xterm.c b/src/xterm.c index 39e4abb1630..85c19ed16af 100644 --- a/src/xterm.c +++ b/src/xterm.c | |||
| @@ -10268,7 +10268,7 @@ x_term_init (Lisp_Object display_name, char *xrm_option, char *resource_name) | |||
| 10268 | = XCreatePixmapFromBitmapData (dpyinfo->display, dpyinfo->root_window, | 10268 | = XCreatePixmapFromBitmapData (dpyinfo->display, dpyinfo->root_window, |
| 10269 | gray_bitmap_bits, | 10269 | gray_bitmap_bits, |
| 10270 | gray_bitmap_width, gray_bitmap_height, | 10270 | gray_bitmap_width, gray_bitmap_height, |
| 10271 | (unsigned long) 1, (unsigned long) 0, 1); | 10271 | 1, 0, 1); |
| 10272 | } | 10272 | } |
| 10273 | 10273 | ||
| 10274 | #ifdef HAVE_X_I18N | 10274 | #ifdef HAVE_X_I18N |