1 files changed, 45 insertions, 17 deletions

diff --git a/src/xdisp.c b/src/xdisp.c
index 76ab430386c..7e65b91fd13 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -701,6 +701,10 @@ Lisp_Object Vresize_mini_windows;
 
 struct buffer *displayed_buffer;
 
+/* Space between overline and text. */
+
+EMACS_INT overline_margin;
+
 /* Value returned from text property handlers (see below).  */
 
 enum prop_handled
@@ -887,7 +891,7 @@ static void redisplay_window P_ ((Lisp_Object, int));
 static Lisp_Object redisplay_window_error ();
 static Lisp_Object redisplay_window_0 P_ ((Lisp_Object));
 static Lisp_Object redisplay_window_1 P_ ((Lisp_Object));
-static void update_menu_bar P_ ((struct frame *, int));
+static int update_menu_bar P_ ((struct frame *, int, int));
 static int try_window_reusing_current_matrix P_ ((struct window *));
 static int try_window_id P_ ((struct window *));
 static int display_line P_ ((struct it *));
@@ -9038,6 +9042,9 @@ prepare_menu_bars ()
     {
       Lisp_Object tail, frame;
       int count = SPECPDL_INDEX ();
+      /* 1 means that update_menu_bar has run its hooks
+         so any further calls to update_menu_bar shouldn't do so again.  */
+      int menu_bar_hooks_run = 0;
 
       record_unwind_save_match_data ();
 
@@ -9069,7 +9076,7 @@ prepare_menu_bars ()
             }
 
           GCPRO1 (tail);
-          update_menu_bar (f, 0);
+          menu_bar_hooks_run = update_menu_bar (f, 0, menu_bar_hooks_run);
 #ifdef HAVE_WINDOW_SYSTEM
           update_tool_bar (f, 0);
 #ifdef MAC_OS
@@ -9084,7 +9091,7 @@ prepare_menu_bars ()
   else
     {
       struct frame *sf = SELECTED_FRAME ();
-      update_menu_bar (sf, 1);
+      update_menu_bar (sf, 1, 0);
 #ifdef HAVE_WINDOW_SYSTEM
       update_tool_bar (sf, 1);
 #ifdef MAC_OS
@@ -9105,12 +9112,18 @@ prepare_menu_bars ()
    before we start to fill in any display lines, because it can call
    eval.
 
-   If SAVE_MATCH_DATA is non-zero, we must save and restore it here.  */
+   If SAVE_MATCH_DATA is non-zero, we must save and restore it here.
 
-static void
-update_menu_bar (f, save_match_data)
+   If HOOKS_RUN is 1, that means a previous call to update_menu_bar
+   already ran the menu bar hooks for this redisplay, so there
+   is no need to run them again.  The return value is the
+   updated value of this flag, to pass to the next call.  */
+
+static int
+update_menu_bar (f, save_match_data, hooks_run)
      struct frame *f;
      int save_match_data;
+     int hooks_run;
 {
   Lisp_Object window;
   register struct window *w;
@@ -9175,15 +9188,21 @@ update_menu_bar (f, save_match_data)
               specbind (Qoverriding_local_map, Qnil);
             }
 
-          /* Run the Lucid hook.  */
-          safe_run_hooks (Qactivate_menubar_hook);
+          if (!hooks_run)
+            {
+              /* Run the Lucid hook.  */
+              safe_run_hooks (Qactivate_menubar_hook);
 
-          /* If it has changed current-menubar from previous value,
-             really recompute the menu-bar from the value.  */
-          if (! NILP (Vlucid_menu_bar_dirty_flag))
-            call0 (Qrecompute_lucid_menubar);
+              /* If it has changed current-menubar from previous value,
+                 really recompute the menu-bar from the value.  */
+              if (! NILP (Vlucid_menu_bar_dirty_flag))
+                call0 (Qrecompute_lucid_menubar);
+
+              safe_run_hooks (Qmenu_bar_update_hook);
+
+              hooks_run = 1;
+            }
 
-          safe_run_hooks (Qmenu_bar_update_hook);
           FRAME_MENU_BAR_ITEMS (f) = menu_bar_items (FRAME_MENU_BAR_ITEMS (f));
 
           /* Redisplay the menu bar in case we changed it.  */
@@ -9212,6 +9231,8 @@ update_menu_bar (f, save_match_data)
           set_buffer_internal_1 (prev);
         }
     }
+
+  return hooks_run;
 }
 
 
@@ -9376,7 +9397,8 @@ update_tool_bar (f, save_match_data)
                                          &new_n_tool_bar);
 
           /* Redisplay the tool-bar if we changed it.  */
-          if (NILP (Fequal (new_tool_bar, f->tool_bar_items)))
+          if (new_n_tool_bar != f->n_tool_bar_items
+              || NILP (Fequal (new_tool_bar, f->tool_bar_items)))
             {
               /* Redisplay that happens asynchronously due to an expose event
                  may access f->tool_bar_items.  Make sure we update both
@@ -20354,7 +20376,7 @@ x_produce_glyphs (it)
           /* If face has an overline, add the height of the overline
              (1 pixel) and a 1 pixel margin to the character height.  */
           if (face->overline_p)
-            it->ascent += 2;
+            it->ascent += overline_margin;
 
           if (it->constrain_row_ascent_descent_p)
             {
@@ -20556,7 +20578,7 @@ x_produce_glyphs (it)
           /* If face has an overline, add the height of the overline
              (1 pixel) and a 1 pixel margin to the character height.  */
           if (face->overline_p)
-            it->ascent += 2;
+            it->ascent += overline_margin;
 
           take_vertical_position_into_account (it);
 
@@ -20831,7 +20853,7 @@ x_produce_glyphs (it)
       /* If face has an overline, add the height of the overline
          (1 pixel) and a 1 pixel margin to the character height.  */
       if (face->overline_p)
-        it->ascent += 2;
+        it->ascent += overline_margin;
 
       take_vertical_position_into_account (it);
 
@@ -24108,6 +24130,12 @@ whose contents depend on various data.  */);
                doc: /* Inhibit try_cursor_movement display optimization.  */);
   inhibit_try_cursor_movement = 0;
 #endif /* GLYPH_DEBUG */
+
+  DEFVAR_INT ("overline-margin", &overline_margin,
+               doc: /* *Space between overline and text, in pixels.
+The default value is 2: the height of the overline (1 pixel) plus 1 pixel
+margin to the caracter height.  */);
+  overline_margin = 2;
 }