aboutsummaryrefslogtreecommitdiffstats
path: root/src/ChangeLog
diff options
context:
space:
mode:
Diffstat (limited to 'src/ChangeLog')
-rw-r--r--src/ChangeLog15705
1 files changed, 4581 insertions, 11124 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index 12845538a9e..3ef8bee2f0b 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,11496 +1,4953 @@
12012-06-01 Dmitry Antipov <dmantipov@yandex.ru> 12013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2 2
3 For a 'struct window', replace some Lisp_Object fields to 3 Make --without-x compatible with --enable-gcc-warnings.
4 bitfields where appropriate, remove unused fields. 4 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
5 * window.h (struct window): Remove unused 'last_mark_x' and 5 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
6 'last_mark_y' fields. Rename 'mini_p' field to 'mini', 6 members under HAVE_WINDOW_SYSTEM.
7 change it's type from Lisp_Object to bitfield. 7 * keyboard.c (make_lispy_focus_out): Likewise.
8 Change type of 'force_start', 'optional_new_start', 8 (record_menu_key): Move under HAVE_MENUS.
9 'last_had_star', 'update_mode_line' and 'start_at_line_beg' 9 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
10 fields from Lisp_Object to bitfield. Adjust users accordingly. 10 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
11 (syms_of_xdisp): Adjust user.
12 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
13 (start_hourglass, cancel_hourglass):
14 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
15 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
16 and CLEAR_FONT_TABLE_NFONTS.
17 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
18 Declare only if HAVE_WINDOW_SYSTEM.
19 (lface_same_font_attributes_p, clear_face_gcs): Define only
20 if HAVE_WINDOW_SYSTEM.
21
222013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
11 23
122012-05-31 Paul Eggert <eggert@cs.ucla.edu> 24 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
25 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
26 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
27
282013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
29
30 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
31
322013-09-04 Paul Eggert <eggert@cs.ucla.edu>
33
34 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
35 This fixes a type error on hosts where ptrdiff_t is wider than int.
36
372013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
38
39 * keyboard.c (read_key_sequence_vs): New function.
40 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
41 common code.
42
43 * callint.c (Fcall_interactively): Always return a vector for 'K'.
44
452013-09-04 Paul Eggert <eggert@cs.ucla.edu>
46
47 Makefile improvements.
48 * Makefile.in (config.status): Don't use double-colon rules, as
49 they are not portable according to POSIX. Fix shell typo with `;
50 I guess this rule has never been tested?
51 (VCSWITNESS): New macro, to override any environment var.
52
532013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
54
55 * xterm.h (struct x_display_info): Do not track X connection
56 fd separately because it is always available from Display.
57 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
58 Adjust users.
59
602013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
61
62 * buffer.c (drop_overlay):
63 * fileio.c (restore_point_unwind): Prefer unchain_marker to
64 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
65
662013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
67
68 * buffer.c (Fmake_overlay, Fmove_overlay):
69 * intervals.c (set_point_from_marker):
70 * print.c (PRINTPREPARE): Prefer signal_error
71 to plain error and report unsuitable marker too.
72
732013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
74
75 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
76 for 'dragging' member.
77 (struct x_output): Remove set-but-unused leftovers
78 'left_before_move' and 'top_before_move'.
79 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
80 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
81 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
82 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
83 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
84 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
85 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
86 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
87
882013-09-03 Jan Djärv <jan.h.d@swipnet.se>
89
90 * nsfont.m (INVALID_GLYPH): New define.
91 (nsfont_encode_char): Use INVALID_GLYPH.
92 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
93
942013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
95
96 * xterm.c (x_last_mouse_movement_time): Revert last change.
97 This code should use XDisplayMotionBufferSize to check display's
98 motion history first, and there are few other issues as well.
99 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
100 (handle_one_xevent): Adjust user.
101
1022013-09-02 Martin Rudalics <rudalics@gmx.at>
103
104 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
105 * frame.c (Flast_nonminibuf_frame): ... to here.
106 (check_minibuf_window): Don't abort if no window was found
107 (Bug#15247).
108
1092013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Use XGetMotionEvents to ask the last mouse motion time from X server.
112 * xterm.c (X_MOTION_HISTORY): Default to 1.
113 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
114 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
115 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
116 Ifdef away legacy code.
117 (XTmouse_position, x_scroll_bar_report_motion):
118 Use x_last_mouse_movement_time.
119 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
120 UnmapNotify event.
121
1222013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
123
124 * msdos.c (last_mouse_window): Move to...
125 (dos_rawgetc): ...this function and adjust comment.
126 * nsterm.m (last_window): Rename to last_mouse_window, move to...
127 (mouseMoved): ...this function and adjust comment.
128 * w32term.c (last_window): Likewise with...
129 (w32_read_socket): ...this function.
130 * xterm.c (last_window): Likewise with...
131 (handle_one_xevent): ...this function.
132
1332013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
134
135 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
136 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
137 (handle_one_xevent): ...to here.
138 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
139 otherwise.
140
1412013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
142
143 * msdos.c (IT_set_terminal_window): Remove no-op.
144 (initialize_msdos_display): Adjust terminal setup.
145 * w32console.c (w32con_set_terminal_window): Remove no-op.
146 (initialize_w32_display): Adjust terminal setup.
147 * w32term.c (w32_set_terminal_window): Remove no-op.
148 (w32_create_terminal): Adjust terminal setup.
149 * xterm.c (XTset_terminal_window): Remove no-op.
150 (x_create_terminal): Adjust terminal setup.
151
1522013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
153
154 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
155 Remove no-ops.
156 (ns_create_terminal): Adjust terminal setup.
157 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
158 Remove no-ops.
159 (w32_create_terminal): Adjust terminal setup.
160 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
161 Remove no-ops.
162 (x_create_terminal): Adjust terminal setup.
163
1642013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
165
166 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
167 (CLIP_TEXT_POS_FROM_MARKER): New macro.
168 * dispnew.c (buffer_posn_from_coords):
169 * window.c (Fwindow_end, displayed_window_lines):
170 * xdisp.c (redisplay_mode_lines): Use it.
171
1722013-09-01 Jan Djärv <jan.h.d@swipnet.se>
173
174 * fontset.c (face_for_char): Check char in the current face font first
175 if HAVE_NS (Bug#15138).
176
1772013-08-31 Martin Rudalics <rudalics@gmx.at>
178
179 * window.c (temp_output_buffer_show): Make sure window returned
180 by display_buffer is live (Bug#15213).
181
1822013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Minor cleanup to avoid forward declarations.
185 * coding.h (struct ccl_spec): Remove forward declaration.
186 * composite.h (toplevel): Include font.h.
187 (struct composition_it, struct face, struct font_metrics):
188 Remove forward declaration.
189 * dispextern.h (struct image, struct atimer): Likewise.
190 * emacsgtkfixed.h (struct frame): Likewise.
191 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
192 * font.h (struct font_driver, struct font, struct glyph_string)
193 (struct face): Remove forward declaration.
194 * fontset.h (struct face, struct font): Likewise.
195 * frame.h (toplevel): Style cleanup.
196 (enum output_method): Move to...
197 * termhooks.h (enum output_method): ...here.
198 (struct glyph, struct frame, struct ns_display_info)
199 (struct x_display_info, struct w32_display_info):
200 Remove forward declaration.
201 * xterm.h (toplevel): Include termhooks.h.
202 (struct font, struct window, struct glyph_matrix, struct frame)
203 (struct input_event, struct face, struct image): Remove forward
204 declaration.
205 * gtkutil.h (struct _widget_value): Likewise.
206 * keyboard.h (toplevel): Include termhooks.h.
207 (struct input_event): Remove forward declaration.
208
2092013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
210
211 * intervals.c (set_point_from_marker): New function.
212 * editfns.c (Fgoto_char):
213 * process.c (Finternal_default_process_filter):
214 * window.c (select_window_1): Use it.
215 * buffer.h (set_point_from_marker): Add prototype.
216
2172013-08-29 Eli Zaretskii <eliz@gnu.org>
218
219 * w32.c (term_winsock): Call release_listen_threads before calling
220 WSACleanup.
221 (_sys_wait_accept): Wait for accept event in a loop with a finite
222 timeout, instead of waiting indefinitely. Will hopefully avoid
223 hanging during exit because WSACleanup deadlocks waiting for the
224 event object to be released. (Bug#14333)
225
226 * w32proc.c (release_listen_threads): New function, signals all
227 the reader threads that listen for connections to stop waiting.
228
229 * w32.h (release_listen_threads): Add prototype.
230
2312013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
232
233 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
234 field of new marker (for sanity and safety).
235 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
236 anyway because XMISCTYPE is a function and can't be an lvalue).
237
2382013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
239
240 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
241 (x_after_update_window_line, x_scroll_bar_create):
242 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
243 (handle_one_xevent, x_clear_frame_area):
244 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
245 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
246 * xterm.h (x_clear_area): Adjust prototype.
247
2482013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
249
250 Hook scanning and indentation functions to find_newline. This helps
251 to avoid duplicated code and renders more respect to newline cache.
252 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
253 * cmds.c (Fforward_line):
254 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
255 Use find_newline and avoid unnecessary point movements.
256 * search.c (scan_newline): Implement on top of find_newline.
257
2582013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
259
260 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
261 scoped code (bug#11258).
262
2632013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
264
265 * nsterm.m (last_window): New variable.
266 (EV_TRAILER2): New macro.
267 (EV_TRAILER): Call EV_TRAILER2.
268 (mouseMoved:): Add support for mouse-autoselect-window
269 on nextstep (Bug#6888).
270
2712013-08-28 Andreas Schwab <schwab@suse.de>
272
273 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
274 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
275 Remove unused macro definitions.
276 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
277 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
278 Only define if emacs.
279
2802013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Prefer enum glyph_row_area to int where appropriate.
283 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
284 Fix comment.
285 (window_box, window_box_width, window_box_left, window_box_left_offset)
286 (window_box_right, window_box_right_offset): Adjust prototypes.
287 * xdisp.c (window_box, window_box_width, window_box_left)
288 (window_box_left_offset, window_box_right, window_box_right_offset):
289 Use enum glyph_row_area. Adjust users and tweak comment where needed.
290 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
291 * nsterm.m (ns_clip_to_row):
292 * w32term.c (w32_clip_to_row):
293 * xterm.c (x_clip_to_row): Likewise.
294
2952013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
296
297 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
298 (Fprevious_overlay_change): Fast path for buffer with no overlays.
299
3002013-08-28 Paul Eggert <eggert@cs.ucla.edu>
301
302 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
303 for portability to hosts where /bin/sh has problems.
304
3052013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
306
307 Redesign redisplay interface to drop global output_cursor.
308 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
309 (toplevel): Remove declaration of output_cursor.
310 (set_output_cursor, x_cursor_to): Remove prototype.
311 * window.h (struct window): New member output_cursor.
312 (output_cursor_to): New function to replace RIF member.
313 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
314 (update_text_area, set_window_cursor_after_update): Use it.
315 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
316 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
317 * nsterm.m (ns_update_window_begin, ns_update_window_end):
318 * w32term.c (x_update_window_begin, x_update_window_end):
319 * xterm.c (x_update_window_begin, x_update_window_end):
320 Adjust to use per-window output cursor.
321
3222013-08-27 Paul Eggert <eggert@cs.ucla.edu>
323
324 Simplify SELECT_TYPE-related code.
325 Like EMACS_TIME, this portability layer is no longer needed, since
326 Emacs has been using fd_set as a portability layer for some time.
327 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
328 (SELECT_TYPE): Remove. All uses changed to fd_set.
329 (fd_set) [!FD_SET]: New typedef.
330
331 Simplify EMACS_TIME-related code.
332 This portability layer is no longer needed, since Emacs has been
333 using struct timespec as a portability layer for some time.
334 * atimer.h, buffer.h, dispextern.h, xgselect.h:
335 Include <time.h> rather than "systime.h"; that's all that's needed now.
336 * dispnew.c: Include <timespec.h> rather than "systime.h";
337 that's all that's needed now.
338 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
339 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
340 TIMESPEC_RESOLUTION.
341 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
342 LOG10_TIMESPEC_RESOLUTION.
343 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
344 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
345 (make_emacs_time): Remove. All used changed to make_timespec.
346 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
347 (current_timespec): Rename from current_emacs_time. All uses changed.
348 (add_emacs_time): Remove. All uses changed to timespec_add.
349 (sub_emacs_time): Remove. All uses change dot timespec_sub.
350 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
351 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
352 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
353 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
354 (current_timespec): Rename from current_emacs_time. All uses changed.
355 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
356 changed to timespec_cmp.
357 * xgselect.c: Include <timespec.h>, since our .h files don't.
358
3592013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
360
361 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
362 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
363 Remove the leftovers.
364 * gtkutil.c (toplevel): Do not declare Qxft but include
365 font.h to do so.
366 * image.c (toplevel): Do not declare Vlibrary_cache because
367 it's already done in lisp.h.
368
3692013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
370
371 * lisp.h (Mouse_HLInfo): Move from here...
372 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
373 (reset_mouse_highlight): New function.
374 * msdos.c (dos_set_window_size, IT_update_begin)
375 (internal_terminal_init):
376 * nsterm.m (ns_update_window_end, x_free_frame_resources)
377 (ns_initialize_display_info):
378 * w32console.c (initialize_w32_display):
379 * w32term.c (x_update_window_end, x_free_frame_resources)
380 (w32_initialize_display_info):
381 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
382 * window.c (Fdelete_other_windows_internal):
383 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
384 * termchar.h (toplevel):
385 * xterm.h (toplevel): Include dispextern.h.
386
3872013-08-26 Paul Eggert <eggert@cs.ucla.edu>
13 388
14 Pacify gcc -Wdouble-precision when using Xaw. 389 Fix minor problems found by static checking.
15 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb) 390 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
16 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]: 391 (expect): Avoid nested-if warning.
17 Use 'float' consistently, rather than 'float' in most places 392 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
18 and 'double' in a couple of places. 393 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
19 394 * nsterm.h, nsterm.m (ns_select):
202012-05-31 Eli Zaretskii <eliz@gnu.org> 395 * xgselect.c, xgselect.h (xg_select):
21 396 Adjust signature to better match pselect's.
22 * xdisp.c (handle_stop): Detect whether we have overlay strings 397 * nsterm.m (ns_select):
23 loaded by testing it->current.overlay_string_index to be 398 Don't set *TIMEOUT, since pselect doesn't.
24 non-negative, instead of checking whether n_overlay_strings is 399 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
25 positive. (Bug#11587) 400 diagnostic about assigning const char * to it.
26 401 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
272012-05-31 Chong Yidong <cyd@gnu.org> 402
28 4032013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
29 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169). 404
30 405 * lread.c (substitute_object_recurse): Handle hash-tables as well
31 * doc.c (Fsubstitute_command_keys): Doc fix. 406 (bug#15190).
32 407
332012-05-31 Eli Zaretskii <eliz@gnu.org> 4082013-08-26 Paul Eggert <eggert@cs.ucla.edu>
34 409
35 * search.c (search_buffer): Remove calls to 410 Fix unlikely core dump in init_tty, and simplify terminfo case.
36 r_alloc_inhibit_buffer_relocation, as it is now called by 411 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
37 maybe_unify_char, which was the cause of relocation of buffer text 412 The old version incorrectly dumped core if malloc returned a
38 in bug#11519. 413 buffer containing only non-NUL bytes.
39 414 (init_tty): Do not allocate or free termcap buffers; the
402012-05-31 Eli Zaretskii <eliz@gnu.org> 415 struct does that for us now.
41 416 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
42 * charset.c (maybe_unify_char): Inhibit relocation of buffer text 417 (struct tty_display_info): Define members termcap_term_buffer and
43 for the duration of call to load_charset, to avoid problems with 418 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
44 callers of maybe_unify_char that access buffer text through C 419 use them. Allocate them directly in struct rather than indirectly
45 pointers. 420 via a pointer, to simplify init_tty.
46 421
47 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and 422 * frame.c (check_minibuf_window): Initialize 'window' properly,
48 decrement the inhibition flag, instead of just setting or 423 so that Emacs reliably aborts later if 'window' is not initialized.
49 resetting it. 424
50 4252013-08-26 Jan Djärv <jan.h.d@swipnet.se>
512012-05-31 Paul Eggert <eggert@cs.ucla.edu> 426
52 427 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
53 Remove obsolete '#define static' cruft. 428 of VoidSymbol (Bug#15154).
54 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef. 429
55 This #undef was "temporary" in 2000; it is no longer needed 4302013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
56 now that '#define static' has gone away. 431
57 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height) 432 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
58 (gray_bitmap_bits): Remove; no longer needed. 433 mouse_face_beg_y and mouse_face_end_y.
59 All uses replaced with definiens. 434 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
60 * xterm.c: Include "bitmaps/gray.xbm". 435 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
61 436 Adjust users and update comment where appropriate.
622012-05-30 Paul Eggert <eggert@cs.ucla.edu> 437
63 4382013-08-26 Martin Rudalics <rudalics@gmx.at>
64 Clean up __executable_start, monstartup when --enable-profiling. 439
65 The following changes affect the code only when profiling. 440 * frame.c (check_minibuf_window): New function.
66 * dispnew.c (__executable_start): Rename from safe_bcopy. 441 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
67 Define only on platforms that need it. 442 Call check_minibuf_window (Bug#15183).
68 * emacs.c: Include <sys/gmon.h> when profiling. 443
69 (_mcleanup): Remove decl, since <sys/gmon.h> does it now. 4442013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
70 (__executable_start): Remove decl, since lisp.h does it now. 445
71 (safe_bcopy): Remove decl; no longer has that name. 446 * window.h (struct window): Replace last_cursor with last_cursor_vpos
72 (main): Coalesce #if into single bit of code, for simplicity. 447 because this is the only last cursor data we need to keep and consult.
73 Cast pointers to uintptr_t, since standard libraries want integers 448 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
74 and not pointers. 449 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
75 * lisp.h (__executable_start): New decl. 450 Adjust users.
76 451
772012-05-31 Glenn Morris <rgm@gnu.org> 4522013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
78 453
79 * image.c (Fimagemagick_types): Doc fix. 454 Fix recovering from possible decompression error.
80 455 Since insert_from_gap doesn't always move point, we can't use PT as
812012-05-30 Jim Meyering <meyering@redhat.com> 456 the position where the partially decompressed data ends, and
82 457 should count how many bytes was produced so far.
83 * callproc.c (Fcall_process_region): Include directory component 458 * decompress.c (struct decompress_unwind_data): Add nbytes member.
84 in mkstemp error message (Bug#11586). 459 (unwind_decompress): Really delete partially uncompressed data.
85 460 (Fzlib_decompress_region): Take decompressed data size into account.
862012-05-30 Paul Eggert <eggert@cs.ucla.edu> 461
87 4622013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
88 * alloc.c, lisp.h (make_pure_vector): Now static. 463
89 464 * syntax.c (init_syntax_once): Adjust comment and do an early
902012-05-30 Stefan Monnier <monnier@iro.umontreal.ca> 465 initialization of Qchar_table_extra_slots just once...
91 466 * casetab.c (init_casetab_once):
92 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function): 467 * category.c (init_category_once):
93 Move to byte-run.el. 468 * character.c (syms_of_character):
94 (Fautoload): Do the hash-doc more carefully. 469 * coding.c (syms_of_coding):
95 * data.c (Fdefalias): Purify definition, except for keymaps. 470 * xdisp.c (syms_of_xdisp): ...and omit it here.
96 (Qdefun): Move from eval.c. 471
97 * lisp.h (Qdefun): Remove. 4722013-08-24 Eli Zaretskii <eliz@gnu.org>
98 * lread.c (read1): Tiny simplification. 473
99 474 * xdisp.c (get_next_display_element): Don't apply to characters
1002012-05-29 Troels Nielsen <bn.troels@gmail.com> 475 from a display vector the logic of setting it->end_of_box_run_p
101 476 suitable for characters from a buffer. (Bug#15175)
102 Do not create empty overlays with the evaporate property (Bug#9642). 477
103 * buffer.c (Fmove_overlay): Reinstate the earlier fix for 478 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
104 Bug#9642, but explicitly check that the buffer the overlay would 479 to handle directories, rather than '_utime' which doesn't.
105 be moved to is live and rearrange lines to make sure that errors 480 (Bug#15176)
106 will not put the overlay in an inconsistent state. 481
107 (Fdelete_overlay): Cosmetics. 4822013-08-24 Jan Djärv <jan.h.d@swipnet.se>
108 483
1092012-05-28 Eli Zaretskii <eliz@gnu.org> 484 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
110 485 or fullscreen (Bug#14627).
111 * w32term.c (my_bring_window_to_top): New function. 486
112 (x_raise_frame): Use handle returned by DeferWindowPos, which 4872013-08-24 Paul Eggert <eggert@cs.ucla.edu>
113 could be different from the original one. 488
114 Call my_bring_window_to_top instead of my_set_foreground_window. 489 System-dependent integer overflow fixes.
115 (Bug#11513) 490 * process.c (Fset_process_window_size): Signal an error if
116 491 the window size is outside the range supported by the lower level.
117 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP 492 * sysdep.c (set_window_size): Return negative on error,
118 by calling BringWindowToTop. 493 nonnegative on success, rather than -1, 0, 1 on not in system,
119 494 failure, success. This is simpler. Caller changed.
120 * w32term.h (WM_EMACS_BRINGTOTOP): New message. 495 (serial_configure): Remove unnecessary initialization of local.
121 (WM_EMACS_END): Increase by one. 496 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
122 497 size fits in unsigned long; this isn't true on some 32-bit hosts.
1232012-05-28 Paul Eggert <eggert@cs.ucla.edu> 498 Avoid buffer overrun if some future version of /proc/meminfo has a
124 499 variable name longer than 20 bytes.
125 * bidi.c (bidi_mirror_char): Put eassert before conversion to int. 500 (system_process_attributes) [__FreeBSD__]:
126 This avoids undefined behavior that might cause the eassert 501 Don't assume hw.availpages fits in 'int'.
127 to not catch an out-of-range value. 502
128 5032013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1292012-05-28 Juanma Barranquero <lekktu@gmail.com> 504
130 505 Don't let very long directory names overrun the stack.
131 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)): 506 Fix some related minor problems involving "//", vfork.
132 Update dependencies. 507 * callproc.c (encode_current_directory): New function.
133 508 (call_process): Don't append "/"; not needed.
1342012-05-27 Eli Zaretskii <eliz@gnu.org> 509 * fileio.c (file_name_as_directory_slop): New constant.
135 510 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
136 * bidi.c (bidi_mirror_char): Fix last change. 511 this can save the caller having to alloca.
137 512 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1382012-05-27 Andreas Schwab <schwab@linux-m68k.org>
139
140 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
141 when referring to sectname field in printf format.
142
1432012-05-27 Paul Eggert <eggert@cs.ucla.edu>
144
145 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
146 Only r_alloc_inhibit_buffer_relocation needed to be added;
147 the others were already declared.
148
149 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
150 before checking whether it's out of range. Put the check inside
151 eassert. See
152 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
153
1542012-05-27 Ken Brown <kbrown@cornell.edu>
155
156 * callproc.c (Fcall_process): Restore a line that was accidentally
157 commented out in the 2011-02-13 change (bug#11547).
158
1592012-05-27 Eli Zaretskii <eliz@gnu.org>
160
161 * lisp.h [REL_ALLOC]: Add prototypes for external functions
162 defined on ralloc.c.
163
164 * buffer.c [REL_ALLOC]: Remove prototypes of
165 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
166 they are now on lisp.h.
167
168 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
169
170 * search.c (search_buffer): Use it to inhibit relocation of buffer
171 text while re_search_2 is doing its job, because re_search_2 is
172 passed C pointers to buffer text. (Bug#11519)
173
174 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
175 Update value to 24.
176
177 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
178 state after an additional call to move_it_in_display_line_to, keep
179 the values of it->max_ascent and it->max_descent found for the
180 entire line.
181 (pos_visible_p): Revert the comparison against bottom_y to what it
182 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
183 (Bug#11464)
184
1852012-05-26 Paul Eggert <eggert@cs.ucla.edu>
186
187 Fix coding-related core dumps with gcc -ftrapv.
188 The code was computing A - B, where A and B are pointers, and B is
189 random garbage. This can lead to core dumps on platforms that
190 have special pointer registers, and it also leads to core dumps on
191 x86-64 when compiled with gcc -ftrapv. The fix is to compute
192 A - B only when B is initialized properly.
193 * coding.c (coding_set_source, coding_set_destination): Return void.
194 (coding_change_source, coding_change_destinations): New functions,
195 with the old behaviors of coding_set_source and coding_set_destination.
196 All callers that need an offset changed to use these new functions.
197
1982012-05-26 Glenn Morris <rgm@gnu.org>
199
200 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
201
2022012-05-26 Eli Zaretskii <eliz@gnu.org>
203
204 Extend mouse support on W32 text-mode console.
205 * xdisp.c (draw_row_with_mouse_face):
206 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
207
208 * w32console.c: Include window.h.
209 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
210 New functions.
211 (initialize_w32_display): Initialize mouse-highlight data.
212
213 * w32inevt.c: Include termchar.h and window.h.
214 (do_mouse_event): Support mouse-autoselect-window. When the mouse
215 moves, call note_mouse_highlight. If help_echo changed, call
216 gen_help_event to produce help-echo message in the echo area.
217 Call clear_mouse_face if mouse_face_hidden is set in the mouse
218 highlight info.
219
2202012-05-26 Paul Eggert <eggert@cs.ucla.edu>
221
222 * lread.c (read1): Simplify slightly to avoid an overflow warning
223 with GCC 4.7.0 on x86-64.
224
2252012-05-26 Eli Zaretskii <eliz@gnu.org>
226
227 * bidi.c (bidi_mirror_char): Revert last change: an int is
228 definitely wide enough here.
229
2302012-05-25 Paul Eggert <eggert@cs.ucla.edu>
231
232 Fix integer width and related bugs (Bug#9874).
233 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
234 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
235 (string_bytes, check_sblock, allocate_string_data):
236 (compact_small_strings, Fmake_bool_vector, make_string)
237 (make_unibyte_string, make_multibyte_string)
238 (make_string_from_bytes, make_specified_string)
239 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
240 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
241 (mark_vectorlike):
242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
243 (allocate_pseudovector):
244 Use int, not EMACS_INT, where int is wide enough.
245 (inhibit_garbage_collection, Fgarbage_collect):
246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
247 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
248 int might not be wide enough.
249 (bidi_cache_search, bidi_cache_find, bidi_init_it)
250 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
251 (bidi_at_paragraph_end, bidi_find_paragraph_start)
252 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
253 (bidi_level_of_next_char, bidi_move_to_visually_next):
254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
255 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
256 (Fkill_buffer, Fset_buffer_major_mode)
257 (advance_to_char_boundary, Fbuffer_swap_text)
258 (Fset_buffer_multibyte, overlays_at, overlays_in)
259 (overlay_touches_p, struct sortvec, record_overlay_string)
260 (overlay_strings, recenter_overlay_lists)
261 (adjust_overlays_for_insert, adjust_overlays_for_delete)
262 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
263 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
264 (Foverlay_recenter, last_overlay_modification_hooks_used)
265 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
267 (validate_region): Omit unnecessary test for b <= e,
268 since that's guaranteed by the previous test.
269 (adjust_overlays_for_delete): Avoid pos + length overflow.
270 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
271 (report_overlay_modification):
272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
273 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
274 Omit pointer cast, which isn't needed anyway, and doesn't work
275 after the EMACS_INT -> ptrdiff_t change.
276 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
277 * buffer.h: Adjust decls to match defn changes elsewhere.
278 (struct buffer_text, struct buffer):
279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
280 Use EMACS_INT, not int, where int might not be wide enough.
281 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
282 not int, to avoid needless 32-bit limit on 64-bit hosts.
283 (exec_byte_code): Use tighter memory-full test, one that checks
284 for alloca overflow. Don't compute the address of the object just
285 before an array, as that's not portable. Use EMACS_INT, not
286 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
287 * callint.c (Fcall_interactively):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 * callproc.c (call_process_kill, Fcall_process):
290 Don't assume pid_t fits into an Emacs fixnum.
291 (call_process_cleanup, Fcall_process, child_setup):
292 Don't assume pid_t fits into int.
293 (call_process_cleanup, Fcall_process, delete_temp_file)
294 (Fcall_process_region):
295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
296 (Fcall_process): Simplify handling of volatile integers.
297 Use int, not EMACS_INT, where int will do.
298 * casefiddle.c (casify_object, casify_region, operate_on_word)
299 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
301 (casify_object): Avoid integer overflow when overallocating buffer.
302 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
303 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
304 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
305 * category.h (CATEGORYP): Don't assume arg is nonnegative.
306 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
307 integers are now checked earlier. All uses replaced with XINT.
308 (ccl_driver):
309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
310 For CCL_MapSingle, check that content and value are in int range.
311 (ccl_driver, Fregister_code_conversion_map):
312 Check that Vcode_version_map_vector is a vector.
313 (resolve_symbol_ccl_program): Check that vector header is in range.
314 Always copy the vector, so that we can check its contents reliably
315 now rather than having to recheck each instruction as it's being
316 executed. Check that vector words fit in 'int'.
317 (ccl_get_compiled_code, Fregister_ccl_program)
318 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
319 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
320 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
321 contents are in range.
322 (Fccl_execute_on_string): Check that status is in range.
323 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
324 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
325 Accept and return EMACS_INT, not int, because callers can pass values
326 out of 'int' range.
327 (c_string_width, strwidth, lisp_string_width, chars_in_text)
328 (multibyte_chars_in_text, parse_str_as_multibyte)
329 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
330 (str_as_unibyte, str_to_unibyte, string_count_byte8)
331 (string_escape_byte8, Fget_byte):
332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
333 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
334 avoid mishandling large integers.
335 * character.h: Adjust decls to match defn changes elsewhere.
336 * charset.c (load_charset_map_from_file, find_charsets_in_text)
337 (Ffind_charset_region):
338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
339 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
340 (load_charset_map_from_vector, Fdefine_charset_internal):
341 Don't assume fixnum fits in int.
342 (load_charset_map_from_vector, Fmap_charset_chars):
343 Remove now-unnecessary CHECK_NATNUMs.
344 (Fdefine_charset_internal): Check ranges here, more carefully.
345 Don't rely on undefined behavior with signed left shift overflow.
346 Don't assume unsigned int fits into fixnum, or that fixnum fits
347 into unsigned int. Don't require max_code to be a valid fixnum;
348 that's not true for gb10830 4-byte on a 32-bit host. Allow
349 invalid_code to be a cons, for the same reason. Require code_offset
350 to be a character. Avoid int overflow if max_char is close
351 to INT_MAX.
352 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
353 this is intended anyway and avoids some undefined behavior.
354 (load_charset_map): Pass unsigned, not int, as 2nd arg of
355 INDEX_TO_CODE_POINT, as that's what it expects.
356 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
357 * charset.h (DECODE_CHAR): Return int, not unsigned;
358 this is what was intended anyway, and it avoids undefined behavior.
359 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
360 integer-overflow issues.
361 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
362 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
363 where the argument is EMACS_INT, and this behavior is not intended.
364 * chartab.c (Fmake_char_table, Fset_char_table_range)
365 (uniprop_get_decoder, uniprop_get_encoder):
366 Don't assume fixnum fits in int.
367 * cmds.c (move_point): New function, that does the gist of
368 Fforward_char and Fbackward_char, but does so while checking
369 for integer overflow more accurately.
370 (Fforward_char, Fbackward_char): Use it.
371 (Fforward_line, Fend_of_line, internal_self_insert)
372 (internal_self_insert):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 Fix a FIXME, by checking for integer overflow when calculating
375 target_clm and actual_clm.
376 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
377 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
378 (ASSURE_DESTINATION, coding_alloc_by_realloc)
379 (coding_alloc_by_making_gap, alloc_destination)
380 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
381 (encode_coding_utf_16, detect_coding_emacs_mule)
382 (decode_coding_emacs_mule, encode_coding_emacs_mule)
383 (detect_coding_iso_2022, decode_coding_iso_2022)
384 (encode_invocation_designation, encode_designation_at_bol)
385 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
386 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
387 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
388 (encode_coding_ccl, encode_coding_raw_text)
389 (detect_coding_charset, decode_coding_charset)
390 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
391 (produce_composition, produce_charset, produce_annotation)
392 (decode_coding, handle_composition_annotation)
393 (handle_charset_annotation, consume_chars, decode_coding_gap)
394 (decode_coding_object, encode_coding_object, detect_coding_system)
395 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
396 (code_convert_region, code_convert_string)
397 (Fdefine_coding_system_internal)
398 (coding_set_source, coding_set_destination):
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
401 (Fdefine_coding_system_internal):
402 Don't assume fixnums fit in int.
403 (decode_coding_gap, decode_coding_object, encode_coding_object)
404 (Fread_coding_system, Fdetect_coding_region)
405 (Funencodable_char_position, Fcheck_coding_systems_region)
406 (get_translation, handle_composition_annotation, consume_chars):
407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
408 (consume_chars): Rewrite to not calculate an address outside buffer.
409 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
410 Don't access memory outside of the args array.
411 (Fdefine_coding_system_internal): Check for charset-id overflow.
412 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
413 result of ENCODE_CHAR.
414 * coding.h: Adjust decls to match defn changes elsewhere.
415 (struct coding_system):
416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
417 * composite.c (get_composition_id, find_composition)
418 (run_composition_function, update_compositions)
419 (compose_text, composition_gstring_put_cache)
420 (composition_gstring_p, composition_gstring_width)
421 (fill_gstring_header, fill_gstring_body, autocmp_chars)
422 (composition_compute_stop_pos, composition_reseat_it)
423 (composition_update_it, struct position_record)
424 (find_automatic_composition, composition_adjust_point)
425 (Fcomposition_get_gstring, Ffind_composition_internal):
426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
427 (update_compositions):
428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
429 * composite.h: Adjust decls to match defn changes elsewhere.
430 (struct composition):
431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
432 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
433 Do not attempt to compute the address of the object just before a
434 buffer; this is not portable.
435 (Faref, Faset):
436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
437 (Faset): Use int, not EMACS_INT, where int is wide enough.
438 (Fstring_to_number): Don't assume fixnums fit in int.
439 (Frem): Don't assume arg is nonnegative.
440 * dbusbind.c (xd_append_arg): Check for integers out of range.
441 (Fdbus_call_method): Don't overflow the timeout int.
442 (extract_signed, extract_unsigned): New functions.
443 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
444 (xd_get_connection_references): Return ptrdiff_t, not int.
445 All uses changed.
446 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
447 (xd_read_message_1):
448 Use int, not unsigned, where the dbus API uses int.
449 (Fdbus_message_internal): Don't overflow mtype.
450 (syms_of_dbusbind): Allocate right-sized buffer for integers.
451 * dired.c (directory_files_internal, file_name_completion, scmp)
452 (file_name_completion_stat):
453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
454 (file_name_completion): Don't overflow matchcount.
455 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
456 * dispextern.h: Adjust decls to match defn changes elsewhere.
457 (struct text_pos, struct glyph, struct bidi_saved_info)
458 (struct bidi_string_data, struct bidi_it, struct composition_it)
459 (struct it):
460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
461 (struct display_pos, struct composition_it, struct it):
462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
463 * dispnew.c (increment_matrix_positions)
464 (increment_row_positions, mode_line_string)
465 (marginal_area_string):
466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
467 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
469 (duration_to_sec_usec): New function, to check for overflow better.
470 (Fsleep_for, sit_for): Use it.
471 * doc.c (get_doc_string, store_function_docstring):
472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
473 (get_doc_string, Fsnarf_documentation):
474 Use int, not EMACS_INT, where int is wide enough.
475 (get_doc_string):
476 Use SAFE_ALLOCA, not alloca. 513 Use SAFE_ALLOCA, not alloca.
477 Check for overflow when converting EMACS_INT to off_t. 514 (directory_file_name, Fexpand_file_name): Leave leading "//"
478 * doprnt.c (doprnt): 515 alone, since it can be special even on POSIX platforms.
479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough. 516 * callproc.c (call_process):
480 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid): 517 * process.c (Fformat_network_address):
481 Don't assume uid_t fits into fixnum. 518 * sysdep.c (sys_subshell):
482 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field) 519 Use encode_current_directory rather than rolling our own.
483 (Ffield_string, Ffield_string_no_properties, Ffield_beginning) 520 (create_process): No need to encode directory; caller does that now.
484 (Ffield_end, Fconstrain_to_field, Fline_beginning_position) 521 * process.h (encode_current_directory): New decl.
485 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before) 522 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
486 (general_insert_function) 523 Rework to avoid 'goto xyzzy;'.
487 (Finsert_char, make_buffer_string, make_buffer_string_both) 524
488 (update_buffer_properties, Fbuffer_substring) 5252013-08-23 Eli Zaretskii <eliz@gnu.org>
489 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings) 526
490 (Fsubst_char_in_region, check_translation) 527 * xdisp.c (handle_face_prop): If the default face was remapped use
491 (Ftranslate_region_internal, save_restriction_restore, Fformat) 528 the remapped face for strings from prefix properties. (Bug#15155)
492 (transpose_markers, Ftranspose_regions): 529
493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough. 5302013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
494 (clip_to_bounds): Move to lisp.h as an inline function). 531
495 (Fconstrain_to_field): Don't assume integers are nonnegative. 532 Minor cleanup for redisplay interface and few related functions.
496 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer): 533 * frame.h (enum text_cursor_kinds): Move from here...
497 (Fsubst_char_in_region, Fsave_restriction): 534 * dispextern.h (enum text_cursor_kinds): ...to here.
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts. 535 (toplevel): Drop unnecessary declarations.
499 (Femacs_pid): Don't assume pid_t fits into fixnum. 536 (struct redisplay_interface): Use bool and enum text_cursor_kinds
500 (lo_time): Use int, not EMACS_INT, when int suffices. 537 in update_window_end_hook and draw_window_cursor functions.
501 (lisp_time_argument): Check for usec out of range. 538 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
502 (Fencode_time): Don't assume fixnum fits in int. 539 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
503 (Fuser_login_name, Fuser_full_name): Signal an error 540 * w32term.c (x_update_window_end,w32_draw_window_cursor):
504 if a uid argument is out of range, rather than relying on 541 * xterm.c (x_update_window_end, x_draw_window_cursor):
505 undefined behavior. 542 * xdisp.c (display_and_set_cursor, update_window_cursor)
506 (Fformat_time_string): Remove now-unnecessary check. 543 (update_cursor_in_window_tree, x_update_cursor): Use bool and
507 lisp_time_argument checks for out-of-range usec now. 544 enum text_cursor_kinds where appropriate.
508 Use ptrdiff_t, not size_t, where ptrdiff_t will do. 545
509 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT. 5462013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
510 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT. 547
511 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT. 548 Redesign redisplay interface to drop updated_row and updated_area.
512 (init_cmdargs, Fdump_emacs): 549 * dispextern.h (updated_row, updated_area): Remove declaration.
513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts. 550 (struct redisplay_interface): Pass glyph row and row area parameters
514 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just 551 to write_glyphs, insert_glyphs and clear_end_of_line functions.
515 the bottom (typically) 32 bits of the fixnum. 552 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
516 * eval.c (specpdl_size, call_debugger): 553 Adjust prototypes.
517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough. 554 * dispnew.c (updated_row, updated_area): Remove.
518 (when_entered_debugger, Fbacktrace_debug): 555 (redraw_overlapped_rows, update_window_line): Adjust user.
519 Don't assume fixnum can fit in int. 556 (update_marginal_area, update_text_area): Likewise. Pass updated row
520 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of 557 as a parameter. Prefer enum glyph_row_area to int where appropriate.
521 the object just before a buffer; this is not portable. 558 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
522 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda) 559 Adjust users.
523 (grow_specpdl, unbind_to): 560
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts. 5612013-08-22 Paul Eggert <eggert@cs.ucla.edu>
525 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum. 562
526 (grow_specpdl): Simplify allocation by using xpalloc. 563 * process.c (flush_pending_output): Remove stub.
527 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify. 564 All uses removed.
528 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file) 565
529 (Finsert_file_contents, Fwrite_region, Fdo_auto_save): 5662013-08-21 Paul Eggert <eggert@cs.ucla.edu>
530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts. 567
531 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents) 568 * callproc.c: Fix race that killed background processes (Bug#15144).
532 (a_write, e_write): 569 (call_process): New arg TEMPFILE_INDEX. Callers changed.
533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough. 570 Record deleted process-id in critical section, not afterwards.
534 (Fcopy_file, non_regular_nbytes, read_non_regular) 571 Don't mistakenly kill process created by a call-process invocation
535 (Finsert_file_contents): 572 that discards output and does not wait.
536 Use int, not EMACS_INT, where int is wide enough. 573
537 (READ_BUF_SIZE): Verify that it fits in int. 5742013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
538 (Finsert_file_contents): Check that counts are in proper range, 575
539 rather than assuming fixnums fit into ptrdiff_t etc. 576 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
540 Don't assume fixnums fit into int. 577 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
541 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow. 578 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
542 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat) 579 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
543 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos) 580 to shut up compiler in mark_object.
544 (string_char_to_byte, string_byte_to_char) 581 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
545 (string_make_multibyte, string_to_multibyte) 582
546 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte) 5832013-08-21 Paul Eggert <eggert@cs.ucla.edu>
547 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties) 584
548 (substring_both, Fdelete, internal_equal, Ffillarray) 585 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
549 (Fclear_string, mapcar1) 586 We can't portably rely on PTY_OPEN doing that, even if
550 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1) 587 it calls posix_openpt with O_CLOEXEC.
551 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1) 588
552 (larger_vector, make_hash_table, maybe_resize_hash_table) 5892013-08-20 Kenichi Handa <handa@gnu.org>
553 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table) 590
554 (Fmaphash, secure_hash): 591 * character.c (string_char): Improve commentary.
555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough. 592
556 (concat): Check for string index and length overflow. 5932013-08-20 Paul Eggert <eggert@cs.ucla.edu>
557 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t. 594
558 (Frequire): 595 * image.c (SIGNATURE_DIGESTSIZE): Remove.
559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts. 596 (struct animation_cache): Make signature a flexible array member.
560 (larger_vector): New API (vec, incr_min, size_max) replaces old 597 All uses changed. This is a tad slower but may insulate us better
561 one (vec, new_size, init). This catches size overflow. 598 from future changes to ImageMagick.
562 INIT was removed because it was always Qnil.
563 All callers changed.
564 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
565 the upper bound on a hash table index size.
566 (make_hash_table, maybe_resize_hash_table): Use it.
567 (secure_hash): Computer start_byte and end_byte only after
568 they're known to be in ptrdiff_t range.
569 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
570 (Ffont_get_glyphs, Ffont_at):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
572 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
573 (Flist_fonts, Fopen_font):
574 Don't assume fixnum can fit in int.
575 (check_gstring): Don't assume index can fit in int.
576 (font_match_p): Check that fixnum is a character, not a nonnegative
577 fixnum, since the later code needs to stuff it into an int.
578 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
579 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
580 conversion overflow issues.
581 (Fopen_font): Check for integer out of range.
582 (Ffont_get_glyphs): Don't assume index can fit in int.
583 * font.h: Adjust decls to match defn changes elsewhere.
584 * fontset.c (reorder_font_vector): Redo score calculation to avoid
585 integer overflow.
586 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
587 printmax_t, where ptrdiff_t is wide enough.
588 (Finternal_char_font):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
591 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
592 (Fset_frame_position, x_set_frame_parameters)
593 (x_set_line_spacing, x_set_border_width)
594 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
595 Check that fixnums are in proper range for system types.
596 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
598 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
599 Use SAFE_ALLOCA_LISP, not alloca.
600 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
601 intptr_t is wide enough.
602 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
603 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
604 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
605 Check for fixnum out of range.
606 * ftfont.c (ftfont_list): Don't assume index fits in int.
607 Check that fixnums are in proper range for system types.
608 (ftfont_shape_by_flt):
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
612 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
613 Check that fixnums are in proper range for system types.
614 * gnutls.h: Adjust decls to match defn changes elsewhere.
615 * gtkutil.c (xg_dialog_run):
616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
617 (update_frame_tool_bar):
618 Check that fixnums are in proper range for system types.
619 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
620 (lookup_image): Check that fixnums are in range for system types.
621 * indent.c (last_known_column, last_known_column_point):
622 (current_column_bol_cache):
623 (skip_invisible, current_column, check_display_width):
624 (check_display_width, scan_for_column, current_column_1)
625 (Findent_to, Fcurrent_indentation, position_indentation)
626 (indented_beyond_p, Fmove_to_column, compute_motion):
627 (Fcompute_motion, Fvertical_motion):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 (last_known_column_modified): Use EMACS_INT, not int.
630 (check_display_width):
631 (Fcompute_motion):
632 Check that fixnums and floats are in proper range for system types.
633 (compute_motion): Don't assume index or fixnum fits in int.
634 (compute_motion, Fcompute_motion):
635 Use int, not EMACS_INT, when it is wide enough.
636 (vmotion): Omit local var start_hpos that is always 0; that way
637 we don't need to worry about overflow in expressions involving it.
638 * indent.h: Adjust decls to match defn changes elsewhere.
639 (struct position):
640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
641 Use int, not EMACS_INT, where int is wide enough.
642 Remove unused members ovstring_chars_done and tab_offset;
643 all uses removed.
644 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
645 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
646 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
647 (make_gap, copy_text, insert, insert_and_inherit)
648 (insert_before_markers, insert_before_markers_and_inherit)
649 (insert_1, count_combining_before, count_combining_after)
650 (insert_1_both, insert_from_string)
651 (insert_from_string_before_markers, insert_from_string_1)
652 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
653 (adjust_after_replace, adjust_after_insert, replace_range)
654 (replace_range_2, del_range, del_range_1, del_range_byte)
655 (del_range_both, del_range_2, modify_region)
656 (prepare_to_modify_buffer, signal_before_change)
657 (signal_after_change, Fcombine_after_change_execute):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 * intervals.c (traverse_intervals, rotate_right, rotate_left)
660 (balance_an_interval, split_interval_right, split_interval_left)
661 (find_interval, next_interval, update_interval)
662 (adjust_intervals_for_insertion, delete_node, delete_interval)
663 (interval_deletion_adjustment, adjust_intervals_for_deletion)
664 (static_offset_intervals, offset_intervals)
665 (merge_interval_right, merge_interval_left, make_new_interval)
666 (graft_intervals_into_buffer, temp_set_point_both)
667 (temp_set_point, set_point, adjust_for_invis_intang)
668 (set_point_both, move_if_not_intangible, get_property_and_range)
669 (get_local_map, copy_intervals, copy_intervals_to_string)
670 (compare_string_intervals, set_intervals_multibyte_1):
671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
672 * intervals.h: Adjust decls to match defn changes elsewhere.
673 (struct interval):
674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
675 * keyboard.c (this_command_key_count, this_single_command_key_start)
676 (before_command_key_count, before_command_echo_length, echo_now)
677 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
678 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
679 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
680 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
682 (last_non_minibuf_size, last_point_position, echo_truncate)
683 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
684 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
685 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
686 (stuff_buffered_input):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 (last_auto_save, command_loop_1, read_char):
689 Use EMACS_INT, not int, to avoid integer overflow.
690 (record_char): Avoid overflow in total_keys computation.
691 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
692 * keyboard.h: Adjust decls to match defn changes elsewhere.
693 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
694 (Fkey_description, Fdescribe_vector, Flookup_key):
695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
696 (click_position): New function, to check that positions are in range.
697 (Fcurrent_active_maps):
698 (describe_command):
699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 (Faccessible_keymaps, Fkey_description):
701 (preferred_sequence_p):
702 Don't assume fixnum can fit into int.
703 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
704 Check for integer overflow in size calculations.
705 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
706 avoid mishandling large integers.
707 * lisp.h: Adjust decls to match defn changes elsewhere.
708 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
709 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
710 (struct Lisp_Marker):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (clip_to_bounds): Now an inline function, moved here from editfns.c.
713 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
714 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
715 All callers changed.
716 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
717 Assume the arg has valid form, since it always does.
718 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
719 unsigned integer system type.
720 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
721 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
723 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
724 (duration_to_sec_usec): New decl.
725 * lread.c (read_from_string_index, read_from_string_index_byte)
726 (read_from_string_limit, readchar, unreadchar, openp)
727 (read_internal_start, read1, oblookup):
728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
729 (Fload, readevalloop, Feval_buffer, Feval_region):
730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
731 (openp): Check for out-of-range argument to 'access'.
732 (read1): Use int, not EMACS_INT, where int is wide enough.
733 Don't assume fixnum fits into int.
734 Fix off-by-one error that can read outside a buffer.
735 (read_filtered_event): Use duration_to_sec_usec
736 to do proper overflow checking on durations.
737 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
738 in size calculation.
739 (Fexecute_kbd_macro):
740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
741 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
742 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
743 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
744 (set_marker_both, set_marker_restricted_both, marker_position)
745 (marker_byte_position, Fbuffer_has_markers_at):
746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
747 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
748 * menu.c (ensure_menu_items): Rename from grow_menu_items.
749 It now merely ensures that the menu is large enough, without
750 necessarily growing it, as this avoids some integer overflow issues.
751 All callers changed.
752 (keymap_panes, parse_single_submenu, Fx_popup_menu):
753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
754 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
755 Use SAFE_ALLOCA_LISP, not alloca.
756 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
757 to EMACS_INT. Check that fixnums are in proper range for system types.
758 * minibuf.c (minibuf_prompt_width, string_to_object)
759 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
760 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (get_minibuffer, read_minibuf_unwind):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
765 this simplifies overflow checking. All callers changed.
766 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
767 (Ftest_completion):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
770 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
771 Check that fixnums are in proper range for system types.
772 (Fx_create_frame, Fx_show_tip):
773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
774 * nsfont.m (ns_findfonts, nsfont_list_family):
775 Don't assume fixnum fits in long.
776 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
778 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
779 wide enough.
780 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
782 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
783 (PRINTDECLARE, PRINTPREPARE):
784 (strout, print_string):
785 (print, print_preprocess, print_check_string_charset_prop)
786 (print_object):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 (PRINTDECLARE):
789 (temp_output_buffer_setup, Fprin1_to_string, print_object):
790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
791 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
792 (printchar, strout): Use xpalloc to catch size calculation overflow.
793 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
794 (print_error_message): Use SAFE_ALLOCA, not alloca.
795 (print_object): Use int, not EMACS_INT, where int is wide enough.
796 (print_depth, new_backquote_output, print_number_index):
797 Use ptrdiff_t, not int, where int might not be wide enough.
798 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
799 (Fset_process_window_size, Fformat_network_address)
800 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
801 (sigchld_handler):
802 Check that fixnums are in proper range for system types.
803 (Fsignal_process): Simplify by avoiding a goto.
804 Check for process-ids out of pid_t range rather than relying on
805 undefined behavior.
806 (process_tick, update_tick): Use EMACS_INT, not int.
807 (Fformat_network_address, read_process_output, send_process)
808 (Fprocess_send_region, status_notify):
809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
810 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
811 (wait_reading_process_output, read_process_output, exec_sentinel):
812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
813 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
814 (Faccept_process_output): Use duration_to_sec_usec to do proper
815 overflow checking on durations.
816 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
817 Don't assume pid_t fits in int.
818 * process.h (struct Lisp_Process): Members tick and update_tick
819 are now of type EMACS_INT, not int.
820 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
821 configured --with-wide-int.
822 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
823 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
824 * search.c (looking_at_1, string_match_1):
825 (fast_string_match, fast_c_string_match_ignore_case)
826 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
827 (scan_newline, find_before_next_newline, search_command)
828 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
829 (set_search_regs, wordify):
830 (Freplace_match):
831 (Fmatch_data):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 (string_match_1, search_buffer, set_search_regs):
834 (Fmatch_data):
835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
836 (wordify): Check for overflow in size calculation.
837 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
838 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
839 Check that fixnums are in proper range for system types.
840 * sound.c (struct sound_device)
841 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
843 (Fplay_sound_internal):
844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
845 * syntax.c (struct lisp_parse_state, find_start_modiff)
846 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
847 (Fparse_partial_sexp):
848 Don't assume fixnums can fit in int.
849 (struct lisp_parse_state, find_start_pos, find_start_value)
850 (find_start_value_byte, find_start_begv)
851 (update_syntax_table, char_quoted, dec_bytepos)
852 (find_defun_start, prev_char_comend_first, back_comment):
853 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
854 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
856 (Finternal_describe_syntax_value): Check that match_lisp is a
857 character, not an integer, since the code stuffs it into int.
858 (scan_words, scan_sexps_forward):
859 Check that fixnums are in proper range for system types.
860 (Fforward_word):
861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
862 (scan_sexps_forward):
863 Use CHARACTERP, not INTEGERP, since the value must fit into int.
864 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
865 * syntax.h: Adjust decls to match defn changes elsewhere.
866 (struct gl_state_s):
867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
868 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
869 MOST_POSITIVE_FIXNUM.
870 * sysdep.c (wait_for_termination_1, wait_for_termination)
871 (interruptible_wait_for_termination, mkdir):
872 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
873 (emacs_read, emacs_write):
874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
875 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
876 and double all fit in int.
877 * term.c (set_tty_color_mode):
878 Check that fixnums are in proper range for system types.
879 * termhooks.h (struct input_event):
880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
881 * textprop.c (validate_interval_range, interval_of)
882 (Fadd_text_properties, set_text_properties_1)
883 (Fremove_text_properties, Fremove_list_of_text_properties)
884 (Ftext_property_any, Ftext_property_not_all)
885 (copy_text_properties, text_property_list, extend_property_ranges)
886 (verify_interval_modification):
887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
888 (Fnext_single_char_property_change)
889 (Fprevious_single_char_property_change):
890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
891 (copy_text_properties):
892 Check for integer overflow in index calculation.
893 * undo.c (last_boundary_position, record_point, record_insert)
894 (record_delete, record_marker_adjustment, record_change)
895 (record_property_change):
896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
897 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
899 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
900 (Fx_hide_tip, Fx_file_dialog):
901 * w32menu.c (set_frame_menubar):
902 Use ptrdiff_t, not int, for consistency with rest of code.
903 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
904 (select_window, Fdelete_other_windows_internal)
905 (window_scroll_pixel_based, window_scroll_line_based)
906 (Frecenter, Fset_window_configuration):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (Fset_window_hscroll, run_window_configuration_change_hook)
909 (set_window_buffer, temp_output_buffer_show, scroll_command)
910 (Fscroll_other_window, Frecenter):
911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
912 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
913 Don't assume fixnum fits in int.
914 (Fset_window_scroll_bars):
915 Check that fixnums are in proper range for system types.
916 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
917 (string_pos, c_string_pos, number_of_chars, init_iterator)
918 (in_ellipses_for_invisible_text_p, init_from_display_pos)
919 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
920 (compute_display_string_end, handle_face_prop)
921 (face_before_or_after_it_pos, handle_invisible_prop)
922 (handle_display_prop, handle_display_spec, handle_single_display_spec)
923 (display_prop_intangible_p, string_buffer_position_lim)
924 (string_buffer_position, handle_composition_prop, load_overlay_strings)
925 (get_overlay_strings_1, get_overlay_strings)
926 (iterate_out_of_display_property, forward_to_next_line_start)
927 (back_to_previous_visible_line_start, reseat, reseat_to_string)
928 (get_next_display_element, set_iterator_to_next)
929 (get_visually_first_element, compute_stop_pos_backwards)
930 (handle_stop_backwards, next_element_from_buffer)
931 (move_it_in_display_line_to, move_it_in_display_line)
932 (move_it_to, move_it_vertically_backward, move_it_by_lines)
933 (add_to_log, message_dolog, message_log_check_duplicate)
934 (message2, message2_nolog, message3, message3_nolog
935 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
936 (current_message_1, truncate_echo_area, truncate_message_1)
937 (set_message, set_message_1, store_mode_line_noprop)
938 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
939 (text_outside_line_unchanged_p, check_point_in_composition)
940 (reconsider_clip_changes)
941 (redisplay_internal, set_cursor_from_row, try_scrolling)
942 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
943 (redisplay_window, find_last_unchanged_at_beg_row)
944 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
945 (trailing_whitespace_p, find_row_edges, display_line)
946 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
947 (display_mode_element, store_mode_line_string)
948 (pint2str, pint2hrstr, decode_mode_spec)
949 (display_count_lines, display_string, draw_glyphs)
950 (x_produce_glyphs, x_insert_glyphs)
951 (rows_from_pos_range, mouse_face_from_buffer_pos)
952 (fast_find_string_pos, mouse_face_from_string_pos)
953 (note_mode_line_or_margin_highlight, note_mouse_highlight):
954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
955 (safe_call, init_from_display_pos, handle_fontified_prop)
956 (handle_single_display_spec, load_overlay_strings)
957 (with_echo_area_buffer, setup_echo_area_for_printing)
958 (display_echo_area, echo_area_display)
959 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
960 (update_tool_bar, hscroll_window_tree, redisplay_internal)
961 (redisplay_window, dump_glyph_row, display_mode_line)
962 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
963 (handle_display_spec, display_prop_string_p):
964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
965 (handle_single_display_spec, build_desired_tool_bar_string)
966 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
967 (get_specified_cursor_type):
968 Check that fixnums are in proper range for system types.
969 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
970 (Flookup_image_map):
971 Don't assume fixnums fit in int.
972 (compare_overlay_entries):
973 Avoid mishandling comparisons due to subtraction overflow.
974 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
975 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
976 (handle_tool_bar_click):
977 Use int, not unsigned, since we prefer signed and the signedness
978 doesn't matter here.
979 (get_next_display_element, next_element_from_display_vector):
980 Use int, not EMACS_INT, when int is wide enough.
981 (start_hourglass): Use duration_to_sec_usec to do proper
982 overflow checking on durations.
983 * xfaces.c (Fbitmap_spec_p):
984 Check that fixnums are in proper range for system types.
985 (compare_fonts_by_sort_order):
986 Avoid mishandling comparisons due to subtraction overflow.
987 (Fx_family_fonts, realize_basic_faces):
988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
989 (Fx_family_fonts):
990 Don't assume fixnum fits in int.
991 Use SAFE_ALLOCA_LISP, not alloca.
992 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
993 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
994 (face_at_buffer_position, face_for_overlay_string)
995 (face_at_string_position):
996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
998 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
999 (Fx_show_tip):
1000 Check that fixnums are in proper range for system types.
1001 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1002 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 (Fx_change_window_property): Don't assume fixnums fit in int.
1005 * xfont.c (xfont_chars_supported):
1006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1007 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1008 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1010 * xml.c (parse_region):
1011 * xrdb.c (magic_file_p):
1012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1013 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1014 (x_get_local_selection, x_reply_selection_request)
1015 (x_handle_selection_request, wait_for_property_change):
1016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1017 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1018 short is wide enough.
1019 (x_send_client_event): Don't assume fixnum fits in int.
1020 * xterm.c (x_x_to_emacs_modifiers):
1021 Don't assume EMACS_INT overflows nicely into int.
1022 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1023 may come from Lisp.
1024 (handle_one_xevent): NATNUMP can eval its arg twice.
1025 (x_connection_closed):
1026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1027 * xterm.h: Adjust decls to match defn changes elsewhere.
1028 (struct scroll_bar): Use struct vectorlike_header
1029 rather than rolling our own approximation.
1030 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1031
10322012-05-25 Glenn Morris <rgm@gnu.org>
1033
1034 * lisp.mk (lisp): Update for more files being compiled now.
1035
10362012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1037
1038 * lread.c: Remove `read_pure' which makes no difference.
1039 (read_pure): Remove var.
1040 (unreadpure): Remove function.
1041 (readevalloop): Don't call read_list with -1 flag.
1042 (read1, read_vector): Don't test read_pure any more.
1043 (read_list): Simplify.
1044
1045 * fileio.c, character.h: Minor style tweaks.
1046
10472012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 * window.h (clip_changed): Remove useless declaration.
1050
10512012-05-22 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1054 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1055
10562012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 Remove src/m/*.
1059 This directory predates autoconf and is no longer needed nowadays.
1060 Move its few remaining bits of functionality to where they're needed.
1061 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1062 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1063 * m/template.h: Remove.
1064 * Makefile.in (M_FILE): Remove. All uses removed.
1065 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1066 * lisp.h (USE_LSB_TAG):
1067 * mem-limits.h (EXCEEDS_LISP_PTR):
1068 Use VAL_MAX, not VALBITS, in #if.
1069 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1070 (EMACS_UINT): Define unconditionally now.
1071 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1072 (BITS_PER_EMACS_INT): New constants, replacing
1073 what used to be in config.h, but not useful in #if.
1074 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1075 define them any more.
1076 (VAL_MAX): New macro.
1077 (VALMASK): Use it.
1078 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1079 BITS_PER_EMACS_INT, in #if.
1080 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1081 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1082 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1083 * s/ms-w32.h (DATA_START):
1084 Move here from removed file m/intel386.h.
1085 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1086 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1087
10882012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 Assume C89 or later.
1091 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1092 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1093 (xrealloc):
1094 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1095 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1096 * textprop.c, tparam.c (NULL): Remove.
1097 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1098 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1099 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1100 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1101 * xterm.c (input_signal_count): Assume volatile works.
1102
11032012-05-21 Ken Brown <kbrown@cornell.edu>
1104
1105 * xgselect.c (xg_select): Fix first argument in call to 'select'
1106 (bug#11508).
1107
11082012-05-20 Ken Brown <kbrown@cornell.edu>
1109
1110 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1111 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1112
11132012-05-19 Ken Brown <kbrown@cornell.edu>
1114
1115 * xfns.c (x_in_use): Remove `static' qualifier.
1116 * xterm.h (x_in_use): Declare.
1117 * xgselect.c: Include xterm.h.
1118 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1119 and `display_arg' (bug#9754).
1120 599
11212012-05-19 Paul Eggert <eggert@cs.ucla.edu> 6002013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1122 601
1123 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed. 602 * image.c: Shrink memory needed for animation cache.
603 (SIGNATURE_DIGESTSIZE): New constant.
604 (struct animation_cache): Make 'signature' a fixed size array of bytes.
605 (imagemagick_create_cache): Copy the signature. This saves
606 several KB of memory that ImageMagick wastes per signature.
607 Don't bother updating the update_time, as the caller does that now.
608 (imagemagick_prune_animation_cache): Don't destroy the signature, as
609 it's a fixed size struct member now.
610 (imagemagick_get_animation_cache): Always destroy the signature,
611 as it's now imagemagick_create_cache's responsibility to copy it.
612 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
613 and use memcmp rather than strcmp.
614 eassert that ImageMagick returns a signature of the specified length.
1124 615
1125 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed. 6162013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1126 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1127 617
11282012-05-18 Eli Zaretskii <eliz@gnu.org> 618 * image.c (imagemagick_get_animation_cache): Don't segfault on
619 each invocation.
620 (imagemagick_get_animation_cache): Revert to previous definition
621 so that it actually works. But keep the memory leak fix.
622 (imagemagick_get_animation_cache): Fix memory leak.
1129 623
1130 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows. 6242013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1131 625
1132 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font. 626 * image.c: Fix animation cache signature memory leak.
1133 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c 627 Fix some other minor performance problems while we're at it.
628 (imagemagick_create_cache): Clear just the members that
629 need clearing. Don't set update_time, as caller does that now.
630 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
631 Simplify by using pointer-to-pointer instead of a prev pointer.
632 (imagemagick_prune_animation_cache): Use make_emacs_time rather
633 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
634 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
635 it's already a copy. Free the signature probe unless it's cached.
1134 636
1135 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken 637 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1136 reference to image_cache->refcount. 638 This was introduced by my 2013-08-12 fix for Bug#15035.
1137 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1138 639
11392012-05-17 Juri Linkov <juri@jurta.org> 6402013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1140 641
1141 * search.c (Fword_search_regexp, Fword_search_backward) 642 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1142 (Fword_search_forward, Fword_search_backward_lax) 643 (imagemagick_prune_animation_cache): Now static.
1143 (Fword_search_forward_lax): Move functions to isearch.el
1144 (bug#10145, bug#11381).
1145 644
11462012-05-16 Paul Eggert <eggert@cs.ucla.edu> 6452013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1147 646
1148 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754). 647 * image.c (imagemagick_get_animation_cache): Don't segfault when
648 pruning all entries.
1149 649
11502012-05-15 Stefan Monnier <monnier@iro.umontreal.ca> 6502013-08-18 Ken Brown <kbrown@cornell.edu>
1151 651
1152 * lread.c (init_obarray): Declare Qt and Qnil as special. 652 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
653 static heap if ENABLE_CHECKING is defined.
654 (max_bss_sbrk_ptr): New variable.
655 (bss_sbrk): Use it.
656 (report_sheap_usage): Report maximum static heap usage instead of
657 ending static heap usage.
1153 658
11542012-05-14 Glenn Morris <rgm@gnu.org> 6592013-08-17 Eli Zaretskii <eliz@gnu.org>
1155 660
1156 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec"). 661 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1157 Put "libexec" before "bin", for the sake of init_callproc_1. 662 of zlib_initialized according to the results of calling
663 init_zlib_functions.
1158 664
11592012-05-14 Paul Eggert <eggert@cs.ucla.edu> 6652013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1160 666
1161 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local. 667 * image.c: Implement an ImageMagick per-image cache.
668 (imagemagick_get_animation_cache): Fix a double-free error.
669 (imagemagick_load_image): Remove the ping_wand code, which only
670 apparently saved time on invalid animated images, and slowed down
671 everything else. Optimise for the common case.
1162 672
1163 * unexaix.c: Port to more-recent AIX compilers. 6732013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1164 (report_error, report_error_1, make_hdr, copy_sym)
1165 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1166 Make arguments const char *, not char *, to avoid violations of C
1167 standard and to fix some AIX warnings reported by Gilles Pion.
1168 674
11692012-05-14 Eli Zaretskii <eliz@gnu.org> 675 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1170 676
1171 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we 677 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1172 already have overlays loaded.
1173 (handle_single_display_spec): Before returning without displaying
1174 fringe bitmap, synchronize the bidi iterator with the main display
1175 iterator, by calling iterate_out_of_display_property.
1176 (iterate_out_of_display_property): Detect buffer iteration by
1177 testing that it->string is a Lisp string.
1178 (get_next_display_element): When the current object is exhausted,
1179 and there's something on it->stack, call set_iterator_to_next to
1180 proceed with what's on the stack, instead of returning zero.
1181 (set_iterator_to_next): If called at the end of a Lisp string,
1182 proceed to consider_string_end without incrementing string
1183 position. Don't increment display vector index past the end of
1184 the display vector. (Bug#11417)
1185 (pos_visible_p): Don't report a position visible when move_it_to
1186 stopped at the last line of window, which happens to be scanned
1187 backwards by the bidi iteration. (Bug#11464)
1188 678
11892012-05-14 Eli Zaretskii <eliz@gnu.org> 679 * marker.c (set_marker): Remove documentation of undefined behavior.
1190 680
1191 * xdisp.c (handle_single_display_spec): Return 1 for left-margin 6812013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1192 and right-margin display specs even if the spec is invalid or we
1193 are on a TTY, and thus unable to display on the fringes.
1194 That's because the text with the property will not be displayed anyway,
1195 so we need to signal to the caller that this is a "replacing"
1196 display spec. This fixes display when the spec is invalid or we
1197 are on a TTY.
1198 682
11992012-05-14 Paul Eggert <eggert@cs.ucla.edu> 683 * image.c (imagemagick_compute_animated_image): Animate correctly
684 when sub-images are smaller than the main image.
685 (imagemagick_compute_animated_image): Setting the iterator row to
686 zero is apparently not allowed.
687 (imagemagick_compute_animated_image): Allow images that say they
688 have sub-images that are bigger than the main image, but just crop
689 them.
1200 690
1201 * unexaix.c (make_hdr): Fix typo in prototype. 6912013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1202 This bug broke the build on AIX. Problem reported by Gilles Pion.
1203 692
12042012-05-14 Michael Albinus <michael.albinus@gmx.de> 693 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1205 694
1206 * keyboard.c (kbd_buffer_get_event): Read special events also in 6952013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1207 batch mode. (Bug#11415)
1208 696
12092012-05-12 Glenn Morris <rgm@gnu.org> 697 * image.c (imagemagick_compute_animated_image): Respect the GIF
698 disposal methods.
1210 699
1211 * ns.mk: Update for ns_appbindir no longer having trailing "/". 7002013-08-15 Ken Brown <kbrown@cornell.edu>
1212 701
12132012-05-12 Eli Zaretskii <eliz@gnu.org> 702 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
703 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
704 needed.
1214 705
1215 * lisp.mk (lisp): Add newcomment.elc. 7062013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1216 707
12172012-05-12 Glenn Morris <rgm@gnu.org> 708 Fix minor problems found by static checking.
709 * frame.c (delete_frame):
710 * xdisp.c (next_element_from_display_vector):
711 Avoid uninitialized local.
712 * image.c (imagemagick_compute_animated_image): Port to C89.
713 Prefer usual GNU indentation style for loops.
714 Be more careful about bizarrely large sizes, by using ptrdiff_t
715 instead of int.
716
7172013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
718
719 Fix infinite frame selection loop (Bug#15025).
720 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
721
7222013-08-15 Eli Zaretskii <eliz@gnu.org>
723
724 * xdisp.c (compute_window_start_on_continuation_line):
725 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
726 to make sure we end up setting the window start at the leftmost
727 visible character of the display line. This avoids funky
728 horizontal shifting because the window start is not kept on the
729 same position. (Bug#15090)
730 (next_element_from_display_vector): Support 'box' face attribute
731 in the face definitions of a display vector. (Bug#15099)
732
7332013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
734
735 * image.c (imagemagick_compute_animated_image): Implement animated
736 images (bug#14700).
737 (imagemagick_compute_animated_image): Fix some compilation
738 warnings. Implement a very simple cache to make the animation
739 usable at all, but it should be replaced with a per-image cache.
740
7412013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
742
743 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
744 to do `for' loops over alist values.
745 * buffer.h (FOR_EACH_BUFFER):
746 * process.c (FOR_EACH_PROCESS): Use it.
747 (handle_child_signal, status_notify, Fget_buffer_process)
748 (kill_buffer_processes): Use FOR_EACH_PROCESS.
749
7502013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
751
752 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
753 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
754 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
755 to xzalloc and so avoid redundant call to memset.
756 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
757 members because it is allocated with xzalloc and so already zeroed.
758
7592013-08-14 Ken Brown <kbrown@cornell.edu>
760
761 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
762 (Bug#15094).
763
7642013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
765
766 Utility function and macro to copy Lisp string to C string.
767 * lisp.h (xlispstrdupa): New macro.
768 (xlispstrdup): New prototype.
769 * alloc.c (xlispstrdup): New function.
770 * callint.c (Fcall_interactively):
771 * fileio.c (Ffile_name_directory, Fexpand_file_name)
772 (Fsubstitute_in_file_name):
773 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
774 * image.c (x_create_bitmap_from_file):
775 * w32term.c (w32_term_init):
776 * xterm.c (x_term_init): Use xlispstrdup.
1218 777
1219 * Makefile.in (MKDIR_P): New, set by configure. 7782013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1220 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1221 779
12222012-05-11 Paul Eggert <eggert@cs.ucla.edu> 780 * image.c (imagemagick_load_image): Make animated pictures work.
781 There's still some problems with background color settings, though
782 (bug#14700).
1223 783
1224 Remove unused function hourglass_started. 784 * decompress.c (unwind_decompress): Always restore point.
1225 * dispextern.h (hourglass_started):
1226 * w32fns.c (hourglass_started):
1227 * xdisp.c (hourglass_started): Remove.
1228 785
12292012-05-10 Juanma Barranquero <lekktu@gmail.com> 7862013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1230 787
1231 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)): 788 * marker.c (set_marker): Reformat documentation.
1232 Update dependencies.
1233 789
12342012-05-10 Paul Eggert <eggert@cs.ucla.edu> 7902013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1235 791
1236 * xgselect.c (xg_select): Put maxfds+1 into a var. 792 * xdisp.c (cursor_type_changed): Now static.
1237 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1238 793
1239 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA. 794 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1240 795 Use changed. This avoids the need to call xmalloc and for the
12412012-05-10 Dave Abrahams <dave@boostpro.com> 796 caller to call xfree, and avoids memory leaks in some situations.
1242 797
1243 * filelock.c (syms_of_filelock): New boolean create-lockfiles. 7982013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1244 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1245 799
12462012-05-09 Michael Albinus <michael.albinus@gmx.de> 800 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
801 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
802 (redisplay_window): If window_end_valid is cleared due to non-zero
803 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
804 so do not call to try_cursor_movement for that window.
1247 805
1248 * dbusbind.c (xd_registered_buses): New internal Lisp object. 8062013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1249 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1250 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1251 Initialize xd_registered_buses.
1252 807
12532012-05-09 Paul Eggert <eggert@cs.ucla.edu> 808 * window.h (struct window): Convert window_end_pos and
1254 809 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1255 Untag more efficiently if USE_LSB_TAG. 810 (wset_window_end_pos, wset_window_end_vpos): Remove.
1256 This is based on a proposal by YAMAMOTO Mitsuharu in 811 * dispnew.c (adjust_glyph_matrix):
1257 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>. 812 * window.c (Fwindow_end, replace_window, set_window_buffer)
1258 For an admittedly artificial (nth 8000 longlist) benchmark on 813 (make_window):
1259 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks 814 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1260 Emacs's overall text size by 1%. 815 (set_vertical_scroll_bar, redisplay_window, try_window)
1261 * lisp.h (XUNTAG): New macro. 816 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1262 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW) 817 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1263 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR) 818 (note_mouse_highlight): Adjust users.
1264 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it. 819 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1265 * eval.c (Fautoload): 820 Add comment.
1266 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1267 * frame.h (XFRAME): Use XUNTAG.
1268 821
1269 Port recent dbusbind.c changes to 32-bit --with-wide-int. 8222013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1270 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1271 Remove unportable assumptions about print widths of types like
1272 dbus_uint32_t.
1273 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1274 intptr_t when converting between pointer and integer, to avoid GCC
1275 warnings about wrong width.
1276 823
12772012-05-09 Eli Zaretskii <eliz@gnu.org> 824 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
825 * image.c (imagemagick_filename_hint): Use `const char *' and
826 prefer SSDATA to SDATA to avoid warnings.
1278 827
1279 * w32proc.c (new_child): Force Windows to reserve only 64KB of 8282013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1280 stack for each reader_thread, instead of defaulting to 8MB
1281 determined by the linker. This avoids failures in creating
1282 subprocesses on Windows 7, see the discussion in this thread:
1283 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1284 829
12852012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com> 830 Cleanup window fringes, margins and scroll bars adjustments.
831 * window.c (set_window_fringes, set_window_margins)
832 (set_window_scroll_bars, apply_window_adjustment): New functions.
833 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
834 (Fset_window_scroll_bars): Use them.
1286 835
1287 Fix up display of the *Minibuf-0* buffer in the mini window. 8362013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1288 * keyboard.c (read_char): Don't clear the echo area if there's no
1289 message to clear.
1290 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1291 contents of *Minibuf-0*) if there's no message displayed in its stead.
1292 837
12932012-05-07 Michael Albinus <michael.albinus@gmx.de> 838 * window.h (struct window): Convert scroll_bar_width
839 from Lisp_Object to integer. Adjust comment.
840 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
841 Adjust users.
842 * window.c (wset_scroll_bar_width): Remove.
843 (make_window): Initialize scroll_bar_width.
844 (Fsplit_window_internal): Use direct assignment.
845 (Fset_window_configuration, save_window_save):
846 Convert Lisp_Object to integer and back where appropriate.
847 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
848 bar was actually changed, and mention this in docstring.
1294 849
1295 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in 8502013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1296 batch mode.
1297 851
12982012-05-06 Chong Yidong <cyd@gnu.org> 852 * decompress.c: Minor simplifications.
853 (Fzlib_decompress_region): Don't bother verifying
854 that avail_out <= UINT_MAX, as that was confusing.
855 Mention the restriction in a comment instead.
856 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1299 857
1300 * lisp.mk (lisp): Update. 8582013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1301 859
13022012-05-05 Jim Meyering <meyering@redhat.com> 860 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
861 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1303 862
1304 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372). 8632013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1305 864
13062012-05-04 Stefan Monnier <monnier@iro.umontreal.ca> 865 * image.c (imagemagick_filename_hint): Check for errors in the
866 alist structure.
1307 867
1308 * data.c (PUT_ERROR): New macro. 8682013-08-13 Eli Zaretskii <eliz@gnu.org>
1309 (syms_of_data): Use it. Add new error type `user-error'.
1310 * undo.c (user_error): New function.
1311 (Fprimitive_undo): Use it.
1312 * print.c (print_error_message): Adjust print style for `user-error'.
1313 * keyboard.c (user_error): New function.
1314 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1315 869
13162012-05-03 Paul Eggert <eggert@cs.ucla.edu> 870 * window.c (Fwindow_margins): Return nil when there's no marginal
871 area, as per the documented API.
1317 872
1318 Do not limit current-time-string to years 1000..9999. 873 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1319 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove. 874 Fmake_vector, as scroll bar's struct members are not all Lisp
1320 (Fcurrent_time_string): Support any year that is supported by the 875 objects now. This avoids crashes in GC.
1321 underlying localtime representation. Don't use asctime, as it
1322 has undefined behavior for years outside the range -999..9999.
1323 876
13242012-05-02 Paul Eggert <eggert@cs.ucla.edu> 877 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
878 bool, so its address could be taken.
1325 879
1326 Fix race conditions involving setenv, gmtime, localtime, asctime. 8802013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327 Without this fix, interrupts could mess up code that uses these
1328 nonreentrant functions, since setting TZ invalidates existing
1329 tm_zone or tzname values, and since most of these functions return
1330 pointers to static storage.
1331 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1332 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1333 Grow the critical sections to include not just invoking
1334 localtime/gmtime, but also accessing these functions' results
1335 including their tm_zone values if any, and any related TZ setting.
1336 (format_time_string): Last arg is now struct tm *, not struct tm **,
1337 so that the struct tm is saved in the critical section.
1338 All callers changed. Simplify allocation of initial buffer, partly
1339 motivated by the fact that memory allocation needs to be outside
1340 the critical section.
1341
13422012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1343
1344 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1345 with RESET_INTERVAL.
1346 881
1347 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): 882 * image.c (imagemagick_filename_hint): New function to possibly
1348 Remove duplicated buffer name initialization. 883 apply `image-content-type-suffixes'.
884 (imagemagick_load_image): Use it.
1349 885
13502012-05-02 Jim Meyering <jim@meyering.net> 8862013-08-13 Eli Zaretskii <eliz@gnu.org>
1351 887
1352 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373). 888 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
889 if loading zlib failed.
1353 890
1354 * xfns.c (x_window): Use xstrdup (Bug#11375). 8912013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1355 892
13562012-05-02 Eli Zaretskii <eliz@gnu.org> 893 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
894 2013-08-13 checkin below. Change bool to BOOL, rule is:
895 All Obj-C code uses BOOL, except for interfaces callable from C.
1357 896
1358 * xdisp.c (pos_visible_p): If already at a newline from the 897 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1359 display string before the 'while' loop, don't walk back the glyphs
1360 from it3.glyph_row. Solves assertion violation when the display
1361 string begins with a newline (egg.el). (Bug#11367)
1362 898
13632012-05-01 Stefan Monnier <monnier@iro.umontreal.ca> 8992013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1364 900
1365 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings): 901 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1366 Move to simple.el. 902 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
903 bool instead of BOOL.
904 * w32term.h (struct scroll_bar): Convert fringe_extended_p
905 from Lisp_Object to bitfield. Adjust comment.
906 * w32term.c (x_scroll_bar_create): Adjust user.
907 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
908 * xterm.c (XTset_vertical_scroll_bar): Likewise.
909 Use bool for boolean.
910 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
911 to `unsigned int' when defining a bitfield.
1367 912
13682012-05-01 Glenn Morris <rgm@gnu.org> 9132013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1369 914
1370 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in 915 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1371 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1372 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1373 All were removed before 23.1.
1374 916
1375 * dispnew.c: Remove HAVE_LIBNCURSES test; 9172013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1376 it is always true on relevant platforms.
1377 918
1378 * Makefile.in (LD_SWITCH_X_SITE_RPATH): 919 * window.h (struct window): Convert left_margin_cols and
1379 Rename from LD_SWITCH_X_SITE_AUX_RPATH. 920 right_margin_cols from Lisp_Objects to integers. Adjust comment.
921 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
922 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
923 Adjust users.
924 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
925 Adjust comment.
926 (showing_window_margins_p, update_window_line, update_frame_1):
927 * fringe.c (draw_fringe_bitmap_1):
928 * xdisp.c (window_box_width): Adjust users.
929 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
930 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
931 Use direct assignment.
932 (Fset_window_configuration, save_window_save, Fwindow_margins):
933 Convert Lisp_Object to integer and back where appropriate.
934 (Fset_window_margins): Adjust user. Return t if any margin
935 was actually changed, and mention this in docstring.
1380 936
1381 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used. 9372013-08-13 Xue Fuqiao <xfq.free@gmail.com>
938
939 * syntax.c (forward_word):
940 * cmds.c (forward_char, backward_char): Mention the optional argument.
1382 941
13832012-04-30 Andreas Schwab <schwab@linux-m68k.org> 9422013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1384 943
1385 * .gdbinit (xpr): Remove checks for no longer existing misc types. 944 * window.h (struct window): Convert left_fringe_width
1386 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal): 945 and right_fringe_width from Lisp_Objects to integers.
946 Adjust comment.
947 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
948 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
949 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1387 Remove. 950 Remove.
951 (make_window): Initialize new integer fields to -1.
952 (Fsplit_window_internal): Use direct assignment.
953 (Fset_window_configuration, save_window_save):
954 Convert Lisp_Object to integer and back where appropriate.
955 (Fset_window_fringes): Adjust user. Return t if any fringe
956 was actually changed, and mention this in docstring.
1388 957
13892012-04-28 Paul Eggert <eggert@cs.ucla.edu> 9582013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1390
1391 Do not avoid creating empty evaporating overlays (Bug#9642).
1392 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1393 That is, do not delete an evaporating overlay if it becomes
1394 empty after its bounds are adjusted to fit within its buffer.
1395 This fix caused other problems, and I'm reverting it until we get
1396 to the bottom of them.
1397
13982012-04-27 Chong Yidong <cyd@gnu.org>
1399
1400 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1401
14022012-04-27 Eli Zaretskii <eliz@gnu.org>
1403
1404 * xdisp.c (pos_visible_p): If the window start position is beyond
1405 ZV, start the display from buffer beginning. Prevents assertion
1406 violation in init_iterator when the minibuffer window is scrolled
1407 via the scroll bar.
1408
1409 * window.c (window_scroll_pixel_based): Likewise.
1410
14112012-04-27 Chong Yidong <cyd@gnu.org>
1412
1413 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1414
14152012-04-27 Glenn Morris <rgm@gnu.org>
1416
1417 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1418 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1419
14202012-04-27 Eli Zaretskii <eliz@gnu.org>
1421
1422 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1423 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1424
14252012-04-26 Eli Zaretskii <eliz@gnu.org>
1426
1427 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1428 display element, check also the underlying string or buffer
1429 character. (Bug#11341)
1430
1431 * w32menu.c: Include w32heap.h.
1432 (add_menu_item): If the call to AppendMenuW (via
1433 unicode_append_menu) fails, disable Unicode menus only if we are
1434 running on Windows 9X/Me.
1435
14362012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1437
1438 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1439 (xgetint): Add missing shift for LSB tags.
1440
14412012-04-24 Martin Rudalics <rudalics@gmx.at>
1442
1443 * keyboard.c (read_char): Don't wipe echo area for select window
1444 events: These might get delayed via `mouse-autoselect-window'
1445 (Bug#11304).
1446
14472012-04-24 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1450 manipulation of :loaded-from data.
1451
14522012-04-23 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1455 now a cons (bug#11311).
1456
14572012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 Do not create empty overlays with the evaporate property (Bug#9642).
1460 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1461 if it becomes empty after its bounds are adjusted to fit within
1462 its buffer. Without this fix, in a nonempty buffer (let ((o
1463 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1464 yields an empty overlay that has the evaporate property, which is
1465 not supposed to happen.
1466
1467 Fix minor GTK3 problems found by static checking.
1468 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1469 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1470 (struct _EmacsFixedClass, emacs_fixed_get_type):
1471 Move decls here from emacsgtkfixed.h, since they needn't be public.
1472 (emacs_fixed_get_type): Now static.
1473 (emacs_fixed_class_init): Omit unused local.
1474 (emacs_fixed_child_type): Remove; unused.
1475 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1476 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1477 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1478 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1479 (EMACS_FIXED_GET_CLASS): Remove; unused.
1480 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1481
1482 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1483 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1484
14852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1488 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1489 (__malloc_size_t, __malloc_ptrdiff_t):
1490 Remove. All uses removed, replaced by the definiens if needed,
1491 since we can assume C89 or better now.
1492 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1493 (protect_malloc_state, align, get_contiguous_space)
1494 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1495 (malloc_atfork_handler_child, malloc_enable_thread)
1496 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1497 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1498 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1499 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1500 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1501 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1502 Define using prototypes, not old style.
1503 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1504 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1505 (align): Don't assume that signed integer overflow wraps around.
1506 Omit unused local var.
1507 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1508 (_free_internal_nolock, memalign, mallochook, reallochook):
1509 Omit no-longer-needed casts.
1510 (valloc): Use getpagesize, not __getpagesize.
1511 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1512 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1513
1514 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1515
15162012-04-22 Michael Albinus <michael.albinus@gmx.de>
1517
1518 Move functions from C to Lisp. Make non-blocking method calls
1519 the default. Implement further D-Bus standard interfaces.
1520
1521 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1522 (QCdbus_request_name_allow_replacement)
1523 (QCdbus_request_name_replace_existing)
1524 (QCdbus_request_name_do_not_queue)
1525 (QCdbus_request_name_reply_primary_owner)
1526 (QCdbus_request_name_reply_in_queue)
1527 (QCdbus_request_name_reply_exists)
1528 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1529 (QCdbus_registered_serial, QCdbus_registered_method)
1530 (QCdbus_registered_signal): New Lisp objects.
1531 (XD_DEBUG_MESSAGE): Use sizeof.
1532 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1533 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1534 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1535 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1536 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1537 (xd_signature, xd_append_arg): Allow float for integer types.
1538 (xd_get_connection_references): New function.
1539 (xd_get_connection_address): Rename from xd_initialize.
1540 Return cached address.
1541 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1542 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1543 level.
1544 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1545 Return number of refcounts.
1546 (Fdbus_get_unique_name): Make stronger parameter check.
1547 (Fdbus_message_internal): New defun.
1548 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1549 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1550 (Fdbus_send_signal, Fdbus_register_service)
1551 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1552 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1553 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1554 (Vdbus_compiled_version, Vdbus_runtime_version)
1555 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1556 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1557 (Vdbus_message_type_signal): New defvars.
1558 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1559 Adapt docstring.
1560
15612012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1564 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1565 Do not assume ptrdiff_t is the same width as 'int'.
1566
1567 * alloc.c: Handle unusual debugging option combinations.
1568 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1569 since the two debugging options are incompatible.
1570 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1571 is defined.
1572 (mem_init, mem_insert, mem_insert_fixup):
1573 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1574 (NEED_MEM_INSERT): Remove; no longer needed.
1575
15762012-04-22 Leo Liu <sdl.web@gmail.com>
1577
1578 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1579
15802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 * sysdep.c [__FreeBSD__]: Minor cleanups.
1583 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1584 Use Emacs indenting style more consistently. Avoid some casts.
1585 Use 'double' consistently rather than mixing 'float' and 'double'.
1586
15872012-04-21 Eduard Wiebe <usenet@pusto.de>
1588
1589 * sysdep.c (list_system_processes, system_process_attributes):
1590 Add implementation for FreeBSD (Bug#5243).
1591
15922012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1593
1594 * lisp.mk (lisp): Update.
1595
15962012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1599 It is never used otherwise.
1600
16012012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1602
1603 * print.c (print_preprocess): Only check print_depth if print-circle
1604 is nil.
1605 (print_object): Check for cycles even when print-circle is nil and
1606 print-gensym is t, but only check print_depth if print-circle is nil.
1607
16082012-04-20 Chong Yidong <cyd@gnu.org>
1609
1610 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1611 set the status to "failed" and ensure that sentinel is run.
1612
16132012-04-20 Glenn Morris <rgm@gnu.org>
1614
1615 * process.c (Fset_process_inherit_coding_system_flag)
1616 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1617 (Fmake_network_process, Fmake_serial_process): Doc fix.
1618
16192012-04-20 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (string_buffer_position_lim): Limit starting position to
1622 BEGV.
1623 (set_cursor_from_row): If called for a mode-line or header-line
1624 row, return zero immediately.
1625 (try_cursor_movement): If inside continuation line, don't back up
1626 farther than the first row after the header line, if any.
1627 Don't consider the header-line row as "partially visible", even if
1628 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1629
16302012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1631
1632 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1633 (bug#11238).
1634
16352012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
16362012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 configure: new option --enable-gcc-warnings (Bug#11207)
1639 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1640 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1641 (ALL_CFLAGS): Use new macros rather than old.
1642 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1643 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1644 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1645 -Wunused-result, -Wunused-variable. This should go away once
1646 the Emacs and Gnulib regex code is merged.
1647 (xmalloc, xrealloc): Now static.
1648
16492012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 * dired.c (Fsystem_groups): Remove unused local.
1652
16532012-04-17 Glenn Morris <rgm@gnu.org>
1654
1655 * dired.c (Fsystem_users): Doc fix.
1656
16572012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1658
1659 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1660 (syms_of_dired): Add them.
1661
16622012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 Fix minor alloc.c problems found by static checking.
1665 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1666 New extern decls, to avoid calling undeclared functions.
1667 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1668 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1669 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1670 (NEED_MEM_INSERT): New macro.
1671 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1672 Remove one incorrect comment and fix another.
1673
1674 Fix minor ralloc.c problems found by static checking.
1675 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1676 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1677 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1678 (r_alloc_sbrk): Now static.
1679
1680 Improve ralloc.c interface checking.
1681 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1682 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1683 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1684 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1685 [REL_ALLOC]: ... to here, to check interface.
1686 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1687 Remove decls. This fixes an "It stinks!".
1688
1689 * alloc.c (which_symbols): Fix alignment issue / type clash.
1690
16912012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1694 (struct Lisp_Misc_Any): Likewise.
1695 (struct Lisp_Free): Likewise.
1696 * alloc.c (union aligned_Lisp_Symbol): Define.
1697 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1698 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1699 (union aligned_Lisp_Misc): Define.
1700 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1701 aligned_Lisp_Misc instead of union Lisp_Misc.
1702 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1703
17042012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1707 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1708 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1709 * s/netbsd.h, s/sol2-6.h:
1710 Remove definition of GC_MARK_STACK, since the default now works.
1711 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1712 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1713 no longer the default.
1714 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1715
17162012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1717
1718 * lread.c (lisp_file_lexically_bound_p):
1719 Fix hang at ";-*-\n" (bug#11238).
1720
17212012-04-14 Eli Zaretskii <eliz@gnu.org>
1722
1723 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1724 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1725
17262012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1727
1728 * nsterm.m (constrainFrameRect): Always constrain when there is only
1729 one screen (Bug#10962).
1730
17312012-04-13 Ken Brown <kbrown@cornell.edu>
1732
1733 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1734
17352012-04-13 Reuben Thomas <rrt@sc3d.org>
1736
1737 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1738
17392012-04-11 Daniel Colascione <dancol@dancol.org>
1740
1741 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1742 against is gone. It's better to use vfork now so that when Cygwin
1743 gains a new, working vfork, we use it automatically (bug#10398).
1744
17452012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1746
1747 * window.c (save_window_save): Obey window-point-insertion-type.
1748
17492012-04-11 Glenn Morris <rgm@gnu.org>
1750
1751 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1752
17532012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1754
1755 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1756
17572012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1758
1759 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1760 (force_quit_count): New var.
1761 (handle_interrupt): Use it.
1762
17632012-04-10 Juanma Barranquero <lekktu@gmail.com>
1764
1765 * w32.c (w32_delayed_load): Record the full path of the library
1766 being loaded (bug#10424).
1767
17682012-04-09 Glenn Morris <rgm@gnu.org>
1769
1770 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1771 not just in the obarray, before snarfing them. (Bug#11036)
1772
1773 * Makefile.in ($(leimdir)/leim-list.el):
1774 Pass EMACS rather than BUILT_EMACS.
1775
17762012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1777
1778 * process.c (make_process):
1779 * process.h: Add integer `gnutls_handshakes_tried' member to
1780 process struct.
1781
1782 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1783 Add convenience `GNUTLS_LOG2i' macro.
1784
1785 * gnutls.c (gnutls_log_function2i): Convenience log function.
1786 (emacs_gnutls_read): Use new log functions,
1787 `gnutls_handshakes_tried' process member, and
1788 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1789 attempts per process (connection).
1790
17912012-04-09 Chong Yidong <cyd@gnu.org>
1792
1793 * eval.c (Fuser_variable_p, user_variable_p_eh)
1794 (lisp_indirect_variable): Functions deleted.
1795 (Fdefvar): Caller changed.
1796
1797 * callint.c (Finteractive, Fcall_interactively):
1798 * minibuf.c (Fread_variable): Callers changed.
1799
18002012-04-09 Eli Zaretskii <eliz@gnu.org>
1801
1802 * xdisp.c (set_cursor_from_row): If the display string appears in
1803 the buffer at position that is closer to point than the position
1804 after the display string, display the cursor on the first glyph of
1805 the display string. Fixes cursor display when a 'display' text
1806 property immediately follows invisible text. (Bug#11094)
1807
18082012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 composite.c: use 'double' consistently
1811 * composite.c (get_composition_id): Use 'double' consistently
1812 instead of converting 'float' to 'double' and vice versa; this is
1813 easier to understand and avoids a GCC warning.
1814
18152012-04-09 Glenn Morris <rgm@gnu.org>
1816
1817 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1818 preparation for dumping it with emacs. (Bug#4789)
1819 (leimdir): New variable.
1820 ($(leimdir)/leim-list.el): New rule.
1821 (emacs$(EXEEXT)): Depend on leim-list.el.
1822
1823 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1824 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1825 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1826
18272012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1828
1829 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1830 proper alignment.
1831
18322012-04-07 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1835 Remove unused local variable.
1836
18372012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1840 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1841 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1842 objects, as mark_maybe_pointer will catch them otherwise.
1843 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1844 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1845
18462012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 Fix typo that broke non-Windows builds.
1849 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1850
18512012-04-07 Eli Zaretskii <eliz@gnu.org>
1852
1853 Support building on MS-Windows with libxml2.
1854
1855 * makefile.w32-in (OBJ2): Add xml.$(O).
1856 (GLOBAL_SOURCES): Add xml.c.
1857 ($(BLD)/xml.$(O)): New dependency list.
1858
1859 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1860 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1861 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1862 [!WINDOWSNT]: New macros.
1863 (init_libxml2_functions, libxml2_loaded_p): New functions.
1864 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1865 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1866 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1867 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1868 linked in).
1869 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1870 Call init_libxml2_functions before calling libxml2 functions.
1871 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1872
1873 * emacs.c: Don't include libxml/parser.h.
1874 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1875 xmlCleanupParser directly.
1876
1877 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1878
18792012-04-07 Eli Zaretskii <eliz@gnu.org>
1880
1881 * indent.c (Fvertical_motion): If there is a display string at
1882 point, use it.vpos to compute how many lines to backtrack after
1883 move_it_to point. (Bug#11133)
1884
18852012-04-06 Eli Zaretskii <eliz@gnu.org>
1886
1887 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1888 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1889 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1890 macros related to unification of CJK characters. For the details,
1891 see the discussion following the message here:
1892 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1893
18942012-04-04 Chong Yidong <cyd@gnu.org>
1895
1896 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1897
18982012-04-01 Eli Zaretskii <eliz@gnu.org>
1899
1900 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1901 instead of alloca. (Bug#11138)
1902
19032012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1904
1905 * w32menu.c (is_simple_dialog): Properly check lisp types.
1906 (Bug#11141)
1907
19082012-03-31 Eli Zaretskii <eliz@gnu.org>
1909
1910 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1911 position we get to after a call to move_it_to fails the
1912 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1913 only if we wind up in a string from display property. (Bug#11063)
1914
1915 * window.c (Fdelete_other_windows_internal): Invalidate the row
1916 and column information about mouse highlight, so that redisplay
1917 restores it after reallocating the glyph matrices. (Bug#7464)
1918
1919 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1920 string comes from a `display' text property, use the buffer
1921 position of that property as if we actually saw that position in
1922 the row's glyphs.
1923 (move_it_by_lines): Remove the assertion that
1924 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1925 violated when there's a before-string at the beginning of a line.
1926 (Bug#11063)
1927
19282012-03-30 Eli Zaretskii <eliz@gnu.org>
1929
1930 * xdisp.c (append_space_for_newline): If the default face was
1931 remapped, use the remapped face for the appended newline.
1932 (extend_face_to_end_of_line): Use the remapped default face for
1933 extending the face to the end of the line.
1934 (display_line): Call extend_face_to_end_of_line when the default
1935 face was remapped. (Bug#11068)
1936
19372012-03-29 Eli Zaretskii <eliz@gnu.org>
1938
1939 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1940
19412012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1942
1943 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1944
19452012-03-27 Glenn Morris <rgm@gnu.org>
1946
1947 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1948 Doc fixes.
1949
19502012-03-26 Kenichi Handa <handa@m17n.org>
1951
1952 * dispextern.h (struct glyph): Fix previous change. Change the
1953 bit length of glyphless.ch to 25 (Bug#11082).
1954
19552012-03-26 Chong Yidong <cyd@gnu.org>
1956
1957 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1958 (command_loop_1): Use it; inhibit selection update for
1959 handle-select-window too (Bug#8996).
1960
19612012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1962
1963 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1964
19652012-03-25 Kenichi Handa <handa@m17n.org>
1966
1967 * dispextern.h (struct glyph): Change the bit length of
1968 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1969
19702012-03-24 Eli Zaretskii <eliz@gnu.org>
1971
1972 * s/ms-w32.h (tzname): Include time.h before redirecting to
1973 _tzname. Fixes the MSVC build. (Bug#9960)
1974
19752012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1976
1977 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1978 characters.
1979
1980 * xterm.c (XTread_socket): Only modify handling_signal if
1981 !SYNC_INPUT. (Bug#11080)
1982
19832012-03-23 Eli Zaretskii <eliz@gnu.org>
1984
1985 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1986 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1987 when fetching a multibyte character consumes more bytes than
1988 CHAR_BYTES returns, due to unification of CJK characters in
1989 string_char. (Bug#11073)
1990
19912012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1992
1993 * process.c (wait_reading_process_output): Handle pty disconnect
1994 by refraining from sending oneself a SIGCHLD (bug#10933).
1995
19962012-03-22 Chong Yidong <cyd@gnu.org>
1997
1998 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1999
2000 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2001 Mark string as coming from a prefix property.
2002 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2003 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2004
20052012-03-21 Chong Yidong <cyd@gnu.org>
2006
2007 * xfaces.c (Vface_remapping_alist): Doc fix.
2008
20092012-03-20 Eli Zaretskii <eliz@gnu.org>
2010
2011 * w32proc.c (Fw32_set_console_codepage)
2012 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2013 Doc fixes.
2014
20152012-03-20 Chong Yidong <cyd@gnu.org>
2016
2017 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2018 to reflect default non-nil value of redisplay-dont-pause.
2019
20202012-03-19 Kenichi Handa <handa@m17n.org>
2021
2022 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2023 it fit in a valid range (Bug#11003).
2024
20252012-03-18 Eli Zaretskii <eliz@gnu.org>
2026
2027 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2028 that is not from display property, accept the row as a "cursor
2029 row" if one of the string's character has a non-nil `cursor'
2030 property. Fixes cursor positioning when there are newlines in
2031 overlay strings, e.g. in icomplete.el. (Bug#11035)
2032
20332012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2036
20372012-03-12 Chong Yidong <cyd@gnu.org>
2038
2039 * eval.c (inhibit_lisp_code): Rename from
2040 inhibit_window_configuration_change_hook; move from window.c.
2041
2042 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2043 * window.c (run_window_configuration_change_hook)
2044 (syms_of_window): Callers changed.
2045
20462012-03-11 Chong Yidong <cyd@gnu.org>
2047
2048 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2049
2050 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2051
20522012-03-10 Chong Yidong <cyd@gnu.org>
2053
2054 * frame.c (other_visible_frames): Don't assume the selected frame
2055 is visible (Bug#10955).
2056
20572012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2058
2059 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2060
20612012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2062
2063 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2064 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2065 zero (Bug#10954).
2066
20672012-03-03 Glenn Morris <rgm@gnu.org>
2068
2069 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2070
20712012-03-02 Eli Zaretskii <eliz@gnu.org>
2072
2073 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2074 position past the first glyph_row that ends at ZV. (Bug#10902)
2075 (redisplay_window, next_element_from_string): Fix typos in
2076 comments.
2077 (redisplay_window): Pass to move_it_vertically the margin in
2078 pixels, not in screen lines.
2079
20802012-03-02 Glenn Morris <rgm@gnu.org>
2081
2082 * buffer.c (buffer-list-update-hook): Doc fix.
2083
20842012-02-29 Eli Zaretskii <eliz@gnu.org>
2085
2086 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2087 push_it before setting up the iterator for the first overlay
2088 string, even if we have an empty string loaded.
2089 (next_overlay_string): If there's an empty string on the iterator
2090 stack, pop the stack. (Bug#10903)
2091
20922012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2095 Suggested by Stefan Monnier in
2096 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2097 * alloc.c (widen_to_Lisp_Object): New static function.
2098 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2099 and widening them to Lisp_Objects. This would work even if
2100 USE_LSB_TAG is defined and wide integers are used, which might
2101 happen in a future version of Emacs.
2102
21032012-02-25 Chong Yidong <cyd@gnu.org>
2104
2105 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2106 Doc fix.
2107
2108 * xselect.c (Fx_selection_exists_p): Doc fix.
2109 (x_clipboard_manager_save_all): Print an informative message
2110 before saving to clipboard manager.
2111
21122012-02-24 Chong Yidong <cyd@gnu.org>
2113
2114 * keyboard.c (process_special_events): Handle all X selection
2115 requests in kbd_buffer, not just the next one (Bug#8869).
2116
21172012-02-23 Chong Yidong <cyd@gnu.org>
2118
2119 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2120 call when setting menu-bar-lines and tool-bar-lines parameters.
2121 (unwind_create_frame_1): New helper function.
2122
2123 * window.c (inhibit_window_configuration_change_hook): New var.
2124 (run_window_configuration_change_hook): Obey it.
2125 (syms_of_window): Initialize it.
2126
21272012-02-22 Chong Yidong <cyd@gnu.org>
2128
2129 * xterm.c (x_draw_image_relief): Add missing type check for
2130 Vtool_bar_button_margin (Bug#10743).
2131
21322012-02-21 Chong Yidong <cyd@gnu.org>
2133
2134 * fileio.c (Vfile_name_handler_alist): Doc fix.
2135
2136 * buffer.c (Fget_file_buffer): Protect against invalid file
2137 handler return value.
2138
21392012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2142 when computing $valmask.
2143
2144 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2145 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2146 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2147 It's useless in that case, and it can cause problems on hosts
2148 that allocate halves of EMACS_INT values separately.
2149 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2150 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2151 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2152 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2153 it avoids undefined behavior on hosts where shifting right by more
2154 than the word width has undefined behavior.
2155
21562012-02-19 Chong Yidong <cyd@gnu.org>
2157
2158 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2159 (Funhandled_file_name_directory, Ffile_name_as_directory)
2160 (Fdirectory_file_name, Fexpand_file_name)
2161 (Fsubstitute_in_file_name): Protect against invalid file handler
2162 return values (Bug#10845).
2163
21642012-02-18 Eli Zaretskii <eliz@gnu.org>
2165
2166 * .gdbinit (pitx): Fix incorrect references to fields of the
2167 iterator stack.
2168
21692012-02-17 Chong Yidong <cyd@gnu.org>
2170
2171 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2172
21732012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2176 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2177
21782012-02-15 Chong Yidong <cyd@gnu.org>
2179
2180 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2181 marked as special. Also, starting docstrings with * is obsolete.
2182
21832012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2184
2185 * gnutls.c (emacs_gnutls_write): Fix last change.
2186
21872012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2188
2189 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2190 send_process.
2191
21922012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * keymap.c (Fsingle_key_description): Handle char ranges.
2195
21962012-02-12 Chong Yidong <cyd@gnu.org>
2197
2198 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2199 as that creates a dangerous corner case.
2200
2201 * window.c (Fdelete_window_internal): Invalidate the mouse
2202 highlight (Bug#9904).
2203
22042012-02-12 Glenn Morris <rgm@gnu.org>
2205
2206 * xselect.c (Fx_own_selection_internal)
2207 (Fx_get_selection_internal, Fx_disown_selection_internal)
2208 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2209 * nsselect.m (Fx_own_selection_internal)
2210 (Fx_disown_selection_internal, Fx_selection_exists_p)
2211 (Fx_selection_owner_p, Fx_get_selection_internal):
2212 Sync docs and argument specs with the xselect.c versions.
2213
22142012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2215
2216 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2217
22182012-02-11 Eli Zaretskii <eliz@gnu.org>
2219
2220 * w32select.c (Fx_selection_exists_p): Sync doc string and
2221 argument list with xselect.c. (Bug#10783)
2222
2223 * w16select.c (Fx_selection_exists_p): Sync doc string and
2224 argument list with xselect.c. (Bug#10783)
2225
22262012-02-10 Glenn Morris <rgm@gnu.org>
2227
2228 * fns.c (Fsecure_hash): Doc fix.
2229
22302012-02-09 Kenichi Handa <handa@m17n.org>
2231
2232 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2233
22342012-02-07 Chong Yidong <cyd@gnu.org>
2235
2236 * buffer.c (Fbuffer_local_variables)
2237 (buffer_lisp_local_variables): Handle unbound vars correctly;
2238 don't let Qunbound leak into Lisp.
2239
22402012-02-07 Glenn Morris <rgm@gnu.org>
2241
2242 * image.c (Fimagemagick_types): Doc fix.
2243
2244 * image.c (imagemagick-render-type): Change it from a lisp object
2245 to an integer. Move the doc here from the lisp manual.
2246 Treat all values not equal to 0 the same.
2247
22482012-02-06 Chong Yidong <cyd@gnu.org>
2249
2250 * doc.c (store_function_docstring): Avoid applying docstring of
2251 alias to base function (Bug#2603).
2252
22532012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * .gdbinit (pp1, pv1): Remove redundant defines.
2256 (pr): Use pp.
2257
22582012-02-04 Chong Yidong <cyd@gnu.org>
2259
2260 * nsterm.m: Declare a global (Bug#10694).
2261
22622012-02-04 Eli Zaretskii <eliz@gnu.org>
2263
2264 * w32.c (get_emacs_configuration_options):
2265 Include --enable-checking, if specified, in the return value.
2266
22672012-02-04 Martin Rudalics <rudalics@gmx.at>
2268
2269 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2270 after rounding frame sizes. (Bug#9723)
2271
22722012-02-04 Eli Zaretskii <eliz@gnu.org>
2273
2274 * keyboard.c (adjust_point_for_property): Don't position point
2275 before BEGV. (Bug#10696)
2276
22772012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 Handle overflow when computing char display width (Bug#9496).
2280 * character.c (char_width): Return EMACS_INT, not int.
2281 (char_width, c_string_width): Check for overflow when
2282 computing the width; this is possible now that individual
2283 characters can have unbounded width. Problem introduced
2284 by merge from Emacs 23 on 2012-01-19.
2285
22862012-02-02 Michael Albinus <michael.albinus@gmx.de>
2287
2288 * dbusbind.c (Fdbus_register_method): Mention the return value
2289 :ignore in the docstring.
2290
22912012-02-02 Glenn Morris <rgm@gnu.org>
2292
2293 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2294
2295 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2296 Unconditionally set to t. (Bug#10673)
2297 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2298 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2299 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2300
23012012-02-02 Kenichi Handa <handa@m17n.org>
2302
2303 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2304 0, do not call append_composite_glyph.
2305
23062012-02-02 Kenichi Handa <handa@m17n.org>
2307
2308 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2309 NULL (Bug#6988).
2310 (x_produce_glyphs): If the component of a composition is a null
2311 string, set it->pixel_width to 1 to avoid zero-width glyph.
2312
23132012-02-01 Eli Zaretskii <eliz@gnu.org>
2314
2315 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2316 first 2 arguments are identical. This makes inserting large
2317 output from a subprocess an order of magnitude faster on
2318 MS-Windows, where all sbrk'ed memory is always contiguous.
2319
23202012-01-31 Glenn Morris <rgm@gnu.org>
2321
2322 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2323 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2324 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2325
23262012-01-29 Glenn Morris <rgm@gnu.org>
2327
2328 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2329
23302012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2331
2332 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2333
23342012-01-28 Chong Yidong <cyd@gnu.org>
2335
2336 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2337
23382012-01-26 Chong Yidong <cyd@gnu.org>
2339
2340 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2341
2342 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2343 repeat counts (Bug#10507).
2344
23452012-01-26 Glenn Morris <rgm@gnu.org>
2346
2347 * lread.c (syms_of_lread): Doc fix.
2348
23492012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2350
2351 * coding.c (encode_designation_at_bol): Change return value to
2352 EMACS_INT.
2353
23542012-01-25 Chong Yidong <cyd@gnu.org>
2355
2356 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2357
23582012-01-21 Chong Yidong <cyd@gnu.org>
2359
2360 * floatfns.c (Fcopysign): Make the second argument non-optional,
2361 since nil is not allowed anyway.
2362
23632012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2364
2365 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2366 (send_process): Likewise.
2367
23682012-01-19 Martin Rudalics <rudalics@gmx.at>
2369
2370 * window.c (save_window_save, Fcurrent_window_configuration)
2371 (Vwindow_persistent_parameters): Do not use Qstate.
2372 Rewrite doc-strings.
2373
23742012-01-19 Kenichi Handa <handa@m17n.org>
2375
2376 * character.c (char_width): New function.
2377 (Fchar_width, c_string_width, lisp_string_width):
2378 Use char_width (Bug#9496).
2379
23802012-01-16 Martin Rudalics <rudalics@gmx.at>
2381
2382 * window.c (Vwindow_persistent_parameters): New variable.
2383 (Fset_window_configuration, save_window_save): Handle persistent
2384 window parameters.
2385
23862012-01-14 Eli Zaretskii <eliz@gnu.org>
2387
2388 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2389 thrashing the stack of the thread. (Bug#9087)
2390
23912012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2394
23952012-01-11 Eli Zaretskii <eliz@gnu.org>
2396
2397 * xdisp.c (rows_from_pos_range): Handle the case where the
2398 highlight ends on a newline. (Bug#10464)
2399 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2400 he end column for display of highlight that ends on a newline
2401 before a R2L line.
2402
24032012-01-11 Glenn Morris <rgm@gnu.org>
2404
2405 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2406 from load-path also when installation-directory is nil. (Bug#10208)
2407
24082012-01-10 Glenn Morris <rgm@gnu.org>
2409
2410 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2411
2412 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2413 Update template values to be closer to their typical values these days.
2414
24152012-01-09 Eli Zaretskii <eliz@gnu.org>
2416
2417 * xdisp.c (rows_from_pos_range): Accept additional argument
2418 DISP_STRING, and accept any glyph in a row whose object is that
2419 string as eligible for mouse highlight. Fixes mouse highlight of
2420 display strings from overlays. (Bug#10464)
2421
24222012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 emacs: fix an auto-save permissions race condition (Bug#10400)
2425 * fileio.c (auto_saving_dir_umask): New static var.
2426 (Fmake_directory_internal): Use it.
2427 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2428 creating the directory. The old code temporarily assigns
2429 too-generous permissions to the directory.
2430 (do_auto_save_eh): Clear it.
2431 (Fdo_auto_save): Catch all errors, not just file errors, so
2432 that the var is always cleared.
2433
24342012-01-07 Eli Zaretskii <eliz@gnu.org>
2435
2436 * search.c (scan_buffer): Pass character positions to
2437 know_region_cache, not byte positions. (Bug#6540)
2438
24392012-01-07 LynX <_LynX@bk.ru> (tiny change)
2440
2441 * w32.c (sys_rename): Report EXDEV when rename of a directory
2442 fails because the target is on another logical disk. (Bug#10284)
2443
24442012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2445
2446 * xterm.c (x_embed_request_focus): New function.
2447
2448 * xterm.h: Add prototype.
2449
2450 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2451
24522012-01-05 Glenn Morris <rgm@gnu.org>
2453
2454 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2455
24562012-01-01 Eli Zaretskii <eliz@gnu.org>
2457
2458 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2459 Load gnutls_transport_set_lowat only if GnuTLS version is below
2460 2.11.1.
2461 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2462 GnuTLS versions below 2.11.1.
2463
24642011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2465
2466 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2467 to the doc string advising against its use for altering the way
2468 windows are scrolled.
2469
24702011-12-28 Kenichi Handa <handa@m17n.org>
2471
2472 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2473 coding-system ASCII compatible only when it does not produce BOM
2474 on encoding (Bug#10383).
2475
24762011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2477
2478 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2479 can scroll.
2480 (create_and_show_popup_menu): Always use menu_position_func for
2481 Gtk3 (Bug#10361).
2482
24832011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2484
2485 * callint.c (Fcall_interactively): Don't truncate prompt string.
2486
24872011-12-23 Eli Zaretskii <eliz@gnu.org>
2488
2489 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2490 property that ends at ZV, so that the bidi iteration could be
2491 resumed from there (after widening). (Bug#10360)
2492
24932011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2494
2495 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2496
24972011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2498
2499 * nsterm.m (x_free_frame_resources):
2500 Release f->output_data.ns->miniimage.
2501 (ns_index_color): Fix indentation. Do not retain
2502 color_table->colors[i].
2503
2504 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2505 before returning.
2506
2507 * nsfns.m (x_set_background_color): Assign return value from
2508 ns_index_color to face-background instead of NSColor*.
2509 (ns_implicitly_set_icon_type): Fix indentation.
2510 Change assignment in for loop to comparison.
2511
2512 * emacs.c (ns_pool): New variable.
2513 (main): Assign ns_pool.
2514 (Fkill_emacs): Call ns_release_autorelease_pool.
2515
2516 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2517 autorelease fdesc, release fdAttrs and tdict.
2518 (ns_get_covering_families): Release charset.
2519 (ns_findfonts): Release NSFontDescriptor created with new.
2520 (ns_uni_to_glyphs): Fix indentation.
2521 (setString): Release attrStr before assigning new value.
2522
25232011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2524
2525 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2526 and NS_IMPL_COCOA.
2527 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2528 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2529
25302011-12-18 David Reitter <reitter@cmu.edu>
2531
2532 * nsterm.m (ns_term_init): Subscribe for notifications
2533 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2534 to method trackingNotification in EmacsMenu.
2535
2536 * nsmenu.m (trackingMenu): New variable.
2537 (trackingNotification): New method (from Aquamacs).
2538 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2539 from Aquamacs (Bug#7030).
2540
25412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2542
2543 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2544 (symbol_to_nsstring): Fix indentation.
2545 (ns_symbol_to_pb): New function.
2546 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2547 (Fns_rotate_cut_buffers_internal): Remove.
2548 (Fns_store_selection_internal): Rename from
2549 Fns_store_cut_buffer_internal.
2550 (ns_get_foreign_selection, Fx_own_selection_internal)
2551 (Fx_disown_selection_internal, Fx_selection_exists_p)
2552 (Fns_get_selection_internal, Fns_store_selection_internal):
2553 Use ns_symbol_to_pb and check if return value is nil.
2554 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2555 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2556 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2557 renamed to Sns_store_selection_internal.
2558 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2559 and remove this function.
2560 (ns_handle_selection_clear): Remove, never used.
2561 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2562 here.
2563
25642011-12-17 Ken Brown <kbrown@cornell.edu>
2565
2566 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2567 GID is unknown (Bug#10257).
2568
25692011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2572 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2573 which caused a build failure on GNU/Linux IA-64. This problem was
2574 introduced by my 2011-10-07 patch.
2575
25762011-12-15 Juri Linkov <juri@jurta.org>
2577
2578 * image.c (imagemagick_error): New function. (Bug#10112)
2579 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2580 Use `imagemagick_error' where ImageMagick functions return
2581 `MagickFalse'.
2582 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2583 proper order.
2584
25852011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2586
2587 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2588 fill background (Bug#8992).
2589
25902011-12-13 Martin Rudalics <rudalics@gmx.at>
2591
2592 * window.c (Vwindow_combination_resize)
2593 (Vwindow_combination_limit): Use t instead of non-nil in
2594 doc-strings.
2595 (Vrecenter_redisplay): Add first sentence of doc-string on
2596 separate line.
2597 (Frecenter): Fix doc-string typo.
2598
25992011-12-11 Kenichi Handa <handa@m17n.org>
2600
2601 * coding.c (Funencodable_char_position): Pay attention to the
2602 buffer text relocation (Bug#9389).
2603
26042011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2605
2606 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2607 gtk_init (Bug#10100).
2608
26092011-12-10 Eli Zaretskii <eliz@gnu.org>
2610
2611 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2612 IT->string is nil. (Bug#10263)
2613
26142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2615
2616 * nsterm.h (x_free_frame_resources): Declare.
2617
2618 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2619 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2620
2621 * nsterm.h (ns_get_defaults_value): Declare.
2622
2623 * nsterm.m (ns_default): Call ns_get_defaults_value.
2624
26252011-12-09 Eli Zaretskii <eliz@gnu.org>
2626
2627 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2628 (Bug#10170)
2629
26302011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2631 959
2632 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case 960 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
2633 that where the value of an _OBJC_* symbol points to is in the .bss 961 * nsfns.m (x_set_cursor_type):
2634 section (Bug#10240). 962 * w32fns.c (x_set_cursor_type):
963 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
964 * xdisp.c (set_frame_cursor_types): ...but in common code.
2635 965
26362011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change) 9662013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2637 967
2638 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end) 968 * font.c (clear_font_cache): New function, stripped from...
2639 after the loop to call ccl_driver at least once (Bug#8619). 969 (Fclear_font_cache): ...here, which now uses the function
970 above. Adjust comment.
971 * font.h (clear_font_cache): Add prototype.
972 * xfaces.c (clear_face_cache): Use clear_font_cache.
2640 973
26412011-12-08 Kenichi Handa <handa@m17n.org> 9742013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2642 975
2643 * ftfont.c (get_adstyle_property): Fix previous change 976 * window.c (Fset_window_start): Compare `w', not `window' because
2644 (Bug#10233). 977 `w' might not be equal to `window' after call to decode_live_window.
2645 978
26462011-12-07 Juanma Barranquero <lekktu@gmail.com> 9792013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2647 980
2648 * w32.c (init_environment): If no_site_lisp, remove site-lisp 981 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2649 dirs from the default value of EMACSLOADPATH (bug#10208). 982 This fixes a problem introduced by the Bug#15035 patch
983 when using GPG. Reported by Herbert J. Skuhra.
2650 984
26512011-12-07 Glenn Morris <rgm@gnu.org> 9852013-08-12 Eli Zaretskii <eliz@gnu.org>
2652 986
2653 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in 987 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2654 installation and source directories as well. (Bug#10208) 988 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
989 not yet initialized.
2655 990
26562011-12-06 Chong Yidong <cyd@gnu.org> 9912013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2657 992
2658 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228). 993 * decompress.c (Fzlib_decompress_region): Support zlib
994 decompression, too, and rename.
2659 995
26602011-12-06 Glenn Morris <rgm@gnu.org> 9962013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2661 997
2662 * process.c (start_process_unwind): Treat any pid <= 0, except -2, 998 Minor zlib configuration tweaks.
2663 as an error, not just -1. (Bug#10217) 999 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1000 Don't assume presence of fn_inflateInit2_ zlib internal function.
2664 1001
26652011-12-05 Chong Yidong <cyd@gnu.org> 10022013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2666 1003
2667 * keyboard.c (process_special_events): New function. 1004 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2668 (swallow_events, Finput_pending_p): Use it (Bug#10195). 1005 include the zlib prefix.
2669 1006
26702011-12-05 Paul Eggert <eggert@cs.ucla.edu> 10072013-08-12 Eli Zaretskii <eliz@gnu.org>
2671 1008
2672 * coding.c (encode_designation_at_bol): Don't use uninitialized 1009 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2673 local variable (Bug#9318). 1010 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1011 define static variables that are pointers to zlib functions to be
1012 dynamically loaded.
1013 (init_zlib_functions) [WINDOWSNT]: New function.
1014 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1015 New macros.
1016 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1017 macros instead of invoking the zlib functions directly.
1018 (syms_of_decompress): DEFSYM Qzlib_dll.
1019 Staticpro Szlib_available_p.
2674 1020
26752011-12-05 Kenichi Handa <handa@m17n.org> 10212013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2676 1022
2677 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF, 1023 Avoid looping over all frame windows to freeze and unfreeze.
2678 return Qnil (Bug#8046, Bug#10193). 1024 * window.h (struct window): Drop frozen_window_start_p.
2679 1025 (freeze_window_starts): Drop prototype.
26802011-12-05 Kenichi Handa <handa@m17n.org> 1026 * frame.h (struct frame): New frozen_window_starts flag.
2681 1027 (FRAME_WINDOWS_FROZEN): New macro.
2682 * coding.c (encode_designation_at_bol): New args charbuf_end and 1028 * window.c (freeze_window_start, freeze_window_starts):
2683 dst. Return the number of produced bytes. Callers changed. 1029 Remove.
2684 (coding_set_source): Return how many bytes coding->source was 1030 (select_window, replace_window): Adjust users.
2685 relocated. 1031 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2686 (coding_set_destination): Return how many bytes 1032 (window_frozen_p): New function.
2687 coding->destination was relocated. 1033 (redisplay_window): Use it.
2688 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET) 1034
2689 (CODING_CHAR_CHARSET_P): Adjust for the avove changes. 10352013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2690 1036
26912011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change) 1037 Fix some fd issues when running subprocesses (Bug#15035).
2692 1038 Fix bugs that can leak files or file descriptors on errors.
2693 * coding.c (CODING_CHAR_CHARSET_P): New macro. 1039 Don't unlink open temp files, as that's hard for users to diagnose
2694 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above 1040 when things go awry (e.g., temp disk exhausted).
2695 macro (Bug#9318). 1041 Don't bother to lock temp files. Check for invalid recursion.
2696 1042 * callproc.c (synch_process_fd): Remove. All uses removed.
26972011-12-05 Andreas Schwab <schwab@linux-m68k.org> 1043 (synch_process_tempfile): New var or macro.
2698 1044 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2699 The following changes are to fix Bug#9318. 1045 New constants.
2700 1046 (record_kill_process): New arg, the temp name. All callers changed.
2701 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros. 1047 (delete_temp_file): Now just a simple wrapper around unlink.
2702 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER) 1048 (call_process_kill): New arg, the call_process_fd array.
2703 (encode_coding_iso_2022, encode_coding_sjis) 1049 Close them all. Clear synch_process_pid. Remove the temp file,
2704 (encode_coding_big5, encode_coding_charset): Use the above macros. 1050 or arrange for it to be removed.
2705 1051 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
27062011-12-05 Juanma Barranquero <lekktu@gmail.com> 1052 that's been moved to synch_process_tempfile. Caller changed.
2707 1053 Do not remove the tempfile; that's now call_process_kill's
2708 * lisp.h (process_quit_flag): Fix external declaration. 1054 responsibility.
2709 1055 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
27102011-12-04 Stefan Monnier <monnier@iro.umontreal.ca> 1056 call_process_kill; the caller now does that.
2711 1057 (call_process_cleanup): Do not close the process fd; that's now
2712 Don't macro-inline non-performance-critical code. 1058 call_process_kill's responsibility.
2713 * eval.c (process_quit_flag): New function. 1059 (Fcall_process): Implement via new function call_process, which
2714 * lisp.h (QUIT): Use it. 1060 has most of the old body of Fcall_process, but with a different API.
2715 1061 (call_process): New function that does not open or close filefd if
27162011-12-04 Jan Djärv <jan.h.d@swipnet.se> 1062 it is nonnegative. Record which fds need to be closed, and let
2717 1063 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2718 * nsfns.m (get_geometry_from_preferences): New function. 1064 Signal an error if invoked recursively (could be done via a hook).
2719 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103). 1065 Simplify creation of the tempfile in the MSDOS case.
2720 1066 Don't create the output file until after checking for the executable.
27212011-12-04 Andreas Schwab <schwab@linux-m68k.org> 1067 Report any failure to open /dev/null.
2722 1068 Don't open /dev/null for writing twice; once is enough.
2723 * emacs.c (Qkill_emacs): Define. 1069 Don't create pipe if all output is being discarded or sent to file.
2724 (syms_of_emacs): Initialize it. 1070 Don't worry about setting up the coding system or reading from the
2725 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set 1071 pipe if all output is being discarded.
2726 Qquit_flag to `kill-emacs' instead. 1072 Hoist fd_error local into top level, to lessen block nesting.
2727 (quit_throw_to_read_char): Add parameter `from_signal'. 1073 Don't record deleted pid here; now done by Fcall_process_region.
2728 All callers changed. Call Fkill_emacs if requested and safe. 1074 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2729 * lisp.h (QUIT): Call Fkill_emacs if requested. 1075 and note its success in synch_process_tempfile.
2730 1076 Do not leak resources when child_setup fails.
27312011-12-03 Jan Djärv <jan.h.d@swipnet.se> 1077 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2732 1078 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2733 * widget.c (update_wm_hints): Return if wmshell is null. 1079 (create_temp_file): Now returns open fd, with an additional
2734 (widget_update_wm_size_hints): New function. 1080 Lisp_Object * argument to return the name. All callers changed.
2735 1081 Do not close the file; rewind it instead, and leave it open for
2736 * widget.h (widget_update_wm_size_hints): Declare. 1082 the caller. Do not lock the temp file. Unwind-protect the file
2737 1083 and the file-descriptor.
2738 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call 1084 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2739 widget_update_wm_size_hints (Bug#10104). 1085 If an asynchrounous process, record it here, not in call_process.
2740 1086 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
27412011-12-03 Eli Zaretskii <eliz@gnu.org> 1087 * eval.c (set_unwind_protect): New function.
2742 1088 * fileio.c (write_region): New function, generalized from the
2743 * xdisp.c (handle_invisible_prop): If the invisible text ends just 1089 old Fwrite_region. Do not lock temp files.
2744 before a newline, prepare the bidi iterator for consuming the 1090 (Fwrite_region): Use it.
2745 newline, and keep the current paragraph direction. (Bug#10183) 1091 * lisp.h (set_unwind_protect, write_region): New decls.
2746 (redisplay_window): Don't let `margin' become negative. (Bug#10192) 1092 * process.c: Include <verify.h>.
2747 1093 (make_process): Mark fds as initially closed.
27482011-12-02 Juri Linkov <juri@jurta.org> 1094 (deleted_pid_list): Now a list of pid-filename pairs.
2749 1095 All uses changed.
2750 * search.c (Fword_search_regexp): New Lisp function created from 1096 (close_process_fd): New function.
2751 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'. 1097 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2752 (Fword_search_backward, Fword_search_forward) 1098 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2753 (Fword_search_backward_lax, Fword_search_forward_lax): 1099 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2754 Use `Fword_search_regexp' instead of `wordify'. Doc fix. 1100 (create_process, create_pty, Fmake_serial_process)
2755 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145) 1101 (server_accept_connection): Record which fds need to be closed,
2756 1102 and let deactivate_process close them.
27572011-12-01 Stefan Monnier <monnier@iro.umontreal.ca> 1103 (Fmake_network_process): Do not discard the unwind-protect
2758 1104 until it's safe to do so.
2759 * fileio.c (Finsert_file_contents): Move after-change-function call 1105 (deactivate_process): Close the fds opened by create_process etc.
2760 to before the "handled:" label, since all "goto handled" appear in 1106 (Fprocess_send_eof): Adjust to new way of recording open fds.
2761 cases where the *-change-functions have already been properly called 1107 Report an error if /dev/null can't be opened, instead of aborting.
2762 (bug#10117). 1108 * process.h (PROCESS_OPEN_FDS): New constant.
2763 1109 (struct Lisp_Process): New member open_fds.
27642011-12-01 Andreas Schwab <schwab@linux-m68k.org> 1110 (record_kill_process, record_deleted_pid): Adjust signatures.
2765 1111 (record_deleted_pid): Move decl here ...
2766 * keyboard.c (interrupt_signal): Don't call kill-emacs when 1112 * syswait.h (record_deleted_pid): ... from here.
2767 waiting for input. (Bug#10169) 1113
2768 11142013-08-11 Paul Eggert <eggert@cs.ucla.edu>
27692011-11-30 Eli Zaretskii <eliz@gnu.org> 1115
2770 1116 * decompress.c: Fix bugs with large buffers and weird inputs.
2771 * dispnew.c (adjust_glyph_matrix): Remove the assertion that 1117 Tune a bit. Reindent as per usual Emacs style.
2772 verifies glyph row's hash code--we have just reallocated the 1118 (BUFFER_SIZE): Remove.
2773 glyphs, so their contents can be complete garbage. (Bug#10164) 1119 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2774 1120 more than UINT_MAX bytes. Decompress into the gap instead of into
27752011-11-30 Juanma Barranquero <lekktu@gmail.com> 1121 an auto buffer, as this should avoid copying. Return nil if
2776 1122 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2777 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check. 1123 set immediate_quit; we shouldn't trust zlib code that much.
2778 1124
27792011-11-30 Eli Zaretskii <eliz@gnu.org> 11252013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2780 1126
2781 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's 1127 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2782 attributes are tested _before_ calling verify_row_hash, to protect 1128 errors, and really move the gap to where we want it.
2783 against GCC re-ordering of the tests. (Bug#10164) 1129
2784 1130 * lisp.h: Include decompress.c support.
27852011-11-29 Jan Djärv <jan.h.d@swipnet.se> 1131
2786 1132 * emacs.c (main): Include decompress.c support.
2787 * xterm.h (struct x_output): net_wm_state_hidden_seen is new. 1133
2788 1134 * Makefile.in: Include -lz if present.
2789 * xterm.c (handle_one_xevent): Only set async_visible and friends 1135
2790 if net_wm_state_hidden_seen is non-zero (Bug#10002) 11362013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2791 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if 1137
2792 _NET_WM_STATE_HIDDEN is in NET_WM_STATE. 1138 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2793 1139 (initWithTitle:): Initialize frame to 0.
27942011-11-28 Paul Eggert <eggert@cs.ucla.edu> 1140 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
2795 1141 (fillWithWidgetValue:frame:): Rename from
2796 Remove GCPRO-related macros that exist only to avoid shadowing locals. 1142 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2797 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR) 1143
2798 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See 1144 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2799 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>. 1145 fillWithWidgetValue:frame:
2800 All uses changed to use GCPRO1 etc. 1146
2801 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO): 1147 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2802 Revert to old implementation (i.e., before 2011-03-11). 1148 remove memory leak warnings.
2803 1149
28042011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> 1150 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2805 1151 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2806 * dispnew.c (scrolling_window): Truncate overlaps in copy destination 1152 menu_pending_title.
2807 of scroll runs so as to avoid assigning disabled bogus rows and 1153
2808 unnecessary graphics copy operations. 1154 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2809 1155 (x_activate_menubar): Update the whole menu.
28102011-11-27 Eli Zaretskii <eliz@gnu.org> 1156 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2811 1157 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2812 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define. 1158 current event is not NSSystemDefined (Bug#15001).
2813 (snprintf) [_MSC_VER]: Redirect to _snprintf. 1159 Call ns_check_menu_open only if trackingMenu is 2.
2814 (strtoll) [_MSC_VER]: Redirect to _strtoi64. 1160 (menuDidClose:): New method, decrease trackingMenu.
2815 (malloc, free, realloc, calloc): Redirect to e_* only when 1161 (fillWithWidgetValue:setDelegate:): New method.
2816 compiling Emacs. 1162 (fillWithWidgetValue:): Call the above.
2817 1163
2818 * lisp.h (GCTYPEBITS): Move before first use. 1164 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2819 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define. 1165
2820 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in 11662013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2821 this macro definition. 1167
2822 1168 Omit some unnecessary casts.
2823 * s/ms-w32.h (tzname): Redirect to _tzname for all values of 1169 Many of these go back to the old pre-C89 days, when they may have
2824 _MSC_VER. 1170 been needed, but we've been assuming C89 or later for a while now.
2825 1171 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
28262011-11-27 Jan Djärv <jan.h.d@swipnet.se> 1172 (live_float_p, live_misc_p, live_vector_p):
2827 1173 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2828 * gtkutil.c (xg_create_frame_widgets): 1174 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2829 Call gtk_window_set_has_resize_grip (FALSE) if that function is 1175 (defvar_per_buffer):
2830 present with Gtk+ 2.0. 1176 * callint.c (Fcall_interactively):
2831 1177 * doc.c (Fsubstitute_command_keys):
28322011-11-26 Paul Eggert <eggert@cs.ucla.edu> 1178 * filelock.c (get_boot_time):
2833 1179 * frame.c (xrdb_get_resource):
2834 * fileio.c (Finsert_file_contents): Undo previous change; see 1180 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2835 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>. 1181 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2836 1182 (xg_get_file_name_from_selector, menuitem_destroy_callback)
28372011-11-26 Paul Eggert <eggert@cs.ucla.edu> 1183 (menuitem_highlight_callback, menu_destroy_callback)
2838 1184 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2839 Rename locals to avoid shadowing. 1185 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2840 * fileio.c (Finsert_file_contents): 1186 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2841 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing. 1187 (xg_tool_bar_help_callback, tb_size_cb):
1188 * image.c (xpm_alloc_color, png_read_from_memory)
1189 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1190 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1191 (syms_of_image):
1192 * keymap.c (describe_map):
1193 * nsfns.m (Fns_display_monitor_attributes_list):
1194 * nsmenu.m (process_dialog:):
1195 * nsterm.m (hold_event):
2842 * process.c (wait_reading_process_output): 1196 * process.c (wait_reading_process_output):
2843 Rename inner 'proc' to 'p' to avoid shadowing. 1197 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2844 Indent for consistency with usual Emacs style. 1198 * scroll.c (do_direct_scrolling, scrolling_1):
2845 1199 * termcap.c (tgetent):
28462011-11-25 Eli Zaretskii <eliz@gnu.org> 1200 * window.c (check_window_containing, add_window_to_list)
2847 1201 (freeze_window_starts):
2848 * xdisp.c (redisplay_window): If cursor row is not fully visible 1202 * xdisp.c (compare_overlay_entries, vmessage):
2849 after recentering, and scroll-conservatively is set to a large 1203 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2850 number, scroll window by a few more lines to make the cursor fully 1204 (x_get_monitor_attributes_xrandr)
2851 visible and out of scroll-margin. (Bug#10105) 1205 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2852 (start_display): Don't move to the next line if the display should 1206 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2853 start at a newline that is part of a display vector or an overlay 1207 * xfont.c (xfont_match, xfont_open):
2854 string. (Bug#10119) 1208 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2855 1209 (menubar_selection_callback, menu_position_func)
28562011-11-24 Juri Linkov <juri@jurta.org> 1210 (popup_selection_callback, create_and_show_popup_menu)
2857 1211 (dialog_selection_callback, create_and_show_dialog):
2858 * image.c (imagemagick_load_image): Move `MagickSetResolution' down 1212 * xrdb.c (x_get_string_resource):
2859 after the `MagickPingImage' call. (Bug#10112) 1213 (main) [TESTRM]:
2860 1214 * xsmfns.c (x_session_check_input):
28612011-11-23 Chong Yidong <cyd@gnu.org> 1215 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2862 1216 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2863 * window.c (Fcoordinates_in_window_p): Accept only live windows. 1217 (xaw_jump_callback, xaw_scroll_callback):
2864 1218 Omit unnecessary casts.
28652011-11-23 Martin Rudalics <rudalics@gmx.at> 1219
2866 12202013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2867 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before 1221
2868 making another buffer current. (Bug#10114) 1222 Minor string-length refactoring.
2869 1223 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
28702011-11-23 Glenn Morris <rgm@gnu.org> 1224 * frame.c (make_monitor_attribute_list):
2871 1225 Prefer build_string to strlen + make_string.
2872 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526) 1226
2873 12272013-08-10 Jan Djärv <jan.h.d@swipnet.se>
28742011-11-23 Chong Yidong <cyd@gnu.org> 1228
2875 1229 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2876 * xdisp.c (compute_stop_pos): Check validity of end_charpos before 1230 don't check minor_code (Bug#14417).
2877 using it (Bug#5984). 1231
2878 12322013-08-09 Eli Zaretskii <eliz@gnu.org>
28792011-11-22 Eli Zaretskii <eliz@gnu.org> 1233
2880 1234 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2881 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode- 1235 vertical positions instead. This avoids calling MATRIX_ROW with
2882 and header-lines, as they don't have one computed for them. 1236 row numbers that are possibly beyond valid limits. (Bug#15064)
2883 (Bug#10098) 1237
2884 12382013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2885 * .gdbinit (prow): Make displayed values more self-explaining. 1239
2886 Add row's hash code. 1240 Use xstrdup and build_unibyte_string where applicable.
2887 1241 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
28882011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org> 1242 * xfns.c (x_window):
2889 1243 * xrdb.c (x_get_customization_string):
2890 * process.c (wait_reading_process_output): Fix asynchrounous 1244 * xterm.c (xim_initialize):
2891 GnuTLS socket handling on some versions of the GnuTLS library. 1245 * w32fns.c (w32_window): Use xstrdup.
2892 (wait_reading_process_output): Add comment and URL. 1246 (w32_display_monitor_attributes_list):
2893 1247 * emacs.c (init_cmdargs):
28942011-11-21 Jan Djärv <jan.h.d@swipnet.se> 1248 * keyboard.c (PUSH_C_STR):
2895 1249 * nsfont.m (nsfont_open):
2896 * xterm.c (x_clear_frame): Reinstate the XClearWindow call. 1250 * sysdep.c (system_process_attributes):
2897 1251 * w32.c (system_process_attributes):
28982011-11-21 Chong Yidong <cyd@gnu.org> 1252 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2899 1253
2900 * window.c (Fnext_window, Fprevious_window): Doc fix. 12542013-08-09 Eli Zaretskii <eliz@gnu.org>
2901 1255
29022011-11-20 Stefan Monnier <monnier@iro.umontreal.ca> 1256 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2903 1257 variables of these types so that GDB would know about them, as aid
2904 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup. 1258 for debugging fatal exceptions. (Bug#15024) See also
2905 1259 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
29062011-11-20 Juanma Barranquero <lekktu@gmail.com> 1260 discussions.
2907 1261
2908 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo. 12622013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2909 1263
29102011-11-20 Martin Rudalics <rudalics@gmx.at> 1264 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2911 1265 larger than the NSWindow (Bug#14934).
2912 * window.c (Fset_window_combination_limit): Rename argument 1266
2913 STATUS to LIMIT. 12672013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2914 (Vwindow_combination_limit): Remove "status" from doc-string. 1268
2915 1269 Redesign redisplay interface to drop global variable updated_window.
29162011-11-20 Andreas Schwab <schwab@linux-m68k.org> 1270 Always pass currently updated window as a parameter to update routines.
2917 1271 * dispextern.h (updated_window): Remove declaration.
2918 * m/ibms390.h: Remove. 1272 (struct redisplay_interface): Pass window parameter to
2919 * m/ibms390x.h: Don't include "ibms390.h". 1273 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2920 1274 and after_update_window_hook.
29212011-11-20 Stefan Monnier <monnier@iro.umontreal.ca> 1275 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2922 1276 Adjust prototypes.
2923 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable. 1277 * dispnew.c (updated_window): Remove.
2924 Suggested by Dmitry Antipov <dmantipov@yandex.ru>. 1278 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2925 1279 (update_window_line): Adjust to match redisplay interface changes.
29262011-11-20 Juanma Barranquero <lekktu@gmail.com> 1280 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2927 1281 (ns_scroll_run, ns_after_update_window_line):
2928 * casetab.c (Fset_case_table): 1282 * w32term.c (x_update_window_begin, x_update_window_end)
2929 * charset.c (Fcharset_after): Fix typos. 1283 (x_after_update_window_line, x_scroll_run):
2930 1284 * xterm.c (x_update_window_begin, x_update_window_end)
29312011-11-20 Paul Eggert <eggert@cs.ucla.edu> 1285 (x_after_update_window_line, x_scroll_run):
2932 1286 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2933 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042). 1287 Likewise. Adjust comments where appropriate.
2934 Otherwise, valgrind does not work on some platforms. 1288 (x_cursor_to): Simplify because this is always called during window
2935 Problem reported by Andreas Schwab in 1289 update (but install debugging check anyway).
2936 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>. 1290 (expose_window): Check must_be_updated_p flag to see whether this
2937 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES 1291 function is called during window update.
2938 is set, removing the need for VIRT_ADDRESS_VARIES. 1292
2939 (PURE_P): Use a more-efficient implementation that needs just one 12932013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2940 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the 1294
2941 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge) 1295 Do not reset window modification event counters excessively.
2942 to 4 (xorl, subq, cmpq, setbe). 1296 These leftovers and poor man's tricky methods to catch extra
2943 * alloc.c (pure): Always extern now, since that's the 1297 redisplay's attention are no longer needed.
2944 VIRT_ADDR_VARIES behavior. 1298 * frame.c (set_menu_bar_lines_1):
2945 (PURE_POINTER_P): Use a single comparison, not two, for 1299 * minibuf.c (read_minibuf_unwind):
2946 consistency with the new puresize.h. 1300 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2947 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed. 1301 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2948 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h: 1302 (window_scroll_line_based, Fset_window_configuration):
2949 Remove VIRT_ADDR_VARIES no longer needed. 1303 * xdisp.c (redisplay_window): Do not reset last_modified and
2950 1304 last_overlay_modified counters.
29512011-11-19 Eli Zaretskii <eliz@gnu.org> 1305
2952 13062013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2953 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph) 1307
2954 (erase_phys_cursor, update_window_cursor, show_mouse_face) 1308 * xselect.c (x_send_client_event): Set send_event and serial, memset
2955 (cursor_in_mouse_face_p): If the cursor position is out of bounds, 1309 data.l as it might be bigger than data.b. Use 24 bit mask to
2956 behave as if the cursor position were at the window margin. 1310 XSendEvent (Bug#15034).
2957 1311
2958 * window.c (get_phys_cursor_glyph): If the window is hscrolled, 13122013-08-07 Eli Zaretskii <eliz@gnu.org>
2959 and the cursor position is out of bounds, behave as if the cursor 1313
2960 position were at the window margin. (Bug#10075) 1314 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2961 1315 for TTY frames that are not the top frame on their console.
29622011-11-18 Chong Yidong <cyd@gnu.org> 1316 (Bug#14616)
2963 1317
2964 * window.c (Fwindow_combination_limit): Make first argument 13182013-08-07 Martin Rudalics <rudalics@gmx.at>
2965 non-optional, since it is meaningless for live windows like the 1319
2966 selected window. 1320 * w32term.c (w32fullscreen_hook): Really maximize frame when
2967 1321 asked for (Bug#14841).
29682011-11-18 Dmitry Antipov <dmantipov@yandex.ru> 1322
2969 13232013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2970 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs. 1324
2971 1325 Prefer selected_window to Fselected_window, likewise for frames.
29722011-11-18 Stefan Monnier <monnier@iro.umontreal.ca> 1326 * buffer.c (Fbuffer_swap_text):
2973 1327 * data.c (Fvariable_binding_locus):
2974 * intervals.c: Fix grafting over the whole buffer (bug#10071). 1328 * window.c (run_window_configuration_change_hook): Adjust users.
2975 (graft_intervals_into_buffer): Simplify. 1329 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2976 1330 Use decode_live_frame.
29772011-11-18 Eli Zaretskii <eliz@gnu.org> 1331
2978 13322013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2979 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the 1333
2980 hash values of the two rows. 1334 Be more careful if selected window shows the buffer other than current,
2981 (copy_row_except_pointers): Preserve the used[] arrays and the 1335 use window_outdated only if this is not so. This change should also
2982 hash values of the two rows. (Bug#10035) 1336 address some weird issues discussed in Bug#13012.
2983 (add_row_entry): Add xassert to verify that ROW's hash code is valid. 1337 * window.h (window_outdated): New prototype.
2984 1338 * window.c (window_outdated): Now here. Convert from static and
2985 * xdisp.c (row_hash): New function, body extracted from 1339 always assume window's buffer.
2986 compute_line_metrics. 1340 (Fwindow_end, Fwindow_line_height): Use it.
2987 (compute_line_metrics): Call row_hash, instead of computing the 1341 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2988 hash code inline. 1342 and always assume window's buffer.
2989 1343 (redisplay_window): Adjust user.
2990 * dispnew.c (verify_row_hash): Call row_hash for computing the 1344 (redisplay_internal): Call to reconsider_clip_changes once and
2991 hash code of a row, instead of duplicating code from xdisp.c. 1345 check whether mode line should be updated only if selected window
2992 1346 shows current buffer.
2993 * dispextern.h (row_hash): Add prototype. 1347 (run_window_scroll_functions): Use eassert for debugging check.
2994 1348 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
29952011-11-18 Tassilo Horn <tassilo@member.fsf.org> 1349
2996 13502013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2997 * frame.c (delete_frame): Don't delete the terminal when the last 1351
2998 X frame is closed if emacs is built with GTK toolkit. 1352 * window.c (window_scroll, window_scroll_pixel_based)
2999 1353 (window_scroll_line_based): Use bool for booleans.
30002011-11-17 Juanma Barranquero <lekktu@gmail.com> 1354
3001 13552013-08-06 Paul Eggert <eggert@cs.ucla.edu>
3002 * window.c (syms_of_window) <window-combination-resize>: Fix typo. 1356
3003 1357 * process.c: Fix minor off-by-one issues in descriptor counts.
30042011-11-17 Martin Rudalics <rudalics@gmx.at> 1358 This shouldn't fix any real bugs, but it cleans up the code a bit.
3005 1359 (max_process_desc, max_input_desc): -1, not 0, means none.
3006 * window.c (Vwindow_splits): Rename to
3007 Vwindow_combination_resize. Suggested by Juri Linkov.
3008 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3009 of Vwindow_splits.
3010
30112011-11-16 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * nsfns.m (Fns_font_name):
3014 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3015
30162011-11-16 Martin Rudalics <rudalics@gmx.at>
3017
3018 * window.h (window): Rename slot "nest" to "combination_limit".
3019 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3020 (Fset_window_nest): Rename to Fset_window_combination_limit.
3021 (Vwindow_nest): Rename to Vwindow_combination_limit.
3022 (recombine_windows, make_parent_window, make_window)
3023 (Fsplit_window_internal, saved_window)
3024 (Fset_window_configuration, save_window_save): Rename all
3025 occurrences of window_nest to window_combination_limit.
3026
30272011-11-15 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * image.c (imagemagick_load_image): Fix typo.
3030
30312011-11-14 Eli Zaretskii <eliz@gnu.org>
3032
3033 * xdisp.c (display_line): Move the call to
3034 highlight_trailing_whitespace before the call to
3035 compute_line_metrics, since the latter needs to see the final
3036 faces of all the glyphs to compute ROW's hash value.
3037 Fixes assertion violations in row_equal_p. (Bug#10035)
3038
30392011-11-14 Juanma Barranquero <lekktu@gmail.com>
3040
3041 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3042 just return (bug#10044).
3043
30442011-11-12 Eli Zaretskii <eliz@gnu.org>
3045
3046 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3047 with user-defined heap size. Bump the default size of the temacs
3048 heap to 27MB, to avoid memory warning when running temacs.
3049 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3050
3051 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3052 current_matrix and desired_matrix. (Bug#9990)
3053 (verify_row_hash) [XASSERTS]: New function.
3054 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3055 that the hash value of glyph rows is correct.
3056
30572011-11-12 Martin Rudalics <rudalics@gmx.at>
3058
3059 * window.h (window): Remove splits slot.
3060 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3061 (Fdelete_other_windows_internal, make_parent_window)
3062 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3063 (Fset_window_configuration, save_window_save): Don't deal with
3064 split status of windows.
3065 (saved_window): Remove splits slot.
3066 (Vwindow_splits): Rewrite doc-string.
3067
30682011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3069
3070 * xfns.c (unwind_create_frame):
3071 * nsfns.m (unwind_create_frame):
3072 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3073 Vframe_list (Bug#9999).
3074
30752011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3076
3077 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3078
30792011-11-11 Kenichi Handa <handa@m17n.org>
3080
3081 * callproc.c (Fcall_process): Set the member dst_multibyte of
3082 process_coding.
3083
30842011-11-11 Johan Bockgård <bojohan@gnu.org>
3085
3086 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3087 avoid a crash (bug#9496).
3088
30892011-11-09 Chong Yidong <cyd@gnu.org>
3090
3091 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3092 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3093
30942011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3097
30982011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3099
3100 Avoid some portability problems by eschewing 'extern inline' functions.
3101 The trivial performance wins aren't worth the portability hassles; see
3102 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3103 et seq.
3104 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3105 (window_box_width, window_box_left, window_box_left_offset)
3106 (window_box_right, window_box_right_offset): Undo previous change,
3107 by removing the "extern"s.
3108 * intervals.c (adjust_intervals_for_insertion)
3109 (adjust_intervals_for_deletion): Undo previous change,
3110 making these static again.
3111 (offset_intervals, temp_set_point_both, temp_set_point)
3112 (copy_intervals_to_string): No longer inline.
3113 * xdisp.c (window_text_bottom_y, window_box_width)
3114 (window_box_height, window_box_left_offset)
3115 (window_box_right_offset, window_box_left, window_box_right)
3116 (window_box): No longer inline.
3117
31182011-11-08 Chong Yidong <cyd@gnu.org>
3119
3120 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3121 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3122 Signal an error if not a live window.
3123 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3124 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3125
31262011-11-07 Juanma Barranquero <lekktu@gmail.com>
3127
3128 * lisp.h (syms_of_abbrev): Remove declaration.
3129 Reported by CHENG Gao <chenggao@royau.me>.
3130
31312011-11-07 Eli Zaretskii <eliz@gnu.org>
3132
3133 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3134 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3135 of temacs in GUI mode.
3136
31372011-11-07 Martin Rudalics <rudalics@gmx.at>
3138
3139 * window.h: Declare delete_all_child_windows instead of
3140 delete_all_subwindows.
3141 * window.c (Fwindow_nest, Fset_window_nest)
3142 (Fset_window_new_total, Fset_window_new_normal)
3143 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3144 (delete_all_subwindows): Rename to delete_all_child_windows.
3145 (Fdelete_other_windows_internal, Fset_window_configuration):
3146 Call delete_all_child_windows instead of delete_all_subwindows.
3147 * frame.c (delete_frame): Call delete_all_child_windows instead
3148 of delete_all_subwindows.
3149
31502011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3151
3152 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3153 This is also needed for porting to any host where GC_MARK_STACK is
3154 not GC_MAKE_GCPROS_NOOPS.
3155 (which_symbols): Use it.
3156
31572011-11-07 Kenichi Handa <handa@m17n.org>
3158
3159 * coding.c (coding_set_destination): Check coding->src_pos only
3160 when coding->src_object is a buffer (bug#9910).
3161
3162 * process.c (send_process): Set the member src_multibyte of coding
3163 to 0 (bug#9911) when sending a unibyte text.
3164
3165 * callproc.c (Fcall_process): Set the member src_multibyte of
3166 process_coding to 0 (bug#9912).
3167
31682011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3169
3170 * xmenu.c (cleanup_widget_value_tree): New function.
3171 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3172 calling free_menubar_widget_value_tree directly (Bug#9830).
3173
31742011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 Fix some portability problems with 'inline'.
3177 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3178 (window_box_width, window_box_left, window_box_left_offset)
3179 (window_box_right, window_box_right_offset): Declare extern.
3180 Otherwise, these inline functions do not conform to C99 and
3181 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3182 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3183 * intervals.c (adjust_intervals_for_insertion)
3184 (adjust_intervals_for_deletion): Now extern, because otherwise the
3185 extern inline functions 'offset_intervals' couldn't refer to it.
3186 (static_offset_intervals): Remove.
3187 (offset_intervals): Rewrite using the old contents of
3188 static_offset_intervals. The old version didn't conform to C99
3189 because an extern inline function contained a reference to an
3190 identifier with static linkage.
3191
31922011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3193
3194 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3195 GC.
3196
31972011-11-06 Eli Zaretskii <eliz@gnu.org>
3198
3199 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3200 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3201 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3202 return Qleft_to_right.
3203
32042011-11-06 Chong Yidong <cyd@gnu.org>
3205
3206 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3207 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3208 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3209 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3210 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3211 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3212 (Fwindow_vscroll): Doc fix.
3213 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3214 argument, since it makes no sense to pass a live window and for
3215 consistency with window-child.
3216
32172011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3218
3219 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3220 support MSVC.
3221
32222011-11-05 Jason Rumney <jasonr@gnu.org>
3223
3224 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3225 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3226 fonts (Bug#6029).
3227 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3228 bitwise arithmetic preventing use of unicode-sip and non-truetype
3229 opentype fonts.
3230
32312011-11-05 Eli Zaretskii <eliz@gnu.org>
3232
3233 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3234 "emacs"-only part.
3235
3236 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3237 initialization code to keep similarity to xfns.c after changes
3238 from 2011-11-05.
3239
32402011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3241
3242 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3243 (unwind_create_frame): New function (Bug#9943).
3244 (Fx_create_frame): Restructure code to be more similar to the one in
3245 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3246 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3247 Move terminal->reference_count++ just before making the frame official
3248 (Bug#9943).
3249
3250 * nsterm.m (x_free_frame_resources): New function.
3251 (x_destroy_window): Move code to x_free_frame_resources.
3252
3253 * xfns.c (unwind_create_frame): Fix comment.
3254 (Fx_create_frame, x_create_tip_frame):
3255 Move terminal->reference_count++ just before making the frame
3256 official. Move initialization of image_cache_refcount and
3257 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3258
32592011-11-05 Eli Zaretskii <eliz@gnu.org>
3260
3261 Support MSVC build with newer versions of Visual Studio.
3262 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3263 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3264 nt/gmake.defs.
3265
3266 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3267 which are not supported by MSVC.
3268 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3269 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3270 bitfields.
3271 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3272 types in bitfields.
3273 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3274
3275 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3276
32772011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3278
3279 Support MSVC build with newer versions of Visual Studio.
3280 * w32.c: Don't include w32api.h for MSVC.
3281 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3282
3283 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3284 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3285 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3286 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3287 e_* cousins.
3288 (alloca) [_MSC_VER]: Define to _alloca.
3289
3290 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3291
3292 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3293
32942011-11-04 Eli Zaretskii <eliz@gnu.org>
3295
3296 * xdisp.c (note_mouse_highlight): If either of
3297 previous/next-single-property-change returns nil, treat that as
3298 the beginning or the end of the buffer. (Bug#9955)
3299
33002011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3301
3302 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3303 label is not null (Bug#9951).
3304 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3305 may be NULL.
3306
33072011-11-04 Eli Zaretskii <eliz@gnu.org>
3308
3309 * window.c (Fwindow_body_size): Mention in the doc string that the
3310 return value is in frame's canonical units. (Bug#9949)
3311
33122011-11-03 Eli Zaretskii <eliz@gnu.org>
3313
3314 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3315
3316 * w32fns.c (unwind_create_frame): If needed, free the glyph
3317 matrices of the partially constructed frame. (Bug#9943)
3318 * xfns.c (unwind_create_frame): Likewise.
3319
33202011-11-01 Eli Zaretskii <eliz@gnu.org>
3321
3322 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3323 Don't stop backward scan on the continuation glyph, even though
3324 its CHARPOS is positive.
3325 (mouse_face_from_buffer_pos, note_mouse_highlight):
3326 Rename cover_string to disp_string.
3327
33282011-11-01 Martin Rudalics <rudalics@gmx.at>
3329
3330 * window.c (temp_output_buffer_show): Don't use
3331 Vtemp_buffer_show_specifiers.
3332 (Vtemp_buffer_show_specifiers): Remove unused variable.
3333
33342011-10-30 Eli Zaretskii <eliz@gnu.org>
3335
3336 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3337 past the beginning of the current glyph matrix.
3338
33392011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3340
3341 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3342 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3343 HAVE_GTK3 (Bug#9869).
3344
3345 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3346 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3347
3348 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3349
3350 * xterm.c: Declare x_handle_net_wm_state to return int.
3351 (handle_one_xevent): Check if we are iconified but don't have
3352 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3353 (get_current_wm_state): Return non-zero if not hidden,
3354 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3355 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3356 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3357 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3358
33592011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3362 so that this new function doesn't get optimized away by a
3363 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3364
33652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3366
3367 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3368
33692011-10-29 Eli Zaretskii <eliz@gnu.org>
3370
3371 Fix the `xbytecode' command.
3372 * .gdbinit (xprintbytestr): New command.
3373 (xwhichsymbols): Rename from `which'; all callers changed.
3374 (xbytecode): Print the byte-code string as well.
3375
33762011-10-29 Kim Storm <storm@cua.dk>
3377
3378 * alloc.c (which_symbols): New function.
3379
33802011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3381
3382 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3383 line. (Bug#9903)
3384
33852011-10-29 Glenn Morris <rgm@gnu.org>
3386
3387 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3388 Not clear what it was for, and it causes various bugs. (Bug#9839)
3389
33902011-10-28 Eli Zaretskii <eliz@gnu.org>
3391
3392 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3393 possible random value that matches one of those tested as
3394 condition to clear the mouse face.
3395
33962011-10-28 Chong Yidong <cyd@gnu.org>
3397
3398 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3399
34002011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3401
3402 * window.c (make_window): Initialize phys_cursor_on_p.
3403
34042011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3405
3406 * lisp.h (struct Lisp_Symbol): Update comments.
3407
34082011-10-28 Juanma Barranquero <lekktu@gmail.com>
3409
3410 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3411
34122011-10-28 Eli Zaretskii <eliz@gnu.org>
3413
3414 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3415 <oslsachem@gmail.com> for helping to debug this.
3416
3417 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3418 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3419 (g_b_init_get_glyph_outline_w): New static variables.
3420 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3421 (GetGlyphOutlineW_Proc): New typedefs.
3422 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3423 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3424 New functions.
3425 (w32font_open_internal, compute_metrics):
3426 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3427 instead of calling the "wide" APIs directly.
3428
3429 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3430
3431 * w32.h (syms_of_w32font): Add prototype.
3432
34332011-10-27 Juanma Barranquero <lekktu@gmail.com>
3434
3435 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3436 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3437 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3438 (Fmove_to_window_line): Doc fix.
3439
34402011-10-27 Chong Yidong <cyd@gnu.org>
3441
3442 * process.c (make_process): Set gnutls_state to NULL.
3443
3444 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3445 non-NULL, regardless of GNUTLS_INITSTAGE.
3446 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3447 an error. Set process slots as soon as we allocate them.
3448
3449 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3450
34512011-10-27 Chong Yidong <cyd@gnu.org>
3452
3453 * gnutls.c (emacs_gnutls_deinit): New function.
3454 Deallocate credentials structures as well as calling gnutls_deinit.
3455 (Fgnutls_deinit, Fgnutls_boot): Use it.
3456
3457 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3458 (deactivate_process): Call emacs_gnutls_deinit.
3459
34602011-10-27 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * image.c (x_create_x_image_and_pixmap):
3463 * w32.c (sys_rename, w32_delayed_load):
3464 * w32font.c (fill_in_logfont):
3465 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3466
34672011-10-26 Juanma Barranquero <lekktu@gmail.com>
3468
3469 * w32fns.c (w32_default_color_map): New function,
3470 extracted from Fw32_default_color_map.
3471 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3472
34732011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3476
34772011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3478
3479 * keyboard.c (test_undefined): New function (bug#9751).
3480 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3481
34822011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3483
3484 * sysdep.c (init_sys_modes): Fix the check for the controlling
3485 terminal (Bug#6649).
3486
34872011-10-20 Eli Zaretskii <eliz@gnu.org>
3488
3489 * dispextern.h (struct bidi_it): New member next_en_type.
3490
3491 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3492 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3493 current character, check also for next_en_type being WEAK_EN.
3494 (bidi_resolve_weak): Don't enter the expensive loop if the current
3495 position is before next_en_pos. Record the bidi type of the first
3496 non-ET, non-BN character we find, in addition to its position.
3497 (bidi_level_of_next_char): Invalidate next_en_type when
3498 next_en_pos is over-stepped.
3499
35002011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3503 * editfns.c: Rewrite current-time-zone so that it invokes
3504 the equivalent of (format-time-string "%Z") to get the time zone name.
3505 This fixes a bug when the time zone name contains characters that
3506 need converting from the system time locale to Emacs internal format.
3507 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3508 that patch fixed format-time-string to do the conversion, but
3509 I forgot to fix current-time-zone.
3510 (format_time_string): New function, containing most of
3511 what Fformat_time_string used to contain.
3512 (Fformat_time_string): Rewrite in terms of format_time_string.
3513 This doesn't change this function's behavior.
3514 (current-time-zone): Rewrite to use format_time_string.
3515 This fixes the bug reported by Michael Schierl in
3516 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3517 Jason Rumney's 2007-06-07 change worked around this bug, but
3518 didn't fix it.
3519 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3520
35212011-10-19 Eli Zaretskii <eliz@gnu.org>
3522
3523 * xdisp.c (start_display): If the character at POS is displayed
3524 via a display vector, reset IT->current.dpvec_index to zero.
3525 (try_window_reusing_current_matrix): If a line ends in a display
3526 vector or the next line starts in a display vector, continue
3527 redrawing the window even though the character position of
3528 start_row was reached.
3529 (Bug#9771, part 2)
3530
35312011-10-18 Chong Yidong <cyd@gnu.org>
3532
3533 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3534 with nobreak-char-display too.
3535
35362011-10-18 Eli Zaretskii <eliz@gnu.org>
3537
3538 Fix part 3 of bug#9771.
3539 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3540 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3541 non-neutral characters if the current character is a paragraph
3542 separator (a.k.a. Newline). This avoids running the same
3543 expensive loop twice, once when we consume the preceding newline
3544 and the other time when the line actually needs to be displayed.
3545 Avoid the loop when we see neutrals on the base embedding level
3546 following a character whose directionality is the same as the
3547 paragraph's. This avoids running the expensive loop when a line
3548 ends in a long sequence of neutrals, like control characters.
3549 Add assertion against STRONG_AL type. Slightly rearrange code
3550 that determines the type of a neutral given the first non-neutral
3551 that follows it.
3552 (bidi_level_of_next_char): Set next_en_pos to zero when
3553 invalidating its info.
3554
35552011-10-17 Eli Zaretskii <eliz@gnu.org>
3556
3557 * xdisp.c (push_display_prop): Determine whether to record string
3558 or buffer position by IT->string, not by IT->method. Allow
3559 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3560 (move_it_vertically_backward): Don't look for character position
3561 immediately after the newline when in a continuation line.
3562 (Bug#9771, part 1)
3563
35642011-10-15 Martin Rudalics <rudalics@gmx.at>
3565
3566 * window.c (coordinates_in_window): Rewrite and delabelize
3567 vertical border check. (Bug#5357) (Bug#9618)
3568
35692011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3570
3571 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3572 errors in XSetWindowBorder (bug#9310).
3573
35742011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3575
3576 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3577 avoid crash when xmalloc overrun checking is enabled.
3578
35792011-10-13 Eli Zaretskii <eliz@gnu.org>
3580
3581 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3582 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3583 cursor motion with <left> and <right> arrow keys.
3584
3585 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3586 some callers set that themselves.
3587
35882011-10-12 Eli Zaretskii <eliz@gnu.org>
3589
3590 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3591 display string and the previous row comes from the same string and
3592 is empty. (Bug#9739) (Bug#9738)
3593
35942011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3595
3596 * doc.c (get_doc_string): Encode file name (bug#9735).
3597
35982011-10-12 Eli Zaretskii <eliz@gnu.org>
3599
3600 * bidi.c (bidi_level_of_next_char):
3601 * xdisp.c (get_visually_first_element): Remove old incorrect
3602 comments regarding the Unicode Line Separator character.
3603
3604 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3605
36062011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3607
3608 * alloc.c (Fgc_status): Do not access beyond zombies array
3609 boundary if nzombies > MAX_ZOMBIES.
3610 * alloc.c (dump_zombies): Add missing format specifier.
3611
36122011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3615 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3616
3617 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3618 Some packages use them to denote characters with modifiers.
3619
36202011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3621
3622 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3623 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3624 matching a pp-number. Rename parameter var to var1.
3625
36262011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3627
3628 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3629
36302011-10-08 Glenn Morris <rgm@gnu.org>
3631
3632 * callint.c (Fcall_interactively): Give a more explicit error for the
3633 'c' case with a non-character input. (Bug#8479)
3634
36352011-10-08 Eli Zaretskii <eliz@gnu.org>
3636
3637 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3638 lines.
3639 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3640 lines that are hscrolled on the left.
3641
3642 * dispnew.c (buffer_posn_from_coords): Account for a possible
3643 presence of header-line. (Bug#4426)
3644
36452011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3646
3647 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3648 Don't advertise functionality which we discourage or doesn't work.
3649
36502011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3653 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3654 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3655 this makes Emacs dump core during garbage collection on rare
3656 occasions. sizeof is obviously inferior to offsetof here, so
3657 stick with offsetof.
3658 (GC_POINTER_ALIGNMENT): New macro.
3659 (mark_memory): Omit 3rd (offset) arg; caller changed.
3660 Don't assume EMACS_INT alignment is the same as pointer alignment.
3661
36622011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3663
3664 * keyboard.c (read_key_sequence_remapped): New var.
3665 (read_key_sequence): Compute remapping in the right buffer.
3666 (command_loop_1): Use read_key_sequence's remapping directly.
3667
36682011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3669
3670 * dired.c (file_name_completion): Don't expand file name.
3671 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3672 before checking file name handler.
3673
3674 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3675 they've been requested explicitly (bug#9591).
3676
36772011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3678
3679 * keymap.c (Fsingle_key_description): Use make_specified_string
3680 instead of build_string to build string from push_key_description.
3681 (Bug#5193)
3682
36832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3684
3685 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3686 This fixes a Y2038 bug on 64-bit hosts.
3687 * buffer.c (reset_buffer):
3688 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3689 (Fclear_buffer_auto_save_failure):
3690 Use 0, not -1, to represent an unset failure time, since time_t
3691 might not be signed.
3692
3693 Remove dependency on glibc malloc internals.
3694 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3695 Move back here from lisp.h, but with their new implementations.
3696 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3697 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3698 * charset.c (charset_table_init): New static var.
3699 (syms_of_charset): Use it instead of xmalloc. This removes a
3700 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3701 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3702 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3703 Move back to alloc.c.
3704 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3705 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3706
37072011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3708
3709 * nsterm.m (windowDidResize): Call x_set_window_size only when
3710 ns_in_resize is true. Otherwise set pixelwidth/height and
3711 call change_frame_size (Bug#9628).
3712
37132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 Port --enable-checking=all to Fedora 14 x86-64.
3716 * charset.c (syms_of_charset): Also account for glibc malloc's
3717 internal overhead when calculating the initial malloc maximum.
3718
3719 Port --enable-checking=all to Fedora 14 x86.
3720 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3721 Move to lisp.h.
3722 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3723 (overrun_check_realloc, overrun_check_free):
3724 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3725 That way, xmalloc returns a properly-aligned pointer even if
3726 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3727 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3728 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3729 into account when calculating the initial malloc maximum.
3730 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3731 Move here from alloc.c, so that charset.c can use it too.
3732 Properly align; the old code wasn't right for common 32-bit hosts
3733 when configured with --enable-checking=all.
3734 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3735 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3736
37372011-09-29 Eli Zaretskii <eliz@gnu.org>
3738
3739 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3740 use EDOM.
3741
37422011-09-28 Eli Zaretskii <eliz@gnu.org>
3743
3744 * xdisp.c (compute_display_string_end): If there's no display
3745 string at CHARPOS, return -1.
3746
3747 * bidi.c (bidi_fetch_char): When compute_display_string_end
3748 returns a negative value, treat the character as a normal
3749 character not covered by a display string. (Bug#9624)
3750
37512011-09-28 Juanma Barranquero <lekktu@gmail.com>
3752
3753 * lread.c (Fread_from_string): Fix typo in docstring.
3754
37552011-09-27 Eli Zaretskii <eliz@gnu.org>
3756
3757 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3758 newline, reseat the iterator instead of bidi-iterating there one
3759 character at a time. (Bug#9610)
3760 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3761 TO_CHARPOS if the bidi iterator is at base embedding level.
3762
37632011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3764
3765 * lread.c (readevalloop): Use correct code for NBSP.
3766 (read1): Likewise. (Bug#9608)
3767
37682011-09-25 Michael Albinus <michael.albinus@gmx.de>
3769
3770 * dbusbind.c (Fdbus_register_signal): When service is not
3771 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3772
37732011-09-25 Glenn Morris <rgm@gnu.org>
3774
3775 * buffer.c (truncate-lines): Doc fix.
3776
37772011-09-24 Chong Yidong <cyd@stupidchicken.com>
3778
3779 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3780 (Fset_window_next_buffers): Doc fix.
3781
37822011-09-24 Glenn Morris <rgm@gnu.org>
3783
3784 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3785
37862011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3787
3788 Fix minor problems found by static checking.
3789 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3790 * indent.c (Fvertical_motion): Fix == vs = typo.
3791
37922011-09-24 Eli Zaretskii <eliz@gnu.org>
3793
3794 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3795 Default value is now t. Doc fix.
3796
3797 * indent.c (Fvertical_motion): Compute and apply the overshoot
3798 logic when moving up, not only when moving down. Fix the
3799 confusing name and values of the it_overshoot_expected variable;
3800 logic changes accordingly. (Bug#9254) (Bug#9549)
3801
3802 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3803 CHARPOS is covered by a display string which includes newlines.
3804 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3805 is covered by a display string with embedded newlines.
3806
38072011-09-24 Michael Albinus <michael.albinus@gmx.de>
3808
3809 * dbusbind.c (Fdbus_register_signal): Add match rule to
3810 Vdbus_registered_objects_table. (Bug#9581)
3811 (Fdbus_register_method, Vdbus_registered_objects_table):
3812 Fix docstring.
3813
38142011-09-24 Jim Meyering <meyering@redhat.com>
3815
3816 do not ignore write error for any output size
3817 The previous change was incomplete.
3818 While it makes emacs --batch detect the vast majority of stdout
3819 write failures, errors were still ignored whenever the output size is
3820 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3821 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3822 && echo FAIL: ignored write error
3823 FAIL: ignored write error
3824 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3825 && echo FAIL: ignored write error
3826 FAIL: ignored write error
3827 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3828
38292011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3830
3831 * emacs.c (Fkill_emacs): In noninteractive mode exit
3832 non-successfully if a write error occurred on stdout. (Bug#9574)
3833
38342011-09-21 Eli Zaretskii <eliz@gnu.org>
3835
3836 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3837 the xassert test.
3838
3839 * dispextern.h (struct it): Update the comment documenting what
3840 can it->OBJECT be.
3841
38422011-09-20 Eli Zaretskii <eliz@gnu.org>
3843
3844 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3845 a display string, extend search for cursor position to end of row.
3846 (find_row_edges): If the row ends in a newline from a display
3847 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3848 Handle the case of a display string with multiple newlines.
3849 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3850 non-empty line. Fixes confusing cursor motion with arrow keys at
3851 the beginning of a line that starts with whitespace.
3852
38532011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3854
3855 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3856 (bug#9493).
3857
38582011-09-18 Chong Yidong <cyd@stupidchicken.com>
3859
3860 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3861 boolean (Bug#9154).
3862
38632011-09-18 Eli Zaretskii <eliz@gnu.org>
3864
3865 * xdisp.c (display_line): Record maximum and minimum buffer
3866 positions even if no glyphs were produced (e.g., by a zero-width
3867 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3868 buffer positions that will be removed from the glyph row because
3869 they don't fit.
3870 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3871 column is beyond frame width: don't subtract 1 "pixel" when
3872 computing width of the stretch.
3873 (reseat_at_next_visible_line_start): Undo the change made on
3874 2011-09-17 that saved paragraph information and restored it after
3875 the call to `reseat'. (Bug#9545)
3876
38772011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3878
3879 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3880 and turn window cursor on if cleared (Bug#9415).
3881
38822011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3883
3884 * search.c (boyer_moore): Take unibyte characters from pattern
3885 literally. (Bug#9458)
3886
38872011-09-18 Eli Zaretskii <eliz@gnu.org>
3888
3889 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3890
38912011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 Fix minor problem found by static checking.
3894 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3895 initialized, to pacify gcc -Wuninitialized.
3896
3897 * fileio.c: Report proper errno when syscall falls.
3898 (Finsert_file_contents): Save and restore errno,
3899 so that report_file_error outputs the correct diagnostic.
3900 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3901
39022011-09-18 Eli Zaretskii <eliz@gnu.org>
3903
3904 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3905
39062011-09-17 Eli Zaretskii <eliz@gnu.org>
3907
3908 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3909 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3910
39112011-09-17 Eli Zaretskii <eliz@gnu.org>
3912
3913 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3914 about the current paragraph and restore it after the call to reseat.
3915
3916 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3917 (bidi_find_paragraph_start): Search back for paragraph beginning
3918 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3919 (bidi_move_to_visually_next): Only trigger paragraph-related
3920 computations when the last character is a newline or at EOB, not
3921 just any NEUTRAL_B. (Bug#9470)
3922
3923 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3924 truncated lines if point is covered by a display string. (Bug#9524)
3925
39262011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3929 (cons_to_x_long): New function.
3930 (lisp_data_to_selection_data): Use it. Correct the test for
3931 short-versus-long data; it was negated. Break out of vector
3932 loop, for efficiency, when a long datum is discovered.
3933
39342011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3935
3936 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3937
39382011-09-16 Eli Zaretskii <eliz@gnu.org>
3939
3940 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3941 GCC PR/17406) by declaring this function with external scope.
3942
39432011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3946 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3947
39482011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3949
3950 * editfns.c (Fformat): Correctly handle text properties on "%%".
3951
39522011-09-15 Eli Zaretskii <eliz@gnu.org>
3953
3954 * xterm.c (x_draw_composite_glyph_string_foreground):
3955 * w32term.c (x_draw_composite_glyph_string_foreground):
3956 * term.c (encode_terminal_code):
3957 * composite.c (composition_update_it, get_composition_id):
3958 * xdisp.c (get_next_display_element)
3959 (fill_composite_glyph_string): Add comments about special meaning
3960 of TAB characters in a composition.
3961
39622011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3963
3964 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3965 This occurs when processing a multibyte format.
3966 Problem reported by Wolfgang Jenker.
3967
39682011-09-15 Johan Bockgård <bojohan@gnu.org>
3969
3970 * xdisp.c (try_cursor_movement): Only check for exact match if
3971 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3972
39732011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3974
3975 Remove unused external symbols.
3976 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3977 * xdisp.c (calc_pixel_width_or_height): Now static.
3978 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3979 * indent.c (check_display_width):
3980 * w32term.c: Fix comment to match code.
3981 * xterm.c, xterm.h (x_catching_errors): Remove.
3982
39832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 * xselect.c: Use signed conversions more consistently (Bug#9498).
3986 (selection_data_to_lisp_data): Assume incoming selection data are
3987 signed integers, not unsigned. This is to be consistent with
3988 outgoing selection data, which was modified to use signed integers
3989 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3990 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3991 expects long, not unsigned long.
3992
39932011-09-14 Eli Zaretskii <eliz@gnu.org>
3994
3995 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3996 computation of loop end. Reported by Johan Bockgård
3997 <bojohan@gnu.org>.
3998
39992011-09-13 Chong Yidong <cyd@stupidchicken.com>
4000
4001 * frame.c (Fother_visible_frames_p): Function deleted.
4002
40032011-09-12 Eli Zaretskii <eliz@gnu.org>
4004
4005 * indent.c (compute_motion): Process display vector front to back
4006 rather than the other way around. (Bug#2496)
4007
40082011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4009
4010 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4011
40122011-09-11 Chong Yidong <cyd@stupidchicken.com>
4013
4014 * minibuf.c (Fread_from_minibuffer): Doc fix.
4015
40162011-09-11 Eli Zaretskii <eliz@gnu.org>
4017
4018 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4019 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4020
40212011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4022
4023 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4024 value for non-existent files.
4025
40262011-09-11 Eli Zaretskii <eliz@gnu.org>
4027
4028 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4029 set its "size" to -1. This will set the modtime_size field of
4030 the corresponding buffer to -1, which is what
4031 verify-visited-file-modtime expects for files that do not exist.
4032 (Bug#9139)
4033
40342011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4035
4036 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4037 here ...
4038 * lisp.h: ... from here. push_key_description is no longer
4039 defined in keyboard.c, so its declaration should not be in
4040 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4041 logically belongs with push_key_description.
4042
40432011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 * buffer.h: Include <sys/types.h> instead of <time.h>.
4046 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4047 Problem reported by Herbert J. Skuhra.
4048
40492011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4050
4051 * xml.c (parse_region): Make the parsing work for
4052 non-comment-starting XML files again (bug#9144).
4053
40542011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4055
4056 * image.c (gif_load): Fix calculation of bottom and right corner.
4057 (Bug#9468)
4058
40592011-09-10 Eli Zaretskii <eliz@gnu.org>
4060
4061 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4062 redisplay in small windows.
4063
40642011-09-09 Eli Zaretskii <eliz@gnu.org>
4065
4066 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4067
40682011-09-08 Martin Rudalics <rudalics@gmx.at>
4069
4070 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4071 Operate on live windows only.
4072
40732011-09-08 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4076
40772011-09-07 Eli Zaretskii <eliz@gnu.org>
4078
4079 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4080 only under bidi iteration.
4081
40822011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4083
4084 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4085
40862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4087
4088 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4089 Without this fix, the command to link temacs failed due to an
4090 undefined symbol __builtin_isnan. This is because
4091 /usr/include/iso/math_c99.h #defines isnan(x) to
4092 __builtin_isnan(x), but the bundled gcc, which identifies itself
4093 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4094 a __builtin_isnan.
4095 * floatfns.c (isnan): #undef, and then #define to a clone of
4096 what's in data.c.
4097 (Fisnan): Always define, since it's always available now.
4098 (syms_of_floatfns): Always define isnan at the Lisp level.
4099
41002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4103
41042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4105
4106 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4107 The previous code assumed that file offsets (off_t values) fit in
4108 EMACS_INT variables, which is not true on typical 32-bit hosts.
4109 The code messed up by falsely reporting buffer overflow in cases
4110 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4111 when "big" contains more than 2**29 bytes, even though this
4112 inserts just one byte and does not overflow the buffer.
4113 (Finsert_file_contents): Store file offsets as off_t
4114 values, not as EMACS_INT values. Check for overflow when
4115 converting between EMACS_INT and off_t. When checking for
4116 buffer overflow or for overlap, take the offsets into account.
4117 Don't use EMACS_INT for small values where int suffices.
4118 When checking for overlap, fix a typo: ZV was used where
4119 ZV_BYTE was intended.
4120 (Fwrite_region): Don't assume off_t fits into 'long'.
4121 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4122
41232011-09-05 Michael Albinus <michael.albinus@gmx.de>
4124
4125 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4126
41272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4128
4129 sprintf-related integer and memory overflow issues (Bug#9412).
4130
4131 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4132 (esprintf, exprintf, evxprintf): New functions.
4133 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4134 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4135 (modify_event_symbol): Do not assume that the length of
4136 name_alist_or_stem is safe to alloca and fits in int.
4137 (Fexecute_extended_command): Likewise for function name and binding.
4138 (Frecursion_depth): Wrap around reliably on integer overflow.
4139 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4140 since some callers pass EMACS_INT values.
4141 (Fsingle_key_description): Don't crash if symbol name contains more
4142 than MAX_ALLOCA bytes.
4143 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4144 (get_minibuffer): Arg is now EMACS_INT, not int.
4145 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4146 (esprintf, exprintf, evxprintf): New decls.
4147 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4148
4149 * dbusbind.c (signature_cat): New function.
4150 (xd_signature, Fdbus_register_signal):
4151 Do not overrun buffer; instead, report string overflow.
4152
4153 * dispnew.c (add_window_display_history): Don't overrun buffer.
4154 Truncate instead; this is OK since it's just a log.
4155
4156 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4157 even if the time zone offset is outlandishly large.
4158 Don't mishandle offset == INT_MIN.
4159
4160 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4161 when creating daemon; the previous buffer-overflow check was incorrect.
4162
4163 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4164 which has the guts of the old verror function.
4165
4166 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4167 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4168
4169 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4170 (font_unparse_xlfd): Don't blindly alloca long strings.
4171 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4172 fits in int, when using sprintf. Use single snprintf to count
4173 length of string rather than counting it via multiple sprintfs;
4174 that's simpler and more reliable.
4175 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4176 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4177 sprintf, in case result does not fit in int.
4178
4179 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4180 (fontset_from_font): Print it.
4181
4182 * frame.c (tty_frame_count): Now printmax_t, not int.
4183 (make_terminal_frame, set_term_frame_name): Print it.
4184 (x_report_frame_params): In X, window IDs are unsigned long,
4185 not signed long, so print them as unsigned.
4186 (validate_x_resource_name): Check for implausibly long names,
4187 and don't assume name length fits in 'int'.
4188 (x_get_resource_string): Don't blindly alloca invocation name;
4189 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4190 not fit in int.
4191
4192 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4193 (xg_check_special_colors, xg_set_geometry):
4194 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4195
4196 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4197 Use esprintf, not sprintf, in case result does not fit in int.
4198
4199 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4200 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4201 it as a large positive number.
4202 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4203 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4204
4205 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4206 in case result does not fit in int.
4207
4208 * print.c (float_to_string): Detect width overflow more reliably.
4209 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4210 buffer overrun. Don't assume list length fits in 'int'. Treat
4211 print length of 0 as 0, not as infinity; to be consistent with other
4212 uses of print length in this function. Don't overflow print length
4213 index. Don't assume hash table size fits in 'long', or that
4214 vectorlike size fits in 'unsigned long'.
4215
4216 * process.c (make_process): Use printmax_t, not int, to format
4217 process-name gensyms.
4218
4219 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4220
4221 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4222 to avoid potential buffer overrun.
4223
4224 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4225 if X resource line is longer than 512 bytes.
4226
4227 * xfns.c (x_window): Make sprintf buffer a bit bigger
4228 to avoid potential buffer overrun.
4229
4230 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4231
4232 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4233
42342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 Integer overflow fixes for scrolling, etc.
4237 Without these, Emacs silently mishandles large integers sometimes.
4238 For example, "C-u 4294967297 M-x recenter" was treated as if
4239 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4240
4241 * xdisp.c (try_window_id): Check Emacs fixnum range before
4242 converting to 'int'.
4243
4244 * window.c (window_scroll_line_based, Frecenter):
4245 Check that an Emacs fixnum is in range before assigning it to 'int'.
4246 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4247 values converted from Emacs fixnums.
4248 (Frecenter): Don't wrap around a line count if it is out of 'int'
4249 range; instead, treat it as an extreme value.
4250 (Fset_window_configuration, compare_window_configurations):
4251 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4252
4253 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4254 that can exceed INT_MAX. Check that EMACS_INT value is in range
4255 before assigning it to the (possibly-narrower) index.
4256 (match_limit): Don't assume that a fixnum can fit in 'int'.
4257
4258 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4259 exceed INT_MAX.
4260
4261 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4262 (Fvertical_motion): Don't wrap around LINES values that don't fit
4263 in 'int'. Instead, treat them as extreme values. This is good
4264 enough for windows, which can't have more than INT_MAX lines anyway.
4265
42662011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4267
4268 * Require libxml/parser.h to avoid compilation warning.
4269
4270 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4271
4272 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4273 since this reportedly can destroy thread storage.
4274
42752011-08-30 Chong Yidong <cyd@stupidchicken.com>
4276
4277 * syntax.c (find_defun_start): Update all cache variables if
4278 exiting early (Bug#9401).
4279
42802011-08-30 Eli Zaretskii <eliz@gnu.org>
4281
4282 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4283
4284 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4285 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4286 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4287
4288 * term.c (tty_append_glyph): New function.
4289 (produce_stretch_glyph): Static function and its prototype deleted.
4290
4291 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4292 Add prototypes.
4293
42942011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4295
4296 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4297 when checking :margin (Bug#9390).
4298 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4299 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4300 so that the name doesn't mislead. All uses changed.
4301
43022011-08-28 Johan Bockgård <bojohan@gnu.org>
4303
4304 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4305 set_tty_hooks.
4306
43072011-08-27 Eli Zaretskii <eliz@gnu.org>
4308
4309 * xdisp.c (move_it_to): Don't bail out early when reaching
4310 position beyond to_charpos, if we are scanning backwards.
4311 (move_it_vertically_backward): When DY == 0, make sure we get to
4312 the first character in the line after the newline.
4313
43142011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4315
4316 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4317 (ccl_driver): Do not generate an out-of-range pointer.
4318 (Fccl_execute_on_string): Remove unnecessary check for
4319 integer overflow, noted by Stefan Monnier in
4320 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4321 Remove a FIXME that didn't need fixing.
4322 Simplify the newly-introduced buffer reallocation code.
4323
43242011-08-27 Juanma Barranquero <lekktu@gmail.com>
4325
4326 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4327
43282011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4329
4330 Integer and memory overflow issues (Bug#9196).
4331
4332 * doc.c (get_doc_string): Rework so that
4333 get_doc_string_buffer_size is the actual buffer size, rather than
4334 being 1 less than the actual buffer size; this makes xpalloc more
4335 convenient.
4336
4337 * image.c (x_allocate_bitmap_record, cache_image):
4338 * xselect.c (Fx_register_dnd_atom):
4339 Simplify previous changes by using xpalloc.
4340
4341 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4342 since either will do and ptrdiff_t is convenient with xpalloc.
4343
4344 * charset.c (charset_table_size)
4345 (struct charset_sort_data.priority): Now ptrdiff_t.
4346 (charset_compare): Don't overflow if priorities differ greatly.
4347 (Fsort_charsets): Don't assume list length fits in int.
4348 Check for size-calculation overflow when allocating sort data.
4349 (syms_of_charset): Allocate an initial charset table that is
4350 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4351
4352 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4353
4354 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4355 The actual value is always <= INT_MAX, and leaving it unsigned made
4356 overflow checking harder.
4357
4358 * dispextern.h (struct glyph_matrix.rows_allocated)
4359 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4360 with xpalloc. The values are still always <= INT_MAX.
4361
4362 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4363
4364 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4365 (SAFE_NALLOCA): New macro.
4366
4367 * region-cache.c (struct boundary.pos, find_cache_boundary)
4368 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4369 (set_cache_region, invalidate_region_cache)
4370 (revalidate_region_cache, know_region_cache, region_cache_forward)
4371 (region_cache_backward, pp_cache):
4372 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4373 so that ptrdiff_t * can be passed to xpalloc.
4374 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4375 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4376 (pp_cache): Don't assume cache_len fits in int.
4377 * region-cache.h: Adjust extern decls to match.
4378
4379 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4380 EMACS_INT, since either will do, for xpalloc.
4381
4382 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4383 (xnmalloc, xnrealloc, xpalloc): New functions.
4384
4385 * bidi.c (bidi_shelve_header_size): New constant.
4386 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4387 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4388
4389 * bidi.c (bidi_cache_shrink):
4390 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4391 (overlay_strings):
4392 Don't update size of array until after memory allocation succeeds,
4393 because xmalloc/xrealloc may not return.
4394 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4395 now that we have proper integer overflow checking.
4396 (record_overlay_string, overlay_strings): Catch overflows when
4397 calculating size of overlay_str_buf.
4398
4399 * callproc.c (Fcall_process): Check for size overflow when
4400 calculating size of args2.
4401 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4402 Normally we prefer signed values, but sticking with ptrdiff_t would
4403 require adding more-complicated checks.
4404
4405 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4406 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4407 Redo buffer-overflow calculations to avoid integer overflow.
4408 Add a FIXME comment where memory seems to be over-allocated.
4409
4410 * character.c (Fstring): Check for size-calculation overflow.
4411
4412 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4413 unnecessary integer overflow. Check for size overflow.
4414 (encode_coding_object): Don't update size until xmalloc succeeds.
4415
4416 * composite.c (get_composition_id): Check for overflow in glyph
4417 length calculations.
4418
4419 Integer and memory overflow fixes for display code.
4420 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4421 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4422 (scrolling_window): Check for overflow in size calculations.
4423 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4424 Don't assume glyph table len fits in int.
4425 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4426 (row_table_size): Now ptrdiff_t, not int.
4427 (scrolling_window): Avoid overflow in size calculations.
4428 Don't update size until allocation succeeds.
4429 * fns.c (concat): Check for overflow in size calculations.
4430 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4431 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4432 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4433
4434 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4435 (get_doc_string): Check for size calculation overflow.
4436 Don't update size until allocation succeeds.
4437 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4438 EMACS_INT, where ptrdiff_t will do.
4439 (Fsubstitute_command_keys): Check for string overflow.
4440
4441 * editfns.c (set_time_zone_rule): Don't assume environment length
4442 fits in int.
4443 (message_length): Now ptrdiff_t, not int.
4444 (Fmessage_box): Don't update size until allocation succeeds.
4445 Don't assume message length fits in int.
4446 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4447
4448 * emacs.c (main): Do not reallocate argv, since there is a null at
4449 the end that can be overwritten, and this way there's no need to
4450 worry about size-calculation overflow.
4451 (sort_args): Check for size-calculation overflow.
4452
4453 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4454 alloc succeeds.
4455 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4456
4457 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4458 (x_set_scroll_bar_width, x_figure_window_size):
4459 Check for integer overflow.
4460 (x_set_alpha): Do not assume XINT fits in int.
4461
4462 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4463 This is for the members text_lines, text_cols, total_lines, total_cols,
4464 where the system imposes an 'int' limit.
4465
4466 * fringe.c (Fdefine_fringe_bitmap):
4467 Don't update size until alloc works.
4468
4469 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4470 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4471
4472 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4473 Check for size-calculation overflow.
4474 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4475 do, as we prefer signed integers.
4476 (id_to_widget.max_size, id_to_widget.used)
4477 (xg_store_widget_in_map, xg_remove_widget_from_map)
4478 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4479 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4480 Use and return ptrdiff_t, not int.
4481 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4482 * gtkutil.h: Change prototypes to match the above.
4483
4484 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4485 are duplicate now that they've been promoted to lisp.h.
4486 (x_allocate_bitmap_record, x_alloc_image_color)
4487 (make_image_cache, cache_image, xpm_load):
4488 Don't update size until alloc is done.
4489 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4490 (x_detect_edges):
4491 Check for size calculation overflow.
4492 (ct_colors_allocated_max): New constant.
4493 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4494 overflow.
4495
4496 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4497 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4498 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4499 Use ptrdiff_t, not int, to count maps.
4500 (read_char_minibuf_menu_prompt): Check for overflow in size
4501 calculations. Don't update size until allocation succeeds.
4502 Redo calculations to avoid overflow.
4503 * keyboard.h: Change prototypes to match the above.
4504
4505 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4506 to count maps.
4507 (current_minor_maps): Check for size calculation overflow.
4508 * keymap.h: Change prototypes to match the above.
4509
4510 * lread.c (read1, init_obarray): Don't update size until alloc done.
4511
4512 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4513 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4514
4515 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4516 Now ptrdiff_t, not int.
4517 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4518 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4519
4520 * process.c (Fnetwork_interface_list): Check for overflow
4521 in size calculation.
4522
4523 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4524
4525 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4526 overflow. Don't bother calling xmalloc when xrealloc will do.
4527
4528 * search.c (Freplace_match): Check for size calculation overflow.
4529 (Fset_match_data): Don't assume list lengths fit in 'int'.
4530
4531 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4532 for command line length. Do not attempt to address one before the
4533 beginning of an array, as that's not portable.
4534
4535 * term.c (max_frame_lines): Remove; unused.
4536 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4537 not int.
4538 (encode_terminal_code, calculate_costs): Check for size
4539 calculation overflow.
4540 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4541 table lengths and related sizes. Don't update size until alloc
4542 done. Redo calculations to avoid overflow.
4543 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4544
4545 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4546 subtracting pointers.
4547 (gobble_line): Check for overflow more carefully. Don't update size
4548 until alloc done.
4549
4550 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4551 Don't update size until alloc done.
4552 Redo size calculations to avoid overflow.
4553 Check for size calculation overflow.
4554 (main) [DEBUG]: Fix typo in invoking tparam1.
4555
4556 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4557 Use ptrdiff_t, not int, for sizes.
4558 (store_mode_line_noprop_char): Don't update size until alloc done.
4559
4560 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4561 Use ptrdiff_t, not int, for sizes.
4562 (Finternal_make_lisp_face, cache_face):
4563 Check for size calculation overflow.
4564 (cache_face): Treat size calculation overflows as if they were
4565 memory exhaustion (the usual treatment), rather than aborting.
4566
4567 * xfns.c (x_encode_text, x_set_name_internal)
4568 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4569 sizes, since they can exceed INT_MAX in size. Check for size
4570 calculation overflow.
4571
4572 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4573 (xg_select): Check for size calculation overflow.
4574 Don't update size until alloc done.
4575
4576 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4577 as sprintf is limited to int lengths.
4578
4579 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4580 (X_LONG_MIN): New macros.
4581 Use them to make the following changes clearer.
4582 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4583 This change doesn't affect the value now, but it may help remind
4584 future maintainers not to raise the value too much later.
4585 (SELECTION_QUANTUM): Remove, replacing with ...
4586 (selection_quantum): ... new function, which avoids overflow.
4587 All uses changed. 1360 All uses changed.
4588 (struct selection_data.size): Now ptrdiff_t, not int, to avoid 1361 (delete_input_desc): New function.
4589 assumption that selection length fits in 'int'. 1362 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
4590 (x_reply_selection_request, x_handle_selection_request) 1363 (deactivate_process): Scan backwards when recomuting max_process_desc;
4591 (x_get_window_property, receive_incremental_selection) 1364 that should be faster.
4592 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data) 1365 (init_process_emacs): Initialize max_input_desc.
4593 (lisp_data_to_selection_data, clean_local_selection_data): 1366
4594 Use ptrdiff_t, not int, to record length of selection. 13672013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4595 (x_reply_selection_request, x_get_window_property) 1368
4596 (receive_incremental_selection, x_property_data_to_lisp): 1369 Use region cache to speedup bidi_find_paragraph_start.
4597 Redo calculations to avoid overflow. 1370 * buffer.h (struct buffer): New member bidi_paragraph_cache.
4598 (x_reply_selection_request): When sending hint, ceiling it at 1371 Rename cache_long_line_scans to cache_long_scans.
4599 X_LONG_MAX rather than relying on wraparound overflow to send 1372 * buffer.c (bset_cache_long_line_scans): Rename to
4600 something. 1373 bset_cache_long_scans.
4601 (x_get_window_property, receive_incremental_selection) 1374 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
4602 (lisp_data_to_selection_data, x_property_data_to_lisp): 1375 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
4603 Check for size-calculation overflow. 1376 into account.
4604 (x_get_window_property, receive_incremental_selection) 1377 (syms_of_buffer): Rename cache-long-line-scans to
4605 (lisp_data_to_selection_data, Fx_register_dnd_atom): 1378 cache-long-scans. Adjust docstring.
4606 Don't store size until memory allocation succeeds. 1379 * search.c (newline_cache_on_off):
4607 (x_get_window_property): Plug memory leak on memory exhaustion. 1380 * indent.c (width_run_cache_on_off): Adjust users.
4608 Don't double-block input; malloc is safe here. Don't assume 2**34 1381 * bidi.c (bidi_paragraph_cache_on_off): New function.
4609 - 4 fits in unsigned long. Add an xassert to check 1382 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
4610 XGetWindowProperty overflow. Be more careful about overflow 1383 * insdel.c (prepare_to_modify_buffer):
4611 calculations, and distinguish size from memory overflow better. 1384 Invalidate bidi_paragraph_cache if enabled.
4612 (receive_incremental_selection): When tracing, don't assume 1385
4613 unsigned int is less than INT_MAX. 13862013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4614 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory 1387
4615 harmful) conversions of unsigned short to int. 1388 Invalidate region caches only if buffer text is going to be changed.
4616 (lisp_data_to_selection_data): Don't assume that integers 1389 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
4617 in the range -65535 through -1 fit in an X unsigned short. 1390 (modify_text): ...new prototype.
4618 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into 1391 (prepare_to_modify_buffer_1): New prototype.
4619 result parameters unless successful. Rely on cons_to_unsigned 1392 * textprop.c (modify_region): Rename to...
4620 to report problems with elements; the old code wasn't right anyway. 1393 (modify_text_properties): ...new function.
4621 (x_check_property_data): Check for int overflow; we cannot use 1394 (add_text_properties_1, set_text_properties, Fremove_text_properties)
4622 a wider type due to X limits. 1395 (Fremove_list_of_text_properties): Adjust users.
4623 (x_handle_dnd_message): Use unsigned int, to avoid int overflow. 1396 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
4624 1397 (modify_text): ...new function.
4625 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow. 1398 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
4626 1399 (prepare_to_modify_buffer_1): ...new function.
4627 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent) 1400 * casefiddle.c (casify_region):
4628 (x_term_init): Check for size calculation overflow. 1401 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
4629 (x_color_cells): Don't store size until memory allocation succeeds. 1402 (Ftranspose_regions): Use modify_text.
4630 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts. 1403
4631 Don't assume alloca size is less than MAX_ALLOCA. 14042013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
4632 (x_term_init): Don't assume length fits in int (sprintf is limited 1405
4633 to int size). 1406 * lisp.mk (lisp): Add nadvice.elc.
4634 1407
4635 Use ptrdiff_t for composition IDs. 14082013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
4636 * character.c (lisp_string_width): 1409
4637 * composite.c (composition_table_size, n_compositions) 1410 New macro to iterate over live buffers similar to frames.
4638 (get_composition_id, composition_gstring_from_id): 1411 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
4639 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id): 1412 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
4640 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): 1413 Declare buffer-related variables here to offload lisp.h.
4641 * window.c (Frecenter): 1414 * buffer.c (Vbuffer_alist): Adjust comment.
4642 Use ptrdiff_t, not int, for composition IDs. 1415 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
4643 * composite.c (get_composition_id): Check for integer overflow. 1416 (other_buffer_safely):
4644 * composite.h: Adjust prototypes to match the above changes. 1417 * data.c (store_symval_forwarding):
4645 1418 * dispnew.c (Fframe_or_buffer_changed_p):
4646 Use ptrdiff_t for hash table indexes. 1419 * fileio.c (Fdo_auto_save):
4647 * category.c (hash_get_category_set): 1420 * filelock.c (unlock_all_files):
4648 * ccl.c (ccl_driver): 1421 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
4649 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4650 * coding.c (coding_system_charset_list, detect_coding_system):
4651 * coding.h (struct coding_system.id):
4652 * composite.c (get_composition_id, gstring_lookup_cache):
4653 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4654 * image.c (xpm_get_color_table_h):
4655 * lisp.h (hash_lookup, hash_put):
4656 * minibuf.c (Ftest_completion):
4657 Use ptrdiff_t for hash table indexes, not int (which is too
4658 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4659 32-bit --with-wide-int hosts).
4660
4661 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4662 Add a FIXME comment about memory leaks.
4663 (syms_of_charset): Don't assume xmalloc returns.
4664
4665 Don't assume that stated character widths fit in int.
4666 * character.c (Fchar_width, c_string_width, lisp_string_width):
4667 * character.h (CHAR_WIDTH):
4668 * indent.c (MULTIBYTE_BYTES_WIDTH):
4669 Use sanitize_char_width to avoid undefined and/or bad behavior
4670 with outlandish widths.
4671 * character.h (sanitize_tab_width): Rename from sanitize_width,
4672 now that we have two such functions. All uses changed.
4673 (sanitize_char_width): New inline function.
4674
4675 Don't assume that tab-width fits in int.
4676 * character.h (sanitize_width): New inline function.
4677 (SANE_TAB_WIDTH): New macro.
4678 (ASCII_CHAR_WIDTH): Use it.
4679 * indent.c (sane_tab_width): Remove. All uses replaced by
4680 SANE_TAB_WIDTH (current_buffer).
4681 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4682
4683 * fileio.c: Integer overflow issues with file modes.
4684 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4685
4686 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4687 Remove unreachable code.
4688 (read_hex, load_charset_map_from_file): Check for integer overflow.
4689
4690 * xterm.c: Don't go over XClientMessageEvent limit.
4691 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4692 (x_send_scroll_bar_event): Likewise. Check that the size does not
4693 exceed limits imposed by XClientMessageEvent, as well as the usual
4694 ptrdiff_t and size_t limits.
4695
4696 * keyboard.c: Overflow, signedness and related fixes.
4697 (make_lispy_movement): Use same integer type in forward decl
4698 that is used in the definition.
4699 (read_key_sequence, keyremap_step):
4700 Change bufsize argument back to int, undoing my 2011-03-30 change.
4701 We prefer signed types, and int is wide enough here.
4702 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4703 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4704 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4705 length, not size_t. Use ptrdiff_t for index, not int.
4706 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4707 possibility of integer overflow.
4708
4709 Overflow, signedness and related fixes for images.
4710
4711 * dispextern.h (struct it.stack[0].u.image.image_id)
4712 (struct_it.image_id, struct image.id, struct image_cache.size)
4713 (struct image_cache.used, struct image_cache.ref_count):
4714 * gtkutil.c (update_frame_tool_bar):
4715 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4716 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4717 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4718 * nsmenu.m (update_frame_tool_bar):
4719 * xdisp.c (calc_pixel_width_or_height):
4720 * xfns.c (image_cache_refcount):
4721 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4722 on typical 64-bit hosts.
4723
4724 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4725 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4726 Omit unnecessary casts to int.
4727 (parse_image_spec): Check that integers fall into 'int' range
4728 when the callers expect that.
4729 (image_ascent): Redo ascent calculation to avoid int overflow.
4730 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4731 (lookup_image): Remove unnecessary tests.
4732 (xbm_image_p): Locals are now of int, not EMACS_INT,
4733 since parse_image_check makes sure they fit into int.
4734 (png_load, gif_load, svg_load_image):
4735 Prefer int to unsigned where either will do.
4736 (tiff_handler): New function, combining the cores of the
4737 old tiff_error_handler and tiff_warning_handler.
4738 This function is rewritten to use vsnprintf and thereby avoid
4739 stack buffer overflows. It uses only the features of vsnprintf
4740 that are common to both POSIX and native Microsoft.
4741 (tiff_error_handler, tiff_warning_handler): Use it.
4742 (tiff_load, gif_load, imagemagick_load_image):
4743 Don't assume :index value fits in 'int'.
4744 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4745 (imagemagick_load_image): Check that crop parameters fit into
4746 the integer types that MagickCropImage accepts. Don't assume
4747 Vimagemagick_render_type has a nonnegative value. Don't assume
4748 size_t fits in 'long'.
4749 (gs_load): Use printmax_t to print the widest integers possible.
4750 Check for integer overflow when computing image height and width.
4751
47522011-08-26 Eli Zaretskii <eliz@gnu.org>
4753
4754 * xdisp.c (redisplay_window): Don't force window start if point
4755 will be invisible in the resulting window. (Bug#9324)
4756
47572011-08-25 Eli Zaretskii <eliz@gnu.org>
4758
4759 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4760 the display spec is of the form `(space ...)'.
4761 (handle_display_spec): Return the value returned by
4762 handle_single_display_spec, not just 1 or zero.
4763 (handle_single_display_spec): If the display spec is of the form
4764 `(space ...)', and specifies display in the text area, return 2
4765 rather than 1.
4766 (try_cursor_movement): Check for the need to scroll more
4767 accurately, and prefer exact match for point under bidi.
4768 Don't advance `row' beyond the last row of the window.
4769
4770 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4771 into disp_prop; all users changed.
4772
4773 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4774 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4775 for the text covered by the display property.
4776
47772011-08-25 Chong Yidong <cyd@stupidchicken.com>
4778
4779 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4780 Change return value to nil.
4781 (Frecord_buffer): Delete unused function.
4782
47832011-08-24 Eli Zaretskii <eliz@gnu.org>
4784
4785 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4786 buffers, return left-to-right.
4787 (set_cursor_from_row): Consider candidate row a win if its glyph
4788 represents a newline and point is on that newline. Fixes cursor
4789 positioning on the newline at EOL of R2L text within L2R
4790 paragraph, and vice versa.
4791 (try_cursor_movement): Check continued rows, in addition to
4792 continuation rows. Fixes unwarranted scroll when point enters a
4793 continued line of R2L text within an L2R paragraph, or vice versa.
4794 (cursor_row_p): Consider the case of point being equal to
4795 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4796 from the end of a short line to the beginning of a continued line
4797 of R2L text within L2R paragraph.
4798 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4799 composed characters.
4800
4801 * bidi.c (bidi_check_type): Use xassert.
4802 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4803 members.
4804
48052011-08-23 Eli Zaretskii <eliz@gnu.org>
4806
4807 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4808 a character.
4809
48102011-08-23 Chong Yidong <cyd@stupidchicken.com>
4811
4812 * nsfont.m (ns_otf_to_script): Fix typo.
4813
48142011-08-22 Kenichi Handa <handa@m17n.org>
4815
4816 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4817 extra slot even if the purpose is char-code-property-table.
4818
48192011-08-23 Eli Zaretskii <eliz@gnu.org>
4820
4821 * xdisp.c (redisplay_window): When computing centering_position,
4822 account for the height of the header line. (Bug#8874)
4823
4824 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4825 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4826 candidate is selected by the mouse, and that candidate has a
4827 composed character under the mouse.
4828
4829 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4830 coordinates reported by pos-visible-in-window-p for a composed
4831 character in column zero.
4832
48332011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4834
4835 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4836
48372011-08-22 Eli Zaretskii <eliz@gnu.org>
4838
4839 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4840 consider it a hit if to_charpos is anywhere in the range of the
4841 composed buffer positions.
4842
48432011-08-22 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * image.c (gif_load): Don't assume that each subimage has the same
4846 dimensions as the base image. Handle disposal method that is
4847 "undefined" by the gif spec (Bug#9335).
4848
48492011-08-20 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4852 (Fcondition_case): Document `debug' symbol in error handler.
4853
48542011-08-19 Eli Zaretskii <eliz@gnu.org>
4855
4856 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4857 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4858 from an Org mode buffer to a Speedbar frame.
4859
4860 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4861 a composition, take its buffer position from IT->cmp_it.charpos.
4862 Fixes cursor positioning at the beginning of a line that begins
4863 with a composed character.
4864
48652011-08-18 Eli Zaretskii <eliz@gnu.org>
4866
4867 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4868 character bidirectional type, use STRONG_L instead. Fixes crashes
4869 in a buffer produced by `describe-categories'.
4870
4871 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4872 members before the level stack, so they would be saved and
4873 restored when copying iterator state. Fixes incorrect reordering
4874 around TABs covered by display properties.
4875
48762011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4877
4878 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4879
48802011-08-17 Chong Yidong <cyd@stupidchicken.com>
4881
4882 * eval.c (internal_condition_case, internal_condition_case_1)
4883 (internal_condition_case_2, internal_condition_case_n):
4884 Remove unnecessary aborts (Bug#9081).
4885
48862011-08-17 Eli Zaretskii <eliz@gnu.org>
4887
4888 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4889 has no `load' handler, try opening the file locally. (Bug#9311)
4890
48912011-08-16 Ken Brown <kbrown@cornell.edu>
4892
4893 * gmalloc.c: Expand comment.
4894
48952011-08-16 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4898 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4899
49002011-08-16 Ken Brown <kbrown@cornell.edu>
4901
4902 Fix memory allocation problems in Cygwin build (Bug#9273).
4903
4904 * unexcw.c ( __malloc_initialized): Declare external variable.
4905 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4906
4907 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4908 New variables.
4909 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4910 dumped emacs.
4911 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4912 in the static heap.
4913 [CYGWIN] (special_realloc): New function.
4914 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4915 requests to realloc storage in the static heap.
4916
49172011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4918
4919 * bidi.c (bidi_initialize): Remove unused local.
4920
49212011-08-15 Eli Zaretskii <eliz@gnu.org>
4922
4923 * bidimirror.h:
4924 * biditype.h: Remove file.
4925 * makefile.w32-in ($(BLD)/bidi.$(O)):
4926 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4927
4928 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4929
4930 * chartab.c: Improve commentary for the uniprop_table API.
4931
4932 * bidi.c (bidi_paragraph_init): Support zero value of
4933 bidi_ignore_explicit_marks_for_paragraph_level.
4934 (bidi_initialize): Use uniprop_table instead of including
4935 biditype.h and bidimirror.h.
4936
4937 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4938 coordinates of the iterator when restoring from ppos_it.
4939 (Bug#9296)
4940
49412011-08-14 Kenichi Handa <handa@m17n.org>
4942
4943 * process.c (create_process): Call setup_process_coding_systems
4944 after the pid of the process is set to -1 (Bug#8162).
4945
49462011-08-14 Eli Zaretskii <eliz@gnu.org>
4947
4948 * xdisp.c (move_it_in_display_line_to): Don't invoke
4949 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4950 ppos_it. Fixes vertical cursor motion when line beginning is
4951 covered by an image. (Bug#9296)
4952
49532011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4954
4955 * nsterm.h (ns_run_ascript): Declare.
4956 (NSAPP_DATA2_RUNASSCRIPT): Define.
4957
4958 * nsfns.m (as_script, as_result, as_status): New static variables.
4959 (ns_run_ascript): New function.
4960 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4961 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4962 the event loop. Get status from as_status (Bug#7276).
4963
4964 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4965 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4966 the event loop (Bug#7276).
4967
49682011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4969
4970 * gnutls.c (QCgnutls_bootprop_priority)
4971 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4972 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4973 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4974 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4975 (QCgnutls_bootprop_verify_hostname_error)
4976 (QCgnutls_bootprop_callbacks_verify): Rename from
4977 Qgnutls_bootprop_..., all uses changed.
4978
4979 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4980 uses changed.
4981
49822011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4983
4984 * xfaces.c (Qframe_set_background_mode): Now static.
4985 * dispextern.h (Qframe_set_background_mode): Remove decl.
4986
4987 * process.c (Fnetwork_interface_info): Declare local only if needed.
4988
49892011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4990
4991 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4992 (Fnetwork_interface_list): Allocate in increments of bytes instead
4993 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4994 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4995 sockaddr.
4996 (struct ifflag_def): notrailers is smart on OSX.
4997 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4998 Get hardware address with getifaddrs if available.
4999
50002011-08-12 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (iterate_out_of_display_property): xassert that
5003 IT->position is set to within IT->object's boundaries. Break from
5004 the loop as soon as EOB is reached; avoids infloops in redisplay
5005 when IT->position is set up wrongly due to some bug.
5006 Set IT->current to match the bidi iterator unconditionally.
5007 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5008 entry. Force push_it to save on the stack the current
5009 buffer/string position, to be restored by pop_it. Fix flags in
5010 the iterator structure wrt the object coming from a display
5011 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5012 properties. (Bug#9284)
5013
50142011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5015
5016 * fontset.c (fontset_get_font_group): Add proper type checks.
5017 (Bug#9172)
5018
50192011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5020
5021 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5022 and LC_VERSION_MIN_MACOSX.
5023 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5024 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5025
50262011-08-08 Eli Zaretskii <eliz@gnu.org>
5027
5028 * xdisp.c (forward_to_next_line_start): Allow to use the
5029 no-display-properties-and-no-overlays under bidi display.
5030 Set disp_pos in the bidi iterator to avoid searches for display
5031 properties and overlays.
5032
50332011-08-08 Chong Yidong <cyd@stupidchicken.com>
5034
5035 * editfns.c (Fset_time_zone_rule): Document relationship with the
5036 setenv function.
5037
5038 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5039 the font entity extracted from the cache (Bug#8109).
5040
50412011-08-07 Chong Yidong <cyd@stupidchicken.com>
5042
5043 * composite.c (autocmp_chars): Don't reset point. That is done by
5044 restore_point_unwind (Bug#5984).
5045
50462011-08-07 Juri Linkov <juri@jurta.org>
5047 1422
5048 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:' 14232013-08-04 Paul Eggert <eggert@cs.ucla.edu>
5049 to show the arg `TIME' instead of `TIMEVAL'.
5050 1424
50512011-08-06 Eli Zaretskii <eliz@gnu.org> 1425 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1426 * callproc.c (create_temp_file):
1427 * filelock.c (create_lock_file):
1428 Assume mkostemp, since it's now provided by Gnulib.
5052 1429
5053 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a 14302013-08-04 Eli Zaretskii <eliz@gnu.org>
5054 display property strides EOL and includes a newline, as in
5055 longlines-mode. (Bug#9254)
5056 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5057 word-wrap under bidirectional display. (Bug#9224)
5058 1431
5059 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE 1432 * w32.c (mkostemp): New function.
5060 is non-zero, even if the data buffer is NULL. Fixes a crash in 1433 (mktemp): Remove, no longer used. Most of the code reused in
5061 vertical-motion with longlines-mode. (Bug#9254) 1434 mkostemp. (Bug#15015)
1435 (mktemp): Don't undef.
5062 1436
50632011-08-05 Eli Zaretskii <eliz@gnu.org> 14372013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
5064 1438
5065 * bidi.c <bidi_cache_total_alloc>: Now static. 1439 * dispnew.c (glyph_matrix_count, glyph_pool_count):
5066 (bidi_initialize): Initialize bidi_cache_total_alloc. 1440 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1441 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1442 (free_glyph_pool, check_glyph_memory): Likewise for
1443 all users. Adjust comments where appropriate.
5067 1444
5068 * xdisp.c (display_line): Release buffer allocated for shelved bidi 14452013-08-03 Paul Eggert <eggert@cs.ucla.edu>
5069 cache. (Bug#9221)
5070 1446
5071 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total 1447 * composite.h: Minor fixups.
5072 amount allocated this far in `bidi_cache_total_alloc'. 1448 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
5073 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if 1449 to fix a misspelling, and change it to an inline function while
5074 non-zero, only free the data buffer without restoring the cache 1450 we're at it (it need not be a macro). All uses changed.
5075 contents. All callers changed. 1451 (composition_method, composition_valid_p):
1452 Rewrite to avoid assignments in if-conditions.
5076 1453
5077 * dispextern.h (bidi_unshelve_cache): Update prototype. 14542013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
5078 1455
5079 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to) 1456 Do not use global Lisp_Object in composition macros.
5080 (move_it_in_display_line, move_it_to) 1457 * composite.h (composition_temp): Remove declaration.
5081 (move_it_vertically_backward, move_it_by_lines): Replace the call 1458 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
5082 to xfree to an equivalent call to bidi_unshelve_cache. 1459 (composition_method, composition_valid_p): ...inline functions.
5083 (move_it_in_display_line_to): Fix logic of returning 1460 (compose_region): Remove the leftover.
5084 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224) 1461 * composite.c (composition_temp): Remove.
1462 (run_composition_function, update_compositions)
1463 (composition_compute_stop_pos, composition_adjust_point)
1464 (Ffind_composition_internal):
1465 * coding.c (handle_composition_annotation):
1466 * xdisp.c (handle_composition_prop, check_point_in_composition):
1467 Related users changed.
1468
14692013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1470
1471 Drop FRAME_PTR typedef.
1472 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1473 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1474 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1475 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1476 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1477 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1478 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1479 All related users changed.
1480
14812013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1482
1483 * eval.c (default_toplevel_binding): New function.
1484 (Fdefvar): Use it.
1485 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1486 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1487 (syms_of_eval): Export them.
1488 * data.c (Fdefault_value): Micro cleanup.
1489 * term.c (init_tty): Use "false".
1490
14912013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1492
1493 Fix X GC leak in GTK and raw (no toolkit) X ports.
1494 * xterm.c (x_free_frame_resources): If white and black relief
1495 GCs are allocated, always free them here.
1496 * xfns.c (x_make_gc): Omit redundant initialization.
1497 * widget.c (create_frame_gcs): Remove the leftover.
1498 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1499 in x_free_frame_resources.
1500
15012013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1502
1503 * nsterm.m (windowWillResize:toSize:): Only change title if
1504 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1505 modifying it.
1506 (viewDidEndLiveResize): New method.
1507
1508 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1509 inside NS_IMPL_COCOA.
1510
15112013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1512
1513 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1514 Do not check whether undo is enabled because record_insert and
1515 record_delete does that themselves.
1516
15172013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1518
1519 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1520 member which is not really used any more.
1521 (FRAME_XIC_BASE_FONTNAME): Remove.
1522 * xfns.c (xic_free_fontset): Adjust user.
1523 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1524 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1525 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1526 (xdialog_show): Use eassert for debugging check.
1527 * w32term.c (x_unfocus_frame): Remove unused dummy function.
1528
15292013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * fileio.c, fns.c (merge): Move extern decl from here ...
1532 * lisp.h (merge): ... to here.
1533
15342013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Fix last font-related change.
1537 * w32font.h (w32font_list_internal, w32font_match_internal):
1538 Fix prototype.
1539 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1540 (uniscribe_list_family): Adjust to match font API change.
1541 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1542 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1543
15442013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1545
1546 * frame.h (FRAME_MOUSE_UPDATE):
1547 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1548 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1549
15502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1553 * font.h (struct font_driver): Change list, match, and list_family
1554 functions to accept struct frame * as first arg.
1555 * font.c (font_score, font_compare, font_sort_entities):
1556 Remove prototypes.
1557 (font_sort_entities, font_list_entities, font_select_entity):
1558 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1559 match font API change.
1560 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1561 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1562 * ftxfont.c (ftxfont_list, ftxfont_match):
1563 * xftfont.c (xftfont_list, xftfont_match):
1564 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1565 * w32font.c (w32font_list, w32font_match, w32font_list):
1566 (w32font_list_internal, w32_font_match_internal): Likewise.
1567 * xfaces.c (Fx_family_fonts): Adjust user.
1568
15692013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1570
1571 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1572 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1573 only if HAVE_X_WINDOWS is in use.
1574 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1575 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1576 * w32term.c (x_wm_set_icon_position): Likewise.
1577 * w32fns.c (x_icon): Adjust user.
1578
15792013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1580
1581 * xterm.c (last_mouse_press_frame): Remove the
1582 leftover which is not really used any more.
1583 (handle_one_xevent, syms_of_xterm): Adjust users.
1584 (x_flush): Call XFlush once per each X display, not frame.
1585 This is better because this code always unconditionally skips
1586 non-X frames in Vframe_list and issues the only XFlush if we
1587 have more than one X frame on the same X display.
1588 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1589 Use bool for booleans.
1590 (x_draw_glyph_string_background, cvt_string_to_pixel):
1591 (cvt_pixel_dtor): Drop unnecessary prototypes.
1592 * xterm.h (x_display_ok): Adjust prototype.
1593
15942013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1595
1596 Drop unnecessary functions that deals with frame pixel size.
1597 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1598 (x_pixel_height): Drop prototypes.
1599 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1600 (x_pixel_height): Drop implementations.
1601 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1602 which should be always valid for window frame.
1603 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1604 * w32menu.c (Fx_popup_dialog):
1605 * xmenu.c (Fx_popup_dialog): Likewise for both.
1606
16072013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1610 frame parameters and call to Fmodify_frame_parameters just once.
1611 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1612 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1613 and mention nil frame in docstring.
1614
16152013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1616
1617 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1618 (x_figure_window_size): Likewise. Adjust to return long.
1619 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1620 (toplevel): Move Qterminal_live_p to...
1621 * terminal.c (toplevel): ...here, make it static, and...
1622 (syms_of_terminal): ...DEFSYM here.
1623 * frame.h (Qterminal_live_p): Remove declaration.
1624 (make_frame, x_figure_window_size): Adjust prototype.
1625 * nsfns.m (Fx_create_frame): Use long for window flags.
1626
16272013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1628
1629 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1630 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1631 Do not assume that emacs_close (INT_MAX) is a no-op.
1632
16332013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1634
1635 * xfaces.c (make_face_cache): For struct face_cache, prefer
1636 xmalloc to xzalloc and so avoid redundant call to memset.
1637 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1638
16392013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1640
1641 * fringe.c (draw_window_fringes, update_window_fringes)
1642 (compute_fringe_widths):
1643 * w32term.c (x_draw_glyph_string):
1644 * window.c (candidate_window_p, Frecenter):
1645 * xfaces.c (realize_basic_faces, realize_default_face)
1646 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1647 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1648 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1649 * xmenu.c (Fx_menu_bar_open_internal):
1650 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1651 * xsettings.c (xft_settings_event):
1652 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1653 Use bool for booleans. Adjust style and comments where
1654 appropriate.
1655 * dispextern.h (draw_window_fringes, update_window_fringes)
1656 (compute_fringe_widths):
1657 * xterm.h (x_had_errors_p): Adjust prototype.
5085 1658
50862011-08-05 Eli Zaretskii <eliz@gnu.org> 16592013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
5087 1660
5088 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that 1661 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
5089 came from a string character with a `cursor' property. (Bug#9229) 1662 CHECK_LIST. Rewrite the loop to avoid useless local variable.
5090 1663
50912011-08-04 Jan Drv <jan.h.d@swipnet.se> 16642013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
5092 1665
5093 * Makefile.in (LIB_PTHREAD): New variable. 1666 * fns.c (toplevel): Remove comment before Fsafe_length because
5094 (LIBES): Add LIB_PTHREAD (Bug#9216). 1667 it checks for QUIT.
5095 1668
5096 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h: 16692013-07-28 Paul Eggert <eggert@cs.ucla.edu>
5097 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5098 1670
50992011-08-04 Andreas Schwab <schwab@linux-m68k.org> 1671 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
5100 1672
5101 * regex.c (re_iswctype): Remove some redundant boolean conversions. 16732013-07-28 Eli Zaretskii <eliz@gnu.org>
5102 1674
51032011-08-04 Jan Djärv <jan.h.d@swipnet.se> 1675 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1676 frame which got the message is still alive, before dereferencing
1677 its pointer. (Bug#14970)
5104 1678
5105 * xterm.c (x_find_topmost_parent): New function. 1679 * frame.c (delete_frame): Test "this" frame's minibuffer window to
5106 (x_set_frame_alpha): Find topmost parent window with 1680 be a live window, before using it as such. (Bug#14970)
5107 x_find_topmost_parent and set the property there also (bug#9181).
5108 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5109 1681
51102011-08-04 Paul Eggert <eggert@cs.ucla.edu> 16822013-07-27 Eli Zaretskii <eliz@gnu.org>
5111 1683
5112 * callproc.c (Fcall_process): Avoid vfork clobbering 1684 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
5113 the local vars buffer, coding_systems, current_dir. 1685 w32_detect_focus_change instead of doing part of its job by hand.
1686 This fixes the problem whereby FOCUS_OUT events were not sent to
1687 the event queue.
5114 1688
51152011-08-03 Stefan Monnier <monnier@iro.umontreal.ca> 16892013-07-26 Eli Zaretskii <eliz@gnu.org>
5116 1690
5117 * keymap.c (Fmake_composed_keymap): Move to subr.el. 1691 * process.c (Fprocess_list): Doc fix.
5118 1692
51192011-08-03 Paul Eggert <eggert@cs.ucla.edu> 1693 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1694 being re-exposed only if it didn't ask to become visible.
1695 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1696 was previously iconified. (Bug#14841)
1697 (x_iconify_frame): Mark the frame iconified.
5120 1698
5121 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE 16992013-07-26 Paul Eggert <eggert@cs.ucla.edu>
5122 so that it is not optimized away.
5123 1700
5124 * xdisp.c (compute_display_string_pos): Remove unused local. 1701 Fix minor problems found by static checking.
1702 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1703 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
5125 1704
51262011-08-02 Eli Zaretskii <eliz@gnu.org> 17052013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
5127 1706
5128 Fix slow cursor motion and scrolling in large buffers with 1707 * eval.c (set_specpdl_old_value): New function.
5129 selective display, like Org Mode buffers. (Bug#9218) 1708 (unbind_to): Minor simplification.
1709 (get_backtrace_frame): New function.
1710 (Fbacktrace_frame): Use it. Add `base' argument.
1711 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1712 (syms_of_eval): Export backtrace-eval.
1713 * xterm.c (x_focus_changed): Simplify.
5130 1714
5131 * dispextern.h (struct bidi_it): New member disp_prop_p. 17152013-07-25 Paul Eggert <eggert@cs.ucla.edu>
5132 1716
5133 * xdisp.c: Remove one-slot cache of display string positions. 1717 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
5134 (compute_display_string_pos): Accept an additional argument
5135 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5136 for a display string or property. If found, set DISP_PROP_P
5137 non-zero.
5138 1718
5139 * bidi.c (bidi_fetch_char): Accept an additional argument 17192013-07-24 Eli Zaretskii <eliz@gnu.org>
5140 DISP_PROP_P, and pass it to compute_display_string_pos.
5141 Only handle text covered by a display string if DISP_PROP_P is returned
5142 non-zero. All callers of bidi_fetch_char changed.
5143 1720
51442011-08-02 Stefan Monnier <monnier@iro.umontreal.ca> 1721 * xdisp.c (redisplay_window): Instead of moving point out of
1722 scroll margin, reject the force_start method, and try scrolling
1723 instead. (Bug#14780)
5145 1724
5146 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE. 17252013-07-24 Ken Brown <kbrown@cornell.edu>
5147 1726
51482010-12-03 Don March <don@ohspite.net> 1727 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1728 (Bug#14944).
5149 1729
5150 * keymap.c (Fdefine_key): Fix non-prefix key error message when 17302013-07-24 Paul Eggert <eggert@cs.ucla.edu>
5151 last character M-[char] is translated to ESC [char] (bug#7541).
5152 1731
51532011-08-02 Kenichi Handa <handa@m17n.org> 1732 * eval.c (Fprogn): Do not check that BODY is a proper list.
1733 This undoes the previous change. The check slows down the
1734 interpreter, and is not needed to prevent a crash. See
1735 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
5154 1736
5155 * lisp.h (uniprop_table): Extern it. 17372013-07-23 Glenn Morris <rgm@gnu.org>
5156 1738
5157 * chartab.c (uniprop_table): Make it non-static. 1739 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
5158 1740
51592011-08-01 Eli Zaretskii <eliz@gnu.org> 17412013-07-23 Paul Eggert <eggert@cs.ucla.edu>
5160 1742
5161 * xdisp.c (forward_to_next_line_start): Accept additional argument 1743 Port to GNU/Linux systems with tinfo but not ncurses.
5162 BIDI_IT_PREV, and store into it the state of the bidi iterator had 1744 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
5163 on the newline. 1745 to decide whether ncurses is being used. Without this change,
5164 (reseat_at_next_visible_line_start): Use the bidi iterator state 1746 GCC complains about tgetent not being declared, on a system
5165 returned by forward_to_next_line_start to restore the state of 1747 that has tinfo installed but ncurses not installed.
5166 it->bidi_it after backing up to previous newline. (Bug#9212)
5167 1748
51682011-07-30 Andreas Schwab <schwab@linux-m68k.org> 1749 * eval.c (Fprogn): Check that BODY is a proper list.
5169 1750
5170 * regex.c (re_comp): Protoize. 1751 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
5171 (re_exec): Fix return type. 1752 * data.c (Fsetq_default):
5172 (regexec): Fix type of `ret'. (Bug#9203) 1753 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1754 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1755 (Fcondition_case):
1756 Tune by taking advantage of the fact that ARGS is always a list
1757 when a function is declared to have UNEVALLED args.
5173 1758
51742011-07-28 Paul Eggert <eggert@cs.ucla.edu> 1759 * emacsgtkfixed.c: Port to GCC 4.6.
1760 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
5175 1761
5176 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189). 17622013-07-23 Juanma Barranquero <lekktu@gmail.com>
5177 This is needed if max-image-size is a floating-point number.
5178 1763
51792011-07-28 Andreas Schwab <schwab@linux-m68k.org> 1764 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1765 here to silence compiler warnings.
5180 1766
5181 * print.c (print_object): Print empty symbol as ##. 17672013-07-22 Paul Eggert <eggert@cs.ucla.edu>
5182 1768
5183 * lread.c (read1): Read ## as empty symbol. 1769 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1770 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1771 from messing up Emacs's 'struct frame' (Bug#14923).
5184 1772
51852011-07-28 Alp Aker <alp.tekin.aker@gmail.com> 17732013-07-21 Paul Eggert <eggert@cs.ucla.edu>
5186 1774
5187 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when 1775 * alloc.c (make_save_ptr_ptr): Define this function.
5188 setting frame foreground color (Bug#9175). 1776 It was inadvertently omitted. It's needed only if
5189 (x_set_background_color): Likewise. 1777 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
5190 1778
5191 * nsmenu.m (-setText): Size tooltip dimensions precisely to 17792013-07-21 Jan Djärv <jan.h.d@swipnet.se>
5192 contents (Bug#9176).
5193 (EmacsTooltip -init): Remove bezels and add shadows to
5194 tooltip windows.
5195 1780
5196 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe 1781 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
5197 or scroll bar (Bug#8470). 1782 frame have focus (Bug#14895).
5198 1783
5199 * nsfont.m (nsfont_open): Remove assignment to voffset and 17842013-07-21 Paul Eggert <eggert@cs.ucla.edu>
5200 unnecessary vars hshink, expand, hd, full_height, min_height.
5201 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5202 1785
5203 * nsterm.h (nsfont_info): Remove voffset field. 1786 Avoid vfork-related deadlock more cleanly.
1787 * callproc.c (child_setup): When the child's exec fails, output
1788 the program name, as that's more useful. Use O_NONBLOCK to avoid
1789 deadlock.
1790 * process.c (create_process_1): Remove; no longer needed.
1791 (create_process): Remove timer hack; no longer needed, now that
1792 the child avoids deadlock.
5204 1793
52052011-07-28 Alp Aker <alp.tekin.aker@gmail.com> 17942013-07-20 Glenn Morris <rgm@gnu.org>
5206 1795
5207 Implement strike-through and overline on NextStep (Bug#8863). 1796 * image.c (Fimage_flush): Fix doc typo.
5208 1797
5209 * nsfont.m (nsfont_open): Use underline position provided by font, 17982013-07-20 Paul Eggert <eggert@cs.ucla.edu>
5210 instead of hard-coded value of 2.
5211 (nsfont_draw): Call ns_draw_text_decoration instead.
5212 1799
5213 * nsterm.h: Add declaration for ns_draw_text_decoration. 1800 Fix array bounds violation when pty allocation fails.
1801 * process.c (PTY_NAME_SIZE): New constant.
1802 (pty_name): Remove static variable; it's now auto.
1803 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1804 Take pty_name as an arg rather than using a static variable.
1805 All callers changed.
1806 (create_process): Recover pty_flag from process, not from volatile local.
1807 (create_pty): Stay inside array even when pty allocation fails.
1808 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1809
1810 * lread.c (Fload): Avoid initialization only when lint checking.
1811 Mention that it's needed only for older GCCs.
1812
18132013-07-20 Kenichi Handa <handa@gnu.org>
1814
1815 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1816 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1817
18182013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1819
1820 * lread.c (Fload): Avoid uninitialized warning.
1821
18222013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 Fix some minor file descriptor leaks and related glitches.
1825 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1826 (create_lock_file): Use write, not emacs_write.
1827 * image.c (slurp_file, png_load_body):
1828 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1829 (server_accept_connection):
1830 Don't leak an fd on memory allocation failure.
1831 * image.c (slurp_file): Add a cheap heuristic for growing files.
1832 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1833 as that's what the other routines do. Maybe input need not be
1834 blocked at all, but it's better to be consistent.
1835 Avoid undefined behavior when strlen is zero.
1836
1837 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1838 (NSTATICS): Now a constant; doesn't need to be a macro.
1839
18402013-07-19 Richard Stallman <rms@gnu.org>
1841
1842 * coding.c (decode_coding_utf_8): Add simple loop for fast
1843 processing of ASCII characters.
1844
18452013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1848
18492013-07-19 Eli Zaretskii <eliz@gnu.org>
1850
1851 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1852 unportable 'struct x_display_info'.
1853 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1854 is a portable type.
1855
18562013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1857
1858 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1859 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1860 or fscanf fails.
1861 (system_process_attributes): Prefer plain char to unsigned char
1862 when either will do. Clean up properly if interrupted or if
1863 memory allocations fail. Don't assume sscanf succeeds.
1864 Remove no-longer-needed workaround to stop GCC from whining.
1865 Read command-line once, instead of multiple times. Check read status a
1866 bit more carefully.
1867
1868 Fix obscure porting bug with varargs functions.
1869 The code assumed that int is treated like ptrdiff_t in a vararg
1870 function, which is not a portable assumption. There was a similar
1871 -- though these days less likely -- porting problem with various
1872 assumptions that pointers of different types all smell the same as
1873 far as vararg functions is conserved. To make this problem less
1874 likely in the future, redo the API to use varargs functions.
1875 * alloc.c (make_save_value): Remove this vararg function.
1876 All uses changed to ...
1877 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1878 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1879 New functions.
1880 (make_save_ptr): Rename from make_save_pointer, for consistency with
1881 the above. Define only on platforms that need it. All uses changed.
5214 1882
5215 * nsterm.m (ns_draw_text_decoration): New function for drawing 18832013-07-18 Paul Eggert <eggert@cs.ucla.edu>
5216 underline, overline, and strike-through.
5217 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5218 ns_draw_text_decoration. Change treatment of cursor drawing to
5219 accommodate underlining, etc.
5220 1884
52212011-07-28 Eli Zaretskii <eliz@gnu.org> 1885 * keyboard.c: Try to fix typos in previous change.
1886 (DISPLAY_LIST_INFO): New macro.
1887 (kbd_buffer_get_event): Do not access members that are not present
1888 in X11. Revert inadvertent change of "!=" to "=".
5222 1889
5223 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by 18902013-07-18 Juanma Barranquero <lekktu@gmail.com>
5224 default.
5225 1891
52262011-07-28 Paul Eggert <eggert@cs.ucla.edu> 1892 * keyboard.c (kbd_buffer_get_event):
1893 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1894 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
5227 1895
5228 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race. 18962013-07-18 Paul Eggert <eggert@cs.ucla.edu>
5229 Without this fix, if a signal arrives just after memory fills up,
5230 'malloc' might be invoked reentrantly.
5231 1897
5232 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1. 1898 * filelock.c: Fix unlikely file descriptor leaks.
5233 In other words, assume that every image size is allowed, on non-X 1899 (get_boot_time_1): Rework to avoid using emacs_open.
5234 hosts. This assumption is probably wrong, but it lets Emacs compile. 1900 This doesn't actually fix a leak, but is better anyway.
1901 (read_lock_data): Use read, not emacs_read.
5235 1902
52362011-07-28 Andreas Schwab <schwab@linux-m68k.org> 1903 * doc.c: Fix minor memory and file descriptor leaks.
1904 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1905 (get_doc_string, Fsnarf_documentation):
1906 Fix file descriptor leak on error.
1907
1908 * term.c: Fix minor fdopen-related file descriptor leaks.
1909 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1910 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1911
1912 * charset.c: Fix file descriptor leaks and errno issues.
1913 Include <errno.h>.
1914 (load_charset_map_from_file): Don't leak file descriptor on error.
1915 Use plain record_xmalloc since the allocation is larger than
1916 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1917 of entries.
1918 * eval.c (record_unwind_protect_nothing):
1919 * fileio.c (fclose_unwind):
1920 New functions.
1921 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1922 The replacement doesn't block input, but that no longer seems
1923 necessary.
1924
19252013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * lread.c: Fix file descriptor leaks and errno issues.
1928 (Fload): Close some races that leaked fds or streams when 'load'
1929 was interrupted.
1930 (Fload, openp): Report error number of last nontrivial failure to open.
1931 ENOENT counts as trivial.
1932 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1933 New functions.
1934 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1935 now that the function is always called with a nonnegative arg.
1936 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1937 All uses replaced with ...
1938 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
5237 1939
5238 * regex.c (re_iswctype): Convert return values to boolean. 1940 A few more minor file errno-reporting bugs.
5239 1941 * callproc.c (Fcall_process):
52402011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org> 1942 * doc.c (Fsnarf_documentation):
5241 1943 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
5242 * xdisp.c (compute_display_string_pos): Don't use cached display 1944 * process.c (set_socket_option):
5243 string position if the buffer had its restriction changed. 1945 Don't let a constructor trash errno.
5244 (Bug#9184) 1946 * doc.c: Include <errno.h>.
5245 1947
52462011-07-28 Paul Eggert <eggert@cs.ucla.edu> 19482013-07-16 Juanma Barranquero <lekktu@gmail.com>
5247 1949
5248 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering. 1950 * w32fns.c (unwind_create_tip_frame): Fix declaration.
5249 1951
52502011-07-28 Paul Eggert <eggert@cs.ucla.edu> 19522013-07-16 Paul Eggert <eggert@cs.ucla.edu>
5251 1953
5252 Integer signedness and overflow and related fixes. (Bug#9079) 1954 Fix w32 bug with call-process-region (Bug#14885).
5253 1955 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
5254 * bidi.c: Integer size and overflow fixes. 1956 to Fcall_process when the input is empty. This simplifies the
5255 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx) 1957 code a bit. It makes no difference on POSIXish platforms but
5256 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search) 1958 apparently it fixes a bug on w32.
5257 (bidi_cache_find_level_change, bidi_cache_ensure_space) 1959
5258 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack) 1960 Fix bug where insert-file-contents closes a file twice (Bug#14839).
5259 (bidi_find_other_level_edge): 1961 * fileio.c (close_file_unwind): Don't close if FD is negative;
5260 Use ptrdiff_t instead of EMACS_INT where either will do. 1962 this can happen when unwinding a zapped file descriptor.
5261 This works better on 32-bit hosts configured --with-wide-int. 1963 (Finsert_file_contents): Unwind-protect the fd before the point marker,
5262 (bidi_cache_ensure_space): Check for size-calculation overflow. 1964 in case Emacs runs out of memory between the two unwind-protects.
5263 Use % rather than repeated addition, for better worst-case speed. 1965 Don't trash errno when closing FD.
5264 Don't set bidi_cache_size until after xrealloc returns, because it 1966 Zap the FD in the specpdl when closing it, instead of deferring
5265 might not return. 1967 the removal of the unwind-protect; this fixes a bug where a child
5266 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow. 1968 function unwinds the stack past us.
5267 (bidi_cache_ensure_space): Also check that the bidi cache size 1969
5268 does not exceed that of the largest Lisp string or buffer. See Eli 1970 New unwind-protect flavors to better type-check C callbacks.
5269 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>. 1971 This also lessens the need to write wrappers for callbacks,
5270 1972 and the need for make_save_pointer.
5271 * alloc.c (__malloc_size_t): Remove. 1973 * alloca.c (free_save_value):
5272 All uses replaced by size_t. See Andreas Schwab's note 1974 * atimer.c (run_all_atimers):
5273 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>. 1975 Now extern.
5274 1976 * alloc.c (safe_alloca_unwind):
5275 * image.c: Improve checking for integer overflow. 1977 * atimer.c (unwind_stop_other_atimers):
5276 (check_image_size): Assume that f is nonnull, since 1978 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
5277 it is always nonnull in practice. This is one less thing to 1979 * menu.c (cleanup_popup_menu) [HAVE_NS]:
5278 worry about when checking for integer overflow later. 1980 * minibuf.c (choose_minibuf_frame_1):
5279 (x_check_image_size): New function, which checks for integer 1981 * process.c (make_serial_process_unwind):
5280 overflow issues inside X. 1982 * xdisp.h (pop_message_unwind):
5281 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it. 1983 * xselect.c (queue_selection_requests_unwind):
5282 This removes the need for a memory_full check. 1984 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
5283 (xbm_image_p): Rewrite to avoid integer multiplication overflow. 1985 * alloca.c (record_xmalloc):
5284 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size. 1986 Prefer record_unwind_protect_ptr to record_unwind_protect with
5285 (xbm_read_bitmap_data): Change locals back to 'int', since 1987 make_save_pointer.
5286 their values must fit in 'int'. 1988 * alloca.c (Fgarbage_collect):
5287 (xpm_load_image, png_load, tiff_load): 1989 Prefer record_unwind_protect_void to passing a dummy.
5288 Invoke x_create_x_image_and_pixmap earlier, 1990 * buffer.c (restore_buffer):
5289 to avoid much needless work if the image is too large. 1991 * window.c (restore_window_configuration):
5290 (tiff_load): Treat overly large images as if 1992 * xfns.c, w32fns.c (do_unwind_create_frame)
5291 x_create_x_image_and_pixmap failed, not as malloc failures. 1993 New wrapper. All record-unwind uses of wrappee changed.
5292 (gs_load): Use x_check_image_size. 1994 * buffer.c (set_buffer_if_live):
5293 1995 * callproc.c (call_process_cleanup, delete_temp_file):
5294 * gtkutil.c: Omit integer casts. 1996 * coding.c (code_conversion_restore):
5295 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast. 1997 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
5296 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast. 1998 * editfns.c (save_excursion_restore)
5297 1999 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
5298 * image.c (png_load): Don't assume height * row_bytes fits in 'int'. 2000 (save_restriction_restore):
5299 2001 * eval.c (restore_stack_limits, un_autoload):
5300 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug. 2002 * fns.c (require_unwind):
5301 Without this fix, (bitmap-spec-p '(34359738368 1 "x")) 2003 * keyboard.c (recursive_edit_unwind, tracking_off):
5302 would wrongly return t on a 64-bit host. 2004 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
5303 2005 * macros.c (pop_kbd_macro, restore_menu_items):
5304 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros. 2006 * nsfns.m (unwind_create_frame):
5305 The plain *_OVERFLOW macros run afoul of GCC bug 49705 2007 * print.c (print_unwind):
5306 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705> 2008 * process.c (start_process_unwind):
5307 and therefore cause GCC to emit a bogus diagnostic in some cases. 2009 * search.c (unwind_set_match_data):
5308 2010 * window.c (select_window_norecord, select_frame_norecord):
5309 * image.c: Integer signedness and overflow and related fixes. 2011 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
5310 This is not an exhaustive set of fixes, but it's time to 2012 (fast_set_selected_frame):
5311 record what I've got. 2013 * xfns.c, w32fns.c (unwind_create_tip_frame):
5312 (lookup_pixel_color, check_image_size): Remove redundant decls. 2014 Return void, not a dummy Lisp_Object. All uses changed.
5313 (check_image_size): Don't assume that arbitrary EMACS_INT values 2015 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
5314 fit in 'int', or that arbitrary 'double' values fit in 'int'. 2016 * callproc.c (call_process_kill):
5315 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load) 2017 * fileio.c (restore_point_unwind, decide_coding_unwind)
5316 (tiff_load, imagemagick_load_image): 2018 (build_annotations_unwind):
5317 Check for overflow in size calculations. 2019 * insdel.c (Fcombine_after_change_execute_1):
5318 (x_create_x_image_and_pixmap): Remove unnecessary test for 2020 * keyboard.c (read_char_help_form_unwind):
5319 xmalloc returning NULL; that can't happen. 2021 * menu.c (unuse_menu_items):
5320 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'. 2022 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
5321 (xpm_color_bucket): Use better integer hashing function. 2023 * sound.c (sound_cleanup):
5322 (xpm_cache_color): Don't possibly over-allocate memory. 2024 * xdisp.c (unwind_redisplay):
5323 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory) 2025 * xfns.c (clean_up_dialog):
5324 (gif_memory_source): 2026 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
5325 Use ptrdiff_t, not int or size_t, to record sizes. 2027 Accept no args and return void, instead of accepting and returning
5326 (png_load): Don't assume values greater than 2**31 fit in 'int'. 2028 a dummy Lisp_Object. All uses changed.
5327 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when 2029 * cygw32.c (fchdir_unwind):
5328 either works, as we prefer signed integers. 2030 * fileio.c (close_file_unwind):
5329 (tiff_read_from_memory, tiff_write_from_memory): 2031 * keyboard.c (restore_kboard_configuration):
5330 Return tsize_t, not size_t, since that's what the TIFF API wants. 2032 * lread.c (readevalllop_1):
5331 (tiff_read_from_memory): Don't fail simply because the read would 2033 * process.c (wait_reading_process_output_unwind):
5332 go past EOF; instead, return a short read. 2034 Accept int and return void, rather than accepting an Emacs integer
5333 (tiff_load): Omit no-longer-needed casts. 2035 and returning a dummy object. In some cases this fixes an
5334 (Fimagemagick_types): Don't assume size fits into 'int'. 2036 unlikely bug when the corresponding int is outside Emacs integer
5335 2037 range. All uses changed.
5336 Improve hashing quality when configured --with-wide-int. 2038 * dired.c (directory_files_internal_unwind):
5337 * fns.c (hash_string): New function, taken from sxhash_string. 2039 * fileio.c (do_auto_save_unwind):
5338 Do not discard information about ASCII character case; this 2040 * gtkutil.c (pop_down_dialog):
5339 discarding is no longer needed. 2041 * insdel.c (reset_var_on_error):
5340 (sxhash-string): Use it. Change sig to match it. Caller changed. 2042 * lread.c (load_unwind):
5341 * lisp.h: Declare it. 2043 * xfns.c (clean_up_file_dialog):
5342 * lread.c (hash_string): Remove, since we now use fns.c's version. 2044 * xmenu.c, nsmenu.m (pop_down_menu):
5343 The fns.c version returns a wider integer if --with-wide-int is 2045 * xmenu.c (cleanup_widget_value_tree):
5344 specified, so this should help the quality of the hashing a bit. 2046 * xselect.c (wait_for_property_change_unwind):
5345 2047 Accept pointer and return void, rather than accepting an Emacs
5346 * emacs.c: Integer overflow minor fix. 2048 save value encapsulating the pointer and returning a dummy object.
5347 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5348 Define only if GNU_LINUX.
5349 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5350
5351 * dispnew.c: Integer signedness and overflow fixes.
5352 Remove unnecessary forward decls, that were a maintenance hassle.
5353 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5354 All uses changed. 2049 All uses changed.
5355 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer) 2050 * editfns.c (Fformat): Update the saved pointer directly via
5356 (scrolling_window): Use ptrdiff_t, not int, for byte count. 2051 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
5357 (prepare_desired_row, line_draw_cost): 2052 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
5358 Use int, not unsigned, where either works. 2053 (unwind_body): New function.
5359 (save_current_matrix, restore_current_matrix): 2054 (record_unwind_protect): First arg is now a function returning void,
5360 Use ptrdiff_t, not size_t, where either works. 2055 not a dummy Lisp_Object.
5361 (init_display): Check for overflow more accurately, and without 2056 (record_unwind_protect_ptr, record_unwind_protect_int)
5362 relying on undefined behavior. 2057 (record_unwind_protect_void): New functions.
5363 2058 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
5364 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide): 2059 * fileio.c (struct auto_save_unwind): New type.
5365 Remove, replacing with the new symbols in lisp.h. All uses changed. 2060 (do_auto_save_unwind): Use it.
5366 * fileio.c (make_temp_name): 2061 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
5367 * filelock.c (lock_file_1, lock_file): 2062 * insdel.c (struct rvoe_arg): New type.
5368 * xdisp.c (message_dolog): 2063 (reset_var_on_error): Use it.
5369 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts. 2064 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
5370 Use pMd etc. instead. 2065 New constants.
5371 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros, 2066 (specbinding_func): Remove; there are now several such functions.
5372 replacing the pWIDE etc. symbols removed from editfns.c. 2067 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
5373 2068 (set_unwind_protect_ptr): New function.
5374 * keyboard.h (num_input_events): Now uintmax_t. 2069 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
5375 This is (very slightly) less likely to mess up due to wraparound. 2070
2071 Be simpler and more consistent about reporting I/O errors.
2072 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2073 Say "Read error" and "Write error", rather than "I/O error", or
2074 "IO error reading", or "IO error writing", when a read or write
2075 error occurs.
2076 * process.c (Fmake_network_process, wait_reading_process_output)
2077 (send_process, Fprocess_send_eof, wait_reading_process_output):
2078 Capitalize diagnostics consistently. Put "failed foo" at the
2079 start of the diagnostic, so that we don't capitalize the
2080 function name "foo". Consistently say "failed" for such
2081 diagnostics.
2082 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2083 All callers changed. This is so it can use report_file_error.
2084 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2085 diagnostics consistently as above.
2086
2087 * fileio.c (report_file_errno): Fix errno reporting bug.
2088 If the file name is neither null nor a pair, package it up as a
2089 singleton list. All callers changed, both to this function and to
2090 report_file_error. This fixes a bug where the memory allocator
2091 invoked by list1 set errno so that the immediately following
2092 report_file_error reported the wrong errno value.
2093
2094 Fix minor problems found by --enable-gcc-warnings.
2095 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2096 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2097
20982013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2099
2100 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2101 Set event->arg to Qt if switch-event shall be generated.
2102 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2103
2104 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2105
2106 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2107 FOCUS_OUT_EVENT.
2108
2109 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2110 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2111 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2112 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
2113 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
2114 and there is a focused frame.
2115 (head_table): Add focus-in and focus-out.
2116 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2117 bind to handle-focus-in/out.
2118
2119 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2120 (Fhandle_switch_frame): Call Fhandle_focus_in.
2121 (syms_of_frame): defsubr handle-focus-in/out.
2122
21232013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 Fix porting bug to older POSIXish platforms (Bug#14862).
2126 * sysdep.c (emacs_pipe): New function, that implements
2127 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2128 This should port better to CentOS 5 and to Mac OS X 10.6.
2129 All calls to pipe2 changed.
2130
2131 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2132 This makes the code easier to read and the executable a bit smaller.
2133 Do not replace all calls to Fcons that happen to create lists,
2134 just calls that are intended to create lists. For example, when
2135 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2136 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2137 Similarly for list2 through list5.
2138 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2139 * bytecode.c (exec_byte_code):
2140 * callint.c (quotify_arg, Fcall_interactively):
2141 * callproc.c (Fcall_process, create_temp_file):
2142 * charset.c (load_charset_map_from_file)
2143 (Fdefine_charset_internal, init_charset):
2144 * coding.c (get_translation_table, detect_coding_system)
2145 (Fcheck_coding_systems_region)
2146 (Fset_terminal_coding_system_internal)
2147 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2148 * composite.c (update_compositions, Ffind_composition_internal):
2149 * dired.c (directory_files_internal, file_name_completion)
2150 (Fsystem_users):
2151 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2152 * doc.c (Fsnarf_documentation):
2153 * editfns.c (Fmessage_box):
2154 * emacs.c (main):
2155 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2156 (Feval, eval_sub, Ffuncall, apply_lambda):
2157 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2158 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2159 (Fset_file_times, Finsert_file_contents)
2160 (Fchoose_write_coding_system, Fwrite_region):
2161 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2162 * font.c (font_registry_charsets, font_parse_fcname)
2163 (font_prepare_cache, font_update_drivers, Flist_fonts):
2164 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2165 * frame.c (make_frame, Fmake_terminal_frame)
2166 (x_set_frame_parameters, x_report_frame_params)
2167 (x_default_parameter, Fx_parse_geometry):
2168 * ftfont.c (syms_of_ftfont):
2169 * image.c (gif_load):
2170 * keyboard.c (command_loop_1):
2171 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2172 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2173 (Fminor_mode_key_binding, accessible_keymaps_1)
2174 (Faccessible_keymaps, Fwhere_is_internal):
2175 * lread.c (read_emacs_mule_char):
2176 * menu.c (find_and_return_menu_selection):
2177 * minibuf.c (get_minibuffer):
2178 * nsfns.m (Fns_perform_service):
2179 * nsfont.m (ns_script_to_charset):
2180 * nsmenu.m (ns_popup_dialog):
2181 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2182 (Fx_own_selection_internal):
2183 * nsterm.m (append2):
2184 * print.c (Fredirect_debugging_output)
2185 (print_prune_string_charset):
2186 * process.c (Fdelete_process, Fprocess_contact)
2187 (Fformat_network_address, set_socket_option)
2188 (read_and_dispose_of_process_output, write_queue_push)
2189 (send_process, exec_sentinel):
2190 * sound.c (Fplay_sound_internal):
2191 * textprop.c (validate_plist, add_properties)
2192 (Fput_text_property, Fadd_face_text_property)
2193 (copy_text_properties, text_property_list, syms_of_textprop):
2194 * unexaix.c (report_error):
2195 * unexcoff.c (report_error):
2196 * unexsol.c (unexec):
2197 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2198 (Fformat_mode_line, syms_of_xdisp):
2199 * xfaces.c (set_font_frame_param)
2200 (Finternal_lisp_face_attribute_values)
2201 (Finternal_merge_in_global_face, syms_of_xfaces):
2202 * xfns.c (x_default_scroll_bar_color_parameter)
2203 (x_default_font_parameter, x_create_tip_frame):
2204 * xfont.c (xfont_supported_scripts):
2205 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2206 (menu_help_callback, xmenu_show):
2207 * xml.c (make_dom):
2208 * xterm.c (set_wm_state):
2209 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2210 and similarly for list2 through list5.
2211
22122013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * callproc.c (Fcall_process_region): Fix minor race and tune.
2215 (create_temp_file): New function, with the temp-file-creation part
2216 of the old Fcall_process_region. Use Fcopy_sequence to create the
2217 temp file name, rather than alloca + build_string, for simplicity.
2218 Don't bother to block input around the temp file creation;
2219 shouldn't be needed. Simplify use of mktemp.
2220 Use record_unwind_protect immediately after creating the temp file;
2221 this closes an unlikely race where the temp file was not removed.
2222 Use memcpy rather than an open-coded loop.
2223 (Fcall_process_region): Use the new function. If the input is
2224 empty, redirect from /dev/null rather than from a newly created
2225 empty temp file; this avoids unnecessary file system traffic.
2226
22272013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2230 Simplify by making this case like the other two. This is a bit
2231 slower on obsolete hosts, but the extra complexity isn't worth it.
2232
2233 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2234 * process.c (create_process) [!DOS_NT]:
2235 Remove now-unnecessary calls to emacs_close.
2236
22372013-07-13 Eli Zaretskii <eliz@gnu.org>
2238
2239 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2240 returning early. (Bug#14850)
2241
2242 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2243 and inhibit-iso-escape-detection attributes of 'undecided'.
2244 (Bug#14822)
2245
22462013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2249 Reported by Herbert J. Skuhra in
2250 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2251
2252 Don't lose top specpdl entry when memory is exhausted.
2253 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2254 specpdl overflow here, to simplify callers; all callers changed.
2255 Always reserve an unused entry at the stack top; this avoids
2256 losing the top entry's information when memory is exhausted.
2257
22582013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 Clean up errno reporting and fix some errno-reporting bugs.
2261 * callproc.c (Fcall_process):
2262 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2263 * process.c (create_process, Fmake_network_process):
2264 * unexaix.c (report_error):
2265 * unexcoff.c (report_error):
2266 Be more careful about reporting the errno of failed operations.
2267 The code previously reported the wrong errno sometimes.
2268 Also, prefer report_file_errno to setting errno + report_file_error.
2269 (Fcall_process): Look at openp return value rather than at path,
2270 as that's a bit faster and clearer when there's a numeric predicate.
2271 * fileio.c (report_file_errno): New function, with most of the
2272 old contents of report_file_error.
2273 (report_file_error): Use it.
2274 (Ffile_exists_p, Ffile_accessible_directory_p):
2275 Set errno to 0 when it is junk.
2276 * fileio.c (Faccess_file):
2277 * image.c (x_create_bitmap_from_file):
2278 Use faccessat rather than opening the file, to avoid the hassle of
2279 having a file descriptor open.
2280 * lisp.h (report_file_errno): New decl.
2281 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2282
2283 Minor EBADF fixes.
2284 * process.c (create_process, wait_reading_process_output) [AIX]:
2285 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2286 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2287 a multithreaded environment anyway).
2288 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2289
22902013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2291
2292 * image.c (x_find_image_file): Don't close a remote file handle.
2293
22942013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2295
2296 Fix races with threads and file descriptors.
2297 * callproc.c (Fcall_process_region):
2298 * dired.c (open_directory):
2299 * emacs.c (main, Fdaemon_initialized):
2300 * image.c (x_find_image_file):
2301 * inotify.c (Finotify_rm_watch):
2302 * lread.c (Flocate_file_internal):
2303 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2304 * term.c (term_mouse_moveto, init_tty):
2305 * termcap.c (tgetent):
2306 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2307 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2308 * unexhp9k800.c, unexmacosx.c (unexec):
2309 * callproc.c (Fcall_process_region):
2310 Use emacs_close, not close.
2311 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2312 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2313 and posix_close function on current platforms (which all lack them).
2314 (emacs_close): Use it. This should fix the races on GNU/Linux and
2315 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2316 and it should avoid closing random victim file descriptors on
2317 other platforms.
2318
23192013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2322 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2323 Touch up doc a bit.
2324
2325 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2326 This is for .gdbinit xbacktrace.
2327
2328 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2329 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2330 (emacs_set_tty): Now static.
2331 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2332 * term.c (tty_capable_p, tty_default_color_capabilities)
2333 (get_tty_terminal, term_mouse_movement)
2334 (handle_one_term_event, init_tty, maybe_fatal):
2335 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2336 (tgetent, scan_file, name_match, compare_contin):
2337 * terminal.c (get_terminal):
2338 Use bool for boolean.
2339 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2340 Prefer char to unsigned char if either will do.
2341 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2342 (tty_write_glyphs): Prefer int to unsigned.
2343 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2344 All callers changed.
2345 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2346
23472013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 Port to C89.
2350 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2351 (B__dummy__): New dummy symbol, to pacify C89.
2352 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2353 they can't grok varargs macros.
2354 * dispnew.c (add_window_display_history)
2355 (add_frame_display_history):
2356 * print.c (print_object):
2357 * xdisp.c (debug_method_add):
2358 Use %p printf format only for void pointers.
2359 * emacs.c (usage_message): New constant, replacing ...
2360 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2361 (main): Adjust to usage reorg.
2362 * fns.c (syms_of_fns):
2363 * profiler.c (syms_of_profiler):
2364 Don't use non-constant struct initializers.
2365 * gnutls.h (gnutls_initstage_t):
2366 * lisp.h (enum Lisp_Fwd_Type):
2367 * lread.c (lisp_file_lexically_bound_p):
2368 * xsettings.c (anonymous enum):
2369 Remove trailing comma.
2370 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2371 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2372 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2373 (DEFUN): Use it.
2374 * regex.c (const_re_char): New type, to pacify strict C89.
2375 All uses of 'const re_char' replaced to use it.
2376 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2377 with glibc when strict C89. This change is imported from gnulib.
5376 All uses changed. 2378 All uses changed.
2379 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2380 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2381 Omit GNU_LINUX implementation, since it requires long long.
2382 * xterm.c (x_draw_underwave):
2383 Do not assume the traditional order of struct's members.
2384 (x_term_init): Rewrite to avoid the need for non-constant structure
2385 initializers.
2386
2387 Syntax cleanup, mostly replacing macros with functions.
2388 This removes the need for the syntax_temp hack.
2389 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2390 * syntax.c (SYNTAX_INLINE): New macro.
2391 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2392 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2393 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2394 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2395 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2396 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2397 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2398 Now constants, not macros.
2399 (syntax_temp) [!__GNUC__]: Remove.
2400 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2401 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2402 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2403 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2404 Move here from syntax.h; now functions, not macros. Except for the
2405 last function, these are static since only syntax.c uses them.
2406 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2407 All uses changed. Now a function, not a macro; use this fact
2408 to simplify the code.
2409 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2410 compiler bugs; no longer relevant.
2411 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2412 (SYNTAX_INLINE): New macro.
2413 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2414 for the new functions. Use bool for boolean member.
2415 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2416 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2417 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2418 (SETUP_BUFFER_SYNTAX_TABLE):
2419 Now extern inline functions, not macros.
2420 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2421 Remove; all uses replaced by implementation.
2422 (syntax_temp) [!__GNUC__]: Remove decl.
2423 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2424
24252013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2426
2427 * emacs.c (main): Fix syntax error.
2428
24292013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 Timestamp fixes for undo (Bug#14824).
2432 * atimer.c (schedule_atimer):
2433 * fileio.c (Ffile_newer_than_file_p):
2434 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2435 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2436 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2437 (syms_of_fileio): Remove Sclear_visited_file_name.
2438 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2439 file doesn't exist; this avoids an ambiguity with negative timestamps.
2440 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2441 * systime.h (make_emacs_time, invalid_emacs_time):
2442 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2443 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2444 * undo.c (record_first_change): Push (visited-file-modtime) onto
2445 undo list rather than reimplementing it by hand, incorrectly.
2446
24472013-07-09 Ken Brown <kbrown@cornell.edu>
2448
2449 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2450
24512013-07-09 Juanma Barranquero <lekktu@gmail.com>
2452
2453 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2454
24552013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 Handle errno and exit status a bit more carefully.
2458 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2459 number into an exit status. Instead, use EXIT_CANCELED.
2460 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2461 * callproc.c (relocate_fd):
2462 * emacs.c (close_output_streams, main):
2463 * process.c (create_process):
2464 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2465 Use emacs_perror for simplicity.
2466 * callproc.c (relocate_fd, main):
2467 * sysdep.c (sys_subshell):
2468 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2469 (shut_down_emacs): Use emacs_write, not write.
2470 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2471 * fileio.c (Fcopy_file, e_write):
2472 * nsterm.m (ns_select):
2473 * process.c (send_process):
2474 * sound.c (vox_write):
2475 Use emacs_write_sig, not emacs_write.
2476 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2477 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2478 New constants.
2479 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2480 of write.
2481 (emacs_full_write): New function.
2482 (emacs_write): Rewrite to use it.
2483 (emacswrite_sig, emacs_perror): New functions.
2484 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2485
24862013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
2487
2488 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2489 on NS even if it is present. Pixmap on NS is a void*.
2490
24912013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 Port to Ubuntu 10 (Bug#14803).
2494 Problem reported by T.V. Raman.
2495 * process.c (close_on_exec, accept4, process_socket):
2496 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2497
24982013-07-07 Eli Zaretskii <eliz@gnu.org>
2499
2500 * w32.c (sys_dup): Declare prototype.
2501
2502 * filelock.c:
2503 * emacs.c:
2504 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2505
25062013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 Make file descriptors close-on-exec when possible (Bug#14803).
2509 This simplifies Emacs a bit, since it no longer needs to worry
2510 about closing file descriptors by hand in some cases.
2511 It also fixes some unlikely races. Not all such races, as
2512 libraries often open files internally without setting
2513 close-on-exec, but it's an improvement.
2514 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2515 * callproc.c (Fcall_process) [!MSDOS]:
2516 * emacs.c (main) [!DOS_NT]:
2517 * nsterm.m (ns_term_init):
2518 * process.c (create_process):
2519 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2520 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2521 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2522 Prefer mkostemp with O_CLOEXEC to mkstemp.
2523 * callproc.c (relocate_fd) [!WINDOWSNT]:
2524 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2525 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2526 now using pipe2.
2527 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2528 Make the resulting file descriptor close-on-exec.
2529 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2530 * lread.c (load_descriptor_list, load_descriptor_unwind):
2531 Remove; no longer needed. All uses removed.
2532 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2533 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2534 New functions.
2535 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2536 (Fmake_network_process, Fnetwork_interface_list):
2537 (Fnetwork_interface_info, server_accept_connection):
2538 Make newly-created socket close-on-exec.
2539 * sysdep.c (emacs_open, emacs_fopen):
2540 Make new-created descriptor close-on-exec.
2541 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2542 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
5377 2543
5378 * buffer.c: Integer signedness fixes. 25442013-07-07 Jan Djärv <jan.h.d@swipnet.se>
5379 (alloc_buffer_text, enlarge_buffer_text):
5380 Use ptrdiff_t rather than size_t when either will do, as we prefer
5381 signed integers.
5382
5383 * alloc.c: Integer signedness and overflow fixes.
5384 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5385 (__malloc_size_t): Default to size_t, not to int.
5386 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5387 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5388 Prefer ptrdiff_t to size_t when either would do, as we prefer
5389 signed integers.
5390 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5391 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5392 Now const. Initialize with values that are in range even if char
5393 is signed.
5394 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5395 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5396 These functions do the right thing with sizes > 2**32.
5397 (check_depth): Now ptrdiff_t, not int.
5398 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5399 Adjust to new way of storing sizes. Check for size overflow bugs
5400 in rest of code.
5401 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5402 slightly wrong anyway, as it missed one instance of
5403 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5404 (refill_memory_reserve): Omit needless cast to size_t.
5405 (mark_object_loop_halt): Mark as externally visible.
5406
5407 * xselect.c: Integer signedness and overflow fixes.
5408 (Fx_register_dnd_atom, x_handle_dnd_message):
5409 Use ptrdiff_t, not size_t, since we prefer signed.
5410 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5411 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5412 x_dnd_atoms_size and x_dnd_atoms_length.
5413
5414 * doprnt.c: Prefer signed to unsigned when either works.
5415 * eval.c (verror):
5416 * doprnt.c (doprnt):
5417 * lisp.h (doprnt):
5418 * xdisp.c (vmessage):
5419 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5420 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5421 prefer signed arithmetic to avoid comparison confusion.
5422 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5423 but is a bit tricky.
5424
5425 Assume freestanding C89 headers, string.h, stdlib.h.
5426 * data.c, doprnt.c, floatfns.c, print.c:
5427 Include float.h unconditionally.
5428 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5429 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5430 * regex.c: Likewise for stddef.h, string.h.
5431 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5432 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5433 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5434 (STDC_HEADERS): Remove obsolete defines.
5435 * sysdep.c: Include limits.h unconditionally.
5436
5437 Assume support for memcmp, memcpy, memmove, memset.
5438 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5439 * regex.c (memcmp, memcpy):
5440 Remove; we assume C89 now.
5441
5442 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5443 (__malloc_safe_bcopy): Remove; no longer needed.
5444
5445 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5446 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5447 well either way, and we prefer signed to unsigned.
5448
54492011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5450
5451 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5452 closes the connection while we're reading (bug#9182).
5453
54542011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5455
5456 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5457 are specified (Bug#9168).
5458
54592011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5460
5461 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5462 Found by GCC static checking and --with-wide-int on a 32-bit host.
5463
54642011-07-25 Eli Zaretskii <eliz@gnu.org>
5465
5466 * xdisp.c (compute_display_string_pos): Fix logic of caching
5467 previous display string position. Initialize cached_prev_pos to
5468 -1. Fixes slow-down at the beginning of a buffer.
5469
54702011-07-24 Eli Zaretskii <eliz@gnu.org>
5471
5472 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5473 for attrs[LFACE_FONTSET_INDEX].
5474
54752011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 * xml.c (parse_region): Remove unused local
5478 that was recently introduced.
5479
54802011-07-23 Eli Zaretskii <eliz@gnu.org>
5481
5482 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5483 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5484
5485 * xdisp.c (move_it_in_display_line_to): Record the best matching
5486 position for TO_CHARPOS while scanning the line, and restore it on
5487 exit if none of the characters scanned was an exact match.
5488 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5489 when exact match is impossible due to invisible text, and the
5490 lines are truncated.
5491
54922011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5493
5494 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5495 for OSX >= 10.7.
5496
54972011-07-22 Eli Zaretskii <eliz@gnu.org>
5498
5499 Fix a significant slow-down of cursor motion with C-n, C-p,
5500 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5501 auto-repeat under bidi redisplay in fontified buffers.
5502 * xdisp.c (compute_stop_pos_backwards): New function.
5503 (next_element_from_buffer): Call compute_stop_pos_backwards to
5504 find a suitable prev_stop when we find ourselves before
5505 base_level_stop.
5506 (reseat): Don't look for prev_stop, as that could mean a very long
5507 run.
5508 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5509 <cached_disp_overlay_modiff>: Cache for last found display string
5510 position.
5511 (compute_display_string_pos): Return the cached position if asked
5512 about the same buffer in the same area of character positions, and
5513 the buffer wasn't changed since the time the display string
5514 position was cached.
5515
55162011-07-22 Eli Zaretskii <eliz@gnu.org>
5517
5518 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5519 is an integer, which is important for empty lines. (Bug#9149)
5520
55212011-07-22 Chong Yidong <cyd@stupidchicken.com>
5522
5523 * frame.c (Fmodify_frame_parameters): In tty case, update the
5524 default face if necessary (Bug#4238).
5525
55262011-07-21 Chong Yidong <cyd@stupidchicken.com>
5527
5528 * editfns.c (Fstring_to_char): No need to explain what a character
5529 is in the docstring (Bug#6576).
5530
55312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5532
5533 * xml.c (parse_region): Make sure we always return a tree.
5534
55352011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5536
5537 * xml.c (parse_region): If a document contains only comments,
5538 return that, too.
5539
55402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5541
5542 * xml.c (make_dom): Return comments, too.
5543
55442011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5545
5546 Port to OpenBSD.
5547 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5548 and the surrounding thread.
5549 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5550 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5551 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5552 timer goes off.
5553 * s/openbsd.h (BROKEN_SIGIO): Define.
5554 * unexelf.c (unexec) [__OpenBSD__]:
5555 Don't update the .mdebug section of the Alpha COFF symbol table.
5556 2545
55572011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org> 2546 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2547 for NS_IMPL_GNUSTEP.
5558 2548
5559 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used 25492013-07-07 Paul Eggert <eggert@cs.ucla.edu>
5560 (bug#8460).
5561 2550
55622011-07-18 Paul Eggert <eggert@cs.ucla.edu> 2551 Fix openp errno handling.
2552 * callproc.c (Fcall_process): Preserve openp errno around close.
2553 * lread.c (openp): Set errno when returning -1, as some callers
2554 expect this.
5563 2555
5564 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask. 25562013-07-06 Jan Djärv <jan.h.d@swipnet.se>
5565 This fixes some race conditions on the permissions of any newly
5566 created file.
5567 2557
5568 * alloc.c (valid_pointer_p): Use pipe, not open. 2558 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
5569 This fixes some permissions issues when debugging.
5570 2559
5571 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002) 2560 * nsterm.h (NSSavePanel): Update comment.
5572 If fchown fails to set both uid and gid, try to set just gid, 2561 (NSAPP_DATA2_RUNFILEDIALOG): Define.
5573 as that is sometimes allowed. Adjust the file's mode to eliminate 2562 (ns_run_file_dialog): Declare.
5574 setuid or setgid bits that are inappropriate if fchown fails.
5575 2563
55762011-07-18 Stefan Monnier <monnier@iro.umontreal.ca> 2564 * nsfns.m: Remove panelOK.
2565 (ns_fd_data): New.
2566 (ns_run_file_dialog): New function.
2567 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2568 event loop, so file dialog is popped up by ns_run_file_dialog, called
2569 by sendEvent (Bug#14578).
2570 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
5577 2571
5578 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ 25722013-07-06 Eli Zaretskii <eliz@gnu.org>
5579 to compare Lisp_Objects.
5580 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5581 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5582 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5583 2573
55842011-07-17 Andreas Schwab <schwab@linux-m68k.org> 2574 * xdisp.c (default_line_pixel_height): New function.
2575 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2576 (try_cursor_movement, redisplay_window, try_window)
2577 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
5585 2578
5586 * lread.c (read_integer): Unread even EOF character. 2579 * window.c (window_scroll_pixel_based):
5587 (read1): Likewise. Properly record start position of symbol. 2580 use default_line_pixel_height.
5588 2581
5589 * lread.c (read1): Read `#:' as empty uninterned symbol if no 2582 * dispextern.h (default_line_pixel_height): Add prototype.
5590 symbol character follows.
5591 2583
55922011-07-17 Paul Eggert <eggert@cs.ucla.edu> 2584 * frame.c (x_set_line_spacing): Accept a float value for
2585 line-spacing parameter, per the documentation.
5593 2586
5594 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002) 2587 * data.c (Fmultibyte_string_p): Doc fix.
5595 This works around a problem with the previous change to Fcopy_file.
5596 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5597 and without this change, GCC might complain about discarding
5598 fchown's return value.
5599 2588
56002011-07-16 Juanma Barranquero <lekktu@gmail.com> 25892013-07-05 Paul Eggert <eggert@cs.ucla.edu>
5601 2590
5602 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059). 2591 Use emacs_open more consistently when opening files.
2592 This handles EINTR more consistently now, and makes it easier
2593 to introduce other uniform changes to file descriptor handling.
2594 * src/systdio.h: New file.
2595 * src/buffer.c (mmap_init):
2596 * cygw32.c (chdir_to_default_directory):
2597 * dispnew.c (Fopen_termscript):
2598 * emacs.c (Fdaemon_initialized):
2599 * fileio.c (Fdo_auto_save):
2600 * image.c (slurp_file, png_load_body, jpeg_load_body):
2601 * keyboard.c (Fopen_dribble_file):
2602 * lread.c (Fload):
2603 * print.c (Fredirect_debugging_output):
2604 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2605 * termcap.c (tgetent):
2606 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2607 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2608 * w32term.c (w32_initialize) [CYGWIN]:
2609 * xfaces.c (Fx_load_color_file):
2610 Use emacs_open instead of plain open, and emacs_fopen instead of
2611 plain fopen.
2612 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2613 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2614 * callproc.c (default_output_mode): New constant.
2615 (Fcall_process): Use it to call emacs_open instead of plain creat.
2616 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2617 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2618 (emacs_fopen): New function.
2619 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2620 Include <lisp.h>, for emacs_open.
2621 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2622
2623 Remove duplicate #include directives.
2624 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2625 * xfaces.c:
2626 Don't include stdio.h twice.
2627 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2628 Don't include sys/types.h or stdio.h twice.
2629 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2630 * lread.c: Don't include coding.h twice.
2631 * nsfont.m: Don't include frame.h twice.
2632 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2633 * ralloc.c: Don't include <unistd.h> twice.
2634 * xdisp.c: Don't include font.h twice.
2635 * xterm.c: Don't include fontset.h twice.
2636 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2637
26382013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2639
2640 Scale ImageMagick images more carefully.
2641 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2642 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2643 Be more careful about avoiding undefined behavior after
2644 integer overflow and division by zero.
2645
26462013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2647
2648 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2649 (syms_of_w32fns): DEFSYM them.
2650 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2651 (CCHDEVICENAME): Define macros if not defined.
2652 (struct MONITOR_INFO_EX): New struct.
2653 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2654 (enum_display_monitors_fn): New variable.
2655 (globals_of_w32fns): Initialize it.
2656 (Fx_display_pixel_width, Fx_display_pixel_height)
2657 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2658 multi-monitor setups in docstrings.
2659 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2660 screen size by primary monitor's millimeter per pixel.
2661 (w32_monitor_enum, w32_display_monitor_attributes_list)
2662 (w32_display_monitor_attributes_list_fallback)
2663 (Fw32_display_monitor_attributes_list): New functions.
2664 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2665
2666 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2667 if not defined.
2668 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2669
26702013-07-04 Michael Albinus <michael.albinus@gmx.de>
2671
2672 * fileio.c (Qfile_notify_error): New error symbol.
2673
2674 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2675 * inotify.c (inotify_callback, symbol_to_inotifymask)
2676 (Finotify_add_watch, Finotify_rm_watch): Use it.
2677 (inotifyevent_to_event): Exchange order of cookie and file name.
2678 (Finotify_add_watch): Adapt docstring.
2679
2680 * lisp.h (Qfile_notify_error): Declare.
2681
26822013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2685 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2686 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2687 which did not work (see <http://bugs.gnu.org/14569#307>).
2688 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2689 && (!noninteractive || initialized)). This attempts to thread
2690 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2691
26922013-07-04 Juanma Barranquero <lekktu@gmail.com>
2693
2694 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2695 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2696
26972013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2700 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2701 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2702 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2703
27042013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2707 Define to __sys_siglist.
2708
27092013-07-02 Eli Zaretskii <eliz@gnu.org>
2710
2711 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2712 word-wrap, so that overflow-newline-into-fringe would work in
2713 visual-line-mode. (Bug#2749)
2714 (move_it_in_display_line_to): When the last scanned display
2715 element fits exactly on the display line, and
2716 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2717 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2718 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2719 finding buffer position that corresponds to pixel coordinates,
2720 e.g. in buffer_posn_from_coords.
2721
27222013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2723
2724 * process.c (handle_child_signal): Call catch_child_signal if
2725 NS_IMPL_GNUSTEP.
2726
27272013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 Don't convert function pointers to void * and back.
2730 It isn't portable C, and it's easy enough to avoid.
2731 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2732 (make_save_value): Add support for SAVE_FUNCPOINTER.
2733 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2734 * print.c (print_object):
2735 Distinguish function from object pointers.
2736 * lisp.h (SAVE_FUNCPOINTER): New constant.
2737 (SAVE_SLOT_BITS): Adjust to it.
2738 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2739 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2740 (voidfuncptr): New typedef.
2741 (struct Lisp_Save_Value): New member data[0].funcpointer.
2742 (XSAVE_FUNCPOINTER): New function.
2743
2744 Simplify buildobj processing.
2745 * Makefile.in (buildobj.h): Make it a sequence of strings each
2746 followed by comma, rather than a single string. Put it into a
2747 .tmp file in case there's an error while generating it.
2748 (gl-stamp): Use .tmp for temp files.
2749 (mostlyclean): Clean .tmp files.
2750 * doc.c (buildobj): Move to just the routine that needs it.
2751 It's now an array of strings, so processing is simpler.
2752
27532013-07-01 Paul Eggert <eggert@cs.ucla.edu>
5603 2754
56042011-07-16 Paul Eggert <eggert@cs.ucla.edu> 2755 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2756 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2757 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2758 Invoke malloc_enable_thread even when not interactive.
2759 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2760 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2761 in this case, since the underlying bug has now been fixed.
5605 2762
5606 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002) 27632013-07-01 Juanma Barranquero <lekktu@gmail.com>
5607 2764
56082011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org> 2765 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2766 unlinking it (bug#14691).
5609 2767
5610 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since 27682013-06-30 Michal Nazarewicz <mina86@mina86.com>
5611 it's used from the C level.
5612 2769
5613 * process.c: Use the same condition for POLL_FOR_INPUT in both 2770 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
5614 keyboard.c and process.c (bug#1858). 2771 before checking whether buffer is modified. This lets
2772 `kill-buffer-query-functions' cancel killing of the buffer or save
2773 its content before `kill-buffer' asks user the "Buffer %s
2774 modified; kill anyway?" question.
5615 2775
56162011-07-09 Lawrence Mitchell <wence@gmx.li> 27762013-06-30 Jan Djärv <jan.h.d@swipnet.se>
5617 2777
5618 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable. 2778 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
5619 (Fgnutls_boot): Use it. 2779 Let the super performKeyEquivalent deal with them (Bug#14747).
5620 2780
56212011-07-15 Andreas Schwab <schwab@linux-m68k.org> 27812013-06-30 Paul Eggert <eggert@cs.ucla.edu>
5622 2782
5623 * doc.c (Fsubstitute_command_keys): Revert last change. 2783 * widget.c (resize_cb): Remove unused local.
5624 2784
56252011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org> 2785 Do not use GTK 3 if it exists but cannot be compiled.
2786 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2787 * xterm.c (x_error_handler) [!USE_GTK]:
2788 Do not use GTK 3.
5626 2789
5627 * doc.c (Fsubstitute_command_keys): Clarify that \= really only 2790 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
5628 quotes the next character, and doesn't affect other longer
5629 sequences (bug#8935).
5630 2791
5631 * lread.c (syms_of_lread): Clarify that is isn't only 27922013-06-30 Eli Zaretskii <eliz@gnu.org>
5632 `eval-buffer' and `eval-defun' that's affected by
5633 `lexical-binding' (bug#8460).
5634 2793
56352011-07-15 Eli Zaretskii <eliz@gnu.org> 2794 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2795 to the valid range of values. (Bug#14753)
5636 2796
5637 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with 2797 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
5638 bidi redisplay when a line includes both an image and is truncated. 2798 when moving point by using the current glyph matrix. This avoids
2799 the need to force redisplay when this function is called in a
2800 loop.
5639 2801
56402011-07-14 Paul Eggert <eggert@cs.ucla.edu> 28022013-06-29 Paul Eggert <eggert@cs.ucla.edu>
5641 2803
5642 Fix minor problems found by static checking. 2804 Fix minor problems found by static checking.
5643 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t. 2805 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
5644 (elsz): Now a signed constant, not a size_t var. We prefer signed 2806 Redo the latter's body to sidestep GCC parenthesization warnings.
5645 types to unsigned, to avoid integer comparison confusion. Without 2807 (setup_coding_system, detect_coding, detect_coding_system): Use them.
5646 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains 2808 * coding.c (detect_coding, detect_coding_system):
5647 "cannot optimize loop, the loop counter may overflow", a symptom 2809 * coding.h (struct undecided_spec):
5648 of the confusion. 2810 Use bool for boolean.
5649 * indent.c (Fvertical_motion): Mark locals as initialized. 2811 * image.c (QCmax_width, QCmax_height): Now static.
5650 * xdisp.c (reseat_to_string): Fix pointer signedness issue. 2812 * xdisp.c (Fmove_point_visually): Remove unused local.
5651 2813
56522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org> 28142013-06-29 Eli Zaretskii <eliz@gnu.org>
5653 2815
5654 * search.c (Fre_search_backward): Mention `case-fold-search' in 2816 * xdisp.c (Fmove_point_visually): New function.
5655 all the re_search_* functions (bug#8138). 2817
5656 28182013-06-28 Kenichi Handa <handa@gnu.org>
5657 * keyboard.c (Fopen_dribble_file): Document when the file is 2819
5658 closed (bug#8056). 2820 * coding.h (define_coding_undecided_arg_index): New enum.
5659 2821 (coding_attr_index): New members
56602011-07-14 Eli Zaretskii <eliz@gnu.org> 2822 coding_attr_undecided_inhibit_null_byte_detection,
5661 2823 coding_attr_undecided_inhibit_iso_escape_detection,
5662 * bidi.c (bidi_dump_cached_states): Fix format of displaying 2824 coding_attr_undecided_prefer_utf_8.
5663 bidi_cache_idx. 2825 (undecided_spec): New struct.
5664 2826 (struct coding_system): New member `undecided' of the member
5665 Support bidi reordering of display and overlay strings. 2827 `spec'.
5666 * xdisp.c (compute_display_string_pos) 2828
5667 (compute_display_string_end): Accept additional argument STRING. 2829 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
5668 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL. 2830 (detect_coding): Likewise.
5669 (reseat_to_string): Initialize bidi_it->string.s and 2831 (detect_coding_system): Likewise.
5670 bidi_it->string.schars. 2832 (Fdefine_coding_system_internal): New coding system properties
5671 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to 2833 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
5672 NULL (avoids a crash in bidi_paragraph_init). 2834 :prefer-utf-8.
5673 Initialize itb.string.lstring. 2835 (syms_of_coding): Adjust for coding_arg_undecided_max.
5674 (init_iterator): Call bidi_init_it only of a valid 2836
5675 buffer position was specified. Initialize paragraph_embedding to 28372013-06-28 Paul Eggert <eggert@cs.ucla.edu>
5676 L2R. 2838
5677 (reseat_to_string): Initialize the bidi iterator. 2839 * image.c (x_from_xcolors): Remove unused local.
5678 (display_string): If we need to ignore text properties of 2840
5679 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The 28412013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5680 original value of -1 will not work with bidi.) 2842
5681 (compute_display_string_pos): First arg is now struct 2843 Defer image data transfer between X client and server until actual
5682 `text_pos *'; all callers changed. Support display properties on 2844 display happens.
5683 Lisp strings. 2845
5684 (compute_display_string_end): Support display properties on Lisp 2846 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
5685 strings. 2847 and `mask_img'.
5686 (init_iterator, reseat_1, reseat_to_string): Initialize the 2848
5687 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS 2849 * image.c (Destroy_Image): Remove.
5688 when iterating on a string not from display properties). 2850 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
5689 (compute_display_string_pos, compute_display_string_end): 2851 `mask_p', and `colors_p'. All uses changed.
5690 Fix calculation of the object to scan. Fixes an error when using 2852 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
5691 arrow keys. 2853 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
5692 (next_element_from_buffer): Don't abort when IT_CHARPOS is before 2854 New macros for `flags' arg to x_clear_image_1.
5693 base_level_stop; instead, set base_level_stop to BEGV. 2855 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
5694 Fixes crashes in vertical-motion. 2856 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
5695 (next_element_from_buffer): Improve commentary for when 2857 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
5696 the iterator is before prev_stop. 2858 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
5697 (init_iterator): Initialize bidi_p from the default value of 2859 (image_get_x_image, image_unget_x_image): New functions or macros.
5698 bidi-display-reordering, not from buffer-local value. Use the 2860 (image_background, image_background_transparent, x_to_xcolors)
5699 buffer-local value only if initializing for buffer iteration. 2861 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
5700 (handle_invisible_prop): Support invisible properties on strings 2862 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
5701 that are being bidi-reordered. 2863 instead of Destroy_Image.
5702 (set_iterator_to_next): Support bidi reordering of C strings and 2864 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
5703 Lisp strings. 2865 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
5704 (next_element_from_string): Support bidi reordering of Lisp 2866 (png_load_body, jpeg_load_body, tiff_load, gif_load)
5705 strings. 2867 (imagemagick_load_image, svg_load_image): Use them instead of
5706 (handle_stop_backwards): Support Lisp strings as well. 2868 x_create_x_image_and_pixmap, and x_put_x_image followed by
5707 (display_string): Support display of R2L glyph rows. 2869 x_destroy_x_image, respectively.
5708 Use IT_STRING_CHARPOS when displaying from a Lisp string. 2870 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
5709 (init_iterator): Don't initialize it->bidi_p for strings 2871 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
5710 here. 2872 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
5711 (reseat_to_string): Initialize it->bidi_p for strings here. 2873 background_transparent fields.
5712 (next_element_from_string, next_element_from_c_string) 2874 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
5713 (next_element_from_buffer): Add xassert's for correspondence 2875 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
5714 between IT's object being iterated and it->bidi_it.string 2876
5715 structure. 28772013-06-27 Paul Eggert <eggert@cs.ucla.edu>
5716 (face_before_or_after_it_pos): Support bidi iteration. 2878
5717 (next_element_from_c_string): Handle the case of the first string 2879 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
5718 character that is not the first one in the visual order. 2880 This mostly consists of undoing recent changes.
5719 (get_visually_first_element): New function, refactored from common 2881 * callproc.c (Fcall_process):
5720 parts of next_element_from_buffer, next_element_from_string, and 2882 * process.c (create_process):
5721 next_element_from_c_string. 2883 Do not worry about catching SIGCHLD here, undoing previous change.
5722 (tool_bar_lines_needed, redisplay_tool_bar) 2884 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
5723 (display_menu_bar): Force left-to-right direction. Add a FIXME 2885 * process.c, process.h (catch_child_signal):
5724 comment for making that be controlled by a user option. 2886 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
5725 (push_it, pop_it): Save and restore the state of the 2887 * process.c (catch_child_handler): Don't worry about being called
5726 bidi iterator. Save and restore the bidi_p flag. 2888 lazily and do not assume caller has blocked SIGCHLD, undoing
5727 (pop_it): Iterate out of display property for string iteration as 2889 previous change. Move first-time stuff back to
5728 well. 2890 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
5729 (iterate_out_of_display_property): Support iteration over strings. 2891 tickle glib, as that causes Cygwin bootstrap to fail. Do not
5730 (handle_single_display_spec): Set up it->bidi_it for iteration 2892 set lib_child_handler if it's already initialized, which may
5731 over a display string, and call bidi_init_it. 2893 help avoid problems on GNUStep.
5732 (handle_single_display_spec, next_overlay_string) 2894
5733 (get_overlay_strings_1, push_display_prop): Set up the bidi 28952013-06-23 Paul Eggert <eggert@cs.ucla.edu>
5734 iterator for displaying display or overlay strings. 2896
5735 (forward_to_next_line_start): Don't use the shortcut if 2897 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
5736 bidi-iterating. 2898 * callproc.c (Fcall_process):
5737 (back_to_previous_visible_line_start): If handle_display_prop 2899 * process.c (create_process):
5738 pushed the iterator stack, restore the internal state of the bidi 2900 Make sure SIGCHLD is caught before we fork,
5739 iterator by calling bidi_pop_it same number of times. 2901 since Emacs startup no arranges to catch SIGCHLD.
5740 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero, 2902 * process.c (lib_child_handler): Initialize to null, not to
5741 and we are bidi-iterating, don't decrement the iterator position; 2903 dummy_handler.
5742 instead, set the first_elt flag in the bidi iterator, to produce 2904 (catch_child_signal): Allow self to be called lazily.
5743 the same effect. 2905 Do nothing if it's already been called.
5744 (reseat_1): Remove redundant setting of string_from_display_prop_p. 2906 Assume caller has blocked SIGCHLD (all callers do now).
5745 (push_display_prop): xassert that we are iterating a buffer. 2907 * emacs.c (main): Do not catch SIGCHLD here; defer it until
5746 (push_it, pop_it): Save and restore paragraph_embedding member. 2908 just before it's really needed.
2909 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2910 since it hasn't been caught yet.
2911
29122013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913
2914 * image.c (compute_image_size): New function to implement
2915 :max-width and :max-height.
2916 (imagemagick_load_image): Use it.
2917
29182013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2919
2920 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2921 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2922 Now extern.
2923 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2924 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2925 the SIGCHLD handler, since the code is not atomic and (due to glib)
2926 signals may be arriving now.
2927 * sysdep.c (init_signals): Do not catch child signals here;
2928 'main' now does that later, at a safer time.
2929
29302013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2931
2932 Clean up SIGCHLD handling a bit (Bug#14569).
2933 * process.c, process.h (catch_child_signal):
2934 Now always extern, even if !NS_IMPL_GNUSTEP.
2935 * process.c (catch_child_signal): Move glib tickler here from
2936 init_process_emacs, so that it's done earlier in Emacs
2937 initialization. Also move the noninteractive && !initialized
2938 check here from init_process_emacs. This is all a bit cleaner for
2939 GNUish platforms, and I hope it works around the Cygwin bug.
2940 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2941 that glib signal handling is tickled before glib creates threads.
2942
2943 * process.c (wait_reading_process_output): Avoid int overflow
2944 when reading more than 2 GiB total from a process.
2945
29462013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * process.c (create_process): Handle a couple more cases,
2949 i.e., work even if new_argv and wait_child_setup[i] are cached.
2950 Use Fcall_process's style for volatile vars.
2951
29522013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2953
2954 * process.c (create_process): Mark PROCESS volatile.
2955
29562013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 Use C99-style flexible array members if available.
2959 This avoids some subtle aliasing issues, which typically
2960 aren't a problem with GCC but may be a problem elsewhere.
2961 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2962 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2963 In either case, it uses a flexible array member rather than
2964 the old struct hack. All uses changed.
2965 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2966 Adjust to sdata reorganization.
2967 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2968 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2969 that ports better to pre-C99 non-GCC.
2970 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2971 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2972 as the latter has changed.
2973 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2974 and port better to pre-C99 GCC.
2975 * image.c (struct xpm_cached_color):
2976 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2977 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2978 Use FLEXIBLE_ARRAY_MEMBER.
2979 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2980 Move decl to top level so it gets checked against implementation.
2981 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2982 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2983
29842013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 * syntax.c: Integer cleanups.
2987 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2988 All uses that need 0-or-2 changed to:
2989 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2990 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2991 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2992 (char_quoted, prev_char_comend_first, back_comment)
2993 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2994 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2995 Use bool for boolean.
2996 (update_syntax_table, skip_chars, skip_syntaxes):
2997 Prefer int to unsigned when either will do.
2998 (back_comment): Return boolean success flag, like forw_comment,
2999 instead of positive-or-minus-1 (which might have overflowed int anyway).
3000 Don't stuff ptrdiff_t into int.
3001 (syntax_spec_code, syntax_code_spec): Now const.
3002 (Fmatching_paren, scan_lists, scan_sexps_forward):
3003 Use enum syntaxcode for syntax code.
3004 (Fmatching_paren): Check that arg is a character, not just an integer.
3005 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3006 (Finternal_describe_syntax_value): Omit no-longer-needed
3007 comparison to 0.
3008 (skip_chars): Use char, not unsigned char, when the distinction
3009 doesn't matter.
3010 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3011 * bytecode.c (exec_byte_code):
3012 * syntax.c (syntax_spec_code, Fchar_syntax)
3013 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3014 (init_syntax_once):
3015 * syntax.h (SYNTAX_WITH_FLAGS):
3016 Omit unnecessary casts.
3017
30182013-06-20 Eli Zaretskii <eliz@gnu.org>
3019
3020 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3021 line dimensions here, to avoid race conditions with the main
3022 thread. (Bug#14062, bug#14630, bug#14669)
3023
3024 * w32term.c (w32_draw_window_cursor): Compute the header line and
3025 mode line dimensions here.
3026 <w32_system_caret_window, w32_system_caret_hdr_height>:
3027 <w32_system_caret_mode_height>: New variables.
3028
3029 * w32term.h: Declare them.
3030
30312013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3032
3033 * alloc.c (die): Move "assertion failed" string here ...
3034 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3035 COND when SUPPRESS_CHECKING. This shrinks the executable text
3036 size by 0.8% to 2.2% when configured with --enable-checking,
3037 depending on optimization flags (GCC 4.8.1 x86-64).
3038
3039 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3040
30412013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
3042
3043 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3044 base is 2; this is more accurate.
3045
30462013-06-19 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * sound.c (string_default): Move to !WINDOWSNT section.
3049 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3050
30512013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 * sound.c: Integer cleanups.
3054 Remove unnecessary forward decls.
3055 (struct sound_device): The 'file' member is now a Lisp_Object, not
3056 a char *, so that we needn't invoke alloca on a huge size.
3057 (Fplay_sound_internal): Adjust to this.
3058 (string_default): New function.
3059 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3060 Use it to adjust to the struct sound_device change.
3061 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3062 (be2hs) [0]: Remove.
3063
3064 * syntax.c (skip_chars): Don't use uninitialized storage
3065 when searching a multibyte buffer for characters that are not in a
3066 unibyte string that contains non-ASCII characters.
3067
30682013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3069
3070 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3071 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3072
30732013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3076
30772013-06-18 Kenichi Handa <handa@gnu.org>
3078
3079 * font.c (Ffont_spec): Signal an error for an invalid font name
3080 (Bug#14648).
3081
30822013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3085 In particular this ports to 32-bit sparc Sun cc.
3086 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3087 array with a dummy element at specpdl[-1], so that its address can
3088 be taken portably.
3089 (unbind_to): Do not copy the binding; not needed, now that we
3090 copy old_value in the one place where the copy is needed.
3091 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3092 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3093 (union specbinding): Rename from struct specbinding. Redo layout
3094 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3095 which is not portable. With Sun C 5.12 32-bit sparc, the
3096 declaration causes nargs to be an unsigned bitfield, a behavior
3097 that the C standard allows; but Emacs wants nargs to be signed.
3098 The overall type is now a union of structures rather than a
3099 structure of union of structures, and the 'kind' member is now a
3100 bitfield, so that the overall type doesn't grow. All uses changed.
3101 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3102
31032013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3106 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3107
3108 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3109
31102013-06-17 Eli Zaretskii <eliz@gnu.org>
3111
3112 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3113 unless we know that the window w's frame is a frame object.
3114 Another attempt at solving bug#14062 and bug#14630.
3115
31162013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3117
3118 * textprop.c (property_set_type): New enum.
3119 (add_properties): Allow appending/prepending text properties.
3120 (add_text_properties_1): Factored out of Fadd_text_properties.
3121 (Fadd_text_properties): Move all the code into
3122 add_text_properties_1.
3123 (Fadd_face_text_property): New function that calls
3124 add_text_properties_1.
3125
31262013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 Move functions from lisp.h to individual modules when possible.
3129 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3130 * alloc.c (XFLOAT_INIT, set_symbol_name):
3131 * buffer.c (CHECK_OVERLAY):
3132 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3133 (set_char_table_parent):
3134 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3135 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3136 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3137 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3138 (set_blv_valcell):
3139 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3140 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3141 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3142 (backtrace_args, backtrace_debug_on_exit):
3143 * floatfns.c (CHECK_FLOAT):
3144 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3145 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3146 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3147 (set_hash_index_slot):
3148 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3149 * marker.c (CHECK_MARKER):
3150 * textprop.c (CHECK_STRING_OR_BUFFER):
3151 * window.c (CHECK_WINDOW_CONFIGURATION):
3152 Move here from lisp.h, and make these functions static rather than
3153 extern inline.
3154 * buffer.c (Qoverlayp):
3155 * data.c (Qsubrp):
3156 * fns.c (Qhash_table_p):
3157 * window.c (Qwindow_configuration_p):
3158 Now static.
3159 * lisp.h: Remove the abovementioned defns and decls.
3160
3161 Use functions, not macros, for XINT etc (Bug#11935).
3162 In lisp.h, prefer functions to function-like macros, and
3163 constants to object-like macros, when either will do. This:
3164 . simplifies use, as there's no more need to worry about
3165 arguments' side effects being evaluated multiple times.
3166 . makes the code easier to debug on some platforms.
3167 However, when using gcc -O0, keep using function-like macros
3168 for a few critical operations, for performance reasons.
3169 This sort of thing isn't needed with gcc -Og, but -Og
3170 is a GCC 4.8 feature and isn't widely-enough available yet.
3171 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3172 Remove enum lsb_bits; no longer needed.
3173 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3174 * buffer.c (Qoverlap):
3175 * data.c (Qsubrp):
3176 * fns.c (Qhash_table_p):
3177 Now extern, so lisp.h can use these symbols.
3178 * dispextern.h: Include character.h, for MAX_CHAR etc.
3179 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3180 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3181 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3182 (GLYPH_CODE_P): Move here from lisp.h.
3183 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3184 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3185 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3186 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3187 XUNTAG now returns void *.
3188 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3189 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3190 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3191 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3192 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3193 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3194 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3195 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3196 New macros, renamed from their sans-lisp_h_ counterparts.
3197 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3198 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3199 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3200 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3201 If compiling via GCC without optimization, define these as macros
3202 in addition to inline functions.
3203 To disable this, compile with -DINLINING=0.
3204 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3205 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3206 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3207 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3208 (INTMASK, VALMASK): Now macros, since static values cannot be
3209 accessed from extern inline functions.
3210 (VALMASK): Also a constant, for benefit of old GDB.
3211 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3212 is INTEGERP, which can fold it in.
3213 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
3214 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3215 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3216 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3217 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3218 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3219 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3220 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3221 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3222 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3223 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3224 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3225 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3226 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3227 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3228 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3229 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3230 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3231 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3232 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3233 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3234 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3235 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3236 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3237 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3238 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3239 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3240 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3241 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3242 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3243 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3244 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3245 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3246 Now functions.
3247 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3248 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3249 (VALMASK): Define in one place rather than in two, merging the
3250 USE_LSB_TAG parts; this is simpler.
3251 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3252 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3253 Move up, to avoid use before definition.
3254 Also include "globals.h" earlier, for the same reason.
3255 (make_natnum): New function.
3256 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3257 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3258 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3259 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3260 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3261 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3262 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3263 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3264 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3265 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3266 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3267 (Qwindow_configuration_p, Qimage): New forward declarations.
3268 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3269 (STRING_COPYIN): Remove; unused.
3270 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3271 (xcar_addr, xcdr_addr): New functions. All uses changed.
3272 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3273 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3274 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3275 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3276 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3277 (TYPE_RANGED_INTEGERP): Simplify.
3278 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3279 (setlocale, fixup_locale, synchronize_system_messages_locale)
3280 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3281 Now empty functions, not macros.
3282 (functionp): Return bool, not int.
3283 * window.c (Qwindow_configuration_p): Now extern,
3284 so window.h can use it.
3285 * window.h (Qwindowp): Move decl back to lisp.h.
3286
32872013-06-15 Eli Zaretskii <eliz@gnu.org>
3288
3289 * xdisp.c (Fline_pixel_height): New function, required for solving
3290 bug #14567.
3291
32922013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3295
32962013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3297
3298 * lread.c (syms_of_lread):
3299 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3300
33012013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3302
3303 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3304
33052013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3306
3307 * fileio.c (expand_file_name): Doc fix.
3308
33092013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3312 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3313 Wait for self, not for 0. This can't hurt on GNU or similar
3314 system, and may help with Cygwin.
3315
3316 * keyboard.c: Don't use PROP (...) as an lvalue.
3317 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3318 Use set_prop (A, B), not PROP (A) = B.
3319
33202013-06-10 Eli Zaretskii <eliz@gnu.org>
3321
3322 * xdisp.c (get_it_property): Use it->window instead of generating
3323 a Lisp object from it->w.
3324
33252013-06-09 Eli Zaretskii <eliz@gnu.org>
3326
3327 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3328 get-char-property the window that is being rendered, instead of
3329 the buffer, to support window-specific overlays. (Bug#14575)
3330 (compute_display_string_pos): When W is NULL, use the current
3331 buffer as the object to pass to get-char-property.
3332 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3333 pointer member of the bidi iterator, since no window is pertinent
3334 to this function.
3335
33362013-06-08 Eli Zaretskii <eliz@gnu.org>
3337
3338 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3339 being displayed, and pass it to compute_display_string_pos.
3340 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3341 (bidi_paragraph_init): All callers changed.
3342
3343 * xdisp.c (init_from_display_pos, init_iterator)
5747 (handle_single_display_spec, next_overlay_string) 3344 (handle_single_display_spec, next_overlay_string)
5748 (get_overlay_strings_1, reseat_1, reseat_to_string) 3345 (get_overlay_strings_1, reseat_1, reseat_to_string)
5749 (push_display_prop): Set up the `unibyte' member of bidi_it.string 3346 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
5750 correctly. Don't assume unibyte strings are not bidi-reordered. 3347 Set bidi_it.w member from it->w.
5751 (compute_display_string_pos) 3348 (compute_display_string_pos): Accept additional argument, the
5752 (compute_display_string_end): Fix handling the case of C string. 3349 window being displayed, and pass it to Fget_char_property.
5753 (push_it, pop_it): Save and restore from_disp_prop_p. 3350 (Bug#14575)
5754 (handle_single_display_spec, push_display_prop): Set the
5755 from_disp_prop_p flag.
5756 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5757 (pop_it): Call iterate_out_of_display_property only if we are
5758 popping after iteration over a string that came from a display
5759 property. Fix a typo in popping stretch info. Add an assertion
5760 for verifying that the iterator position is in sync with the bidi
5761 iterator.
5762 (handle_single_display_spec, get_overlay_strings_1)
5763 (push_display_prop): Fix initialization of paragraph direction for
5764 string when that of the parent object is not yet determined.
5765 (reseat_1): Call bidi_init_it to resync the bidi
5766 iterator with IT's position. (Bug#7616)
5767 (find_row_edges): If ROW->start.pos gives position
5768 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5769 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5770 Reset the from_disp_prop_p flag.
5771 (SAVE_IT, RESTORE_IT): New macros.
5772 (pos_visible_p, face_before_or_after_it_pos)
5773 (back_to_previous_visible_line_start)
5774 (move_it_in_display_line_to, move_it_in_display_line)
5775 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5776 (try_scrolling, redisplay_window, display_line): Use them when
5777 saving a temporary copy of the iterator and restoring it back.
5778 (back_to_previous_visible_line_start, reseat_1)
5779 (init_iterator): Empty the bidi cache "stack".
5780 (move_it_in_display_line_to): If iterator ended up at
5781 EOL, but we never saw any buffer positions smaller than
5782 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5783 motion in bidi-reordered lines.
5784 (move_it_in_display_line_to): Record prev_method and prev_pos
5785 immediately before the call to set_iterator_to_next. Fixes cursor
5786 motion in bidi-reordered lines with stretch glyphs and strings
5787 displayed in margins. (Bug#8133) (Bug#8867)
5788 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5789 TO_CHARPOS.
5790 (pos_visible_p): Support positions in bidi-reordered lines.
5791 Save and restore bidi cache.
5792
5793 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5794 (bidi_paragraph_info): Delete unused struct.
5795 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5796 (bidi_cache_start): New variable.
5797 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5798 to zero.
5799 (bidi_cache_fetch_state, bidi_cache_search)
5800 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5801 (bidi_cache_find, bidi_peek_at_next_level)
5802 (bidi_level_of_next_char, bidi_find_other_level_edge)
5803 (bidi_move_to_visually_next): Compare cache index with
5804 bidi_cache_start rather than with zero.
5805 (bidi_fetch_char): Accept new argument STRING; all callers
5806 changed. Support iteration over a string. Support strings with
5807 display properties. Support unibyte strings. Fix the type of
5808 `len' according to what STRING_CHAR_AND_LENGTH expects.
5809 (bidi_paragraph_init, bidi_resolve_explicit_1)
5810 (bidi_resolve_explicit, bidi_resolve_weak)
5811 (bidi_level_of_next_char, bidi_move_to_visually_next):
5812 Support iteration over a string.
5813 (bidi_set_sor_type, bidi_resolve_explicit_1)
5814 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5815 can now be zero (for strings); special values 0 and -1 were
5816 changed to -1 and -2, respectively.
5817 (bidi_char_at_pos): New function.
5818 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5819 Call it instead of FETCH_MULTIBYTE_CHAR.
5820 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5821 initialized to valid values.
5822 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5823 values.
5824 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5825 the test for valid cached positions. Fix the logic for looking up
5826 the sentinel state in the cache. GCPRO the Lisp string we are
5827 iterating.
5828 (bidi_push_it, bidi_pop_it): New functions.
5829 (bidi_initialize): Initialize the bidi cache start stack pointer.
5830 (bidi_cache_ensure_space): New function, refactored from part of
5831 bidi_cache_iterator_state. Don't assume the required size is just
5832 one BIDI_CACHE_CHUNK away.
5833 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5834 (bidi_count_bytes, bidi_char_at_pos): New functions.
5835 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5836 always valid if bidi_cache_idx is valid.
5837 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5838 is valid if it's going to be used.
5839 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5840 (bidi_cache_fetch_state, bidi_cache_search)
5841 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5842 (bidi_cache_iterator_state, bidi_cache_find)
5843 (bidi_find_other_level_edge, bidi_cache_start_stack):
5844 All variables related to cache indices are now EMACS_INT.
5845
5846 * dispextern.h (struct bidi_string_data): New structure.
5847 (struct bidi_it): New member `string'. Make flag members be 1-bit
5848 fields, and put them last in the struct.
5849 (compute_display_string_pos, compute_display_string_end):
5850 Update prototypes.
5851 (bidi_push_it, bidi_pop_it): Add prototypes.
5852 (struct iterator_stack_entry): New members bidi_p,
5853 paragraph_embedding, and from_disp_prop_p.
5854 (struct it): Member bidi_p is now a bit field 1 bit wide.
5855 (bidi_shelve_cache, bidi_unshelve_cache):
5856 Declare prototypes.
5857
5858 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5859 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5860 and vector-like objects.
5861
5862 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5863 cache around display iteration.
5864
5865 * window.c (Fwindow_end, window_scroll_pixel_based)
5866 (displayed_window_lines, Frecenter): Save and restore the bidi
5867 cache around display iteration.
5868
58692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5870
5871 * editfns.c (Fdelete_region): Clarify the use of the named
5872 parameters (bug#6788).
5873
58742011-07-14 Martin Rudalics <rudalics@gmx.at>
5875
5876 * indent.c (Fvertical_motion): Set and restore w->pointm when
5877 saving and restoring the window's buffer (Bug#9006).
5878
58792011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5880
5881 * editfns.c (Fstring_to_char): Clarify just what is returned
5882 (bug#6576). Text by Eli Zaretskii.
5883
58842011-07-13 Juanma Barranquero <lekktu@gmail.com>
5885
5886 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5887
58882011-07-13 Eli Zaretskii <eliz@gnu.org>
5889
5890 * buffer.c (mmap_find): Fix a typo.
5891
58922011-07-13 Johan Bockgård <bojohan@gnu.org>
5893
5894 Fix execution of x selection hooks.
5895 * xselect.c (Qx_lost_selection_functions)
5896 (Qx_sent_selection_functions): New vars.
5897 (syms_of_xselect): DEFSYM them.
5898 (x_handle_selection_request): Pass Qx_sent_selection_functions
5899 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5900 (x_handle_selection_clear,x_clear_frame_selections):
5901 Pass Qx_lost_selection_functions rather than
5902 Vx_lost_selection_functions to Frun_hook_with_args.
5903
59042011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5907 The old code sometimes used this field without initializing it.
5908
5909 * alloc.c (gc_sweep): Don't read past end of array.
5910 In theory, the old code could also have corrupted Emacs internals,
5911 though it'd be very unlikely.
5912
59132011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5914
5915 * character.c (Fcharacterp): Don't advertise optional ignored
5916 argument. (Bug#4026)
5917
59182011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5919
5920 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5921 key" (bug#4257).
5922
5923 * window.c (Fset_window_start): Doc fix (bug#4199).
5924 (Fset_window_hscroll): Ditto.
5925
59262011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 Fix minor new problems caught by GCC 4.6.1.
5929 * term.c (init_tty): Remove unused local.
5930 * xsettings.c (store_monospaced_changed): Define this function only
5931 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5932 not used otherwise.
5933
59342011-07-12 Chong Yidong <cyd@stupidchicken.com>
5935
5936 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5937
59382011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5939
5940 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5941 are the mini-buffer and the echo area (bug#3320).
5942
5943 * term.c (init_tty): Remove support for supdup, c10 and perq
5944 terminals, which are no longer supported (bug#1482).
5945
59462011-07-10 Johan Bockgård <bojohan@gnu.org>
5947
5948 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5949
59502011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5951
5952 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5953 for non-popups (Bug#3642).
5954
59552011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5956
5957 * alloc.c (reset_malloc_hooks): Protoize.
5958 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5959 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5960 * cm.c (losecursor): Likewise.
5961 * data.c (fmod): Likewise.
5962 * dispnew.c (swap_glyphs_in_rows): Likewise.
5963 * emacs.c (memory_warning_signal): Likewise.
5964 * floatfns.c (float_error): Likewise.
5965 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5966 (otf_open, font_otf_capability, generate_otf_features)
5967 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5968 Likewise.
5969 * image.c (pbm_read_file): Likewise.
5970 * indent.c (string_display_width): Likewise.
5971 * intervals.c (check_for_interval, search_for_interval)
5972 (inc_interval_count, count_intervals, root_interval)
5973 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5974 * lread.c (defalias): Likewise.
5975 * ralloc.c (r_alloc_check): Likewise.
5976 * regex.c (set_image_of_range_1, set_image_of_range)
5977 (regex_grow_registers): Likewise.
5978 * sysdep.c (strerror): Likewise.
5979 * termcap.c (valid_filename_p, tprint, main): Likewise.
5980 * tparam.c (main): Likewise.
5981 * unexhp9k800.c (run_time_remap, save_data_space)
5982 (update_file_ptrs, read_header, write_header, calculate_checksum)
5983 (copy_file, copy_rest, display_header): Likewise.
5984 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5985 Likewise.
5986 * xdisp.c (check_it): Likewise.
5987 * xfaces.c (register_color, unregister_color, unregister_colors):
5988 Likewise.
5989 * xfns.c (print_fontset_result): Likewise.
5990 * xrdb.c (member, fatal, main): Likewise.
5991
59922011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 Fix minor problems found by static checking (Bug#9031).
5995 * chartab.c (char_table_set_range, map_sub_char_table):
5996 Remove unused locals.
5997 (uniprop_table): Now static.
5998 * composite.c (_work_char): Remove unused static var.
5999
60002011-07-09 Juanma Barranquero <lekktu@gmail.com>
6001 3351
6002 * chartab.c (uniprop_table_uncompress): Remove unused local variable. 3352 * dispextern.h (struct bidi_it): New member w, the window being
3353 displayed.
3354 (compute_display_string_pos): Adjust prototype.
6003 3355
60042011-07-09 Jan Djärv <jan.h.d@swipnet.se> 33562013-06-08 Jan Djärv <jan.h.d@swipnet.se>
6005 3357
6006 * gtkutil.c (qttip_cb): Remove code without function. 3358 * xgselect.c: Remove unneeded include xterm.h.
6007 3359
60082011-07-09 Eli Zaretskii <eliz@gnu.org> 3360 * process.c (wait_reading_process_output): Check for NS before GLIB.
3361 GLIB may be linked in due to rsvg, but ns_select must be called.
6009 3362
6010 * w32.c (pthread_sigmask): New stub. 3363 * xgselect.c (xg_select): Remove call to window_system_available
3364 and g_main_context_pending at the top, so Gdk events (i.e. file
3365 notify) are processed when Emacs is started with -nw.
6011 3366
60122011-07-08 Paul Eggert <eggert@cs.ucla.edu> 33672013-06-07 Eli Zaretskii <eliz@gnu.org>
6013 3368
6014 Use pthread_sigmask, not sigprocmask (Bug#9010). 3369 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
6015 sigprocmask is portable only for single-threaded applications, and 3370 (ctagsfiles3): New variable, includes only *.m files.
6016 Emacs can be multi-threaded when it uses GTK. 3371 (TAGS): Use an explicit language name in the regular expressions,
6017 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro. 3372 to avoid transformation of '/SOMETHING' by MSYS to
6018 (LIBES): Use it. 3373 'c:\MSYS\SOMETHING'.
6019 * callproc.c (Fcall_process):
6020 * process.c (create_process):
6021 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6022 Use pthread_sigmask, not sigprocmask.
6023
60242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6025 3374
6026 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget. 33752013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
6027 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6028 wrong (Bug#8591).
6029 3376
60302011-07-08 Jan Djärv <jan.h.d@swipnet.se> 3377 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
6031 3378
6032 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment. 33792013-06-06 Eli Zaretskii <eliz@gnu.org>
6033 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6034 (xg_hide_tooltip): Fix comment.
6035 3380
6036 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types 3381 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
6037 in registerServicesMenuSendTypes. 3382 still need to set the mouse pointer shape and activate help-echo.
6038 (validRequestorForSendType): Don't check ns_return_types. 3383 (Bug#14558)
6039 3384
6040 * nsfns.m (Fx_open_connection): Put NSStringPboardType into 33852013-06-06 Paul Eggert <eggert@cs.ucla.edu>
6041 ns_return_type.
6042 3386
60432011-07-08 Jason Rumney <jasonr@gnu.org> 3387 A few porting etc. fixes for the new file monitor code.
3388 See the thread containing
3389 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3390 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3391 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3392 (dir_monitor_callback, Fgfile_rm_watch):
3393 Use assq_no_quit instead of Fassoc, for speed.
3394 (dir_monitor_callback, Fgfile_rm_watch):
3395 eassert that the monitor is a fixnum.
3396 (dir_monitor_callback): No need for CDR_SAFE.
3397 Simplify building of lisp with alternative tails.
3398 (Fgfile_add_watch, Fgfile_rm_watch):
3399 Do not assume glib functions set errno reliably on failure.
3400 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3401 and signal an error otherwise.
3402 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3403 Use Fdelq instead of Fdelete, for speed.
6044 3404
6045 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than 34052013-06-05 Eli Zaretskii <eliz@gnu.org>
6046 SH_SHOW for hidden windows (Bug#5482).
6047 3406
6048 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using 3407 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
6049 frame struct members of non-existent frames (Bug#6284). 3408 don't insist on being invoked on a highlighted tool-bar button.
3409 Avoids losing tool-bar functionality when mouse-highlight is nil.
3410 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3411 Don't highlight when mouse-highlight is nil.
3412 (note_mouse_highlight): When mouse-highlight is nil, don't return
3413 right away; instead, run tool-bar and mode-line highlight
3414 subroutine, clear any existing highlight, and revert the mouse
3415 pointer to its default shape. (Bug#14558)
6050 3416
60512011-07-08 Jan Djärv <jan.h.d@swipnet.se> 34172013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
6052 3418
6053 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and 3419 * lisp.mk (lisp): Add prog-mode.el.
6054 variable firstTime not needed on OSX >= 10.6.
6055 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6056 >= 10.5. Use setKnobProportion, setDoubleValue.
6057 3420
6058 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4) 34212013-06-05 Paul Eggert <eggert@cs.ucla.edu>
6059 (MAC_OS_X_VERSION_10_5): Define if not defined.
6060 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6061 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6062 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6063 3422
6064 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods 3423 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
6065 cString and lossyCString on OSX >= 10.4 3424 * process.c (dummy_handler): New function.
3425 (lib_child_handler): New static var.
3426 (handle_child_signal): Invoke it.
3427 (catch_child_signal): If a library has set up a signal handler,
3428 save it into lib_child_handler.
3429 (init_process_emacs): If using glib and not on Windows, tickle glib's
3430 child-handling code so that it initializes its private SIGCHLD handler.
3431 * syssignal.h (SA_SIGINFO): Default to 0.
3432 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3433 31; it should no longer be needed now.
6066 3434
6067 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method 34352013-06-05 Michael Albinus <michael.albinus@gmx.de>
6068 sizeToFit on OSX >= 10.2.
6069 3436
6070 * nsimage.m (allocInitFromFile): Don't use deprecated method 3437 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
6071 bestRepresentationForDevice on OSX >= 10.6.
6072 3438
6073 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error 3439 * gfilenotify.c (globals_of_gfilenotify): New function.
6074 to avoid warning. 3440 (syms_of_gfilenotify): Move global initialization there.
6075 3441
6076 * emacs.c: Declare unexec_init_emacs_zone. 3442 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
6077 3443
6078 * nsgui.h: Fix compiler warning about gnulib redefining verify. 34442013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
6079 3445
6080 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842). 3446 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3447 * keyboard.c (menu_bar_items, tool_bar_items):
3448 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3449 not override local keymaps any more.
6081 3450
6082 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call 34512013-06-04 Eli Zaretskii <eliz@gnu.org>
6083 on svcsMenu (Bug#8842).
6084 3452
6085 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from 3453 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
6086 ns_return_types.
6087 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6088 3454
6089 * nsterm.m (QUTF8_STRING): Declare. 34552013-06-03 Eli Zaretskii <eliz@gnu.org>
6090 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6091 (validRequestorForSendType): Return type is (id).
6092 Change indexOfObjectIdenticalTo to indexOfObject.
6093 Check if we have local selection before returning self (Bug#8842).
6094 (writeSelectionToPasteboard): Put local selection into paste board
6095 if we have a local selection (Bug#8842).
6096 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6097 3456
6098 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m. 3457 * w32console.c (initialize_w32_display): Return the dimensions of
6099 (ns_get_local_selection): Declare. 3458 the console window via 2 additional arguments, not via the current
3459 frame. This avoids crashes due to overrunning the bounds of
3460 frame's decode_mode_spec_buffer, which is not resized following
3461 the change of the frame dimensions from the initial 10x10.
6100 3462
61012011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org> 3463 * w32term.h (w32_initialize_display_info): Adjust prototype.
6102 3464
6103 * keymap.c (describe_map_tree): Don't insert a double newline at 3465 * term.c (init_tty): Take dimensions of the frame from the values
6104 the end of the buffer (bug#1169) and return whether we inserted 3466 returned by initialize_w32_display.
6105 something.
6106 3467
6107 * callint.c (Fcall_interactively): Change "reading args" to 3468 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
6108 "providing args" to try to clarify what it does (bug#1010). 3469 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3470 (LIBES): Add $(GFILENOTIFY_LIBS).
6109 3471
61102011-07-07 Kenichi Handa <handa@m17n.org> 3472 * w32inevt.c (handle_file_notifications): Add dummy implementation
3473 for !HAVE_W32NOTIFY.
6111 3474
6112 * composite.c (composition_compute_stop_pos): Ignore a static 3475 * w32term.c: Wrap code with HAVE_W32NOTIFY.
6113 composition starting before CHARPOS (Bug#8915).
6114 3476
6115 * xdisp.c (handle_composition_prop): Likewise. 34772013-06-03 Jan Djärv <jan.h.d@swipnet.se>
6116 3478
61172011-07-07 Eli Zaretskii <eliz@gnu.org> 3479 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
6118 3480
6119 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what. 3481 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
6120 (Bug#9015)
6121 3482
61222011-07-07 Kenichi Handa <handa@m17n.org> 3483 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
6123 3484
6124 * character.h (unicode_category_t): New enum type. 34852013-06-03 Paul Eggert <eggert@cs.ucla.edu>
6125 3486
6126 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types. 3487 Fix minor problems found by static checking.
6127 (Qchar_code_property_table): New variable. 3488 * data.c (pure_write_error):
6128 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER) 3489 Use xsignal2, not Fsignal, as Fsignal might return.
6129 (UNIPROP_COMPRESSED_FORM_P): New macros. 3490 * eval.c (set_backtrace_debug_on_exit): Now static.
6130 (char_table_ascii): Uncompress the compressed values. 3491 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
6131 (sub_char_table_ref): New arg is_uniprop. Callers changed. 3492 No longer inline. EXTERN_INLINE is needed only for functions
6132 Uncompress the compressed values. 3493 defined in .h files. Reindent function header as per GNU style.
6133 (sub_char_table_ref_and_range): Likewise. 3494 (backtrace_p, backtrace_top, backtrace_next):
6134 (char_table_ref_and_range): Uncompress the compressed values. 3495 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
6135 (sub_char_table_set): New arg is_uniprop. Callers changed. 3496 compiler or linker. Add extern decls to pacify gcc -Wall.
6136 Uncompress the compressed values. 3497 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
6137 (sub_char_table_set_range): Args changed. Callers changed. 3498 Now static.
6138 (char_table_set_range): Adjuted for the above change. 3499 * frame.c (free_monitors): Define only on platforms that need it.
6139 (map_sub_char_table): Delete args default_val and parent. Add arg 3500 * nsterm.m (ns_term_init):
6140 top. Give decoded values to a Lisp function. 3501 * process.c (catch_child_signal):
6141 (map_char_table): Adjust for the above change. Give decoded 3502 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
6142 values to a Lisp function. Gcpro more variables. 3503 defined on all porting targets these days.
6143 (uniprop_table_uncompress) 3504 * process.c, process.h (catch_child_signal):
6144 (uniprop_decode_value_run_length): New functions. 3505 Make it extern only if NS_IMPL_GNUSTEP is defined.
6145 (uniprop_decoder, uniprop_decoder_count): New variables.
6146 (uniprop_get_decoder, uniprop_encode_value_character)
6147 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6148 New functions.
6149 (uniprop_encoder, uniprop_encoder_count): New variables.
6150 (uniprop_get_encoder, uniprop_table)
6151 (Funicode_property_table_internal, Fget_unicode_property_internal)
6152 (Fput_unicode_property_internal): New functions.
6153 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6154 Sunicode_property_table_internal, Sget_unicode_property_internal,
6155 and Sput_unicode_property_internal. Defvar_lisp
6156 char-code-property-alist.
6157
6158 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6159 Vunicode_category_table.
6160
6161 * font.c (font_range): Adjust for the change of
6162 Vunicode_category_table.
6163
61642011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6165
6166 * m/iris4d.h: Remove file, move contents ...
6167 * s/irix6-5.h: ... here.
6168
61692011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6170
6171 Remove unportable assumption about struct layout (Bug#8884).
6172 * alloc.c (mark_buffer):
6173 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6174 (clone_per_buffer_values): Don't assume that
6175 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6176 This isn't true in general, and it's particularly not true
6177 if Emacs is configured with --with-wide-int.
6178 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6179 New macros, used in the buffer.c change.
6180
61812011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6182
6183 * xsettings.c: Use both GConf and GSettings if both are available.
6184 (store_config_changed_event): Add comment.
6185 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6186 (store_tool_bar_style_changed): New functions.
6187 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6188 (struct xsettings): Move font inside HAVE_XFT.
6189 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6190 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6191 Move inside HAVE_XFT.
6192 (something_changed_gsettingsCB): Rename from something_changedCB.
6193 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6194 also.
6195 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6196 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6197 (something_changed_gconfCB): Rename from something_changedCB.
6198 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6199 (parse_settings): Move check for font inside HAVE_XFT.
6200 (read_settings, apply_xft_settings): Add comment.
6201 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6202 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6203 call store_font_name_changed.
6204 (xft_settings_event): Add comment.
6205 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6206 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6207 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6208 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6209 (xsettings_initialize): Call init_gsettings last.
6210 (xsettings_get_system_font, xsettings_get_system_normal_font):
6211 Add comment.
6212 3506
62132011-07-05 Paul Eggert <eggert@cs.ucla.edu> 35072013-06-03 Eli Zaretskii <eliz@gnu.org>
6214 3508
6215 Random fixes. E.g., (random) never returned negative values. 3509 * w32.c (gettimeofday): Make the signature identical to prototype
6216 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the 3510 in nt/inc/sys/time.h.
6217 subseconds part to the entropy, as that's a bit more random.
6218 Prefer signed to unsigned, since the signedness doesn't matter and
6219 in general we prefer signed. When given a limit, use a
6220 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6221 latter isn't right if USE_2_TAGS_FOR_INTS.
6222 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6223 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6224 3511
62252011-07-04 Stefan Monnier <monnier@iro.umontreal.ca> 35122013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
6226 3513
6227 * textprop.c (text_property_stickiness): 3514 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
6228 Obey Vtext_property_default_nonsticky. 3515 .gdbinit.
6229 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6230 * w32fns.c (syms_of_w32fns):
6231 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6232 3516
62332011-07-04 Paul Eggert <eggert@cs.ucla.edu> 3517 * keyboard.c (safe_run_hooks_error): Improve error message.
6234 3518
6235 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR. 3519 * data.c (pure_write_error): Add `object' argument.
6236 This is more efficient than Ffile_directory_p and avoids a minor race. 3520 * puresize.h (CHECK_IMPURE): Use it.
6237 3521
62382011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org> 35222013-06-03 Michael Albinus <michael.albinus@gmx.de>
6239 3523
6240 * buffer.c (Foverlay_put): Say what the return value is 3524 * Makefile.in (NOTIFY_OBJ): New variable.
6241 (bug#7835). 3525 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
6242 3526
6243 * fileio.c (barf_or_query_if_file_exists): Check first if the file 3527 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
6244 is a directory before asking whether to use the file name 3528 Call syms_of_gfilenotify.
6245 (bug#7564).
6246 (barf_or_query_if_file_exists): Make the "File is a directory"
6247 error be more correct.
6248 3529
6249 * fns.c (Frequire): Remove the mention of the .gz files, since 3530 * gfilenotify.c: New file.
6250 that's installation-specific, but keep the mention of
6251 `get-load-suffixes'.
6252 3531
62532011-07-04 Paul Eggert <eggert@cs.ucla.edu> 3532 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3533 and Qfile_w32notify.
3534 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3535 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
6254 3536
6255 * editfns.c (Fformat_time_string): Don't assume strlen fits in int. 3537 * lisp.h: Declare syms_of_gfilenotify.
6256 Report string overflow if the output is too long.
6257 3538
62582011-07-04 Juanma Barranquero <lekktu@gmail.com> 3539 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
6259 3540
6260 * gnutls.c (Fgnutls_boot): Don't mention :verify-error. 35412013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
6261 (syms_of_gnutls): Remove duplicate DEFSYM for
6262 Qgnutls_bootprop_verify_hostname_error, an error for
6263 Qgnutls_bootprop_verify_error (which is no longer used).
6264 3542
6265 * eval.c (find_handler_clause): Remove parameters `sig' and `data', 3543 Merge the specpdl and backtrace stacks. Make the structure of the
6266 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed. 3544 specpdl entries more obvious via a tagged union of structs.
6267 Also (re)move comments that are misplaced or no longer relevant. 3545 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3546 (enum specbind_tag): New enum.
3547 (struct specbinding): Make it a tagged union of structs.
3548 Add a case for backtrace records.
3549 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3550 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3551 (backtrace_debug_on_exit): New accessors.
3552 (struct backtrace): Remove.
3553 (struct catchtag): Remove backlist field.
3554 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3555 Move to eval.c.
3556 (Flocal_variable_p): Speed up the common case where the binding is
3557 already loaded.
3558 * eval.c (backtrace_list): Remove.
3559 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3560 (set_backtrace_args, set_backtrace_nargs)
3561 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3562 (backtrace_next): New functions.
3563 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3564 (unwind_to_catch, internal_lisp_condition_case)
3565 (internal_condition_case, internal_condition_case_1)
3566 (internal_condition_case_2, internal_condition_case_n): Don't bother
3567 with backtrace_list any more.
3568 (Fsignal): Adjust to new backtrace format.
3569 (grow_specpdl): Move up.
3570 (record_in_backtrace): New function.
3571 (eval_sub, Ffuncall): Use it.
3572 (apply_lambda): Adjust to new backtrace format.
3573 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3574 data.c.
3575 (specbind): Adjust to new specpdl format. Simplify.
3576 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3577 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3578 backtrace format.
3579 (mark_backtrace): Remove.
3580 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3581 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3582 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3583 Use mark_specpdl.
3584 * profiler.c (record_backtrace): Use get_backtrace.
3585 (handle_profiler_signal): Use backtrace_top_function.
3586 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3587 accessor functions.
3588
35892013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3590
3591 * process.h (catch_child_signal): Declare.
3592
3593 * process.c (catch_child_signal): New function.
3594 (init_process_emacs): Call it.
3595
3596 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3597 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3598 NS_IMPL_COCOA.
3599 (x_set_cursor_type): Remove declaration.
3600 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3601 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3602 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3603 (ns_get_color): Use F suffix on float.
3604 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3605 (ns_get_rgb_color): Remove.
3606 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3607 (note_mouse_movement): x and y are CGFloat.
3608 (ns_draw_fringe_bitmap): Remove unused rowY.
3609 Change #if to COCOA && >= 10_6.
3610 (ns_draw_window_cursor): Remove unused overspill.
3611 (ns_draw_underwave): width and x are EamcsCGFloat.
3612 (ns_draw_box): thickness is CGFloat.
3613 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3614 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3615 if not in main thread.
3616 (ns_get_pending_menu_title, ns_check_menu_open)
3617 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3618 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3619 (sendFromMainThread:): New method.
3620 (changeFont:): size is CGFloat.
3621 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3622 Disable warning about permanent text.
3623 (characterIndexForPoint:): Adjust return type depending on GNUStep
3624 version.
3625 (mouseDown:): delta is CGFloat.
3626 (updateFrameSize): Remove unised variable f.
3627 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3628 Cast float to EmacsCGFloat.
3629 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3630 also to -1 when restoring.
3631 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3632 inside NS_IMPL_COCOA.
3633 (toggleFullScreen:): Put call to toggleFullScreen inside
3634 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3635 (setPosition:portion:whole:): por is CGFloat.
3636 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3637 (mouseDown:): Use CGFloat.
3638 (mouseDragged:): Remove unised variable edge.
3639 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3640
3641 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3642 of CGFloat differs.
3643 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3644 when NS_IMPL_GNUSTEP.
3645 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3646 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3647 (EmacsToolbar): Add clearAll. Add tag argument to
3648 addDisplayItemWithImage.
3649 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3650
3651 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3652
3653 * nsmenu.m (ns_update_menubar): Make static.
3654 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3655 (fillWithWidgetValue:): Add cast to SEL for setAction.
3656 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3657 (update_frame_tool_bar): Update code for GNUStep.
3658 (clearAll): New method.
3659 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
3660 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
3661 Move identifierToItem setObject and activeIdentifiers addObject before
3662 call to insertItemWithItemIdentifier.
3663 (validateVisibleItems): Fix indentation.
3664 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3665 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3666 UtilityWindow to aStyle, remove call to setStyleMask.
3667
3668 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3669
3670 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3671 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3672 Use F suffix on floats.
3673 (ns_char_width): Returns CGFloat.
3674 (ns_ascii_average_width): w is CGFloat instead of float.
3675 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
3676 DPSxshow.
3677 (ns_glyph_metrics): CGFloat instead of float.
3678
3679 * nsfns.m (x_set_foreground_color, x_set_background_color):
3680 Use EmacsCGFloat.
3681 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3682 remove unused variables.
3683 (Fns_read_file_name): Keep track if panel is for save.
3684 Use ns_filename_from_panel/ns_directory_from_panel.
3685 (Fns_list_services): delegate only used for COCOA.
3686 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3687 Just return the input if GNUStep.
3688 (x_screen_planes): Remove.
3689 (Fxw_color_values): Use EmacsCGFloat
3690 (Fns_display_monitor_attributes_list): Only get screen number for
3691 Cocoa.
3692 (getDirectory, getFilename): Remove from EmacsOpenPanel and
3693 EmacsSavePanel.
3694 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3695 ns_directory_from_panel.
3696
36972013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * process.c (handle_child_signal): Also use WCONTINUED.
3700 This is so that list-processes doesn't mistakenly list the process
3701 as stopped, when the process has actually been continued and is
3702 now running.
3703
37042013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3705
3706 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3707 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3708 not already configured.
3709
3710 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3711
37122013-05-29 Eli Zaretskii <eliz@gnu.org>
3713
3714 * Makefile.in (mostlyclean): Remove *.res files.
3715
37162013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3717
3718 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3719 a buffer (bug#8447).
3720
37212013-05-27 Eli Zaretskii <eliz@gnu.org>
3722
3723 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3724 display vector, and we backtrack, handle the case that the
3725 previous character position is also displayed from a display
3726 vector or covered by a display string or image. (Bug#14476)
3727
37282013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3729
3730 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3731 (struct MonitorInfo, free_monitors): Remove.
3732 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3733 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3734 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3735 Qframes, Qsource.
3736
3737 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3738 (struct MonitorInfo, free_monitors): Remove.
3739 (ns_screen_name): Make static.
3740 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3741 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3742 Qframes, Qsource.
3743
3744 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3745 (struct MonitorInfo): New struct.
3746 (free_monitors, make_monitor_attribute_list): Declare.
3747
3748 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3749 New Lisp_Object:s.
3750 (free_monitors, make_monitor_attribute_list): New functions.
3751 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3752 Qsource.
3753
37542013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3755
3756 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3757
37582013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3759
3760 * keyboard.c: Apply keyboard decoding only to events that come directly
3761 from the tty, not from unread-command-events (bug#14368).
3762 (read_event_from_main_queue): New function, extracted from read_char).
3763 (read_decoded_char): Remove.
3764 (read_decoded_event_from_main_queue): New function to replace it.
3765 (read_char): Use it.
3766 (read_key_sequence): Use read_char rather than read_decoded_char.
3767
3768 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3769
37702013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3771
3772 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3773
37742013-05-22 Kenichi Handa <handa@gnu.org>
3775
3776 The following changes are to fix the setting of
3777 buffer-file-coding-system on, for instance, C-x RET c unix RET
3778 _FILE_OF_DOS_EOL_TYPE_ RET.
3779
3780 * coding.h (struct coding_system): New member detected_utf8_chars.
3781
3782 * coding.c (detect_coding_utf_8): Count characters and check EOL
3783 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3784 BOM is there.
3785 (setup_coding_system): Do not initialize coding->head_ascii.
3786 (check_ascii): Do not set coding->eol_seen but update it. Do not
3787 call adjust_coding_eol_type here.
3788 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3789 If the eol-type of CODING is already specified, adjust the eol type
3790 of the found coding-system.
3791 (decode_coding_gap): Cancel previous change. Utilize the
3792 character numbers counted by detect_coding_utf_8. Fix detection
3793 of BOM for utf-8.
3794
37952013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3796
3797 * search.c (looking_at_1): Only set last_thing_searched if the match
3798 changed the match-data (bug#14281).
3799
38002013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3801
3802 * xdisp.c (reseat_at_previous_visible_line_start):
3803 Already declared in dispextern.h, so remove it here.
3804 (move_it_vertically_backward): Likewise.
3805
38062013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3807
3808 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
3809 (Fx_display_pixel_width, Fx_display_pixel_height)
3810 (Fx_display_mm_width, Fx_display_mm_height):
3811 Mention `display-monitor-attributes-list' in docstrings.
3812
3813 * nsfns.m (ns_get_screen): Remove function. All uses removed.
3814 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
3815 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3816 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3817 (Fx_display_backing_store, Fx_display_visual_class)
3818 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3819 (Fx_display_grayscale_p, Fx_display_pixel_width)
3820 (Fx_display_pixel_height, Fx_display_planes)
3821 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3822 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3823 (Fx_display_mm_width, Fx_display_mm_height)
3824 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3825 height for all physical monitors as in X11.
3826
3827 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3828 Return pixel width or height for all physical monitors as in X11.
3829
38302013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Port --enable-gcc-warnings to clang.
3833 * bytecode.c (exec_byte_code):
3834 * regex.c:
3835 Redo diagnostic pragmas to pacify clang, too.
3836 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3837 * editfns.c (Fencode_time):
3838 * fileio.c (file_accessible_directory_p):
3839 * font.c (font_unparse_xlfd):
3840 Use '&"string"[index]' instead of '"string" + (index)'.
3841 * undo.c (user_error): Remove; unused.
3842
38432013-05-16 Eli Zaretskii <eliz@gnu.org>
3844
3845 * insdel.c (insert_1_both): Document the arguments, instead of
3846 referring to insert_1, which no longer exists.
3847
3848 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3849 some window, increment windows_or_buffers_changed, so that
3850 *Messages* display in that window is updated. (Bug#14408)
3851
3852 * w32.c: Include epaths.h.
3853 (init_environment): Use cmdproxy.exe without leading directories.
3854 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3855 case.
3856 (gettimeofday): Adjust signature and return value to Posix
3857 expectations.
3858
3859 * unexw32.c (open_output_file): Delete the existing emacs.exe
3860 before creating it, to break the hard link to the versioned
3861 executable.
3862
3863 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3864 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3865 (FIRSTFILE_OBJ): New variables.
3866 (W32_RES): Rename to EMACSRES. All users changed.
3867 (base_obj): Use $(CM_OBJ).
3868 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3869 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3870 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3871 $(W32_RES_LINK) before $(LIBES).
3872 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3873
38742013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3875
3876 * makefile.w32-in (DOC): Use just "DOC".
3877
3878 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3879
3880 * process.c: Export default filters and sentinels to Elisp.
3881 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3882 New constants.
3883 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3884 (Fset_process_sentinel, Fformat_network_address):
3885 Default to them instead of nil.
3886 (server_accept_connection): Sentinels can't be nil any more.
3887 (read_and_dispose_of_process_output): New function, extracted from
3888 read_process_output.
3889 (read_process_output): Use it; filters can't be nil.
3890 (Finternal_default_process_filter): New function, extracted from
3891 read_process_output.
3892 (exec_sentinel_unwind): Remove function.
3893 (exec_sentinel): Don't zilch sentinel while running.
3894 (status_notify): Sentinels can't be nil.
3895 (Finternal_default_process_sentinel): New function extracted from
3896 status_notify.
3897 (setup_process_coding_systems): Default filter is not nil any more.
3898 (syms_of_process): Export new Elisp functions and initialize
3899 new constants.
3900 * lisp.h (make_lisp_proc): New function.
3901
39022013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3903
3904 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3905
39062013-05-14 Eli Zaretskii <eliz@gnu.org>
3907
3908 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3909 unless we know that the window w is a leaf window.
3910 Another attempt at solving bug#14062.
3911
39122013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3913
3914 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3915 fdesc (Bug#14375).
3916
39172013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3918
3919 * image.c (gif_load): Check that subimages fit (Bug#14345).
3920
39212013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3922
3923 * lread.c (skip_dyn_eof): New function.
3924 (read1): Use it to skip the end of a file in response to #@00.
3925
3926 * doc.c (get_doc_string): Slightly relax the sanity checking.
3927
39282013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3929
3930 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3931 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3932 (MonitorInfo): New struct.
3933 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3934 (Fns_display_monitor_attributes_list): New functions.
3935 (display-usable-bounds): Remove.
3936 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3937 Qsource.
3938
39392013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3940
3941 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3942 (GTK_CHECK_VERSION): New macro, if not already defined.
3943 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3944 replaced by GTK_CHECK_VERSION.
3945
39462013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 * xterm.h (GTK_PREREQ): New macro.
3949 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3950 to use this macro instead, for consistency and clarity.
3951
39522013-05-08 Eli Zaretskii <eliz@gnu.org>
3953
3954 * xdisp.c (row_for_charpos_p): New function, with code of
3955 cursor_row_p, but accepts an additional argument CHARPOS instead
3956 of using a hardcoded PT.
3957 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3958 (row_containing_pos): Call row_for_charpos_p instead of partially
3959 doing the same. Fixes cursor positioning under longlines-mode
3960 when longlines-show-effect includes more than one newline, when
3961 moving the cursor vertically up.
3962
39632013-05-08 Juanma Barranquero <lekktu@gmail.com>
3964
3965 * makefile.w32-in (ACL_H): New macro.
3966 ($(BLD)/fileio.$(O)): Update dependencies.
3967
39682013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3971 * Makefile.in (LIB_ACL): New macro.
3972 (LIBACL_LIBS): Remove.
3973 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3974 * fileio.c: Include <acl.h>.
3975 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3976 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3977 !acl_errno_valid.
3978 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3979 it ourselves.
3980
3981 * unexelf.c: Don't assume ElfW (Half) fits in int.
3982 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3983 when dealing with ElfW (Half) values, since they can exceed 2**31
3984 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3985 (entry_address): Omit unused NUM arg. All uses changed.
3986
39872013-05-07 Juri Linkov <juri@jurta.org>
3988
3989 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3990 to the string converted from number with `Fnumber_to_string'.
3991 (Bug#14254)
3992
39932013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3994
3995 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3996 This fixes a problem introduced by my previous change.
3997
39982013-05-07 Glenn Morris <rgm@gnu.org>
3999
4000 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4001
40022013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4003
4004 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4005
40062013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Static checking by GCC 4.8.0.
4009 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4010 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4011 (x_get_monitor_attributes_fallback)
4012 (x_get_monitor_attributes_xinerama)
4013 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4014 Define only if USE_GTK.
4015 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4016 (x_get_monitor_attributes_fallback): Omit unused locals.
4017 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4018 Use double, not float, to avoid mixed-mode floating point arithmetic.
4019
40202013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4021 Jan Djärv <jan.h.d@swipnet.se>
4022
4023 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4024 (XINERAMA_CFLAGS): New macros.
4025 (ALL_CFLAGS, LIBES): Use them.
4026
4027 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4028 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4029 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4030 (syms_of_xfns): DEFSYM them.
4031 (struct MonitorInfo): New struct.
4032 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4033 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4034 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4035 (x_get_monitor_attributes_xinerama): New functions.
4036 (Fx_display_monitor_attributes_list): New primitive.
4037 (syms_of_xfns): Defsubr it.
4038
4039 * xterm.h (x_display_info): Add Xatom_net_workarea and
4040 Xatom_net_current_desktop.
4041
4042 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4043 and dpyinfo->Xatom_net_current_desktop.
4044
40452013-05-06 Eli Zaretskii <eliz@gnu.org>
4046
4047 * xdisp.c (pos_visible_p): Use the special code for finding the
4048 beginning of a display property or overlay for any "replacing"
4049 display property, not just for display strings. This solves
4050 incorrect reporting of position by posn-at-point. (Bug#14241)
4051
40522013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4055 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4056 Verify that ElfW (Half) fits in int.
4057 (fatal): Use same signature as lisp.h.
4058 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4059 configure and build with -DUNEXELF_DEBUG without worrying about
4060 other modules that use DEBUG.
4061 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4062 possibly-wide integers now uses it instead of plain fprintf.
4063 (entry_address): New function, which avoids problems with 32-bit
4064 overflow on 64-bit hosts.
4065 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4066 (round_up): Don't assume the remainder fits in int.
4067 (find_section): Use bool for boolean. Simplify debug code.
4068 (unexec): Don't assume file sizes fit in int or size_t.
4069 Omit unnecessary trailing newline in 'fatal' format.
4070 Use strerror rather than outputting decimal error number.
4071 Remove unused code when emacs is not defined;
4072 this file relies on Emacs now.
4073 Don't assume e_phnum and e_shnum are positive.
6268 4074
62692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org> 4075 * regex.c: Fix problems when DEBUG is defined.
4076 (extract_number, extract_number_and_incr): Define regardless of
4077 whether DEBUG is defined; that's simpler and makes the code less
4078 likely to go stale in the normal case when DEBUG is not defined.
4079 Return int rather than taking an int * arg. All callers changed.
4080 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4081 Remove, replacing with ...
4082 (DEBUG_PRINT): New macro. All callers changed.
4083 (DEBUG_COMPILES_ARGUMENTS): New macro.
4084 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4085 (print_compiled_pattern, print_double_string) [DEBUG]:
4086 Use prototype rather than old-style definition.
4087 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4088 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4089 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4090 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4091 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4092 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4093 This matters only when DEBUG is defined.
6270 4094
6271 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813). 40952013-05-05 Eli Zaretskii <eliz@gnu.org>
6272 4096
62732011-07-03 Chong Yidong <cyd@stupidchicken.com> 4097 * xdisp.c (set_iterator_to_next): Set the
4098 ignore_overlay_strings_at_pos_p flag only if we are _really_
4099 iterating over an overlay string, as indicated by the
4100 current.overlay_string_index member. (Bug#14306)
4101
41022013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4103
4104 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4105 to where it is used, to avoid autorelease issues (Bug#14050).
4106
41072013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4110 * fileio.c (syms_of_fileio): Implement this.
4111 * filelock.c (create_lock_file): If symbolic links don't work, so
4112 we use a regular file as a lock file, do not fsync the lock file;
4113 it's not needed.
6274 4114
6275 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground 41152013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6276 and background color parameters if they have been changed.
6277 4116
62782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org> 4117 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4118 (syms_of_minibuf): Adjust accodingly.
4119 * lread.c (Fread):
4120 * callint.c (Fcall_interactively): Adjust calls accordingly.
6279 4121
6280 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659). 41222013-05-04 Eli Zaretskii <eliz@gnu.org>
6281 4123
62822011-07-03 Paul Eggert <eggert@cs.ucla.edu> 4124 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
4125 w->contents is a buffer before computing everything else.
4126 Use parentheses to disambiguate last part of the condition.
6283 4127
6284 * xsettings.c (SYSTEM_FONT): Define only when used. 4128 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
6285 No need to define when HAVE_GSETTINGS || !HAVE_XFT. 4129 assertion violations. (Bug#14062)
6286 4130
6287 * keymap.c (access_keymap_1): Now static. 41312013-05-01 David Reitter <david.reitter@gmail.com>
6288 4132
62892011-07-02 Chong Yidong <cyd@stupidchicken.com> 4133 * nsfns.m (ns_tooltip): Initialize.
6290 4134
6291 * keyboard.c (command_loop_1): If a down-mouse event is unbound, 41352013-04-28 Eli Zaretskii <eliz@gnu.org>
6292 leave any prefix arg for the up event (Bug#1586).
6293 4136
62942011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org> 4137 * coding.c (decode_coding_gap): Don't remove the character before
4138 a newline unless it's a CR character. (Bug#14287)
6295 4139
6296 * lread.c (syms_of_lread): Mention single symbols defined by 41402013-04-28 Dan Nicolaescu <dann@gnu.org>
6297 `defvar' or `defconst' (bug#7154).
6298 4141
6299 * fns.c (Frequire): Mention .el.gz files (bug#7314). 4142 * dispextern.h (struct face): Move enum face_underline_type
6300 (Frequire): Mention get-load-suffixes. 4143 earlier so that bitfields can be in the same word.
6301 4144
63022011-07-02 Martin Rudalics <rudalics@gmx.at> 41452013-04-28 Jan Djärv <jan.h.d@swipnet.se>
6303 4146
6304 * window.h (window): Remove clone_number slot. 4147 * nsfns.m (handlePanelKeys): New function.
6305 * window.c (Fwindow_clone_number, Fset_window_clone_number): 4148 (EmacsOpenPanel:performKeyEquivalent:)
6306 Remove. 4149 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
6307 (make_parent_window, make_window, saved_window) 4150 arrows/function/control and copy/paste keys (Bug#14296).
6308 (Fset_window_configuration, save_window_save): Don't deal with
6309 clone numbers.
6310 * buffer.c (Qclone_number): Remove declaration.
6311 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6312
63132011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6314
6315 Add multiple inheritance to keymaps.
6316 * keymap.c (Fmake_composed_keymap): New function.
6317 (Fset_keymap_parent): Simplify.
6318 (fix_submap_inheritance): Remove.
6319 (access_keymap_1): New function extracted from access_keymap to handle
6320 embedded parents and handle lists of maps.
6321 (access_keymap): Use it.
6322 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6323 (Fcopy_keymap): Handle embedded parents.
6324 (Fcommand_remapping, define_as_prefix): Simplify.
6325 (Fkey_binding): Simplify.
6326 (syms_of_keymap): Move minibuffer-local-completion-map,
6327 minibuffer-local-filename-completion-map,
6328 minibuffer-local-must-match-map, and
6329 minibuffer-local-filename-must-match-map to Elisp.
6330 (syms_of_keymap): Defsubr make-composed-keymap.
6331 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6332 (parse_menu_item): Trivial simplification.
6333
63342011-07-01 Glenn Morris <rgm@gnu.org>
6335
6336 * Makefile.in (SETTINGS_LIBS): Fix typo.
6337
63382011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6339
6340 * coding.c (Fencode_coding_string): Record the last coding system
6341 used, as the function doc string says (bug#8738).
6342
63432011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6344
6345 * xsettings.c (store_monospaced_changed): Take new font as arg and
6346 check for change against current_mono_font.
6347 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6348 (emacs_settings_constructor, emacs_settings_get_property)
6349 (emacs_settings_set_property, emacs_settings_class_init)
6350 (emacs_settings_init, gsettings_obj): Remove.
6351 (something_changedCB): New function for HAVE_GSETTINGS.
6352 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6353 with value as argument.
6354 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6355 g_settings_new (Bug#8967). Do not create gsettings_obj.
6356 Remove calls to g_settings_bind. Connect something_changedCB to
6357 "changed".
6358
6359 * xgselect.c: Add defined (HAVE_GSETTINGS).
6360 (xgselect_initialize): Ditto.
6361
6362 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6363 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6364 xg_select.
6365
63662011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6367
6368 * eval.c (struct backtrace): Simplify and port the data structure.
6369 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6370 signed bit field, as this assumption is not portable and it makes
6371 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6372 "char debug_on_exit : 1" as this is not portable either; instead,
6373 use the portable "unsigned int debug_on_exit : 1". Remove unused
6374 member evalargs. Remove obsolete comments about cc bombing out.
6375
63762011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6377
6378 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6379 Let HAVE_GSETTINGS override HAVE_GCONF.
6380 (store_monospaced_changed): New function.
6381 (EMACS_SETTINGS): A new type derived from GObject to handle
6382 GSettings notifications.
6383 (emacs_settings_constructor, emacs_settings_get_property)
6384 (emacs_settings_set_property, emacs_settings_class_init):
6385 New functions.
6386 (gsettings_client, gsettings_obj): New variables.
6387 (GSETTINGS_SCHEMA): New define.
6388 (something_changedCB): Call store_monospaced_changed.
6389 (init_gsettings): New function.
6390 (xsettings_initialize): Call init_gsettings.
6391 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6392 to NULL.
6393 4151
6394 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from 41522013-04-27 Juri Linkov <juri@jurta.org>
6395 GCONF_CFLAGS/LIBS.
6396 4153
63972011-06-29 Martin Rudalics <rudalics@gmx.at> 4154 * callint.c (Fcall_interactively): Call `Qread_number' for
4155 interactive code letter `n' instead of using duplicate code.
4156 (Bug#14254)
6398 4157
6399 * window.c (resize_root_window, grow_mini_window) 41582013-04-27 Paul Eggert <eggert@cs.ucla.edu>
6400 (shrink_mini_window): Rename Qresize_root_window to
6401 Qwindow_resize_root_window and Qresize_root_window_vertically to
6402 Qwindow_resize_root_window_vertically.
6403 4159
64042011-06-28 Paul Eggert <eggert@cs.ucla.edu> 4160 * systime.h (make_timeval): Declare as 'const'.
6405 4161
6406 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var. 41622013-04-27 Kenichi Handa <handa@gnu.org>
6407 4163
64082011-06-27 Juanma Barranquero <lekktu@gmail.com> 4164 * font.c (font_open_entity): Always open a font of manageable
4165 size.
6409 4166
6410 * makefile.w32-in: Redesign dependencies so they reflect more 41672013-04-26 Paul Eggert <eggert@cs.ucla.edu>
6411 clearly which files are directly included by each source file,
6412 and not through other includes.
6413 4168
64142011-06-27 Martin Rudalics <rudalics@gmx.at> 4169 Port better to AIX (Bug#14258).
4170 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4171 to pacify AIX xlc.
6415 4172
6416 * buffer.c (Qclone_number): Declare static and DEFSYM it. 41732013-04-24 Kenichi Handa <handa@gnu.org>
6417 (sort_overlays, overlay_strings): When an overlay's clone number
6418 matches the window's clone number process the overlay even if
6419 the overlay's window property doesn't match the current window.
6420 4174
6421 * window.c (Fwindow_vchild): Rename to Fwindow_top_child. 4175 * coding.c (decode_coding_iso_2022): When an invalid escape
6422 (Fwindow_hchild): Rename to Fwindow_left_child. 4176 sequence is encountered, reset the invocation and designation
6423 (Fwindow_next): Rename to Fwindow_next_sibling. 4177 status to the safest one.
6424 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6425 (resize_window_check): Rename to window_resize_check.
6426 (resize_window_apply): Rename to window_resize_apply.
6427 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6428 (Fdelete_other_windows_internal, resize_frame_windows)
6429 (Fsplit_window_internal, Fdelete_window_internal)
6430 (grow_mini_window, shrink_mini_window)
6431 (Fresize_mini_window_internal): Fix callers accordingly.
6432 4178
64332011-06-26 Jan Djärv <jan.h.d@swipnet.se> 41792013-04-22 Paul Eggert <eggert@cs.ucla.edu>
6434 4180
6435 * emacsgtkfixed.h: State that this is only used with Gtk+3. 4181 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
6436 (emacs_fixed_set_min_size): Remove. 4182 Without this fix, "make distclean" leaves stamp-h1 behind.
6437 (emacs_fixed_new): Take frame as argument.
6438 4183
6439 * emacsgtkfixed.c: State that this is only used with Gtk+3. 41842013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
6440 (_EmacsFixedPrivate): Remove minwidth/height.
6441 Add struct frame *f.
6442 (emacs_fixed_init): Initialize priv->f.
6443 (get_parent_class, emacs_fixed_set_min_size): Remove.
6444 (emacs_fixed_new): Set priv->f to argument.
6445 (emacs_fixed_get_preferred_width)
6446 (emacs_fixed_get_preferred_height): Use min_width/height from
6447 frames size_hint to set minimum and natural (Bug#8919).
6448 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6449 and use min_width/height from frames size_hint to set
6450 min_width/height (Bug#8919).
6451 4185
6452 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new. 4186 * w32fns.c (w32_fullscreen_rect): New function to compute the
6453 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. 4187 window rectangle for the given fullscreen mode.
6454 Fix indentation. 4188 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4189 longer tunes the window size. This keeps the window's edges flush
4190 with the screen and allows the taskbar to hide itself in fullboth.
6455 4191
64562011-06-26 Eli Zaretskii <eliz@gnu.org> 4192 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4193 window decorations and uses the entire screen.
6457 4194
6458 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling 4195 * w32term.h (w32_fullscreen_rect) Add prototype.
6459 bidi_at_paragraph_end, since fast_looking_at doesn't like to be 4196 (struct w32_output): Replace normal_width, normal_height,
6460 called at ZV. 4197 normal_top, and normal_left members with a single normal_placement
4198 struct.
4199 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4200 Remove macros.
4201 (FRAME_NORMAL_PLACEMENT): New macro.
6461 4202
64622011-06-26 Chong Yidong <cyd@stupidchicken.com> 42032013-04-16 Juanma Barranquero <lekktu@gmail.com>
6463 4204
6464 * process.c (wait_reading_process_output): Bypass select if 4205 * minibuf.c (Ftest_completion): Silence compiler warning.
6465 waiting for a cell while ignoring keyboard input, and input is
6466 pending. Suggested by Jan Djärv (Bug#8869).
6467 4206
64682011-06-25 Paul Eggert <eggert@cs.ucla.edu> 42072013-04-15 Eli Zaretskii <eliz@gnu.org>
6469 4208
6470 Use gnulib's dup2 module instead of rolling our own. 4209 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
6471 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this. 4210 bug#14062.
6472 4211
64732011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> 4212 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4213 parentheses.
6474 4214
6475 * dispnew.c (scrolling_window): Before scrolling, turn off a 4215 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
6476 mouse-highlight in the window being scrolled. 4216 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4217 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4218 parentheses where appropriate.
6477 4219
64782011-06-24 Juanma Barranquero <lekktu@gmail.com> 42202013-04-14 Paul Eggert <eggert@cs.ucla.edu>
6479 4221
6480 Move DEFSYM to lisp.h and use everywhere. 4222 * keyboard.c (timer_start_idle): Remove no-longer-used local.
6481 4223
6482 * character.h (DEFSYM): Move declaration... 42242013-04-14 Eli Zaretskii <eliz@gnu.org>
6483 * lisp.h (DEFSYM): ...here.
6484 4225
6485 * gnutls.c: 4226 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
6486 * minibuf.c: 4227 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
6487 * w32menu.c: 4228 Mention in the doc string that setting these variables takes
6488 * w32proc.c: 4229 effect only after a call to set-window-buffer. (Bug#14200)
6489 * w32select.c: Don't include character.h.
6490 4230
6491 * alloc.c (syms_of_alloc): 42312013-04-13 Eli Zaretskii <eliz@gnu.org>
6492 * buffer.c (syms_of_buffer):
6493 * bytecode.c (syms_of_bytecode):
6494 * callint.c (syms_of_callint):
6495 * casefiddle.c (syms_of_casefiddle):
6496 * casetab.c (init_casetab_once):
6497 * category.c (init_category_once, syms_of_category):
6498 * ccl.c (syms_of_ccl):
6499 * cmds.c (syms_of_cmds):
6500 * composite.c (syms_of_composite):
6501 * dbusbind.c (syms_of_dbusbind):
6502 * dired.c (syms_of_dired):
6503 * dispnew.c (syms_of_display):
6504 * doc.c (syms_of_doc):
6505 * editfns.c (syms_of_editfns):
6506 * emacs.c (syms_of_emacs):
6507 * eval.c (syms_of_eval):
6508 * fileio.c (syms_of_fileio):
6509 * fns.c (syms_of_fns):
6510 * frame.c (syms_of_frame):
6511 * fringe.c (syms_of_fringe):
6512 * insdel.c (syms_of_insdel):
6513 * keymap.c (syms_of_keymap):
6514 * lread.c (init_obarray, syms_of_lread):
6515 * macros.c (syms_of_macros):
6516 * msdos.c (syms_of_msdos):
6517 * print.c (syms_of_print):
6518 * process.c (syms_of_process):
6519 * search.c (syms_of_search):
6520 * sound.c (syms_of_sound):
6521 * syntax.c (init_syntax_once, syms_of_syntax):
6522 * terminal.c (syms_of_terminal):
6523 * textprop.c (syms_of_textprop):
6524 * undo.c (syms_of_undo):
6525 * w32.c (globals_of_w32):
6526 * window.c (syms_of_window):
6527 * xdisp.c (syms_of_xdisp):
6528 * xfaces.c (syms_of_xfaces):
6529 * xfns.c (syms_of_xfns):
6530 * xmenu.c (syms_of_xmenu):
6531 * xsettings.c (syms_of_xsettings):
6532 * xterm.c (syms_of_xterm): Use DEFSYM.
6533
65342011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6535
6536 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6537
65382011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 Integer and buffer overflow fixes (Bug#8873).
6541
6542 * print.c (printchar, strout): Check for string overflow.
6543 (PRINTPREPARE, printchar, strout):
6544 Don't set size unless allocation succeeds.
6545
6546 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6547 for sizes. Check for string overflow more accurately.
6548 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6549
6550 * macros.c: Integer and buffer overflow fixes.
6551 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6552 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6553 Use ptrdiff_t, not int, for sizes.
6554 Don't increment bufsize until after realloc succeeds.
6555 Check for size-calculation overflow.
6556 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6557
6558 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6559
6560 * lread.c: Integer overflow fixes.
6561 (read_integer): Radix is now EMACS_INT, not int,
6562 to improve quality of diagnostics for out-of-range radices.
6563 Calculate buffer size correctly for out-of-range radices.
6564 (read1): Check for integer overflow in radices, and in
6565 read-circle numbers.
6566 (read_escape): Avoid int overflow.
6567 (Fload, openp, read_buffer_size, read1)
6568 (substitute_object_recurse, read_vector, read_list, map_obarray):
6569 Use ptrdiff_t, not int, for sizes.
6570 (read1): Use EMACS_INT, not int, for sizes.
6571 Check for size overflow.
6572
6573 * image.c (cache_image): Check for size arithmetic overflow.
6574
6575 * lread.c: Integer overflow issues.
6576 (saved_doc_string_size, saved_doc_string_length)
6577 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6578 Now ptrdiff_t, not int.
6579 (read1): Don't assume doc string length fits in int. Check for
6580 out-of-range doc string lengths.
6581 (read_list): Don't assume file position fits in int.
6582 (read_escape): Check for hex character overflow.
6583
65842011-06-22 Leo Liu <sdl.web@gmail.com>
6585
6586 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6587 Move to minibuffer.el.
6588
65892011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6590
6591 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6592 The following patches are for when GLYPH_DEBUG && !XASSERT.
6593 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6594 * dispnew.c (flush_stdout):
6595 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6596 Mark as externally visible.
6597 * dispnew.c (check_window_matrix_pointers): Now static.
6598 * dispnew.c (window_to_frame_vpos):
6599 * xfns.c (unwind_create_frame):
6600 * xterm.c (x_check_font): Remove unused local.
6601 * scroll.c (CHECK_BOUNDS):
6602 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6603 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6604 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6605 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6606 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6607 Now static.
6608 (debug_method_add): Use va_list and vsprintf rather than relying
6609 on undefined behavior with wrong number of arguments.
6610 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6611 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6612 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6613 since we're not interested in debugging glyphs with old libraries.
6614 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6615 GCC 4.6.0's static checking.
6616
66172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6618
6619 Integer overflow and signedness fixes (Bug#8873).
6620 A few related buffer overrun fixes, too.
6621
6622 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6623
6624 * dispextern.h (struct face.stipple):
6625 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6626 (x_bitmap_mask, x_allocate_bitmap_record)
6627 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6628 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6629 (x_create_bitmap_from_xpm_data):
6630 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6631 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6632 (.bitmaps_last):
6633 * xfaces.c (load_pixmap):
6634 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6635 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6636 (.bitmaps_last, struct x_output.icon_bitmap):
6637 Use ptrdiff_t, not int, for bitmap indexes.
6638 (x_allocate_bitmap_record): Check for size overflow.
6639 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6640
6641 Use ptrdiff_t, not int, for overlay counts.
6642 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6643 * editfns.c (overlays_around, get_pos_property):
6644 * textprop.c (get_char_property_and_overlay):
6645 * xdisp.c (next_overlay_change, note_mouse_highlight):
6646 * xfaces.c (face_at_buffer_position):
6647 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6648 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6649 (Fnext_overlay_change, Fprevious_overlay_change)
6650 (mouse_face_overlay_overlaps, Foverlays_in):
6651 Use ptrdiff_t, not int, for sizes.
6652 (overlays_at, overlays_in): Check for size-calculation overflow.
6653
6654 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6655
6656 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6657 (x_session_initialize): Do not assume string length fits in int.
6658
6659 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6660 This is unlikely, but can occur if DPI is outlandish.
6661
6662 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6663 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6664
6665 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6666 * xrdb.c (magic_file_p, search_magic_path):
6667 Omit last arg SUFFIX; it was always 0. All callers changed.
6668 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6669
6670 * xfont.c (xfont_match): Avoid need for strlen.
6671
6672 * xfns.c: Don't assume strlen fits in int.
6673 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6674
6675 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6676 not unsigned long, as we prefer signed integers. All callers changed.
6677 Detect integer overflow in repeat count.
6678 (message_dolog): Don't assume print length fits in 39 bytes.
6679 (display_mode_element): Don't assume strlen fits in int.
6680
6681 * termcap.c: Don't assume sizes fit in int and never overflow.
6682 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6683 (gobble_line): Check for size-calculation overflow.
6684
6685 * minibuf.c (Fread_buffer):
6686 * lread.c (intern, intern_c_string):
6687 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6688 Don't assume string length fits in int.
6689
6690 * keyboard.c (parse_tool_bar_item):
6691 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6692
6693 * font.c: Don't assume string length fits in int.
6694 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6695 Use ptrdiff_t, not int.
6696 (font_intern_prop): Don't assume string length fits in int.
6697 Don't assume integer property fits in fixnum.
6698 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6699
6700 * filelock.c: Fix some buffer overrun and integer overflow issues.
6701 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6702 Reformulate so as not to need the command string.
6703 Invoke gzip -cd rather than gunzip, as it's more portable.
6704 (lock_info_type, lock_file_1, lock_file):
6705 Don't assume pid_t and time_t fit in unsigned long.
6706 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6707 (current_lock_owner): Prefer signed type for sizes.
6708 Use memcpy, not strncpy, where memcpy is what is really wanted.
6709 Don't assume (via atoi) that time_t and pid_t fit in int.
6710 Check for time_t and/or pid_t out of range, e.g., via a network share.
6711 Don't alloca where an auto var works fine.
6712
6713 * fileio.c: Fix some integer overflow issues.
6714 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6715 Don't assume string length fits in int.
6716 (directory_file_name): Don't assume string length fits in long.
6717 (make_temp_name): Don't assume pid fits in int, or that its print
6718 length is less than 20.
6719
6720 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6721
6722 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6723
6724 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6725
6726 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6727 We prefer signed integers, even for size calculations.
6728
6729 * emacs.c: Don't assume string length fits in 'int'.
6730 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6731 (main): Don't invoke strlen when not needed.
6732
6733 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6734 (XD_DEBUG_MESSAGE): Don't waste a byte.
6735
6736 * callproc.c (getenv_internal_1, getenv_internal)
6737 (Fgetenv_internal):
6738 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6739
6740 * lread.c (invalid_syntax): Omit length argument.
6741 All uses changed. This doesn't fix a bug, but it simplifies the
6742 code away from its former Hollerith-constant appearance, and it's
6743 one less 'int' to worry about when looking at integer-overflow issues.
6744 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6745
6746 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6747 This didn't break anything, but it didn't help either.
6748 It's confusing to put a bogus integer in a place where the actual
6749 value does not matter.
6750 (LIST_END_P): Remove unused macro and its bogus comment.
6751 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6752 4232
6753 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT. 4233 * indent.c (Fvertical_motion): Don't consider display strings on
6754 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE, 4234 overlay strings as display strings on the buffer position we
6755 implementation. 4235 started from. This prevents vertical cursor motion from jumping
6756 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT. 4236 more than one line when there's an overlay string with a display
6757 We prefer signed types, and the value cannot exceed the EMACS_INT 4237 property at end of line.
6758 range anyway (because otherwise the length would not be representable). 4238 Reported by Karl Chen <Karl.Chen@quarl.org> in
6759 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t, 4239 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
6760 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6761 This avoids a GCC warning when WIDE_EMACS_INT.
6762
6763 * indent.c (sane_tab_width): New function.
6764 (current_column, scan_for_column, Findent_to, position_indentation)
6765 (compute_motion): Use it. This is just for clarity.
6766 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6767
6768 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6769
6770 * lisp.h (lint_assume): New macro.
6771 * composite.c (composition_gstring_put_cache):
6772 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6773
6774 * editfns.c, insdel.c:
6775 Omit unnecessary forward decls, to simplify future changes.
6776
6777 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6778
6779 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6780
6781 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6782 Use much-faster test for byte-length change.
6783 Don't assume string byte-length fits in 'int'.
6784 Check that character arg fits in 'int'.
6785 (mapcar1): Declare byte as byte, for clarity.
6786
6787 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6788
6789 * fns.c (concat): Catch string overflow earlier.
6790 Do not rely on integer wraparound.
6791
6792 * dispextern.h (struct it.overlay_strings_charpos)
6793 (struct it.selective): Now EMACS_INT, not int.
6794 * xdisp.c (forward_to_next_line_start)
6795 (back_to_previous_visible_line_start)
6796 (reseat_at_next_visible_line_start, next_element_from_buffer):
6797 Don't arbitrarily truncate the value of 'selective' to int.
6798
6799 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6800
6801 * composite.c: Don't truncate sizes to 'int'.
6802 (composition_gstring_p, composition_reseat_it)
6803 (composition_adjust_point): Use EMACS_INT, not int.
6804 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6805 not EMACS_UINT, for indexes.
6806 4240
6807 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT. 42412013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
6808 4242
6809 * buffer.c: Include <verify.h>. 4243 * window.c (select_window): `record_buffer' even if window is
6810 (struct sortvec.priority, struct sortstr.priority): 4244 already selected (bug#14191).
6811 Now EMACS_INT, not int.
6812 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6813 (struct sortstr.size, record_overlay_string)
6814 (struct sortstrlist.size, struct sortlist.used):
6815 Don't truncate size to int.
6816 (record_overlay_string): Check for size-calculation overflow.
6817 (init_buffer_once): Check at compile-time, not run-time.
6818 4245
68192011-06-22 Jim Meyering <meyering@redhat.com> 42462013-04-11 Eli Zaretskii <eliz@gnu.org>
6820 4247
6821 Don't leak an XBM-image-sized buffer 4248 * window.c (Fwindow_end): Test more flags, including the buffer's
6822 * image.c (xbm_load): Free the image buffer after using it. 4249 last_overlay_modified flag, to determine whether the window's
4250 display is really up-to-date. Prevents the function from
4251 returning a stale value. (Bug#14170)
4252 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4253 current matrix.
6823 4254
68242011-06-21 Paul Eggert <eggert@cs.ucla.edu> 42552013-04-10 Eli Zaretskii <eliz@gnu.org>
6825 4256
6826 Port to Sun C. 4257 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
6827 * composite.c (find_automatic_composition): Omit needless 'return 0;' 4258 garbaged only if it is not already the top frame on its TTY.
6828 that Sun C diagnosed. 4259 This prevents flickering due to constant redrawing of TTY frames when
6829 * fns.c (secure_hash): Fix pointer signedness issue. 4260 there are GUI frames open in the same session. (Bug#13864)
6830 * intervals.c (static_offset_intervals): New function.
6831 (offset_intervals): Use it.
6832 4261
68332011-06-21 Leo Liu <sdl.web@gmail.com> 42622013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
6834 4263
6835 * deps.mk (fns.o): 4264 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
6836 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and 4265 of marking the idle timers directly.
6837 sha512.h.
6838 4266
6839 * fns.c (secure_hash): Rename from crypto_hash_function and change 42672013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
6840 the first arg to accept symbols.
6841 (Fsecure_hash): New primitive.
6842 (syms_of_fns): New symbols.
6843 4268
68442011-06-20 Deniz Dogan <deniz@dogan.se> 4269 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4270 tables (bug#14054).
6845 4271
6846 * process.c (Fset_process_buffer): Clarify return value in 42722013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
6847 docstring.
6848 4273
68492011-06-18 Chong Yidong <cyd@stupidchicken.com> 4274 * window.c (select_window): Don't record_buffer while the invariant is
4275 temporarily broken (bug#14161).
6850 4276
6851 * dispnew.c (add_window_display_history): Use BVAR. 4277 * fns.c (Fdelq): Don't assume !NILP => CONSP.
6852 4278
6853 * xdisp.c (debug_method_add): Use BVAR. 42792013-04-07 Eli Zaretskii <eliz@gnu.org>
6854 (check_window_end, dump_glyph_matrix, dump_glyph)
6855 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6856 4280
6857 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face): 4281 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
6858 Likewise.
6859 4282
6860 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache 42832013-04-07 Romain Francoise <romain@orebokech.com>
6861 check till after the cache is created in init_frame_faces.
6862
68632011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6864
6865 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6866
68672011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6868
6869 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6870 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6871 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6872
6873 Improve buffer-overflow checking (Bug#8873).
6874 * fileio.c (Finsert_file_contents):
6875 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6876 Remove the old (too-loose) buffer overflow checks.
6877 They weren't needed, since make_gap checks for buffer overflow.
6878 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6879 The old code merely checked for Emacs fixnum overflow, and relied
6880 on undefined (wraparound) behavior. The new code avoids undefined
6881 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6882
6883 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6884 Tune. Don't use wider integers than needed. Don't use alloca.
6885 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6886
6887 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6888
6889 * insdel.c, lisp.h (buffer_overflow): New function.
6890 (insert_from_buffer_1, replace_range, replace_range_2):
6891 * insdel.c (make_gap_larger):
6892 * editfns.c (Finsert_char):
6893 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6894
6895 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6896
68972011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6898
6899 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6900 4284
6901 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772. 4285 Ignore additional platform-specific ACL errors (Bug#13702).
6902 (GET_CCL_RANGE, IN_INT_RANGE): Use it. 4286 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4287 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
6903 4288
6904 * fileio.c: Don't assume EMACS_INT fits in off_t. 42892013-03-31 Jan Djärv <jan.h.d@swipnet.se>
6905 (emacs_lseek): New static function.
6906 (Finsert_file_contents, Fwrite_region): Use it.
6907 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6908 4290
6909 * fns.c (Fload_average): Don't assume 100 * load average fits in int. 4291 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
6910 4292 f->output_data.ns.
6911 * fns.c: Don't overflow int when computing a list length.
6912 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6913 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6914 truncation on 64-bit hosts. Check for QUIT every
6915 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6916 faster and is responsive enough.
6917 (Flength): Report an error instead of overflowing an integer.
6918 (Fsafe_length): Return a float if the value is not representable
6919 as a fixnum. This shouldn't happen except in contrived situations.
6920 (Fnthcdr, Fsort): Don't assume list length fits in int.
6921 (Fcopy_sequence): Don't assume vector length fits in int.
6922 4293
6923 * alloc.c: Check that resized vectors' lengths fit in fixnums. 42942013-04-07 Paul Eggert <eggert@cs.ucla.edu>
6924 (header_size, word_size): New constants.
6925 (allocate_vectorlike): Don't check size overflow here.
6926 (allocate_vector): Check it here instead, since this is the only
6927 caller of allocate_vectorlike that could cause overflow.
6928 Check that the new vector's length is representable as a fixnum.
6929 4295
6930 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5. 4296 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
6931 The previous code was bogus. For example, next_almost_prime (32) 4297 This bug was introduced by my 2013-02-25 change that simplified
6932 returned 39, which is undesirable as it is a multiple of 3; and 4298 data_start configuration. Without this change, on GNU/Linux
6933 next_almost_prime (24) returned 25, which is a multiple of 5 so 4299 an Emacs configured with --enable-profiling fails immediately
6934 why was the code bothering to check for multiples of 7? 4300 due to a profiler signal.
6935 4301 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
6936 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length. 4302 with these flags. On platforms where special flags are needed
6937 4303 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
6938 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now. 4304 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
6939 4305 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
6940 Variadic C functions now count arguments with ptrdiff_t.
6941 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6942 Back then I didn't know that the Emacs coding style prefers signed int.
6943 Also, in the meantime I found a few more instances where arguments
6944 were being counted with int, which may truncate counts on 64-bit
6945 machines, or EMACS_INT, which may be unnecessarily wide.
6946 * lisp.h (struct Lisp_Subr.function.aMANY)
6947 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6948 Arg counts are now ptrdiff_t, not size_t.
6949 All variadic functions and their callers changed accordingly.
6950 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6951 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6952 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6953 * callint.c (Fcall_interactively): Check arg count for overflow,
6954 to avoid potential buffer overrun. Use signed char, not 'int',
6955 for 'varies' array, so that we needn't bother to check its size
6956 calculation for overflow.
6957 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6958 * eval.c (apply_lambda):
6959 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6960 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6961 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6962
6963 * callint.c (Fcall_interactively): Don't use index var as event count.
6964
6965 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6966 * mem-limits.h (SIZE): Remove; no longer used.
6967
6968 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6969
6970 Remove unnecessary casts.
6971 * xterm.c (x_term_init):
6972 * xfns.c (x_set_border_pixel):
6973 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6974 These aren't needed now that we assume ANSI C.
6975
6976 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6977 It's more likely to cause problems (due to unsigned overflow)
6978 than to cure them.
6979
6980 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6981
6982 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6983
6984 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6985
6986 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6987
6988 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6989
6990 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6991
6992 GLYPH_CODE_FACE returns EMACS_INT, not int.
6993 * dispextern.h (merge_faces):
6994 * xfaces.c (merge_faces):
6995 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6996 Don't assume EMACS_INT fits in int.
6997
6998 * character.h (CHAR_VALID_P): Remove unused parameter.
6999 * fontset.c, lisp.h, xdisp.c: All uses changed.
7000
7001 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7002
7003 * fns.c (concat): Minor tuning based on overflow analysis.
7004 This doesn't fix any bugs. Use int to hold character, instead
7005 of constantly refetching from Emacs object. Use XFASTINT, not
7006 XINT, for value known to be a character. Don't bother comparing
7007 a single byte to 0400, as it's always less.
7008
7009 * floatfns.c (Fexpt):
7010 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7011
7012 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7013 for characters.
7014
7015 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7016
7017 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7018 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7019 incorrectly succeed when S was a string, because 4294967386 was
7020 truncated before it was used.
7021
7022 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7023 Otherwise, an out-of-range integer could cause undefined behavior
7024 on a 64-bit host.
7025
7026 * composite.c: Use int, not EMACS_INT, for characters.
7027 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7028 EMACS_INT, for values that are known to be in character range.
7029 This doesn't fix any bugs but is the usual style inside Emacs and
7030 may generate better code on 32-bit machines.
7031
7032 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7033 This is for reasons similar to the recent CHAR_STRING fix.
7034 * charset.c (Fencode_char): Check that character arg is actually
7035 a character. Pass an int to ENCODE_CHAR.
7036 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7037 wider than 'int', as a compile-time check to prevent future regressions
7038 in this area.
7039
7040 * character.c (char_string): Remove unnecessary casts.
7041
7042 Make sure a 64-bit char is never passed to CHAR_STRING.
7043 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7044 by silently ignoring the top 32 bits, allowing some values
7045 that were far too large to be valid characters.
7046 * character.h: Include <verify.h>.
7047 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7048 arguments are no wider than unsigned, as a compile-time check
7049 to prevent future regressions in this area.
7050 * data.c (Faset):
7051 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7052 (Fsubst_char_in_region):
7053 * fns.c (concat):
7054 * xdisp.c (decode_mode_spec_coding):
7055 Adjust to CHAR_STRING's new requirement.
7056 * editfns.c (Finsert_char, Fsubst_char_in_region):
7057 * fns.c (concat): Check that character args are actually
7058 characters. Without this test, these functions did the wrong
7059 thing with wildly out-of-range values on 64-bit hosts.
7060
7061 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7062 These casts should not be needed on 32-bit hosts, either.
7063 * keyboard.c (read_char):
7064 * lread.c (Fload): Remove casts to unsigned.
7065
7066 * lisp.h (UNSIGNED_CMP): New macro.
7067 This fixes comparison bugs on 64-bit hosts.
7068 (ASCII_CHAR_P): Use it.
7069 * casefiddle.c (casify_object):
7070 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7071 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7072 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7073 * dispextern.h (FACE_FROM_ID):
7074 * keyboard.c (read_char): Use UNSIGNED_CMP.
7075
7076 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7077 not to EMACS_INT, to avoid GCC warning.
7078
7079 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7080
7081 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7082 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7083 isn't needed on 32-bit machines.
7084
7085 * buffer.c (Fgenerate_new_buffer_name):
7086 Use EMACS_INT for count, not int.
7087 (advance_to_char_boundary): Return EMACS_INT, not int.
7088
7089 * data.c (Qcompiled_function): Now static.
7090
7091 * window.c (window_body_lines): Now static.
7092
7093 * image.c (gif_load): Rename local to avoid shadowing.
7094
7095 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7096 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7097 * alloc.c (make_save_value): Integer argument is now of type
7098 ptrdiff_t, not int.
7099 (mark_object): Use ptrdiff_t, not int.
7100 * lisp.h (pD): New macro.
7101 * print.c (print_object): Use it.
7102
7103 * alloc.c: Use EMACS_INT, not int, to count objects.
7104 (total_conses, total_markers, total_symbols, total_vector_size)
7105 (total_free_conses, total_free_markers, total_free_symbols)
7106 (total_free_floats, total_floats, total_free_intervals)
7107 (total_intervals, total_strings, total_free_strings):
7108 Now EMACS_INT, not int. All uses changed.
7109 (Fgarbage_collect): Compute overall total using a double, so that
7110 integer overflow is less likely to be a problem. Check for overflow
7111 when converting back to an integer.
7112 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7113 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7114 These were 'int' variables that could overflow on 64-bit hosts;
7115 they were never used, so remove them instead of repairing them.
7116 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7117 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7118 Previously, this ceilinged at INT_MAX, but that doesn't work on
7119 64-bit machines.
7120 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7121
7122 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7123 (allocate_vectorlike): Check for ptrdiff_t overflow.
7124 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7125 when a (possibly-narrower) signed value would do just as well.
7126 We prefer using signed arithmetic, to avoid comparison confusion.
7127
7128 * alloc.c: Catch some string size overflows that we were missing.
7129 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7130 for convenience in STRING_BYTES_MAX.
7131 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7132 The definition here is exact; the one in lisp.h was approximate.
7133 (allocate_string_data): Check for string overflow. This catches
7134 some instances we weren't catching before. Also, it catches
7135 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7136 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7137 and ptrdiff_t and EMACS_INT are both 64 bits.
7138
7139 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7140 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7141 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7142
7143 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7144
7145 * alloc.c (Fmake_string): Check for out-of-range init.
7146
71472011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7148
7149 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7150
71512011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7152
7153 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7154 xg_get_default_scrollbar_width.
7155
7156 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7157 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7158 (style_changed_cb): Call update_theme_scrollbar_width and call
7159 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7160 all frames (Bug#8505).
7161 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7162 Call gtk_window_set_resizable if HAVE_GTK3.
7163 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7164 and height if HAVE_GTK3 (Bug#8505).
7165 (scroll_bar_width_for_theme): New variable.
7166 (update_theme_scrollbar_width): New function.
7167 (xg_get_default_scrollbar_width): Move code to
7168 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7169 (xg_initialize): Call update_theme_scrollbar_width.
7170
7171 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7172
7173 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7174
71752011-06-12 Martin Rudalics <rudalics@gmx.at>
7176
7177 * frame.c (make_frame): Call other_buffer_safely instead of
7178 other_buffer.
7179
7180 * window.c (temp_output_buffer_show): Call display_buffer with
7181 second argument Vtemp_buffer_show_specifiers and reset latter
7182 immediately after the call.
7183 (Vtemp_buffer_show_specifiers): New variable.
7184 (auto_window_vscroll_p, next_screen_context_lines)
7185 (Vscroll_preserve_screen_position): Remove leading asterisks from
7186 doc-strings.
7187
71882011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7189
7190 Fix minor problems found by GCC 4.6.0 static checking.
7191 * buffer.c (Qclone_number): Remove for now, as it's unused.
7192 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7193 (record_buffer): Remove unused local.
7194 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7195 (set_frame_buffer_list): Remove; unused.
7196 * frame.h (other_visible_frames): Remove decl.
7197 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7198 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7199 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7200 if HAVE_GPM.
7201 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7202 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7203 Define only if HAVE_GPM.
7204 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7205 (update_hints_inhibit): Remove; never set. All uses removed.
7206 * widgetprv.h (emacsFrameClassRec): Remove decl.
7207 * window.c (delete_deletable_window): Now returns void, since it
7208 wasn't returning anything.
7209 (compare_window_configurations): Remove unused locals.
7210 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7211 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7212 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7213 the same widths as pointers. This follows up on the 2011-05-06 patch.
7214 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7215 * xterm.h: Likewise.
7216 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7217
72182011-06-12 Juanma Barranquero <lekktu@gmail.com>
7219
7220 * makefile.w32-in: Update dependencies.
7221 (LISP_H): Add lib/intprops.h.
7222
72232011-06-11 Chong Yidong <cyd@stupidchicken.com>
7224
7225 * image.c (gif_load): Add animation frame delay to the metadata.
7226 (syms_of_image): Use DEFSYM. New symbol `delay'.
7227
72282011-06-11 Martin Rudalics <rudalics@gmx.at>
7229
7230 * window.c (delete_deletable_window): Re-add.
7231 (Fset_window_configuration): Rewrite to handle dead buffers and
7232 consequently deletable windows.
7233 (window_tree, Fwindow_tree): Remove. Supply functionality in
7234 window.el.
7235 (compare_window_configurations): Simplify code.
7236
72372011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7238
7239 * image.c (imagemagick_load_image): Fix type mismatch.
7240 (Fimagemagick_types): Likewise.
7241
7242 * window.h (replace_buffer_in_windows): Declare.
7243
72442011-06-11 Martin Rudalics <rudalics@gmx.at>
7245
7246 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7247 Qclone_number. Remove external declaration of Qdelete_window.
7248 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7249 code.
7250 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7251 Run Qbuffer_list_update_hook if allowed.
7252 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7253 buffer list implementation.
7254 (other_buffer_safely): New function.
7255 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7256 calls to replace_buffer_in_windows and
7257 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7258 if allowed.
7259 (record_buffer): Inhibit quitting and rewrite using quittable
7260 functions. Run Qbuffer_list_update_hook if allowed.
7261 (Frecord_buffer, Funrecord_buffer): New functions.
7262 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7263 Move switch-to-buffer to window.el.
7264 (bury-buffer): Move to window.el.
7265 (Vbuffer_list_update_hook): New variable.
7266
7267 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7268 section.
7269
7270 * window.h (resize_frame_windows): Move up in code.
7271 (Fwindow_frame): Remove EXFUN.
7272 (replace_buffer_in_all_windows): Remove prototype.
7273 (replace_buffer_in_windows_safely): Add prototype.
7274
7275 * window.c: Declare Qdelete_window static again. Move down
7276 declaration of select_count.
7277 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7278 (Fother_window): Move to window.el.
7279 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7280 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7281 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7282 window.el.
7283 (replace_buffer_in_windows): Implement by calling
7284 Qreplace_buffer_in_windows.
7285 (replace_buffer_in_all_windows): Remove with some functionality
7286 moved into replace_buffer_in_windows_safely.
7287 (replace_buffer_in_windows_safely): New function.
7288 (select_window_norecord, select_frame_norecord): Move in front
7289 of run_window_configuration_change_hook. Remove now obsolete
7290 declarations.
7291 (Fset_window_buffer): Rewrite doc-string.
7292 Call Qrecord_window_buffer.
7293 (keys_of_window): Move binding for other-window to window.el.
7294
72952011-06-11 Chong Yidong <cyd@stupidchicken.com>
7296
7297 * dispextern.h (struct image): Replace data member, whose int_val
7298 and ptr_val fields were not used by anything, with a single
7299 lisp_val object.
7300
7301 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7302 (gif_clear_image, gif_load, imagemagick_load_image)
7303 (gs_clear_image, gs_load): Callers changed.
7304
73052011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7306
7307 * buffer.h: Include <time.h>, for time_t.
7308 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7309 4306
7310 Fix minor problems found by static checking. 43072013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
7311 4308
7312 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't. 4309 Get rid of some platform-specific functions examining window
7313 4310 system and its capabilities. This is a partial rework of the
7314 Make identifiers static if they are not used in other modules. 4311 2013-04-05 change.
7315 * data.c (Qcompiled_function, Qframe, Qvector): 4312 * lisp.h (have_menus_p): Remove prototype. This function is
7316 * image.c (QimageMagick, Qsvg): 4313 replaced with platform-independent window_system_available.
7317 * minibuf.c (Qmetadata): 4314 (check_window_system): Move to...
7318 * window.c (resize_window_check, resize_root_window): Now static. 4315 * frame.h (decode_window_system_frame, window_system_available):
7319 * window.h (resize_window_check, resize_root_window): Remove decls. 4316 ...here, add new prototypes.
7320 4317 * frame.c (window_system_available, decode_window_system_frame):
7321 * window.c (window_deletion_count, delete_deletable_window):
7322 Remove; unused.
7323 (window_body_lines): Now static.
7324 (Fdelete_other_windows_internal): Mark vars as initialized.
7325 Make sure 'resize_failed' is initialized.
7326 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7327 (resize_window_apply): Remove unused local.
7328 * window.h (delete_deletable_window): Remove decl.
7329
7330 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7331 (imagemagick_load_image): Fix pointer signedness problem by changing
7332 last arg from unsigned char * to char *. All uses changed.
7333 Also, fix a local for similar reasons.
7334 Remove unused locals. Remove locals to avoid shadowing.
7335 (fn_rsvg_handle_free): Remove; unused.
7336 (svg_load, svg_load_image): Fix pointer signedness problem.
7337 (imagemagick_load_image): Don't use garbage pointer image_wand.
7338
7339 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7340
73412011-06-10 Chong Yidong <cyd@stupidchicken.com>
7342
7343 * image.c (gif_load): Fix omitted cast error introduced by
7344 2011-06-06 change.
7345
73462011-06-10 Martin Rudalics <rudalics@gmx.at>
7347
7348 * window.h (resize_proportionally, orig_total_lines)
7349 (orig_top_line): Remove from window structure.
7350 (set_window_height, set_window_width, change_window_heights)
7351 (Fdelete_window): Remove prototypes.
7352 (resize_frame_windows): Remove duplicate declaration.
7353
73542011-06-10 Eli Zaretskii <eliz@gnu.org>
7355
7356 * window.h (resize_frame_windows, resize_window_check)
7357 (delete_deletable_window, resize_root_window)
7358 (resize_frame_windows): Declare prototypes.
7359
7360 * window.c (resize_window_apply): Make definition be "static" to
7361 match the prototype.
7362
73632011-06-10 Martin Rudalics <rudalics@gmx.at>
7364
7365 * window.c: Remove declarations of Qwindow_size_fixed,
7366 window_min_size_1, window_min_size_2, window_min_size,
7367 size_window, window_fixed_size_p, enlarge_window, delete_window.
7368 Remove static from declaration of Qdelete_window, it's
7369 temporarily needed by Fbury_buffer.
7370 (replace_window): Don't assign orig_top_line and
7371 orig_total_lines.
7372 (Fdelete_window, delete_window): Remove. Window deletion is
7373 handled by window.el.
7374 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7375 Replace Fdelete_window calls with calls to Qdelete_window.
7376 (Fdelete_other_windows): Remove. Deleting other windows is
7377 handled by window.el.
7378 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7379 handled in window.el.
7380 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7381 Window minimum sizes are handled in window.el.
7382 (shrink_windows, size_window, set_window_height)
7383 (set_window_width, change_window_heights, window_height)
7384 (window_width, CURBEG, CURSIZE, enlarge_window)
7385 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7386 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7387 handled in window.el.
7388 (make_dummy_parent): Rename to make_parent_window and give it a
7389 second argument horflag.
7390 (make_window): Don't set resize_proportionally any more.
7391 (Fsplit_window): Remove. Windows are split in window.el.
7392 (save_restore_action, save_restore_orig_size)
7393 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7394 Resize mini windows in window.el.
7395 (grow_mini_window, shrink_mini_window): Implement by calling
7396 Qresize_root_window_vertically, resize_window_check and
7397 resize_window_apply.
7398 (saved_window, Fset_window_configuration, save_window_save):
7399 Do not handle orig_top_line, orig_total_lines, and
7400 resize_proportionally.
7401 (window_min_height, window_min_width): Move to window.el.
7402 (keys_of_window): Move bindings for delete-other-windows,
7403 split-window, delete-window and enlarge-window to window.el.
7404
7405 * buffer.c: Temporarily extern Qdelete_window.
7406 (Fbury_buffer): Temporarily call Qdelete_window instead of
7407 Fdelete_window (Fbury_buffer will move to window.el soon).
7408
7409 * frame.c (set_menu_bar_lines_1): Remove code handling
7410 orig_top_line and orig_total_lines.
7411
7412 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7413 set_window_height but set heights directly.
7414 (change_frame_size_1): Use resize_frame_windows.
7415
7416 * xdisp.c (init_xdisp): Don't use set_window_height but set
7417 heights directly.
7418
7419 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7420 Use resize_frame_windows instead of change_window_heights and run
7421 run_window_configuration_change_hook.
7422
7423 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7424 instead of change_window_heights and run
7425 run_window_configuration_change_hook.
7426
74272011-06-09 Martin Rudalics <rudalics@gmx.at>
7428
7429 * window.c (replace_window): Rename second argument REPLACEMENT to
7430 NEW. New third argument SETFLAG. Rewrite.
7431 (delete_window, make_dummy_parent): Call replace_window with
7432 third argument 1.
7433 (window_list_1): Move down in code.
7434 (run_window_configuration_change_hook): Move set_buffer part
7435 before select_frame_norecord part in order to unwind correctly.
7436 Rename count1 to count.
7437 (recombine_windows, delete_deletable_window, resize_root_window)
7438 (Fdelete_other_windows_internal)
7439 (Frun_window_configuration_change_hook, make_parent_window)
7440 (resize_window_check, resize_window_apply, Fresize_window_apply)
7441 (resize_frame_windows, Fsplit_window_internal)
7442 (Fdelete_window_internal, Fresize_mini_window_internal):
7443 New functions. 4318 New functions.
7444 (syms_of_window): New variables Vwindow_splits and Vwindow_nest. 4319 (check_window_system): Platform-independent now.
4320 * xterm.h (x_in_use): Remove declaration.
4321 (check_x_frame):
4322 * w32term.h (check_x_frame):
4323 * nsterm.h (check_x_frame): Remove prototypes. This function
4324 is replaced with platform-independent decode_window_system_frame.
4325 * msdos.c (have_menus_p): Remove.
4326 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4327 Remove platform-specific functions. Use check_window_system,
4328 decode_window_system_frame and check_ns_display_info where
4329 appropriate. Minor style and comment tweaks.
4330 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4331 (check_x_frame): Likewise.
4332 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4333 Likewise.
4334 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4335 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4336 * xmenu.c, xselect.c: All related users changed.
7445 4337
74462011-06-08 Martin Rudalics <rudalics@gmx.at> 43382013-04-03 Kenichi Handa <handa@gnu.org>
7447 4339
7448 * window.h (window): Add some new members to window structure - 4340 The following changes is to optimize the code for reading UTF-8
7449 normal_lines, normal_cols, new_total, new_normal, clone_number, 4341 files.
7450 splits, nest, prev_buffers, next_buffers.
7451 (WINDOW_TOTAL_SIZE): Move here from window.c.
7452 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7453 4342
7454 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p): 4343 * coding.c (check_ascii): Rename from detect_ascii. Return value
7455 Remove. 4344 changed. Check EOL format. Do not call adjust_coding_eol_type
7456 (make_dummy_parent): Set new members of windows structure. 4345 here.
7457 (make_window): Move down in code. Handle new members of window 4346 (check_utf_8): New function.
7458 structure. 4347 (adjust_coding_eol_type): Do nothing if already adjusted.
7459 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits) 4348 (detect_coding): Compare the return value of check_ascii with
7460 (Fwindow_nest, Fset_window_nest, Fwindow_new_total) 4349 coding->src_bytes. Call adjust_coding_eol_type if necessary.
7461 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers) 4350 (decode_coding_gap): Optimize for valid UTF-8.
7462 (Fset_window_prev_buffers, Fwindow_next_buffers) 4351
7463 (Fset_window_next_buffers, Fset_window_clone_number): 43522013-03-21 Kenichi Handa <handa@gnu.org>
7464 New functions. 4353
7465 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start) 4354 * coding.c (syms_of_coding): Cancel previous change.
7466 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p): 4355
7467 Doc-string fixes. 4356 * insdel.c (insert_from_gap): Fix previous change.
7468 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter): 4357
7469 Argument WINDOW can be now internal window too. 43582013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
7470 (Fwindow_use_time): Move up in code. 4359
7471 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES. 4360 Consistently use platform-specific function to detect window system.
7472 Rewrite doc-string. 4361 * lisp.h (check_window_system): New prototype. This function is
7473 (Fset_window_configuration, saved_window) 4362 going to replace check_x, check_w32 and check_ns.
7474 (Fcurrent_window_configuration, save_window_save): Handle new 4363 (have_menus_p): Mention msdos.c in comment.
7475 members of window structure. 4364 * fontset.c (check_window_system_func): Remove. Adjust all users.
7476 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH) 4365 * fontset.h (check_window_system_func): Remove prototype.
7477 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h. 4366 * nsterm.h (check_ns):
7478 (syms_of_window): New Lisp objects Qrecord_window_buffer, 4367 * xterm.h (check_x):
7479 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows, 4368 * w32term.h (check_w32): Likewise.
7480 Qget_mru_window, Qresize_root_window, 4369 * menu.c (Fx_popup_menu): Use check_window_system.
7481 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow, 4370 * msdos.c (check_window_system): Define for MS-DOS.
7482 Qauto_buffer_name; staticpro them. 4371 * nsfns.m (check_window_system): Define for NS. Adjust all users.
7483 4372 * w32fns.c (check_window_system): Likewise for MS-Windows.
74842011-06-07 Martin Rudalics <rudalics@gmx.at> 4373 * xfns.c (check_window_system): Likewise for X.
7485 4374 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
7486 * window.c (Fwindow_total_size, Fwindow_left_column) 4375 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
7487 (Fwindow_top_line, window_body_lines, Fwindow_body_size) 4376
7488 (Fwindow_list_1): New functions. 43772013-04-02 Paul Eggert <eggert@cs.ucla.edu>
7489 (window_box_text_cols): Replace with window_body_cols. 4378
7490 (Fwindow_width, Fscroll_left, Fscroll_right): 4379 Prefer < to > in range checks such as 0 <= i && i < N.
7491 Use window_body_cols instead of window_box_text_cols. 4380 This makes it easier to visualize quantities on a number line.
7492 (delete_window, Fset_window_configuration): 4381 This patch doesn't apply to all such range checks,
7493 Call delete_all_subwindows with window as argument. 4382 only to the range checks affected by the 2013-03-24 change.
7494 (delete_all_subwindows): Take a window as argument and not a 4383 This patch reverts most of the 2013-03-24 change.
7495 structure. Rewrite. 4384 * alloc.c (xpalloc, Fgarbage_collect):
7496 (window_loop): Remove handling of GET_LRU_WINDOW and 4385 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
7497 GET_LARGEST_WINDOW.
7498 (Fget_lru_window, Fget_largest_window): Move to window.el.
7499
7500 * window.h: Extern window_body_cols instead of
7501 window_box_text_cols. delete_all_subwindows now takes a
7502 Lisp_Object as argument.
7503
7504 * indent.c (compute_motion, Fcompute_motion):
7505 Use window_body_cols instead of window_box_text_cols.
7506
7507 * frame.c (delete_frame): Call delete_all_subwindows with root
7508 window as argument.
7509
75102011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7511
7512 * fns.c (Fputhash): Document return value.
7513
75142011-06-06 Chong Yidong <cyd@stupidchicken.com>
7515
7516 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7517
75182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7519
7520 Cons<->int and similar integer overflow fixes (Bug#8794).
7521
7522 Check for overflow when converting integer to cons and back.
7523 * charset.c (Fdefine_charset_internal, Fdecode_char):
7524 Use cons_to_unsigned to catch overflow.
7525 (Fencode_char): Use INTEGER_TO_CONS.
7526 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7527 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7528 * data.c (long_to_cons, cons_to_long): Remove.
7529 (cons_to_unsigned, cons_to_signed): New functions.
7530 These signal an error for invalid or out-of-range values.
7531 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7532 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7533 * font.c (Ffont_variation_glyphs):
7534 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7535 * lisp.h: Include <intprops.h>.
7536 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7537 (cons_to_signed, cons_to_unsigned): New decls.
7538 (long_to_cons, cons_to_long): Remove decls.
7539 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7540 (Fprimitive_undo): Use CONS_TO_INTEGER.
7541 * xfns.c (Fx_window_property): Likewise.
7542 * xselect.c: Include <limits.h>.
7543 (x_own_selection, selection_data_to_lisp_data):
7544 Use INTEGER_TO_CONS.
7545 (x_handle_selection_request, x_handle_selection_clear)
7546 (x_get_foreign_selection, Fx_disown_selection_internal)
7547 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7548 (lisp_data_to_selection_data): Use cons_to_unsigned.
7549 (x_fill_property_data): Use cons_to_signed.
7550 Report values out of range.
7551
7552 Check for buffer and string overflow more precisely.
7553 * buffer.h (BUF_BYTES_MAX): New macro.
7554 * lisp.h (STRING_BYTES_MAX): New macro.
7555 * alloc.c (Fmake_string):
7556 * character.c (string_escape_byte8): 4386 * character.c (string_escape_byte8):
7557 * coding.c (coding_alloc_by_realloc): 4387 * charset.c (read_hex):
4388 * data.c (cons_to_unsigned):
4389 * dispnew.c (update_frame_1):
4390 * doc.c (Fsubstitute_command_keys):
7558 * doprnt.c (doprnt): 4391 * doprnt.c (doprnt):
7559 * editfns.c (Fformat): 4392 * editfns.c (hi_time, decode_time_components):
7560 * eval.c (verror): 4393 * fileio.c (file_offset):
7561 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM, 4394 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
7562 since they may not be the same number. 4395 * font.c (font_intern_prop):
7563 * editfns.c (Finsert_char): 4396 * frame.c (x_set_alpha):
7564 * fileio.c (Finsert_file_contents): 4397 * gtkutil.c (get_utf8_string):
7565 Likewise for BUF_BYTES_MAX. 4398 * indent.c (check_display_width):
7566 4399 * keymap.c (Fkey_description):
7567 * image.c: Use ptrdiff_t, not int, for sizes. 4400 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
7568 (slurp_file): Switch from int to ptrdiff_t. 4401 * lread.c (read1):
7569 All uses changed. 4402 * minibuf.c (read_minibuf_noninteractive):
7570 (slurp_file): Check that file size fits in both size_t (for 4403 * process.c (wait_reading_process_output):
7571 malloc) and ptrdiff_t (for sanity and safety). 4404 * search.c (Freplace_match):
7572 4405 * window.c (get_phys_cursor_glyph):
7573 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow 4406 * xdisp.c (redisplay_internal):
7574 if b->modtime has its maximal value. 4407 * xsmfns.c (smc_save_yourself_CB):
7575 4408 Prefer < to > for range checks.
7576 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits. 4409 * dispnew.c (sit_for): Don't mishandle NaNs.
7577 4410 This fixes a bug introduced in the 2013-03-24 change.
7578 Don't assume time_t can fit into int. 4411 * editfns.c (decode_time_components): Don't hoist comparison.
7579 * buffer.h (struct buffer.modtime): Now time_t, not int. 4412 This fixes another bug introduced in the 2013-03-24 change.
7580 * fileio.c (Fvisited_file_modtime): No need for time_t cast now. 4413
7581 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value. 44142013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
7582 4415
7583 Minor fixes for signed vs unsigned integers. 4416 * frame.h (struct frame): Drop scroll_bottom_vpos
7584 * character.h (MAYBE_UNIFY_CHAR): 4417 member becaue all real users are dead long ago.
7585 * charset.c (maybe_unify_char): 4418 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
7586 * keyboard.c (read_char, reorder_modifiers): 4419 * xdisp.c (redisplay_internal): Adjust user.
7587 XINT -> XFASTINT, since the integer must be nonnegative. 4420
7588 * ftfont.c (ftfont_spec_pattern): 44212013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
7589 * keymap.c (access_keymap, silly_event_symbol_error): 4422
7590 XUINT -> XFASTINT, since the integer must be nonnegative. 4423 * nsmenu.m (showAtX:Y:for:): setLevel to
7591 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT, 4424 NSPopUpMenuWindowLevel (Bug#13998).
7592 since it makes no difference and we prefer signed. 4425
7593 * keyboard.c (record_char): Use XUINT when all the neighbors do. 44262013-03-30 Jan Djärv <jan.h.d@swipnet.se>
7594 (access_keymap): NATNUMP -> INTEGERP, since the integer must be 4427
7595 nonnegative. 4428 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
7596 4429 (ns_check_pending_open_menu): Declare.
75972011-06-06 Stefan Monnier <monnier@iro.umontreal.ca> 4430
7598 4431 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
7599 * window.h (Fwindow_frame): Declare. 4432 (x_activate_menubar): Update the menu with title that matches
7600 4433 ns_get_pending_menu_title, and call
76012011-06-06 Paul Eggert <eggert@cs.ucla.edu> 4434 ns_check_pending_openmenu (Bug#12698).
7602 4435 (menuWillOpen:): New method.
7603 * alloc.c: Simplify handling of large-request failures (Bug#8800). 4436 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
7604 (SPARE_MEMORY): Always define. 4437
7605 (LARGE_REQUEST): Remove. 4438 * nsterm.m (menu_will_open_state, menu_mouse_point)
7606 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST. 4439 (menu_pending_title): New varaibles.
7607 4440 (ns_get_pending_menu_title, ns_check_menu_open)
76082011-06-06 Martin Rudalics <rudalics@gmx.at> 4441 (ns_check_pending_open_menu): New functions.
7609 4442
7610 * lisp.h: Move EXFUNS for Fframe_root_window, 44432013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
7611 Fframe_first_window and Fset_frame_selected_window to window.h. 4444
7612 4445 * indent.c (current_column_bol_cache): Remove leftover which is not
7613 * window.h: Move EXFUNS for Fframe_root_window, 4446 used in Fmove_to_column any more.
7614 Fframe_first_window and Fset_frame_selected_window here from 4447 (current_column, scan_for_column): Adjust users.
7615 lisp.h. 4448 * keyboard.c (last_point_position_buffer, last_point_position_window):
7616 4449 Remove leftovers which are not used for recording undo any more.
7617 * frame.c (Fwindow_frame, Fframe_first_window) 4450 (command_loop_1, syms_of_keyboard): Adjust users.
7618 (Fframe_root_window, Fframe_selected_window) 4451 * xdisp.c (last_max_ascent): Remove leftover which is not used in
7619 (Fset_frame_selected_window): Move to window.c. 4452 redisplay_window any more.
7620 (Factive_minibuffer_window): Move to minibuf.c. 4453 (move_it_to): Adjust user.
7621 (Fother_visible_frames_p): New function. 4454
7622 44552013-03-29 Juanma Barranquero <lekktu@gmail.com>
7623 * minibuf.c (Factive_minibuffer_window): Move here from frame.c. 4456
7624 4457 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
7625 * window.c (decode_window, decode_any_window): Move up in code.
7626 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7627 (inhibit_frame_unsplittable): Remove unused variable.
7628 (Fwindow_buffer): Move up and rewrite doc-string.
7629 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7630 (Fwindow_prev): New functions.
7631 (Fwindow_frame): Move here from frame.c. Accept any window as
7632 argument.
7633 (Fframe_root_window, Fframe_first_window)
7634 (Fframe_selected_window): Move here from frame.c. Accept frame
7635 or arbitrary window as argument. Update doc-strings.
7636 (Fminibuffer_window): Move up in code.
7637 (Fwindow_minibuffer_p): Move up in code and simplify.
7638 (Fset_frame_selected_window): Move here from frame.c.
7639 Marginal rewrite.
7640 (Fselected_window, select_window, Fselect_window): Move up in
7641 code. Minor doc-string fixes.
7642
76432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7644
7645 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7646 Do not assume that spare memory exists; that assumption is valid
7647 only if SYSTEM_MALLOC.
7648 (LARGE_REQUEST): New macro, so that the issue of large requests
7649 is separated from the issue of spare memory.
7650
76512011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7652
7653 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7654 format. (Bug#8806)
7655
7656 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7657
7658 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7659 before statements.
7660
76612011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7662
7663 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7664
7665 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7666
7667 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7668 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7669
76702011-06-05 Juanma Barranquero <lekktu@gmail.com>
7671
7672 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7673
76742011-06-04 Chong Yidong <cyd@stupidchicken.com>
7675
7676 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7677 (x_clipboard_manager_save): Add return value.
7678 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7679 New error handlers.
7680 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7681 Obey Vx_select_enable_clipboard_manager. Catch errors in
7682 x_clipboard_manager_save (Bug#8779).
7683 (Vx_select_enable_clipboard_manager): New variable.
7684 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7685
76862011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7687
7688 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7689
76902011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7691
7692 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7693 in the current matrix if keep_current_p is non-zero.
7694
76952011-06-04 Eli Zaretskii <eliz@gnu.org>
7696
7697 * bidi.c (bidi_level_of_next_char): Fix last change.
7698
76992011-06-03 Eli Zaretskii <eliz@gnu.org>
7700
7701 Support bidi reordering of text covered by display properties.
7702
7703 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7704 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7705 (bidi_cache_search, bidi_cache_iterator_state)
7706 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7707 (bidi_level_of_next_char, bidi_move_to_visually_next):
7708 Support character positions inside a run of characters covered by a
7709 display string.
7710 (bidi_paragraph_init, bidi_resolve_explicit_1)
7711 (bidi_level_of_next_char): Call bidi_fetch_char and
7712 bidi_fetch_char_advance instead of FETCH_CHAR and
7713 FETCH_CHAR_ADVANCE.
7714 (bidi_init_it): Initialize new members.
7715 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7716 definitions.
7717 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7718 instead of using explicit *_CHAR codes.
7719 (bidi_resolve_explicit, bidi_resolve_weak):
7720 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7721 bidirectional text is supported only in multibyte buffers.
7722 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7723 it to initialize the frame_window_p member of struct bidi_it.
7724 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7725 (bidi_resolve_explicit, bidi_resolve_weak)
7726 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7727 bidi_it->nchars is non-positive.
7728 (bidi_level_of_next_char): Don't try to lookup the cache for the
7729 next/previous character if nothing is cached there yet, or if we
7730 were just reseat()'ed to a new position.
7731
7732 * xdisp.c (set_cursor_from_row): Set start and stop points
7733 according to the row's direction when priming the loop that looks
7734 for the glyph on which to display cursor.
7735 (single_display_spec_intangible_p): Function deleted.
7736 (display_prop_intangible_p): Reimplement to call
7737 handle_display_spec instead of single_display_spec_intangible_p.
7738 Accept 3 additional arguments needed by handle_display_spec.
7739 This fixes incorrect cursor motion across display property with complex
7740 values: lists, `(when COND...)' forms, etc.
7741 (single_display_spec_string_p): Support property values that are
7742 lists with the argument STRING its top-level element.
7743 (display_prop_string_p): Fix the condition for processing a
7744 property that is a list to be consistent with handle_display_spec.
7745 (handle_display_spec): New function, refactored from the
7746 last portion of handle_display_prop.
7747 (compute_display_string_pos): Accept additional argument
7748 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7749 value of a `display' property is a "replacing spec".
7750 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7751 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7752 the display property, but just return a value indicating whether
7753 the display property will replace the characters it covers.
7754 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7755 frame_window_p members of struct bidi_it.
7756 (compute_display_string_pos, compute_display_string_end):
7757 New functions.
7758 (push_it): Accept second argument POSITION, where pop_it should
7759 jump to continue iteration.
7760 (reseat_1): Initialize bidi_it.disp_pos.
7761
7762 * keyboard.c (adjust_point_for_property): Adjust the call to
7763 display_prop_intangible_p to its new signature.
7764
7765 * dispextern.h (struct bidi_it): New member frame_window_p.
7766 (bidi_init_it): Update prototypes.
7767 (display_prop_intangible_p): Update prototype.
7768 (compute_display_string_pos, compute_display_string_end):
7769 Declare prototypes.
7770 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7771 EMACS_INT.
7772
77732011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7774
7775 Malloc failure behavior now depends on size of allocation.
7776 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7777 * lisp.h: Change signatures accordingly.
7778 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7779 All callers changed. (Bug#8762)
7780
7781 * gnutls.c: Use Emacs's memory allocators.
7782 Without this change, the gnutls library would invoke malloc etc.
7783 directly, which causes problems on non-SYNC_INPUT hosts, and which
7784 runs afoul of improving memory_full behavior. (Bug#8761)
7785 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7786 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7787 xfree instead of the default malloc, realloc, free.
7788 (Fgnutls_boot): No need to check for memory allocation failure,
7789 since xmalloc does that for us.
7790
7791 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7792 * category.c (hash_get_category_set):
7793 * ccl.c (ccl_driver):
7794 * charset.c (Fdefine_charset_internal):
7795 * charset.h (struct charset.hash_index):
7796 * composite.c (get_composition_id, gstring_lookup_cache)
7797 (composition_gstring_put_cache):
7798 * composite.h (struct composition.hash_index):
7799 * dispextern.h (struct image.hash):
7800 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7801 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7802 (hashfn_equal, hashfn_user_defined, make_hash_table)
7803 (maybe_resize_hash_table, hash_lookup, hash_put)
7804 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7805 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7806 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7807 * image.c (make_image, search_image_cache, lookup_image)
7808 (xpm_put_color_table_h):
7809 * lisp.h (struct Lisp_Hash_Table):
7810 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7811 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7812 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7813 * alloc.c (allocate_vectorlike):
7814 Check for overflow in vector size calculations.
7815 * ccl.c (ccl_driver):
7816 Check for overflow when converting EMACS_INT to int.
7817 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7818 need to be updated by these changes.
7819 * fns.c (make_hash_table, maybe_resize_hash_table):
7820 Check for integer overflow with large hash tables.
7821 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7822 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7823 (SXHASH_REDUCE): New macro.
7824 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7825 Use it instead of discarding useful hash info with large hash values.
7826 (sxhash_float): New function.
7827 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7828 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7829 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7830 Rewrite to use FIXNUM_BITS, as this simplifies things.
7831 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7832 Adjust signatures to match updated version of code.
7833 (consing_since_gc): Now EMACS_INT, since a single hash table can
7834 use more than INT_MAX bytes.
7835
78362011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7837
7838 Make it possible to build with GCC-4.6+ -O2 -flto.
7839
7840 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7841
78422011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7843
7844 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7845 Call minibuffer-inactive-mode.
7846
78472011-05-31 Juanma Barranquero <lekktu@gmail.com>
7848
7849 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7850 Update dependencies. 4458 Update dependencies.
7851 4459
78522011-05-31 Dan Nicolaescu <dann@ics.uci.edu> 44602013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7853 4461
7854 * data.c (init_data): Remove code for UTS, this system is not 4462 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
7855 supported anymore. 4463 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
7856 4464 forward references.
78572011-05-31 Dan Nicolaescu <dann@ics.uci.edu> 4465
7858 44662013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
7859 Don't force ./temacs to start in terminal mode. 4467
7860 4468 * window.h (struct window): Replace hchild, vchild and buffer slots
7861 * frame.c (make_initial_frame): Initialize faces in all cases, not 4469 with the only contents slot. This is possible because each valid
7862 only when CANNOT_DUMP is defined. 4470 window may have either the child window (in vertical or horizontal
7863 * dispnew.c (init_display): Remove CANNOT_DUMP condition. 4471 combination) or buffer to display (for the leaf window). Using that,
7864 4472 a lof of operations to traverse and/or change window hierarchies may
78652011-05-31 Dan Nicolaescu <dann@ics.uci.edu> 4473 be simplified. New member horizontal is used to distinguish between
7866 4474 horizontal and vertical combinations of internal windows.
7867 * dispnew.c (add_window_display_history): Use const for the string 4475 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
7868 pointer. Remove declaration, not needed. 4476 (WINDOW_VERTICAL_COMBINATION_P): New macros.
7869 4477 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
78702011-05-31 Paul Eggert <eggert@cs.ucla.edu> 4478 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
7871 4479 Use contents slot, not buffer, where appropriate.
7872 Use 'inline', not 'INLINE'. 4480 (wset_combination): New function.
7873 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html> 4481 (wset_buffer): Add eassert.
7874 * alloc.c, fontset.c (INLINE): Remove. 4482 (Fframe_first_window): Simplify the loop reaching first window.
7875 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c: 4483 (Fwindow_buffer): Use WINDOW_LEAF_P.
7876 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c: 4484 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
7877 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline. 4485 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
7878 * gmalloc.c (register_heapinfo): Use inline unconditionally. 4486 (unshow_buffer): Convert initial debugging check to eassert.
7879 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__. 4487 (replace_window, recombine_windows, Fdelete_other_windows_internal)
7880 4488 (make_parent_window, window_resize_check, window_resize_apply)
78812011-05-31 Dan Nicolaescu <dann@ics.uci.edu> 4489 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
7882 4490 (Fset_window_configuration, delete_all_child_windows, save_window_save):
7883 Make it possible to run ./temacs. 4491 Adjust to match struct window changes.
7884 4492 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
7885 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code, 4493 (mark_window_cursors_off, count_windows, get_leaf_windows)
7886 syms_of_callproc does the same thing. Remove test for 4494 (foreach_window_1): Simplify the loop.
7887 "initialized", do it in the caller. 4495 * alloc.c (mark_object): Do not check for the leaf window because
7888 * emacs.c (main): Avoid calling set_initial_environment when dumping. 4496 internal windows has no glyph matrices anyway.
7889 4497 * dispnew.c (clear_window_matrices, showing_window_margins_p)
78902011-05-31 Stefan Monnier <monnier@iro.umontreal.ca> 4498 (allocate_matrices_for_window_redisplay, fake_current_matrices)
7891 4499 (allocate_matrices_for_frame_redisplay, free_window_matrices)
7892 * minibuf.c (Finternal_complete_buffer): Return `category' metadata. 4500 (build_frame_matrix_from_window_tree, mirror_make_current)
7893 (read_minibuf): Use get_minibuffer. 4501 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
7894 (syms_of_minibuf): Use DEFSYM. 4502 (update_window_tree, set_window_update_flags): Simplify the loop.
7895 (Qmetadata): New var. 4503 (sync_window_with_frame_matrix_rows): Enforce live window.
7896 * data.c (Qbuffer): Don't make it static. 4504 Use contents slot, not buffer, where appropriate.
7897 (syms_of_data): Use DEFSYM. 4505 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
7898 4506 and WINDOW_HORIZONTAL_COMBINATION_P.
78992011-05-31 Paul Eggert <eggert@cs.ucla.edu> 4507 (make_frame_visible_1): Simplify the loop.
7900 4508 Use contents slot, not buffer, where appropriate.
7901 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751) 4509 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
7902 (CCL_CODE_MIN): New macro. 4510 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
7903 4511 (expose_window_tree): Likewise.
79042011-05-30 Paul Eggert <eggert@cs.ucla.edu> 4512 Use contents slot, not buffer, where appropriate.
7905 4513 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
7906 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests. 4514 to avoid deleted windows. Use contents slot instead of buffer.
7907 4515 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
7908 * eval.c (Qdebug): Now static. 4516 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
7909 * lisp.h (Qdebug): Remove decl. This reverts a part of the 4517 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
7910 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of 4518 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
7911 2011-04-14T06:48:41Z!eggert@cs.ucla.edu. 4519
7912 45202013-03-28 Eli Zaretskii <eliz@gnu.org>
79132011-05-29 Chong Yidong <cyd@stupidchicken.com> 4521
7914 4522 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
7915 * image.c: Various fixes to ImageMagick code comments. 4523 identify the reasons for assertion violations in bug#14062 and
7916 (Fimagemagick_types): Doc fix. 4524 similar ones.
7917 4525 (Fx_show_tip): Fix compilation error under
79182011-05-29 Paul Eggert <eggert@cs.ucla.edu> 4526 "--enable-check-lisp-object-type". (Bug#14073)
7919 4527
7920 Minor fixes prompted by GCC 4.6.0 warnings. 4528 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
7921 4529 Reported by <rzl24ozi@gmail.com>.
7922 * xselect.c (converted_selections, conversion_fail_tag): Now static. 4530
7923 45312013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
7924 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h". 4532
7925 (x_clipboard_manager_save_all): Move extern decl to ... 4533 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
7926 * xterm.h: ... here, so that it can be checked for consistency. 4534 start marker...
7927 4535 (unwind_with_echo_area_buffer): ...to restore it here.
79282011-05-29 Chong Yidong <cyd@stupidchicken.com> 4536 This is needed to ensure that...
7929 4537 (redisplay_window): ...both window markers are valid here,
7930 * xselect.c (x_clipboard_manager_save_frame) 4538 which is verified by eassert.
7931 (x_clipboard_manager_save_all): New functions. 4539 * editfns.c (save_excursion_save): Do not assume that
7932 (Fx_clipboard_manager_save): Lisp function deleted. 4540 selected_window always displays the buffer.
7933 4541 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
7934 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all. 4542 Fix comment.
7935 * frame.c (delete_frame): Call x_clipboard_manager_save_frame. 4543
7936 45442013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
7937 * xterm.h: Update prototype. 4545
7938 4546 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
79392011-05-28 William Xu <william.xwl@gmail.com> 4547 the upcase table.
7940 4548
7941 * nsterm.m (ns_term_shutdown): Synchronize user defaults before 45492013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
7942 exiting (Bug#8239). 4550
7943 4551 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
79442011-05-28 Jim Meyering <meyering@redhat.com> 4552
7945 45532013-03-27 Eli Zaretskii <eliz@gnu.org>
7946 Avoid a sign-extension bug in crypto_hash_function. 4554
7947 * fns.c (to_uchar): Define. 4555 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
7948 (crypto_hash_function): Use it to convert some newly-signed 4556 since MinGW's w32api headers do. This avoids compiler warnings.
7949 variables to unsigned, to avoid sign-extension bugs. For example, 4557
7950 without this change, (md5 "truc") would evaluate to 4558 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
7951 45723a2aff78ff4fff7fff1114760e62 rather than the expected 4559 if already defined.
7952 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in 4560
7953 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html. 45612013-03-26 Eli Zaretskii <eliz@gnu.org>
7954 4562
79552011-05-27 Paul Eggert <eggert@cs.ucla.edu> 4563 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
7956 4564
7957 Integer overflow fixes. 45652013-03-26 Jan Djärv <jan.h.d@swipnet.se>
7958 4566
7959 * dbusbind.c: Serial number integer overflow fixes. 4567 * gtkutil.c (style_changed_cb): Check if frame is live and an
7960 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro. 4568 X frame (Bug#14038).
7961 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float 4569
7962 to hold a serial number that is too large for a fixnum. 45702013-03-26 Eli Zaretskii <eliz@gnu.org>
7963 (Fdbus_method_return_internal, Fdbus_method_error_internal): 4571
7964 Check for serial numbers out of range. Decode any serial number 4572 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
7965 that was so large that it became a float. (Bug#8722) 4573 Define only for _WIN32_WINNT less than 0x0500.
7966 4574 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
7967 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg. 4575 MinGW64.
7968 (Fdbus_call_method, Fdbus_call_method_asynchronously): 4576 Move inclusion of time.h before sys/time.h, so that MinGW64 could
7969 Use XFASTINT rather than XUINT when numbers are nonnegative. 4577 see its own definitions of 'struct timeval' and 'struct timezone'.
7970 (xd_append_arg, Fdbus_method_return_internal): 4578
7971 (Fdbus_method_error_internal): Likewise. Also, for unsigned 4579 Fix incompatibilities between MinGW.org and MinGW64 headers.
7972 arguments, check that Lisp number is nonnegative, rather than 4580 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
7973 silently wrapping negative numbers around. (Bug#8722) 4581
7974 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int. 4582 * w32.c (REPARSE_DATA_BUFFER): Guard with
7975 (Bug#8722) 4583 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
7976 4584
7977 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT. 45852013-03-25 Jan Djärv <jan.h.d@swipnet.se>
7978 4586
7979 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'. 4587 * xterm.c: Include X11/XKBlib.h
7980 4588 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
7981 ccl: Add integer overflow checks. 4589
7982 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT): 45902013-03-24 Andreas Schwab <schwab@linux-m68k.org>
7983 (IN_INT_RANGE): New macros. 4591
7984 (ccl_driver): Use them to check for integer overflow when 4592 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
7985 decoding a CCL program. Many of the new checks are whether XINT (x) 4593 written backwards.
7986 fits in int; it doesn't always, on 64-bit hosts. The new version 4594 * blockinput.h (input_blocked_p): Likewise.
7987 doesn't catch all possible integer overflows, but it's an 4595 * bytecode.c (exec_byte_code): Likewise.
7988 improvement. (Bug#8719) 4596 * callproc.c (call_process_kill, call_process_cleanup)
7989 4597 (Fcall_process): Likewise.
7990 * alloc.c (make_event_array): Use XINT, not XUINT. 4598 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
7991 There's no need for unsigned here. 4599 (Fccl_execute_on_string): Likewise.
7992
7993 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7994 This follows up to the 2011-05-06 change that substituted uintptr_t
7995 for EMACS_INT. This case wasn't caught back then.
7996
7997 Rework Fformat to avoid integer overflow issues.
7998 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7999 now (part of C89). Include <verify.h>.
8000 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8001 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8002 (Fformat): Avoid the prepass trying to compute sizes; it was only
8003 approximate and thus did not catch overflow reliably. Instead, walk
8004 through the format just once, formatting and computing sizes as we go,
8005 checking for integer overflow at every step, and allocating a larger
8006 buffer as needed. Keep track separately whether the format is
8007 multibyte. Keep only the most-recently calculated precision, rather
8008 than them all. Record whether each argument has been converted to
8009 string. Use EMACS_INT, not int, for byte and char and arg counts.
8010 Support field widths and precisions larger than INT_MAX. Avoid
8011 sprintf's undefined behavior with conversion specifications such as %#d
8012 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8013 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8014 formatting out-of-range floating point numbers with int
8015 formats. (Bug#8668)
8016
8017 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8018
8019 * data.c: Avoid integer truncation in expressions involving floats.
8020 * data.c: Include <intprops.h>.
8021 (arith_driver): When there's an integer overflow in an expression
8022 involving floating point, convert the integers to floating point
8023 so that the resulting value does not suffer from catastrophic
8024 integer truncation. For example, on a 64-bit host (* 4
8025 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8026 Do not rely on undefined behavior after integer overflow.
8027
8028 merge count_size_as_multibyte, parse_str_to_multibyte
8029 * character.c, character.h (count_size_as_multibyte):
8030 Rename from parse_str_to_multibyte; all uses changed.
8031 Check for integer overflow.
8032 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8033 since it's now a duplicate of the other. This is more of
8034 a character than a buffer op, so better that it's in character.c.
8035 * fns.c, print.c: Adjust to above changes.
8036
80372011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8038
8039 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8040
80412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8042
8043 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8044 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8045 (x_clipboard_manager_save): Now static.
8046 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8047
8048 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8049 (crypto_hash_function): Now static.
8050 Fix pointer signedness problems. Avoid unnecessary initializations.
8051
80522011-05-27 Chong Yidong <cyd@stupidchicken.com>
8053
8054 * termhooks.h (Vselection_alist): Make it terminal-local.
8055
8056 * terminal.c (create_terminal): Initialize it.
8057
8058 * xselect.c: Support for clipboard managers.
8059 (Vselection_alist): Move to termhooks.h as terminal-local var.
8060 (LOCAL_SELECTION): New macro.
8061 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8062 (symbol_to_x_atom): Remove gratuitous arg.
8063 (x_handle_selection_request, lisp_data_to_selection_data)
8064 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8065 (x_own_selection, x_get_local_selection, x_convert_selection):
8066 New arg, specifying work frame. Use terminal-local Vselection_alist.
8067 (some_frame_on_display): Delete unused function.
8068 (Fx_own_selection_internal, Fx_get_selection_internal)
8069 (Fx_disown_selection_internal, Fx_selection_owner_p)
8070 (Fx_selection_exists_p): New optional frame arg.
8071 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8072 (x_handle_selection_clear): Don't treat other terminals with the
8073 same keyboard specially. Use the terminal-local Vselection_alist.
8074 (x_clear_frame_selections): Use Frun_hook_with_args.
8075
8076 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8077
8078 * xterm.h: Add support for those atoms.
8079
80802011-05-26 Chong Yidong <cyd@stupidchicken.com>
8081
8082 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8083 (converted_selections, conversion_fail_tag): New global variables.
8084 (x_selection_request_lisp_error): Free the above.
8085 (x_get_local_selection): Remove unnecessary code.
8086 (x_reply_selection_request): Args changed; handle arbitrary array
8087 of converted selections stored in converted_selections.
8088 Separate the XChangeProperty and SelectionNotify steps.
8089 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8090 (x_convert_selection): New function.
8091 (x_handle_selection_event): Simplify.
8092 (x_get_foreign_selection): Don't ignore incoming requests while
8093 waiting for an answer; this will fail when we implement
8094 SAVE_TARGETS, and seems unnecessary anyway.
8095 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8096 (Vx_sent_selection_functions): Doc fix.
8097
80982011-05-26 Leo Liu <sdl.web@gmail.com>
8099
8100 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8101
81022011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8103
8104 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8105
8106 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8107 for fringe update if it has periodic bitmap.
8108 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8109 and fringe_bitmap_periodic_p.
8110
8111 * fringe.c (get_fringe_bitmap_data): New function.
8112 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8113 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8114 row. Mark glyph row for fringe update if periodicity changed.
8115
8116 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8117 for fringe update unless it has periodic bitmap.
8118
81192011-05-25 Kenichi Handa <handa@m17n.org>
8120
8121 * xdisp.c (get_next_display_element): Set correct it->face_id for
8122 a static composition.
8123
81242011-05-24 Leo Liu <sdl.web@gmail.com>
8125
8126 * deps.mk (fns.o):
8127 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8128
8129 * fns.c (crypto_hash_function, Fsha1): New function.
8130 (Fmd5): Use crypto_hash_function.
8131 (syms_of_fns): Add Ssha1.
8132
81332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8134
8135 * gnutls.c: Remove unused macros.
8136 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8137 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8138 Remove macros that are defined and never used.
8139 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8140
81412011-05-22 Chong Yidong <cyd@stupidchicken.com>
8142
8143 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8144 (Fx_get_selection_internal): Minor cleanup.
8145 (Fx_own_selection_internal): Rename arguments for consistency with
8146 select.el.
8147
81482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8149
8150 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8151
81522011-05-22 Chong Yidong <cyd@stupidchicken.com>
8153
8154 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8155
81562011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8157
8158 * dispnew.c (scrolling_window): Don't exclude the case that the
8159 last enabled row in the desired matrix touches the bottom boundary.
8160
81612011-05-21 Glenn Morris <rgm@gnu.org>
8162
8163 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8164 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8165 and add some more files.
8166
81672011-05-20 Eli Zaretskii <eliz@gnu.org>
8168
8169 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8170 report_file_error introduced by the change from 2011-05-07.
8171
81722011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8173
8174 * systime.h (Time): Define only if emacs is defined.
8175 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8176 where the include path doesn't have X11/X.h by default. See
8177 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8178
81792011-05-20 Kenichi Handa <handa@m17n.org>
8180
8181 * composite.c (find_automatic_composition): Fix previous change.
8182
81832011-05-20 Glenn Morris <rgm@gnu.org>
8184
8185 * lisp.mk: New file, split from Makefile.in.
8186 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8187 (shortlisp): Remove.
8188 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8189
81902011-05-19 Glenn Morris <rgm@gnu.org>
8191
8192 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8193 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8194 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8195 (lisp): Set the order to that of loadup.el.
8196 (shortlisp): Make it a copy of $lisp.
8197 (SOME_MACHINE_LISP): Remove.
8198 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8199 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8200
82012011-05-18 Kenichi Handa <handa@m17n.org>
8202
8203 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8204 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8205 (find_automatic_composition): Mostly rewrite for efficiency.
8206
82072011-05-18 Juanma Barranquero <lekktu@gmail.com>
8208
8209 * makefile.w32-in: Update dependencies.
8210
82112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8212
8213 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8214 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8215
82162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8217
8218 Fix some integer overflow issues, such as string length overflow.
8219
8220 * insdel.c (count_size_as_multibyte): Check for string overflow.
8221
8222 * character.c (lisp_string_width): Check for string overflow.
8223 Use EMACS_INT, not int, for string indexes and lengths; in
8224 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8225 the resulting string length overflows an EMACS_INT; instead,
8226 report a string overflow if no precision given. When checking for
8227 precision exhaustion, use a check that cannot possibly have
8228 integer overflow. (Bug#8675)
8229 * character.h (lisp_string_width): Adjust to new signature.
8230
8231 * alloc.c (string_overflow): New function.
8232 (Fmake_string): Use it. This doesn't change behavior, but saves
8233 a few bytes and will simplify future changes.
8234 * character.c (string_escape_byte8): Likewise. 4600 * character.c (string_escape_byte8): Likewise.
8235 * lisp.h (string_overflow): New decl. 4601 * charset.c (read_hex): Likewise.
8236 4602 * cm.c (calccost): Likewise.
8237 Fixups, following up to the user-interface timestamp change. 4603 * data.c (cons_to_unsigned): Likewise.
8238 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time 4604 * dired.c (directory_files_internal, file_name_completion):
8239 for UI timestamps, instead of unsigned long.
8240 * msdos.c (mouse_get_pos): Likewise.
8241 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8242 * w32gui.h (Time): Define by including "systime.h" rather than by
8243 declaring it ourselves. (Bug#8664)
8244
8245 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8246 * image.c (clear_image_cache): Likewise.
8247
8248 * term.c (term_mouse_position): Don't assume time_t wraparound.
8249
8250 Be more systematic about user-interface timestamps.
8251 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8252 and sometimes 'EMACS_UINT', to represent these timestamps.
8253 This change causes it to use 'Time' uniformly, as that's what X uses.
8254 This makes the code easier to follow, and makes it easier to catch
8255 integer overflow bugs such as Bug#8664.
8256 * frame.c (Fmouse_position, Fmouse_pixel_position):
8257 Use Time, not unsigned long, for user-interface timestamps.
8258 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8259 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8260 * keyboard.h (last_event_timestamp): Likewise.
8261 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8262 * menu.h (xmenu_show): Likewise.
8263 * term.c (term_mouse_position): Likewise.
8264 * termhooks.h (struct input_event.timestamp): Likewise.
8265 (struct terminal.mouse_position_hook): Likewise.
8266 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8267 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8268 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8269 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8270 what it was before.
8271 * menu.h, termhooks.h: Include "systime.h", for Time.
8272
8273 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8274 Don't assume that the difference between two unsigned long values
8275 can fit into an integer. At this point, we know button_down_time
8276 <= event->timestamp, so the difference must be nonnegative, so
8277 there's no need to cast the result if double-click-time is
8278 nonnegative, as it should be; check that it's nonnegative, just in
8279 case. This bug is triggered when events are more than 2**31 ms
8280 apart (about 25 days). (Bug#8664)
8281
8282 * xselect.c (last_event_timestamp): Remove duplicate decl.
8283 (x_own_selection): Remove needless cast to unsigned long.
8284
8285 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8286 that always fit in int. Use a sentinel instead of a counter, to
8287 avoid a temp and to allay GCC's concerns about possible int overflow.
8288 * frame.h (struct frame): Use int for menu_bar_items_used
8289 instead of EMACS_INT, since it always fits in int.
8290
8291 * menu.c (grow_menu_items): Check for int overflow.
8292
8293 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8294
8295 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8296 Before, the code was not consistent. These values cannot exceed
8297 2**31 - 1 so there's no need to make them unsigned.
8298 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8299 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8300 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8301 as modifiers.
8302 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8303
8304 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8305 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8306 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8307 presumably because the widths might not match.
8308
8309 * window.c (size_window): Avoid needless test at loop start.
8310
83112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8312
8313 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8314
83152011-05-12 Drew Adams <drew.adams@oracle.com>
8316
8317 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8318
83192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8320
8321 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8322 `width' to `bar_area_x' and `bar_area_width', respectively.
8323 (x_scroll_run): Take account of fringe background extension.
8324
8325 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8326 Rename local vars `left' and `width' to `bar_area_x' and
8327 `bar_area_width', respectively.
8328 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8329 background extension.
8330
83312011-05-10 Jim Meyering <meyering@redhat.com>
8332
8333 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8334
83352011-05-10 Juanma Barranquero <lekktu@gmail.com>
8336
8337 * image.c (Finit_image_library): Return t for built-in image types,
8338 like pbm and xbm. (Bug#8640)
8339
83402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8341
8342 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8343
83442011-05-07 Eli Zaretskii <eliz@gnu.org>
8345
8346 * w32console.c (Fset_screen_color): Doc fix.
8347 (Fget_screen_color): New function.
8348 (syms_of_ntterm): Defsubr it.
8349
8350 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8351 unlink the temporary file if Fcall_process didn't create it in the
8352 first place.
8353 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8354 child process will be redirected to a file specified with `:file'.
8355 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8356 cue to call_process_cleanup not to close that handle.
8357
83582011-05-07 Ben Key <bkey76@gmail.com>
8359
8360 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8361 one of two shell specific rules, either bootstrap-temacs-CMD or
8362 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8363 to the previous implementation of the bootstrap-temacs rule.
8364 The bootstrap-temacs-CMD rule is similar to the previous
8365 implementation of the bootstrap-temacs rule except that it
8366 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8367 variable.
8368
8369 These changes, along with some changes to nt/configure.bat,
8370 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8371 earlier fix to add support for --cflags and --ldflags options
8372 that include quotes so that it works whether make uses cmd or
8373 sh as the shell.
8374
83752011-05-06 Michael Albinus <michael.albinus@gmx.de>
8376
8377 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8378 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8379 is a constant.
8380 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8381 a string. Handle both cases.
8382 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8383 (Fdbus_register_method): Use Qinvalid_function.
8384
83852011-05-06 Juanma Barranquero <lekktu@gmail.com>
8386
8387 * makefile.w32-in: Update dependencies.
8388 (LISP_H): Add inttypes.h and stdin.h.
8389 (PROCESS_H): Add unistd.h.
8390
83912011-05-06 Eli Zaretskii <eliz@gnu.org>
8392
8393 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8394 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8395
83962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8397
8398 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8399
8400 * term.c (vfatal): Remove stray call to va_end.
8401 It's not needed and the C Standard doesn't allow it here anyway.
8402
8403 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8404 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8405
8406 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8407 bytes.
8408
8409 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8410
8411 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8412
8413 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8414
8415 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8416
8417 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8418
8419 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8420 * charset.c (Fdefine_charset_internal): Don't initialize
8421 charset.code_space[15]. The value was garbage, on hosts with
8422 32-bit int (Bug#8600).
8423
8424 * lread.c (read_integer): Be more consistent with string-to-number.
8425 Use string_to_number to do the actual conversion; this avoids
8426 rounding errors and fixes some other screwups. Without this fix,
8427 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8428 (digit_to_number): Move earlier, for benefit of read_integer.
8429 Return -1 if the digit is out of range for the base, -2 if it is
8430 not a digit in any supported base. (Bug#8602)
8431
8432 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8433
8434 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8435 to match comment at start of function. This also removes a
8436 GCC warning about overflow in a 32+64-bit port.
8437
8438 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8439
8440 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8441 Reported by Stefan Monnier in
8442 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8443 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8444 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8445
8446 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8447 (EMACS_UINTPTR): Likewise, with uintptr_t.
8448
8449 * lisp.h: Prefer 64-bit EMACS_INT if available.
8450 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8451 on 32-bit hosts that have 64-bit int, so that they can access
8452 large files.
8453 However, temporarily disable this change unless the temporary
8454 symbol WIDE_EMACS_INT is defined.
8455
8456 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8457
8458 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8459 This removes an assumption that EMACS_INT and long are the same
8460 width as pointers. The assumption is true for Emacs porting targets
8461 now, but we want to make other targets possible.
8462 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8463 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8464 In the rest of the code, change types of integers that hold casted
8465 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8466 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8467 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8468 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8469 No need to cast type when ORing.
8470 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8471 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8472 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8473 assume EMACS_INT is the same width as char *.
8474 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8475 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8476 Remove no-longer-needed casts.
8477 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8478 (xg_tool_bar_help_callback, xg_make_tool_item):
8479 Use EMACS_INTPTR to hold an integer
8480 that will be cast to void *; this can avoid a GCC warning
8481 if EMACS_INT is not the same width as void *.
8482 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8483 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8484 (current_message_1, set_message_1):
8485 Use a local to convert to proper width without a cast.
8486 * xmenu.c (dialog_selection_callback): Likewise.
8487
8488 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8489 Also, don't assume VALBITS / RAND_BITS is less than 5,
8490 and don't rely on undefined behavior when shifting a 1 left into
8491 the sign bit.
8492 * lisp.h (get_random): Change signature to match.
8493
8494 * lread.c (hash_string): Use size_t, not int, for hash computation.
8495 Normally we prefer signed values; but hashing is special, because
8496 it's better to use unsigned division on hash table sizes so that
8497 the remainder is nonnegative. Also, size_t is the natural width
8498 for hashing into memory. The previous code used 'int', which doesn't
8499 retain enough info to hash well into very large tables.
8500 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8501
8502 * dbusbind.c: Don't possibly lose pointer info when converting.
8503 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8504 Use XPNTR rather than XHASH, so that the high-order bits of
8505 the pointer aren't lost when converting through void *.
8506
8507 * eval.c (Fautoload): Don't double-shift a pointer.
8508
8509 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8510
85112011-05-06 Juanma Barranquero <lekktu@gmail.com>
8512
8513 * gnutls.c (DEF_GNUTLS_FN):
8514 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8515
85162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8517
8518 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8519 marker. (Bug#8610)
8520
85212011-05-05 Eli Zaretskii <eliz@gnu.org>
8522
8523 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8524 New version that can reserve upto 2GB of heap space.
8525
85262011-05-05 Chong Yidong <cyd@stupidchicken.com>
8527
8528 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8529
85302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8531
8532 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8533 `gnutls_certificate_set_x509_key_file'.
8534
85352011-05-05 Juanma Barranquero <lekktu@gmail.com>
8536
8537 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8538 Update dependencies.
8539
85402011-05-04 Juanma Barranquero <lekktu@gmail.com>
8541
8542 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8543 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8544 Remove unused parameter `fildes'.
8545 * process.c (read_process_output, send_process): Don't pass it.
8546
85472011-05-04 Juanma Barranquero <lekktu@gmail.com>
8548
8549 Fix previous change: the library cache is defined in w32.c.
8550 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8551 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8552
85532011-05-04 Juanma Barranquero <lekktu@gmail.com>
8554
8555 Implement dynamic loading of GnuTLS on Windows.
8556
8557 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8558 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8559 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8560 Declare.
8561
8562 * gnutls.c (Qgnutls_dll): Define.
8563 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8564 (gnutls_*): Declare function pointers.
8565 (init_gnutls_functions): New function to initialize function pointers.
8566 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8567 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8568 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8569 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8570 (emacs_gnutls_write, emacs_gnutls_read)
8571 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8572 (Fgnutls_available_p): New function.
8573 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8574 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8575 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8576
8577 * image.c: Include w32.h.
8578 (Vimage_type_cache): Delete.
8579 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8580 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8581 (w32_delayed_load): Move to w32.c.
8582
8583 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8584
8585 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8586 (w32_delayed_load): Move from image.c. When loading a library, record
8587 its filename in the :loaded-from property of the library id.
8588 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8589 Initialize and staticpro them.
8590 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8591
8592 * process.c: Include lisp.h before w32.h, not after.
8593 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8594 instead of gnutls_record_check_pending.
8595
8596 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8597
85982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8599
8600 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8601 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8602 as passed in.
8603
86042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8605
8606 * xterm.c (x_set_frame_alpha): Do not set property on anything
8607 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8608
86092011-05-02 Juanma Barranquero <lekktu@gmail.com>
8610
8611 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8612
86132011-05-02 Juanma Barranquero <lekktu@gmail.com>
8614
8615 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8616 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8617 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8618 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8619 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8620 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8621 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8622 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8623 (Qgnutls_bootprop_callbacks_verify): Make static.
8624
86252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8626
8627 * callproc.c: Indentation fixup.
8628
8629 * sysdep.c (wait_for_termination_1): Make static.
8630 (wait_for_termination, interruptible_wait_for_termination):
8631 Move after wait_for_termination_1.
8632
86332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8634
8635 * sysdep.c (interruptible_wait_for_termination): New function
8636 which is like wait_for_termination, but allows keyboard
8637 interruptions.
8638
8639 * callproc.c (Fcall_process): Add (:file "file") as an option for
8640 the STDOUT buffer.
8641 (Fcall_process_region): Ditto.
8642
86432011-04-30 Eli Zaretskii <eliz@gnu.org>
8644
8645 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8646 rather than `XVECTOR (FOO)->size'.
8647
8648 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8649 inttypes.h, as a gnulib replacement is used if it not available in
8650 system headers.
8651
86522011-04-21 Eli Zaretskii <eliz@gnu.org>
8653
8654 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8655 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8656 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8657
8658 * coding.c (coding_alloc_by_realloc): Error out if destination
8659 will grow beyond MOST_POSITIVE_FIXNUM.
8660 (decode_coding_emacs_mule): Abort if there isn't enough place in
8661 charbuf for the composition carryover bytes. Reserve an extra
8662 space for up to 2 characters produced in a loop.
8663 (decode_coding_iso_2022): Abort if there isn't enough place in
8664 charbuf for the composition carryover bytes.
8665
86662011-04-21 Eli Zaretskii <eliz@gnu.org>
8667
8668 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8669 aborting when %lld or %lll format is passed.
8670 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8671 %llo or %llx format is passed. (Bug#8545)
8672
8673 * window.c (window_scroll_line_based): Use a marker instead of
8674 simple variables to record original value of point. (Bug#7952)
8675
8676 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8677 produced by %s or %c overflows available buffer space. (Bug#8545)
8678
86792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8680
8681 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8682 (SIZE_MAX): Move defn after all includes, as they might #define it.
8683
86842011-04-28 Juanma Barranquero <lekktu@gmail.com>
8685
8686 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8687
86882011-04-28 Juanma Barranquero <lekktu@gmail.com>
8689
8690 * keyboard.c (Qdelayed_warnings_hook): Define.
8691 (command_loop_1): Run `delayed-warnings-hook'
8692 if Vdelayed_warnings_list is non-nil.
8693 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8694 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8695
86962011-04-28 Eli Zaretskii <eliz@gnu.org>
8697
8698 * doprnt.c (doprnt): Don't return value smaller than the buffer
8699 size if the message was truncated. (Bug#8545).
8700
87012011-04-28 Juanma Barranquero <lekktu@gmail.com>
8702
8703 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8704 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8705
87062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8707
8708 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8709
87102011-04-27 Juanma Barranquero <lekktu@gmail.com>
8711
8712 * makefile.w32-in: Update dependencies.
8713
87142011-04-27 Eli Zaretskii <eliz@gnu.org>
8715
8716 Improve `doprnt' and its usage. (Bug#8545)
8717 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8718 `format_end'. Remove support for %l as a conversion specifier.
8719 Don't use xrealloc. Improve diagnostics when the %l size modifier
8720 is used. Update the commentary.
8721
8722 * eval.c (verror): Simplify calculation of size_t.
8723
8724 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8725 messages.
8726
87272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8728
8729 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8730 change.
8731
87322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8733
8734 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8735 This makes this file independent of the recent pseudovector change.
8736
87372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8738
8739 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8740
8741 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8742 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8743 Remove unused local.
8744 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8745
8746 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8747 GCC 4.6.0 optimizes based on type-based alias analysis.
8748 For example, if b is of type struct buffer * and v of type struct
8749 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8750 != &v->size, and therefore "v->size = 1; b->size = 2; return
8751 v->size;" must therefore return 1. This assumption is incorrect
8752 for Emacs, since it type-puns struct Lisp_Vector * with many other
8753 types. To fix this problem, this patch adds a new type struct
8754 vectorlike_header that documents the constraints on layout of vectors
8755 and pseudovectors, and helps optimizing compilers not get fooled
8756 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8757 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8758 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8759 the size member.
8760 (XSETPVECTYPE): Rewrite in terms of new macro.
8761 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8762 This is a bit clearer, and further avoids the possibility of
8763 undesirable aliasing.
8764 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8765 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8766 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8767 since Lisp_Subr is a special case (no "next" field).
8768 (ASIZE): Now uses header.size rather than size.
8769 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8770 to avoid the hassle of writing XVECTOR (foo)->header.size.
8771 (struct vectorlike_header): New type.
8772 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8773 object, to help avoid aliasing.
8774 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8775 (SUBRP): Likewise, since Lisp_Subr is a special case.
8776 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8777 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8778 (struct Lisp_Hash_Table): Combine first two members into a single
8779 struct vectorlike_header member. All uses of "size" and "next" members
8780 changed to be "header.size" and "header.next".
8781 * buffer.h (struct buffer): Likewise.
8782 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8783 * frame.h (struct frame): Likewise.
8784 * process.h (struct Lisp_Process): Likewise.
8785 * termhooks.h (struct terminal): Likewise.
8786 * window.c (struct save_window_data, struct saved_window): Likewise.
8787 * window.h (struct window): Likewise.
8788 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8789 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8790 * buffer.c (init_buffer_once): Likewise.
8791 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8792 special case.
8793 * process.c (Fformat_network_address): Use local var for size,
8794 for brevity.
8795
8796 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8797
8798 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8799 * data.c (atof): Remove decl; no longer used or needed.
8800 (digit_to_number): Move to lread.c.
8801 (Fstring_to_number): Use new string_to_number function, to be
8802 consistent with how the Lisp reader treats infinities and NaNs.
8803 Do not assume that floating-point numbers represent EMACS_INT
8804 without losing information; this is not true on most 64-bit hosts.
8805 Avoid double-rounding errors, by insisting on integers when
8806 parsing non-base-10 numbers, as the documentation specifies.
8807 * lisp.h (string_to_number): New decl, replacing ...
8808 (isfloat_string): Remove.
8809 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8810 (read1): Do not accept +. and -. as integers; this
8811 appears to have been a coding error. Similarly, do not accept
8812 strings like +-1e0 as floating point numbers. Do not report
8813 overflow for integer overflows unless the base is not 10 which
8814 means we have no simple and reliable way to continue.
8815 Break out the floating-point parsing into a new
8816 function string_to_number, so that Fstring_to_number parses
8817 floating point numbers consistently with the Lisp reader.
8818 (digit_to_number): Move here from data.c. Make it static inline.
8819 (E_CHAR, EXP_INT): Remove, replacing with ...
8820 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8821 (string_to_number): New function, replacing isfloat_string.
8822 This function checks for valid syntax and produces the resulting
8823 Lisp float number too. Rework it so that string-to-number
8824 no longer mishandles examples like "1.0e+". Use strtoumax,
8825 so that overflow for non-base-10 numbers is reported only when
8826 there's no portable and simple way to convert to floating point.
8827
8828 * textprop.c (set_text_properties_1): Rewrite for clarity,
8829 and to avoid GCC warning about integer overflow.
8830
8831 * intervals.h (struct interval): Use EMACS_INT for members
8832 where EMACS_UINT might cause problems. See
8833 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8834 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8835 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8836 All uses changed.
8837 (offset_intervals): Tell GCC not to worry about length overflow
8838 when negating a negative length.
8839
8840 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8841 (overrun_check_free): Likewise.
8842
8843 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8844 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8845 word size.
8846
8847 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8848 (gnutls_make_error): Rename local to avoid shadowing.
8849 (gnutls_emacs_global_deinit): ifdef out; not used.
8850 (Fgnutls_boot): Use const for pointer to readonly storage.
8851 Comment out unused local. Fix pointer signedness problems.
8852
8853 * lread.c (openp): Don't stuff size_t into an 'int'.
8854 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8855 about possible signed overflow.
8856
8857 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8858 (GDK_KEY_g): Don't define if already defined.
8859 (xg_prepare_tooltip): Avoid pointer signedness problem.
8860 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8861
8862 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8863 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8864
8865 * xfns.c (Fx_window_property): Simplify a bit,
8866 to make a bit faster and to avoid GCC 4.6.0 warning.
8867 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8868
8869 * fns.c (internal_equal): Don't assume size_t fits in int.
8870
8871 * alloc.c (compact_small_strings): Tighten assertion a little.
8872
8873 Replace pEd with more-general pI, and fix some printf arg casts.
8874 * lisp.h (pI): New macro, generalizing old pEd macro to other
8875 conversion specifiers. For example, use "...%"pI"d..." rather
8876 than "...%"pEd"...".
8877 (pEd): Remove. All uses replaced with similar uses of pI.
8878 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8879 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8880 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8881 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8882 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8883 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8884 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8885 64-bit hosts.
8886 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8887 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8888 * print.c (safe_debug_print, print_object): Likewise.
8889 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8890 to int.
8891 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8892 avoiding the 0 flag, which is not portable.
8893 * process.c (Fmake_network_process): Use pI to avoid cast.
8894 * region-cache.c (pp_cache): Likewise.
8895 * xdisp.c (decode_mode_spec): Likewise.
8896 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8897 behavior on 64-bit hosts with printf arg.
8898 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8899 (x_stop_queuing_selection_requests): Likewise.
8900 (x_get_window_property): Don't truncate byte count to an 'int'
8901 when tracing.
8902
8903 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8904 here, since it parses constructs like leading '-' and spaces,
8905 which are not wanted; and it overflows with large numbers.
8906 Instead, simply match F[0-9]+, which is what is wanted anyway.
8907
8908 * alloc.c: Remove unportable assumptions about struct layout.
8909 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8910 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8911 (allocate_vectorlike, make_pure_vector): Use the new macros,
8912 plus offsetof, to remove unportable assumptions about struct layout.
8913 These assumptions hold on all porting targets that I know of, but
8914 they are not guaranteed, they're easy to remove, and removing them
8915 makes further changes easier.
8916
8917 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8918 This doesn't fix a bug but makes the code clearer.
8919 (string_overrun_cookie): Now const. Use initializers that
8920 don't formally overflow signed char, to avoid warnings.
8921 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8922 can cause Emacs to crash when string overrun checking is enabled.
8923 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8924 multiple of sizeof (EMACS_INT); it need not be, if
8925 alignof(EMACS_INT) < sizeof (EMACS_INT).
8926 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8927
89282011-04-26 Juanma Barranquero <lekktu@gmail.com>
8929
8930 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8931
89322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8933
8934 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8935 supposed to be handshaking. (Bug#8556)
8936 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8937
89382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8939
8940 * lisp.h (Qdebug): List symbol.
8941 * eval.c (Qdebug): Restore global linkage.
8942 * keyboard.c (debug-on-event): New variable.
8943 (handle_user_signal): Break into debugger when debug-on-event
8944 matches the current signal symbol.
8945
89462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8947
8948 * alloc.c (check_sblock, check_string_bytes)
8949 (check_string_free_list): Convert to standard C.
8950
89512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8952
8953 * w32.c (emacs_gnutls_push): Fix typo.
8954
89552011-04-25 Eli Zaretskii <eliz@gnu.org>
8956
8957 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8958 "cast to pointer from integer of different size".
8959
8960 Improve doprnt and its use in verror. (Bug#8545)
8961 * doprnt.c (doprnt): Document the set of format control sequences
8962 supported by the function. Use SAFE_ALLOCA instead of always
8963 using `alloca'.
8964
8965 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8966 is one byte too soon. Don't use xrealloc; instead xfree and
8967 xmalloc anew.
8968
89692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8970
8971 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8972 callbacks stage.
8973
8974 * gnutls.c: Renamed global_initialized to
8975 gnutls_global_initialized. Added internals for the
8976 :verify-hostname-error, :verify-error, and :verify-flags
8977 parameters of `gnutls-boot' and documented those parameters in the
8978 docstring. Start callback support.
8979 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8980 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8981 on error. Return error code.
8982 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8983 (emacs_gnutls_read): Likewise.
8984 (Fgnutls_boot): Return handshake error code.
8985 (emacs_gnutls_handle_error): New function.
8986 (wsaerror_to_errno): Likewise.
8987
8988 * w32.h (emacs_gnutls_pull): Add prototype.
8989 (emacs_gnutls_push): Likewise.
8990
8991 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8992 (emacs_gnutls_push): Likewise.
8993
89942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8995
8996 * process.c (wait_reading_process_output): Check if GnuTLS
8997 buffered some data internally if no FDs are set for TLS
8998 connections.
8999
9000 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9001 (LIBS): Link to USER_LIBS.
9002 ($(BLD)/gnutls.$(0)): New target.
9003
90042011-04-24 Eli Zaretskii <eliz@gnu.org>
9005
9006 * xdisp.c (handle_single_display_spec): Rename the
9007 display_replaced_before_p argument into display_replaced_p, to
9008 make it consistent with the commentary. Fix typos in the
9009 commentary.
9010
9011 * textprop.c (syms_of_textprop): Remove dead code.
9012 (copy_text_properties): Delete obsolete commentary about an
9013 interface that was deleted long ago. Fix typos in the description
9014 of arguments.
9015
9016 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9017 to changes in oldXMenu/XMenu.h from 2011-04-16.
9018 <menu_help_message, prev_menu_help_message>: Constify.
9019 (IT_menu_make_room): menu->help_text is now `const char **';
9020 adjust.
9021
9022 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9023 to changes in oldXMenu/XMenu.h from 2011-04-16.
9024 (struct XMenu): Declare `help_text' `const char **'.
9025
9026 * xfaces.c <Qunspecified>: Make extern again.
9027
9028 * syntax.c: Include sys/types.h before including regex.h, as
9029 required by POSIX.
9030
9031 * doc.c (get_doc_string): Improve the format passed to `error'.
9032
9033 * doprnt.c (doprnt): Improve commentary.
9034
9035 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9036
9037 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9038 them with etags.
9039
9040 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9041 changes in globals.h immediately force recompilation.
9042 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9043 $(CURDIR)/s/ms-w32.h.
9044 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9045
9046 * character.c (Fchar_direction): Function deleted.
9047 (syms_of_character): Don't defsubr it.
9048 <char-direction-table>: Deleted.
9049
90502011-04-23 Eli Zaretskii <eliz@gnu.org>
9051
9052 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9053 * doprnt.c: Include limits.h.
9054 (SIZE_MAX): New macro.
9055 (doprnt): Return a size_t value. 2nd arg is now size_t.
9056 Many local variables are now size_t instead of int or unsigned.
9057 Improve overflow protection. Support `l' modifier for integer
9058 conversions. Support %l conversion. Don't assume an EMACS_INT
9059 argument for integer conversions and for %c.
9060
9061 * lisp.h (doprnt): Restore prototype.
9062
9063 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9064 $(SRC)/character.h.
9065
9066 * Makefile.in (base_obj): Add back doprnt.o.
9067
9068 * deps.mk (doprnt.o): Add back prerequisites.
9069 (callint.o): Depend on character.h.
9070
9071 * eval.c (internal_lisp_condition_case): Include the handler
9072 representation in the error message.
9073 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9074 when breaking from the loop.
9075
9076 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9077
9078 * callint.c (Fcall_interactively): When displaying error message
9079 about invalid control letter, pass the character's codepoint, not
9080 a pointer to its multibyte form. Improve display of the character
9081 in octal and display also its hex code.
9082
9083 * character.c (char_string): Use %x to display the (unsigned)
9084 codepoint of an invalid character, to avoid displaying a bogus
9085 negative value.
9086
9087 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9088 `error', not SYMBOL_NAME itself.
9089
9090 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9091 character arguments to `error'.
9092
9093 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9094 to `error' in error message about FINAL_CHAR argument. Make sure
9095 FINAL_CHAR is a character, and use %c when it is passed as
9096 argument to `error'.
9097
90982011-04-23 Eli Zaretskii <eliz@gnu.org>
9099
9100 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9101
9102 * w32.c: Include <time.h>.
9103 (sys_localtime): New function.
9104
91052011-04-23 Chong Yidong <cyd@stupidchicken.com>
9106
9107 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9108
9109 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9110
91112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9112
9113 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9114 zombies (Bug#8467).
9115
91162011-04-19 Eli Zaretskii <eliz@gnu.org>
9117
9118 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9119 gl_state.e_property when gl_state.object is Qt.
9120
9121 * insdel.c (make_gap_larger): Remove limitation of buffer size
9122 to <= INT_MAX.
9123
91242011-04-18 Chong Yidong <cyd@stupidchicken.com>
9125
9126 * xdisp.c (lookup_glyphless_char_display)
9127 (produce_glyphless_glyph): Handle cons cell entry in
9128 glyphless-char-display.
9129 (Vglyphless_char_display): Document it.
9130
9131 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9132 glyphless-char-display.
9133
91342011-04-17 Chong Yidong <cyd@stupidchicken.com>
9135
9136 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9137
9138 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9139
9140 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9141 definition for no-X builds.
9142
91432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9144
9145 Static checks with GCC 4.6.0 and non-default toolkits.
9146
9147 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9148
9149 * process.c (keyboard_bit_set): Define only if SIGIO.
9150 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9151 (send_process): Repair possible setjmp clobbering.
9152
9153 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9154
9155 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9156
9157 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9158
9159 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9160 Define only if needed.
9161
9162 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9163 by pacifying GCC about it. Maybe it's time to retire it?
9164 * xfaces.c (USG, __TIMEVAL__): Likewise.
9165
9166 * dispextern.h (struct redisplay_interface): Rename param
9167 to avoid shadowing.
9168 * termhooks.h (struct terminal): Likewise.
9169 * xterm.c (xembed_send_message): Likewise.
9170
9171 * insdel.c (make_gap_smaller): Define only if
9172 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9173
9174 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9175 it.
9176
9177 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9178 so that we aren't warned about unused symbols.
9179
9180 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9181
9182 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9183
9184 * xfns.c (x_real_positions): Mark locals as initialized.
9185
9186 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9187
9188 * xterm.c: Fix problems found by static analysis with other toolkits.
9189 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9190 (x_dispatch_event): Declare static if USE_GTK, and
9191 define if USE_GTK || USE_X_TOOLKIT.
9192 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9193 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9194 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9195 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9196
9197 * xmenu.c (menu_help_callback): Pointer type fixes.
9198 Use const pointers when pointing at readonly data. Avoid pointer
9199 signedness clashes.
9200 (FALSE): Remove unused macro.
9201 (update_frame_menubar): Remove unused decl.
9202
9203 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9204
9205 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9206 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9207 (single_menu_item): Rename local to avoid shadowing.
9208
9209 * keyboard.c (make_lispy_event): Remove unused local var.
9210
9211 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9212 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9213
9214 * bitmaps: Change bitmaps from unsigned char back to the X11
9215 compatible char. Avoid the old compiler warnings about
9216 out-of-range initializers by using, for example, '\xab' rather
9217 than 0xab.
9218
9219 * xgselect.c (xgselect_initialize): Check vs interface
9220 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9221
9222 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9223
9224 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9225 to read-only memory.
9226
9227 * fns.c (vector): Remove; this old hack is no longer needed.
9228
9229 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9230 Remove unused var.
9231 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9232
9233 * xrdb.c (x_load_resources): Omit unused local.
9234
9235 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9236 (x_window): Rename locals to avoid shadowing.
9237 (USG): Use the kludged USG macro, to pacify gcc.
9238
9239 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9240 (x_term_init): Remove local to avoid shadowing.
9241
9242 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9243
9244 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9245 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9246
92472011-04-16 Eli Zaretskii <eliz@gnu.org>
9248
9249 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9250
9251 Fix regex.c, syntax.c and friends for buffers > 2GB.
9252 * syntax.h (struct gl_state_s): Declare character position members
9253 EMACS_INT.
9254
9255 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9256
9257 * textprop.c (verify_interval_modification, interval_of):
9258 Declare arguments EMACS_INT.
9259
9260 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9261 EMACS_INT.
9262
9263 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9264
9265 * indent.c (Fvertical_motion): Local variable it_start is now
9266 EMACS_INT.
9267
9268 * regex.c (re_match, re_match_2, re_match_2_internal)
9269 (bcmp_translate, regcomp, regexec, print_double_string)
9270 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9271 (re_compile_pattern, re_exec): Declare arguments and local
9272 variables `size_t' and `ssize_t' and return values `regoff_t', as
9273 appropriate.
9274 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9275 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9276 <compile_stack_type>: `size' and `avail' are now `size_t'.
9277
9278 * regex.h <regoff_t>: Use ssize_t, not int.
9279 (re_search, re_search_2, re_match, re_match_2): Arguments that
9280 specify buffer/string position and length are now ssize_t and
9281 size_t. Return type is regoff_t.
9282
92832011-04-16 Ben Key <bkey76@gmail.com>
9284
9285 * nsfont.m: Fixed bugs in ns_get_family and
9286 ns_descriptor_to_entity that were caused by using free to
9287 deallocate memory blocks that were allocated by xmalloc (via
9288 xstrdup). This caused Emacs to crash when compiled with
9289 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9290 --enable-checking=xmallocoverrun). xfree is now used to
9291 deallocate these memory blocks.
9292
92932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9294
9295 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9296
9297 emacs_write: Accept and return EMACS_INT for sizes.
9298 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9299 et seq.
9300 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9301 Accept and return EMACS_INT.
9302 (emacs_gnutls_write): Return the number of bytes written on
9303 partial writes.
9304 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9305 (emacs_read, emacs_write): Remove check for negative size, as the
9306 Emacs source code has been audited now.
9307 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9308 (emacs_read, emacs_write): Use it.
9309 * process.c (send_process): Adjust to the new signatures of
9310 emacs_write and emacs_gnutls_write. Do not attempt to store
9311 a byte offset into an 'int'; it might overflow.
9312 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9313
9314 * sound.c: Don't assume sizes fit in 'int'.
9315 (struct sound_device.period_size, alsa_period_size):
9316 Return EMACS_INT, not int.
9317 (struct sound_device.write, vox_write, alsa_write):
9318 Accept EMACS_INT, not int.
9319 (wav_play, au_play): Use EMACS_INT to store sizes and to
9320 record read return values.
9321
93222011-04-15 Ben Key <bkey76@gmail.com>
9323
9324 * keyboard.c (Qundefined): Don't declare static since it is used
9325 in nsfns.m.
9326 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9327 static since they are used in nsfont.m.
9328
93292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9330
9331 * process.c (Qprocessp): Don't declare static.
9332 * lisp.h (Qprocessp): Declare again.
9333
93342011-04-15 Juanma Barranquero <lekktu@gmail.com>
9335
9336 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9337
93382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9339
9340 Improve C-level modularity by making more things 'static'.
9341
9342 Don't publish debugger-only interfaces to other modules.
9343 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9344 (verify_bytepos, count_markers): Move decls to the only modules
9345 that need them.
9346 * region-cache.h (pp_cache): Likewise.
9347 * window.h (check_all_windows): Likewise.
9348 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9349
9350 * sysdep.c (croak): Now static, if
9351 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9352 * syssignal.h (croak): Declare only if not static.
9353
9354 * alloc.c (refill_memory_reserve): Now static if
9355 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9356 * lisp.h (refill_memory_reserve): Declare only if not static.
9357
9358 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9359 Define only if USE_LUCID.
9360
9361 * xrdb.c (x_customization_string, x_rm_string): Now static.
9362
9363 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9364 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9365
9366 * xdisp.c (draw_row_with_mouse_face): Now static.
9367 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9368
9369 * window.h (check_all_windows): Mark externally visible.
9370
9371 * window.c (window_deletion_count): Now static.
9372
9373 * undo.c: Make symbols static if they're not exported.
9374 (last_undo_buffer, last_boundary_position, pending_boundary):
9375 Now static.
9376
9377 * textprop.c (interval_insert_behind_hooks): Now static.
9378 (interval_insert_in_front_hooks): Likewise.
9379
9380 * term.c: Make symbols static if they're not exported.
9381 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9382 (max_frame_lines, tty_set_terminal_modes):
9383 (tty_reset_terminal_modes, tty_turn_off_highlight):
9384 (get_tty_terminal): Now static.
9385 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9386 * termhooks.h (term_mouse_moveto): Do not declare if
9387 HAVE_WINDOW_SYSTEM.
9388 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9389 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9390
9391 * sysdep.c: Make symbols static if they're not exported.
9392 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9393 Now static.
9394 (sigprocmask_set, full_mask): Remove; unused.
9395 (wait_debugging): Mark as visible.
9396 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9397 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9398
9399 * syntax.c (syntax_temp): Define only if !__GNUC__.
9400
9401 * sound.c (current_sound_device, current_sound): Now static.
9402
9403 * search.c (searchbufs, searchbuf_head): Now static.
9404
9405 * scroll.c (scroll_cost): Remove; unused.
9406 * dispextern.h (scroll_cost): Remove decl.
9407
9408 * region-cache.h (pp_cache): Mark as externally visible.
9409
9410 * process.c: Make symbols static if they're not exported.
9411 (process_tick, update_tick, create_process, chan_process):
9412 (Vprocess_alist, proc_buffered_char, datagram_access):
9413 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9414 (deactivate_process): Mark defn as static, as well as decl.
9415 * lisp.h (create_process): Remove decl.
9416 * process.h (chan_process, Vprocess_alist): Remove decls.
9417
9418 * print.c: Make symbols static if they're not exported.
9419 (print_depth, new_backquote_output, being_printed, print_buffer):
9420 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9421 (print_interval, print_number_index, initial_stderr_stream):
9422 Now static.
9423 * lisp.h (Fprinc): Remove decl.
9424 (debug_output_compilation_hack): Mark as externally visible.
9425
9426 * sysdep.c (croak): Move decl from here to syssignal.h.
9427 * syssignal.h (croak): Put it here, so the API can be checked when
9428 'croak' is called from dissociate_if_controlling_tty.
9429
9430 * minibuf.c: Make symbols static if they're not exported.
9431 (minibuf_save_list, choose_minibuf_frame): Now static.
9432 * lisp.h (choose_minibuf_frame): Remove decl.
9433
9434 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9435
9436 * lread.c: Make symbols static if they're not exported.
9437 (read_objects, initial_obarray, oblookup_last_bucket_number):
9438 Now static.
9439 (make_symbol): Remove; unused.
9440 * lisp.h (initial_obarray, make_symbol): Remove decls.
9441
9442 * keyboard.c: Make symbols static if they're not exported.
9443 (single_kboard, recent_keys_index, total_keys, recent_keys):
9444 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9445 (this_single_command_key_start, echoing, last_auto_save):
9446 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9447 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9448 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9449 (Vlispy_mouse_stem, double_click_count):
9450 Now static.
9451 (force_auto_save_soon): Define only if SIGDANGER.
9452 (ignore_mouse_drag_p): Now static if
9453 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9454 (print_help): Remove; unused.
9455 (stop_character, last_timer_event): Mark as externally visible.
9456 * keyboard.h (ignore_mouse_drag_p): Declare only if
9457 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9458 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9459 * lisp.h (echoing): Remove decl.
9460 (force_auto_save_soon): Declare only if SIGDANGER.
9461 * xdisp.c (redisplay_window): Simplify code, to make it more
9462 obvious that ignore_mouse_drag_p is not accessed if !defined
9463 USE_GTK && !defined HAVE_NS.
9464
9465 * intervals.c: Make symbols static if they're not exported.
9466 (merge_properties_sticky, merge_interval_right, delete_interval):
9467 Now static.
9468 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9469
9470 * insdel.c: Make symbols static if they're not exported.
9471 However, leave prepare_to_modify_buffer alone. It's never
9472 called from outside this function, but that appears to be a bug.
9473 (combine_after_change_list, combine_after_change_buffer):
9474 (adjust_after_replace, signal_before_change): Now static.
9475 (adjust_after_replace_noundo): Remove; unused.
9476 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9477 (signal_before_change): Remove decls.
9478
9479 * indent.c (val_compute_motion, val_vmotion): Now static.
9480
9481 * image.c: Make symbols static if they're not exported.
9482 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9483 if USE_GTK.
9484 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9485 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9486
9487 * fringe.c (standard_bitmaps): Now static.
9488 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9489
9490 * frame.c: Make symbols static if they're not exported.
9491 (x_report_frame_params, make_terminal_frame): Now static.
9492 (get_frame_param): Now static, unless HAVE_NS.
9493 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9494 (x_get_resource_string): Remove; not used.
9495 * frame.h (make_terminal_frame, x_report_frame_params):
9496 (x_get_resource_string); Remove decls.
9497 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9498 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9499
9500 * font.c, fontset.c: Make symbols static if they're not exported.
9501 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9502 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9503 * font.c (font_close_object): Now static.
9504 * font.h (font_close_object): Remove.
9505 * fontset.c (FONTSET_OBJLIST): Remove.
9506 (free_realized_fontset) #if-0 the body, which does nothing.
9507 (face_suitable_for_char_p): #if-0, as it's never called.
9508 * fontset.h (face_suitable_for_char_p): Remove decl.
9509 * xfaces.c (face_at_string_position):
9510 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9511 since 0 is always ASCII.
9512
9513 * fns.c (weak_hash_tables): Now static.
9514
9515 * fileio.c: Make symbols static if they're not exported.
9516 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9517 (Vwrite_region_annotation_buffers): Now static.
9518
9519 * eval.c: Make symbols static if they're not exported.
9520 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9521 * lisp.h (backtrace_list): Remove decl.
9522
9523 * emacs.c: Make symbols static if they're not exported.
9524 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9525 (fatal_error_code, fatal_error_signal_hook, standard_args):
9526 Now static.
9527 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9528 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9529 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9530 * lisp.h (fatal_error_signal_hook): Remove decl.
9531 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9532
9533 * editfns.c: Move a (normally-unused) function to its only use.
9534 * editfns.c, lisp.h (get_operating_system_release): Remove.
9535 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9536 worth the hassle of breaking this out.
9537
9538 * xterm.c: Make symbols static if they're not exported.
9539 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9540 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9541 (x_destroy_window, x_delete_display):
9542 Now static.
9543 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9544 (x_mouse_leave): Remove; unused.
9545 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9546 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9547 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9548 Remove decls.
9549 (x_mouse_leave): Declare only if WINDOWSNT.
9550 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9551 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9552 USE_X_TOOLKIT.
9553
9554 * ftxfont.c: Make symbols static if they're not exported.
9555 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9556 HAVE_FREETYPE.
9557 * font.h (ftxfont_driver): Likewise.
9558
9559 * xfns.c: Make symbols static if they're not exported.
9560 (x_last_font_name, x_display_info_for_name):
9561 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9562 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9563 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9564 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9565 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9566 (last_show_tip_args): Now static.
9567 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9568 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9569 (x_screen_planes): Remove; unused.
9570 * dispextern.h (x_screen_planes): Remove decl.
9571
9572 * dispnew.c: Make symbols static if they're not exported.
9573 * dispextern.h (redraw_garbaged_frames, scrolling):
9574 (increment_row_positions): Remove.
9575 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9576 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9577 Now static.
9578 (redraw_garbaged_frames): Remove; unused.
9579
9580 * xfaces.c: Make symbols static if they're not exported.
9581 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9582 Remove decls.
9583 * xterm.h (defined_color): Remove decls.
9584 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9585 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9586 (menu_face_changed_default, defined_color, free_realized_face):
9587 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9588 (ascii_face_of_lisp_face): Remove; unused.
9589
9590 * xdisp.c: Make symbols static if they're not exported.
9591 * dispextern.h (scratch_glyph_row, window_box_edges):
9592 (glyph_to_pixel_coords, set_cursor_from_row):
9593 (get_next_display_element, set_iterator_to_next):
9594 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9595 (show_mouse_face): Remove decls
9596 * frame.h (message_buf_print): Likewise.
9597 * lisp.h (pop_message, set_message, check_point_in_composition):
9598 Likewise. 4605 Likewise.
9599 * xterm.h (set_vertical_scroll_bar): Likewise. 4606 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
9600 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed): 4607 (sit_for): Likewise.
9601 (message_buf_print, scratch_glyph_row, displayed_buffer): 4608 * doc.c (Fsubstitute_command_keys): Likewise.
9602 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row): 4609 * doprnt.c (doprnt): Likewise.
9603 (get_next_display_element, show_mouse_face, window_box_edges): 4610 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
9604 (frame_to_window_pixel_xy, check_point_in_composition): 4611 * emacsgtkfixed.c: Likewise.
9605 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static. 4612 * fileio.c (file_offset, Fwrite_region): Likewise.
9606 (glyph_to_pixel_coords): Remove; unused. 4613 * floatfns.c (Fexpt, fmod_float): Likewise.
9607 4614 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
9608 * dired.c (file_name_completion): Now static.
9609
9610 * dbusbind.c (xd_in_read_queued_messages): Now static.
9611
9612 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9613 * data.c (circular_list_error): Remove.
9614
9615 * commands.h (last_point_position, last_point_position_buffer):
9616 (last_point_position_window): Remove decls.
9617 * keyboard.c: Make these variables static.
9618
9619 * coding.h (coding, code_convert_region, encode_coding_gap):
9620 Remove decls.
9621 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9622 (iso_code_class, detect_coding, code_convert_region): Now static.
9623 (encode_coding_gap): Remove; unused.
9624
9625 * chartab.c (chartab_chars, chartab_bits): Now static.
9626
9627 * charset.h (charset_iso_8859_1): Remove decl.
9628 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9629 Now static.
9630
9631 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9632 * ccl.c (Vccl_program_table): Now static.
9633 (check_ccl_update): Remove; unused.
9634
9635 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9636 * category.h: ... from here.
9637 * category.c (check_category_table, set_category_set): Now static.
9638
9639 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9640 * lisp.h: Remove these decls.
9641
9642 * buffer.c (buffer_count): Remove unused var.
9643
9644 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9645 so that it's not optimized away.
9646 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9647 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9648 exported only to the debugger.
9649
9650 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9651 * atimer.h (run_all_atimers): Remove; not exported.
9652
9653 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9654 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9655 was inaccessible from Lisp.
9656 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9657 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9658
9659 alloc.c: Import and export fewer symbols, and remove unused items.
9660 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9661 is defined.
9662 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9663 it's not optimized away by whole-program optimization.
9664 (message_enable_multibyte, free_misc): Remove.
9665 (catchlist, handlerlist, mark_backtrace):
9666 Declare only if BYTE_MARK_STACK.
9667 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9668 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9669 (message_enable_multibyte): Remove decl.
9670 (free_misc, interval_free_list, float_block, float_block_index):
9671 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9672 (cons_free_list, last_marked_index):
9673 Now static.
9674 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9675 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9676 (mark_backtrace): Define only if BYTE_MARK_STACK.
9677 * xdisp.c (message_enable_multibyte): Now static.
9678
9679 Declare Lisp_Object Q* variables to be 'static' if not exported.
9680 This makes it easier for human readers (and static analyzers)
9681 to see whether these variables are used from other modules.
9682 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9683 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9684 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9685 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9686 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9687 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9688 * xmenu.c, xselect.c:
9689 Declare Q* vars static if they are not used in other modules.
9690 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9691 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9692 Remove decls of unexported vars.
9693 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9694
9695 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9696
9697 Make Emacs functions such as Fatom 'static' by default.
9698 This makes it easier for human readers (and static analyzers)
9699 to see whether these functions can be called from other modules.
9700 DEFUN now defines a static function. To make the function external
9701 so that it can be used in other C modules, use the new macro DEFUE.
9702 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9703 (Finit_image_library):
9704 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9705 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9706 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9707 Remove decls, since these functions are now static.
9708 (Funintern, Fget_internal_run_time): New decls, since these functions
9709 were already external.
9710
9711 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9712 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9713 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9714 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9715 * keyboard.c, keymap.c, lread.c:
9716 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9717 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9718 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9719 Mark functions with DEFUE instead of DEFUN,
9720 if they are used in other modules.
9721 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9722 decls for now-static functions.
9723 * buffer.h (Fdelete_overlay): Remove decl.
9724 * callproc.c (Fgetenv_internal): Mark as internal.
9725 * composite.c (Fremove_list_of_text_properties): Remove decl.
9726 (Fcomposition_get_gstring): New forward static decl.
9727 * composite.h (Fcomposite_get_gstring): Remove decl.
9728 * dired.c (Ffile_attributes): New forward static decl.
9729 * doc.c (Fdocumntation_property): New forward static decl.
9730 * eval.c (Ffetch_bytecode): New forward static decl.
9731 (Funintern): Remove extern decl; now in .h file where it belongs.
9732 * fileio.c (Fmake_symbolic_link): New forward static decl.
9733 * image.c (Finit_image_library): New forward static decl.
9734 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9735 * intervals.h (Fprevious_property_change):
9736 (Fremove_list_of_text_properties): Remove decls.
9737 * keyboard.c (Fthis_command_keys): Remove decl.
9738 (Fcommand_execute): New forward static decl.
9739 * keymap.c (Flookup_key): New forward static decl.
9740 (Fcopy_keymap): Now static.
9741 * keymap.h (Flookup_key): Remove decl.
9742 * process.c (Fget_process): New forward static decl.
9743 (Fprocess_datagram_address): Mark as internal.
9744 * syntax.c (Fsyntax_table_p): New forward static decl.
9745 (skip_chars): Remove duplicate decl.
9746 * textprop.c (Fprevious_property_change): New forward static decl.
9747 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9748 Now internal.
9749 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9750 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9751
9752 * editfns.c (Fformat): Remove unreachable code.
9753
97542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9755
9756 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9757 change. (Bug#8496)
9758
97592011-04-13 Eli Zaretskii <eliz@gnu.org>
9760
9761 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9762 when at ZV. (Bug#8487)
9763
97642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9765
9766 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9767 (Bug#8437)
9768 * keyboard.c (parse_tool_bar_item): Likewise.
9769 * sound.c (sound_cleanup, alsa_close): Likewise.
9770 * termcap.c (tgetent): Likewise.
9771 * xfns.c (x_default_font_parameter): Likewise.
9772 * xsettings.c (read_and_apply_settings): Likewise.
9773
9774 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9775 (overrun_check_free): Protoize.
9776
97772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9778
9779 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9780 since callers should never pass a negative size.
9781 Change the signature to match that of plain 'read' and 'write'; see
9782 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9783 * lisp.h: Update prototypes of emacs_write and emacs_read.
9784
97852011-04-11 Eli Zaretskii <eliz@gnu.org>
9786
9787 * xdisp.c (redisplay_window): Don't try to determine the character
9788 position of the scroll margin if the window start point w->startp
9789 is outside the buffer's accessible region. (Bug#8468)
9790
97912011-04-10 Eli Zaretskii <eliz@gnu.org>
9792
9793 Fix write-region and its subroutines for buffers > 2GB.
9794 * fileio.c (a_write, e_write): Modify declaration of arguments and
9795 local variables to support buffers larger than 2GB.
9796 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9797
9798 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9799 argument, local variables, and return value.
9800
9801 * lisp.h: Update prototypes of emacs_write and emacs_read.
9802
9803 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9804
98052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9806
9807 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9808
9809 Fix more problems found by GCC 4.6.0's static checks.
9810
9811 * xdisp.c (vmessage): Use a better test for character truncation.
9812
9813 * charset.c (load_charset_map): <, not <=, for optimization,
9814 and to avoid potential problems with integer overflow.
9815 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9816 * casetab.c (set_identity, shuffle): Likewise.
9817 * editfns.c (Fformat): Likewise.
9818 * syntax.c (skip_chars): Likewise.
9819
9820 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9821 This also lets GCC 4.6.0 generate slightly better loop code.
9822
9823 * callint.c (Fcall_interactively): <, not <=, for optimization.
9824 (Fcall_interactively): Count the number of arguments produced,
9825 not the number of arguments given. This is simpler and lets GCC
9826 4.6.0 generate slightly better code.
9827
9828 * ftfont.c: Distingish more carefully between FcChar8 and char.
9829 The previous code passed unsigned char * to a functions like
9830 strlen and xstrcasecmp that expect char *, which does not
9831 conform to the C standard.
9832 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9833 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9834 char * when the C standard requires it.
9835
9836 * keyboard.c (read_char): Remove unused var.
9837
9838 * eval.c: Port to Windows vsnprintf (Bug#8435).
9839 Include <limits.h>.
9840 (SIZE_MAX): Define if the headers do not.
9841 (verror): Do not give up if vsnprintf returns a negative count.
9842 Instead, grow the buffer. This ports to Windows vsnprintf, which
9843 does not conform to C99. Problem reported by Eli Zaretskii.
9844 Also, simplify the allocation scheme, by avoiding the need for
9845 calling realloc, and removing the ALLOCATED variable.
9846
9847 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9848
9849 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9850 But keep the doprint source code for now, as we might revamp it
9851 and use it again (Bug#8435).
9852 * lisp.h (doprnt): Remove.
9853 * Makefile.in (base_obj): Remove doprnt.o.
9854 * deps.mk (doprnt.o): Remove.
9855
9856 error: Print 32- and 64-bit integers portably (Bug#8435).
9857 Without this change, on typical 64-bit hosts error ("...%d...", N)
9858 was used to print both 32- and 64-bit integers N, which relied on
9859 undefined behavior.
9860 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9861 * lisp.h (error, verror): Mark as printf-like functions.
9862 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9863 Report overflow in size calculations when allocating printf buffer.
9864 Do not truncate output string at its first null byte.
9865 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9866 Truncate the output at a character boundary, since vsnprintf does not
9867 do that.
9868 * charset.c (check_iso_charset_parameter): Convert internal
9869 character to string before calling 'error', since %c now has the
9870 printf meaning.
9871 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9872 overflow when computing char to be passed to 'error'. Do not
9873 pass Lisp_Object to 'error'; pass the integer instead.
9874 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9875 formatted with plain %d.
9876
9877 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9878
9879 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9880
9881 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9882
9883 * xterm.c (x_catch_errors): Remove duplicate declaration.
9884
9885 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9886
9887 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9888
98892011-04-10 Jim Meyering <meyering@redhat.com>
9890
9891 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9892 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9893 return ssize_t not "int", and use size_t as the buffer length.
9894 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9895 * gnutls.h: Update declarations.
9896 * process.c (read_process_output): Use ssize_t, to match.
9897 (send_process): Likewise.
9898
98992011-04-09 Chong Yidong <cyd@stupidchicken.com>
9900
9901 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9902
99032011-04-09 Chong Yidong <cyd@stupidchicken.com>
9904
9905 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9906 Use unsigned char, to match FcChar8 type definition.
9907
9908 * xterm.c (handle_one_xevent):
9909 * xmenu.c (create_and_show_popup_menu):
9910 * xselect.c (x_decline_selection_request)
9911 (x_reply_selection_request): Avoid type-punned deref of X events.
9912
99132011-04-09 Eli Zaretskii <eliz@gnu.org>
9914
9915 Fix some uses of `int' instead of EMACS_INT.
9916 * search.c (string_match_1, fast_string_match)
9917 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9918 (scan_buffer, find_next_newline_no_quit)
9919 (find_before_next_newline, search_command, Freplace_match)
9920 (Fmatch_data): Make some `int' variables be EMACS_INT.
9921
9922 * xdisp.c (display_count_lines): 3rd argument and return value now
9923 EMACS_INT. All callers changed.
9924 (pint2hrstr): Last argument is now EMACS_INT.
9925
9926 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9927 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9928 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9929 (decode_coding_utf_16, decode_coding_emacs_mule)
9930 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9931 (decode_coding_ccl, decode_coding_charset)
9932 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9933 (decode_coding_iso_2022, decode_coding_emacs_mule)
9934 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9935 <char_offset, last_offset>: Declare EMACS_INT.
9936 (encode_coding_utf_8, encode_coding_utf_16)
9937 (encode_coding_emacs_mule, encode_invocation_designation)
9938 (encode_designation_at_bol, encode_coding_iso_2022)
9939 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9940 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9941 Declare EMACS_INT.
9942 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9943 (encode_invocation_designation): Last argument P_NCHARS is now
9944 EMACS_INT.
9945 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9946 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9947
9948 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9949 All users changed.
9950
9951 * ccl.c (Fccl_execute_on_string): Declare some variables
9952 EMACS_INT.
9953
99542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9955
9956 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9957
99582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9959
9960 * process.c (Fformat_network_address): Doc fix.
9961
99622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9963
9964 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9965
99662011-04-08 Chong Yidong <cyd@stupidchicken.com>
9967
9968 * keyboard.c (read_char): Call Lisp function help-form-show,
9969 instead of using internal_with_output_to_temp_buffer.
9970 (Qhelp_form_show): New var.
9971 (syms_of_keyboard): Use DEFSYM macro.
9972
9973 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9974
9975 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9976
99772011-04-06 Chong Yidong <cyd@stupidchicken.com>
9978
9979 * process.c (Flist_processes): Remove to Lisp.
9980 (list_processes_1): Delete.
9981
99822011-04-06 Eli Zaretskii <eliz@gnu.org>
9983
9984 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9985
9986 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9987
99882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9989
9990 Fix more problems found by GCC 4.6.0's static checks.
9991
9992 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9993
9994 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9995
9996 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9997
9998 * xdisp.c (vmessage): Mark as a printf-like function.
9999
10000 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10001
10002 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10003
10004 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10005 printf-like functions.
10006 (tiff_load): Add casts to remove these marks before passing them
10007 to system-supplied API.
10008
10009 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10010
10011 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10012 This avoids several warnings with gcc -Wstrict-overflow.
10013 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10014 directly, rather than having caller test rule sign. This avoids
10015 some unnecessary tests.
10016 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10017 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10018 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10019
10020 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10021 (xfont_open): Avoid unnecessary tests.
10022
10023 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10024
10025 * composite.h, composite.c (composition_gstring_put_cache):
10026 Use EMACS_INT, not int, for length.
10027
10028 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10029 breaking out part of COMPOSITION_DECODE_RULE.
10030 (COMPOSITION_DECODE_RULE): Use it.
10031 * composite.c (get_composition_id): Remove unused local vars,
10032 by using the new macro.
10033
10034 * textprop.c (set_text_properties_1): Change while to do-while,
10035 since the condition is always true at first.
10036
10037 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10038 (interval_deletion_adjustment): Return unsigned value.
10039 All uses changed.
10040
10041 * process.c (list_processes_1, create_pty, read_process_output):
10042 (exec_sentinel): Remove vars that were set but not used.
10043 (create_pty): Remove unnecessary "volatile"s.
10044 (Fnetwork_interface_info): Avoid possibility of int overflow.
10045 (read_process_output): Do adaptive read buffering even if carryover.
10046 (read_process_output): Simplify nbytes computation if buffered.
10047
10048 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10049
10050 * syntax.c (scan_words): Remove var that was set but not used.
10051 (update_syntax_table): Use unsigned instead of int.
10052
10053 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10054 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10055 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10056
10057 * print.c (print_error_message): Avoid int overflow.
10058
10059 * font.c (font_list_entities): Redo for clarity,
10060 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10061
10062 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10063 (font_score): Avoid potential overflow in diff calculation.
10064
10065 * fns.c (substring_both): Remove var that is set but not used.
10066 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10067
10068 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10069
10070 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10071 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10072 can always succeed if overflow has undefined behavior.
10073
10074 * search.c (boyer_moore, wordify): Remove vars set but not used.
10075 (wordify): Omit three unnecessary tests.
10076
10077 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10078 All callers changed. This avoids the need for an unused var.
10079
10080 * casefiddle.c (casify_region): Remove var that is set but not used.
10081
10082 * dired.c (file_name_completion): Remove var that is set but not used.
10083
10084 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10085
10086 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10087 (Finsert_file_contents): Remove unnecessary code checking fd.
10088
10089 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10090 Check for integer overflow on size calculations.
10091
10092 * buffer.c (Fprevious_overlay_change): Remove var that is set
10093 but not used.
10094
10095 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10096 Remove vars that are set but not used.
10097 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10098 (timer_check_2): Mark vars as initialized.
10099
10100 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10101
10102 * image.c (lookup_image): Remove var that is set but not used.
10103 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10104
10105 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10106 that are set but not used.
10107
10108 * xfns.c (make_invisible_cursor): Don't return garbage
10109 if XCreateBitmapFromData fails (Bug#8410).
10110
10111 * xselect.c (x_get_local_selection, x_handle_property_notify):
10112 Remove vars that are set but not used.
10113
10114 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10115 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10116
10117 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10118 Remove var that is set but not used.
10119 (scroll_bar_windows_size): Now size_t, not int.
10120 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10121 Check for overflow.
10122
10123 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10124 (map_tty_color) [!defined MSDOS]: Likewise.
10125
10126 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10127
10128 * coding.c: Remove vars that are set but not used.
10129 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10130 All callers changed.
10131 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10132 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10133 (decode_coding_charset): Remove vars that are set but not used.
10134
10135 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10136 that is set but not used.
10137
10138 * print.c (print_object): Remove var that is set but not used.
10139
10140 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10141 The gnulib version avoids calling malloc in the usual case,
10142 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10143 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10144 * filelock.c (current_lock_owner): Likewise.
10145 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10146 * sysdep.c: Include allocator.h, careadlinkat.h.
10147 (emacs_no_realloc_allocator): New static constant.
10148 (emacs_readlink): New function.
10149 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10150 ../lib/careadlinkat.h.
10151
101522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10153
10154 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10155 first non-nil return value).
10156
101572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10158
10159 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10160 if not defined (Bug#8403).
10161
101622011-04-02 Juanma Barranquero <lekktu@gmail.com>
10163
10164 * xdisp.c (display_count_lines): Remove parameter `start',
10165 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10166 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10167 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10168 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10169 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10170 and thereabouts. All callers changed.
10171 (get_per_char_metric): Remove parameter `f', unused since
10172 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10173
101742011-04-02 Jim Meyering <meyering@redhat.com>
10175
10176 do not dereference NULL upon failed strdup
10177 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10178 (ns_get_family): Likewise.
10179
101802011-04-02 Juanma Barranquero <lekktu@gmail.com>
10181
10182 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10183
101842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10185
10186 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10187 later (Bug#8403).
10188
101892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10190
10191 Add lexical binding.
10192
10193 * window.c (Ftemp_output_buffer_show): New fun.
10194 (Fsave_window_excursion):
10195 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10196
10197 * lread.c (lisp_file_lexically_bound_p): New function.
10198 (Fload): Bind Qlexical_binding.
10199 (readevalloop): Remove `evalfun' arg.
10200 Bind Qinternal_interpreter_environment.
10201 (Feval_buffer): Bind Qlexical_binding.
10202 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10203 Mark as dynamic.
10204 (syms_of_lread): Declare `lexical-binding'.
10205
10206 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10207
10208 * keyboard.c (eval_dyn): New fun.
10209 (menu_item_eval_property): Use it.
10210
10211 * image.c (parse_image_spec): Use Ffunctionp.
10212
10213 * fns.c (concat, mapcar1): Accept byte-code-functions.
10214
10215 * eval.c (Fsetq): Handle lexical vars.
10216 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10217 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10218 (FletX, Flet): Obey lexical binding.
10219 (Fcommandp): Handle closures.
10220 (Feval): New `lexical' arg.
10221 (eval_sub): New function extracted from Feval. Use it almost
10222 everywhere where Feval was used. Look up vars in lexical env.
10223 Handle closures.
10224 (Ffunctionp): Move from subr.el.
10225 (Ffuncall): Handle closures.
10226 (apply_lambda): Remove `eval_flags'.
10227 (funcall_lambda): Handle closures and new byte-code-functions.
10228 (Fspecial_variable_p): New function.
10229 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10230 but without exporting it to Lisp.
10231
10232 * doc.c (Fdocumentation, store_function_docstring):
10233 * data.c (Finteractive_form): Handle closures.
10234
10235 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10236 interactive spec.
10237
10238 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10239 New byte-codes.
10240 (exec_byte_code): New function extracted from Fbyte_code to handle new
10241 calling convention for byte-code-functions. Add new byte-codes.
10242
10243 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10244
10245 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10246
102472011-03-31 Juanma Barranquero <lekktu@gmail.com>
10248
10249 * xdisp.c (redisplay_internal): Fix prototype.
10250
102512011-03-31 Eli Zaretskii <eliz@gnu.org>
10252
10253 * xdisp.c (SCROLL_LIMIT): New macro.
10254 (try_scrolling): Use it when setting scroll_limit.
10255 Limit scrolling to 100 screen lines.
10256 (redisplay_window): Even when falling back on "recentering",
10257 position point in the window according to scroll-conservatively,
10258 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10259
10260 (try_scrolling): When point is above the window, allow searching
10261 as far as scroll_max, or one screenful, to compute vertical
10262 distance from PT to the scroll margin position. This prevents
10263 try_scrolling from unnecessarily failing when
10264 scroll-conservatively is set to a value slightly larger than the
10265 window height. Clean up the case of PT below the margin at bottom
10266 of window: scroll_max can no longer be INT_MAX. When aggressive
10267 scrolling is in use, don't let point enter the opposite scroll
10268 margin as result of the scroll.
10269 (syms_of_xdisp) <scroll-conservatively>: Document the
10270 threshold of 100 lines for never-recentering scrolling.
10271
102722011-03-31 Juanma Barranquero <lekktu@gmail.com>
10273
10274 * dispextern.h (move_it_by_lines):
10275 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10276 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10277 (message_log_check_duplicate): Remove parameters `prev_bol' and
10278 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10279 (redisplay_internal): Remove parameter `preserve_echo_area',
10280 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10281
10282 * indent.c (Fvertical_motion):
10283 * window.c (window_scroll_pixel_based, Frecenter):
10284 Don't pass `need_y_p' to `move_it_by_lines'.
10285
102862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10287
10288 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10289 steal a few bits to be more compact.
10290 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10291 Remove unneeded casts.
10292
10293 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10294
102952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10296
10297 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10298 binding" message (bug#7967).
10299
103002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10301
10302 Fix more problems found by GCC 4.6.0's static checks.
10303
10304 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10305 Remove unused local var.
10306
10307 * editfns.c (Fmessage_box): Remove unused local var.
10308
10309 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10310 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10311 Omit unused local vars.
10312 * window.c (shrink_windows): Omit unused local var.
10313 * menu.c (digest_single_submenu): Omit unused local var.
10314 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10315 Omit unused local var.
10316
10317 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10318 Don't assume string length fits in int.
10319 (keyremap_step, read_key_sequence): Use size_t for sizes.
10320 (read_key_sequence): Don't check last_real_key_start redundantly.
10321
10322 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10323 instead of alloca (Bug#8344).
10324
10325 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10326 (Fbacktrace_frame): Don't assume nframes fits in int.
10327
10328 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10329
10330 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10331 concerns.
10332
10333 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10334
10335 * cm.c (calccost): Turn while-do into do-while, for clarity.
10336
10337 * keyboard.c (syms_of_keyboard): Use the same style as later
10338 in this function when indexing through an array. This also
10339 works around GCC bug 48267.
10340
10341 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10342
10343 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10344
10345 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10346 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10347
10348 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10349 This avoids undefined behavior on integer overflow, and is a bit
10350 more convenient anyway since it is compared to a size_t variable.
10351
10352 Variadic C functions now count arguments with size_t, not int.
10353 This avoids an unnecessary limitation on 64-bit machines, which
10354 caused (substring ...) to crash on large vectors (Bug#8344).
10355 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10356 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10357 All variadic functions and their callers changed accordingly.
10358 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10359 * data.c (arith_driver, float_arith_driver): Likewise.
10360 * editfns.c (general_insert_function): Likewise.
10361 * eval.c (struct backtrace.nargs, interactive_p)
10362 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10363 (funcall_lambda, mark_backtrace): Likewise.
10364 * fns.c (concat): Likewise.
10365 * frame.c (x_set_frame_parameters): Likewise.
10366 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10367 0 if not found, not -1. All callers changed.
10368
10369 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10370 (stack_copy_size): Now size_t, not int.
10371 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10372
103732011-03-28 Juanma Barranquero <lekktu@gmail.com>
10374
10375 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10376 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10377 All callers changed.
10378
10379 * lisp.h (multibyte_char_to_unibyte):
10380 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10381 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10382 * character.h (CHAR_TO_BYTE8):
10383 * cmds.c (internal_self_insert):
10384 * editfns.c (general_insert_function):
10385 * keymap.c (push_key_description):
10386 * search.c (Freplace_match):
10387 * xdisp.c (message_dolog, set_message_1): All callers changed.
10388
103892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10390
10391 * keyboard.c (safe_run_hook_funcall): New function.
10392 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10393 don't set the hook to nil, but remove the offending function instead.
10394 (Qcommand_hook_internal): Remove, unused.
10395 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10396 Vcommand_hook_internal.
10397
10398 * eval.c (enum run_hooks_condition): Remove.
10399 (funcall_nil, funcall_not): New functions.
10400 (run_hook_with_args): Call each function through a `funcall' argument.
10401 Remove `cond' argument, now redundant.
10402 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10403 (Frun_hook_with_args_until_failure): Adjust accordingly.
10404 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10405
104062011-03-28 Juanma Barranquero <lekktu@gmail.com>
10407
10408 * dispextern.h (string_buffer_position): Remove declaration.
10409
10410 * print.c (strout): Remove parameter `multibyte', unused since
10411 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10412
10413 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10414 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10415 All callers changed.
10416
10417 * w32.c (_wsa_errlist): Use braces for struct initializers.
10418
10419 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10420 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10421 All callers changed.
10422 (string_buffer_position): Likewise. Also, make static (it's never
10423 used outside xdisp.c).
10424 (cursor_row_p): Remove parameter `w', unused since
10425 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10426 (decode_mode_spec): Remove parameter `precision', introduced during
10427 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10428 All callers changed.
10429
104302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10431
10432 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10433
104342011-03-27 Anders Lindgren <andlind@gmail.com>
10435
10436 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10437 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10438 (ns_update_auto_hide_menu_bar): New functions.
10439 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10440 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10441 ns_constrain_all_frames.
10442 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10443 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10444
104452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10446
10447 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10448
104492011-03-27 Glenn Morris <rgm@gnu.org>
10450
10451 * syssignal.h: Replace RETSIGTYPE with void.
10452 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10453 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10454 Replace SIGTYPE with void everywhere.
10455 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10456 * s/template.h (SIGTYPE): Remove commented out definition.
10457
104582011-03-26 Eli Zaretskii <eliz@gnu.org>
10459
10460 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10461 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10462
104632011-03-26 Juanma Barranquero <lekktu@gmail.com>
10464
10465 * w32.c (read_unc_volume): Use parameter `henum', instead of
10466 global variable `wget_enum_handle'.
10467
10468 * keymap.c (describe_vector): Remove parameters `indices' and
10469 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10470 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10471
10472 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10473
10474 * keyboard.c (timer_check): Remove parameter `do_it_now',
10475 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10476 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10477 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10478
10479 * keyboard.c (read_char):
10480 * w32menu.c (w32_menu_display_help):
10481 * xmenu.c (show_help_event, menu_help_callback):
10482 Adjust calls to `show_help_echo'.
10483
10484 * gtkutil.c (xg_maybe_add_timer):
10485 * keyboard.c (readable_events):
10486 * process.c (wait_reading_process_output):
10487 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10488
10489 * insdel.c (adjust_markers_gap_motion):
10490 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10491 (gap_left, gap_right): Don't call it.
10492
104932011-03-25 Chong Yidong <cyd@stupidchicken.com>
10494
10495 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10496 incurred during fontification.
10497
104982011-03-25 Juanma Barranquero <lekktu@gmail.com>
10499
10500 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10501 (DEFVAR_PER_BUFFER): Don't pass it.
10502
10503 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10504 (scrolling_window): Don't pass it.
10505
105062011-03-25 Juanma Barranquero <lekktu@gmail.com>
10507
10508 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10509
10510 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10511 and `suffix'.
10512 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10513 of variables specific to SELinux and computation of `encoded_absname'.
10514
10515 * image.c (XPutPixel): Remove unused variable `height'.
10516
10517 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10518
10519 * unexw32.c (get_section_info): Remove unused variable `section'.
10520
10521 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10522 (system_process_attributes): Remove unused variable `sess'.
10523 (sys_read): Remove unused variable `err'.
10524
10525 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10526 (w32_wnd_proc): Remove unused variable `isdead'.
10527 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10528 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10529 (x_create_tip_frame): Remove unused variable `tem'.
10530
10531 * w32inevt.c (w32_console_read_socket):
10532 Remove unused variable `no_events'.
10533
10534 * w32term.c (x_draw_composite_glyph_string_foreground):
10535 Remove unused variable `width'.
10536
105372011-03-24 Juanma Barranquero <lekktu@gmail.com>
10538
10539 * w32term.c (x_set_glyph_string_clipping):
10540 Don't pass uninitialized region to CombineRgn.
10541
105422011-03-23 Juanma Barranquero <lekktu@gmail.com>
10543
10544 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10545 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10546 (Fx_close_connection): Remove unused variable `i'.
10547
10548 * w32font.c (w32font_draw): Return number of glyphs.
10549 (w32font_open_internal): Remove unused variable `i'.
10550 (w32font_driver): Add missing initializer.
10551
10552 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10553 (fill_in_menu): Remove unused variable `items_added'.
10554
10555 * w32term.c (last_mouse_press_frame): Remove static global variable.
10556 (w32_clip_to_row): Remove unused variable `f'.
10557 (x_delete_terminal): Remove unused variable `i'.
10558
10559 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10560 (NOTHING): Remove unused static global variable.
10561 (uniscribe_check_otf): Remove unused variable `table'.
10562 (uniscribe_font_driver): Add missing initializers.
10563
105642011-03-23 Julien Danjou <julien@danjou.info>
10565
10566 * term.c (Fsuspend_tty, Fresume_tty):
10567 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10568 * window.c (temp_output_buffer_show):
10569 * insdel.c (signal_before_change):
10570 * frame.c (Fhandle_switch_frame):
10571 * fileio.c (Fdo_auto_save):
10572 * emacs.c (Fkill_emacs):
10573 * editfns.c (save_excursion_restore):
10574 * cmds.c (internal_self_insert):
10575 * callint.c (Fcall_interactively):
10576 * buffer.c (Fkill_all_local_variables):
10577 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10578 Use Frun_hooks.
10579 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10580 unconditionally since it does the check itself.
10581
105822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10583
10584 Fix more problems found by GCC 4.5.2's static checks.
10585
10586 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10587 the first time through the loop, since we know p0 < p1 then.
10588 This also avoids a gcc -Wstrict-overflow warning.
10589
10590 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10591 leading to a memory leak, possible in functions like
10592 load_charset_map_from_file that can allocate an unbounded number
10593 of objects (Bug#8318).
10594
10595 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10596 that could (at least in theory) be that large.
10597
10598 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10599 This is less likely to overflow, and avoids undefined behavior if
10600 overflow does occur. All callers changed. Use strtoul to scan
10601 for the unsigned long integer.
10602 (pint2hrstr): Simplify and tune code slightly.
10603 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10604
10605 * scroll.c (do_scrolling): Work around GCC bug 48228.
10606 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10607
10608 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10609 This also avoids a warning with gcc -Wstrict-overflow.
10610 (validate_x_resource_name): Simplify count usage.
10611 This also avoids a warning with gcc -Wstrict-overflow.
10612
10613 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10614 fail (Bug#8306).
10615
10616 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10617
10618 * process.c (Fmake_network_process): Use socklen_t, not int,
10619 where POSIX says socklen_t is required in portable programs.
10620 This fixes a porting bug on hosts like 64-bit HP-UX, where
10621 socklen_t is wider than int (Bug#8277).
10622 (Fmake_network_process, server_accept_connection):
10623 (wait_reading_process_output, read_process_output):
10624 Likewise. 4615 Likewise.
4616 * font.c (font_intern_prop): Likewise.
4617 * frame.c (x_set_alpha): Likewise.
4618 * gtkutil.c (get_utf8_string): Likewise.
4619 * indent.c (check_display_width): Likewise.
4620 * intervals.c (create_root_interval, rotate_right, rotate_left)
4621 (split_interval_right, split_interval_left)
4622 (adjust_intervals_for_insertion, delete_node)
4623 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4624 (merge_interval_right, merge_interval_left, copy_intervals)
4625 (set_intervals_multibyte_1): Likewise.
4626 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4627 * keymap.c (Fkey_description): Likewise.
4628 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4629 * lread.c (openp, read_integer, read1, string_to_number):
4630 Likewise.
4631 * menu.c (ensure_menu_items): Likewise.
4632 * minibuf.c (read_minibuf_noninteractive): Likewise.
4633 * print.c (printchar, strout): Likewise.
4634 * process.c (create_process, Faccept_process_output)
4635 (wait_reading_process_output, read_process_output, send_process)
4636 (wait_reading_process_output): Likewise.
4637 * profiler.c (make_log, handle_profiler_signal): Likewise.
4638 * regex.c (re_exec): Likewise.
4639 * regex.h: Likewise.
4640 * search.c (looking_at_1, Freplace_match): Likewise.
4641 * sysdep.c (get_child_status, procfs_ttyname)
4642 (procfs_get_total_memory): Likewise.
4643 * systime.h (EMACS_TIME_VALID_P): Likewise.
4644 * term.c (dissociate_if_controlling_tty): Likewise.
4645 * window.c (get_phys_cursor_glyph): Likewise.
4646 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4647 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4648 Likewise.
4649 * xfns.c (Fx_window_property): Likewise.
4650 * xmenu.c (set_frame_menubar): Likewise.
4651 * xselect.c (x_get_window_property, x_handle_dnd_message):
4652 Likewise.
4653 * xsmfns.c (smc_save_yourself_CB): Likewise.
4654 * xterm.c (x_scroll_bar_set_handle): Likewise.
4655
46562013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4657
4658 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4659 to be optional or nil. Adjust comment and convert it to docstring.
4660 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4661 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4662
46632013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4664
4665 Static checking by GCC 4.8-20130319.
4666 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4667 * process.c (Fset_process_datagram_address)
4668 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4669 * xdisp.c (get_char_face_and_encoding):
4670 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4671 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4672 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4673
46742013-03-24 Ken Brown <kbrown@cornell.edu>
4675
4676 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4677 fix compilation on 64-bit Cygwin, where underscores are not
4678 automatically prepended.
4679
4680 * w32term.c (w32_initialize): Silence compiler warning.
4681
46822013-03-23 Eli Zaretskii <eliz@gnu.org>
4683
4684 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4685 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
4686 variables, to save and restore frame dimensions.
4687 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4688 after returning from a 'fullscreen' configuration.
4689 use SendMessage instead of PostMessage to send the SC_RESTORE message,
4690 to avoid races between the main thread and the input thread.
4691
4692 * w32term.h (struct w32_output): New members normal_width,
4693 normal_height, normal_top, normal_left, and prev_fsmode.
4694 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4695 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4696 members of a frame.
4697
4698 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4699 'fullscreen' parameter. Always record previous width and height
4700 of the frame, except when switching out of maximized modes, so
4701 that they could be restored correctly, instead of resetting to the
4702 default frame dimensions. Send SC_RESTORE command to the frame,
4703 unless we are going to send SC_MAXIMIZE, to restore the frame
4704 resize hints in the mouse pointer shown by the window manager.
4705 (Bug#14032)
4706
4707 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4708
4709 * lisp.h (get_frame_param): Adjust conditions for prototype
4710 declaration.
4711
47122013-03-22 Ken Brown <kbrown@cornell.edu>
4713
4714 * unexcw.c: Drop unneeded inclusion of w32common.h.
4715 (report_sheap_usage): Declare.
4716 (read_exe_header): Add magic numbers for x86_64.
4717 (fixup_executable): Fix printf format specifier for unsigned long
4718 argument.
10625 4719
10626 * process.c: Rename or move locals to avoid shadowing. 47202013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
10627 (list_processes_1, Fmake_network_process): 4721
10628 (read_process_output_error_handler, exec_sentinel_error_handler): 4722 * frame.h (struct frame): Put menu_bar_window under #ifdef
10629 Rename or move locals. 4723 because this member is not needed when X toolkit is in use.
10630 (Fmake_network_process): Define label "retry_connect" only if needed. 4724 (fset_menu_bar_window):
10631 (Fnetwork_interface_info): Fix pointer signedness. 4725 * dispnew.c (clear_current_matrices, clear_desired_matrices)
10632 (process_send_signal): Add cast to avoid pointer signedness problem. 4726 (free_glyphs, update_frame):
10633 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros. 4727 * xdisp.c (expose_frame): Likewise.
10634 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298). 4728 (display_menu_bar): Likewise. Remove redundant eassert.
10635 4729 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
10636 Make tparam.h and terminfo.c consistent. 4730 toolkit is in use.
10637 * cm.c (tputs, tgoto, BC, UP): Remove extern decls. 4731
10638 Include tparam.h instead, since it declares them. 47322013-03-21 Paul Eggert <eggert@cs.ucla.edu>
10639 * cm.h (PC): Remove extern decl; tparam.h now does this. 4733
10640 * deps.mk (cm.o, terminfo.o): Depend on tparam.h. 4734 Use functions and constants to manipulate Lisp_Save_Value objects.
10641 * terminfo.c: Include tparam.h, to check interfaces. 4735 This replaces code that used macros and strings and token-pasting.
10642 (tparm): Make 1st arg a const pointer in decl. Put it at top level. 4736 The change makes the C source a bit easier to follow,
10643 (tparam): Adjust signature to match interface in tparam.h; 4737 and shrinks the Emacs executable a bit.
10644 this removes some undefined behavior. Check that outstring and len 4738 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
10645 are zero, which they always are with Emacs. 4739 (make_save_value): Change 1st arg from string to enum. All callers
10646 * tparam.h (PC, BC, UP): New extern decls.
10647
10648 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10649 (xftfont_open): Rename locals to avoid shadowing.
10650
10651 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10652 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10653 (OTF_TAG_SYM): Omit macro if not needed.
10654 (ftfont_list): Remove unused local.
10655 (get_adstyle_property, ftfont_pattern_entity):
10656 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10657 Rename locals to avoid shadowing.
10658
10659 * xfont.c (xfont_list_family): Mark var as initialized.
10660
10661 * xml.c (make_dom): Now static.
10662
10663 * composite.c (composition_compute_stop_pos): Rename local to
10664 avoid shadowing.
10665 (composition_reseat_it): Remove unused locals.
10666 (find_automatic_composition, composition_adjust_point): Likewise.
10667 (composition_update_it): Mark var as initialized.
10668 (find_automatic_composition): Mark vars as initialized,
10669 with a FIXME (Bug#8290).
10670
10671 character.h: Rename locals to avoid shadowing.
10672 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10673 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10674 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10675 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10676 to avoid shadowing.
10677
10678 * textprop.c (property_change_between_p): Remove; unused.
10679
10680 * intervals.c (interval_start_pos): Now static.
10681
10682 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10683
10684 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10685 Rename locals to avoid shadowing.
10686
10687 * sound.c (wav_play, au_play, Fplay_sound_internal):
10688 Fix pointer signedness.
10689 (alsa_choose_format): Remove unused local var.
10690 (wav_play): Initialize a variable to 0, to prevent undefined
10691 behavior (Bug#8278).
10692
10693 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10694
10695 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10696
10697 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10698 clobbering (Bug#8298).
10699 * sysdep.c (sys_subshell): Likewise.
10700 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10701
10702 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10703 This should get cleaned up, so that child_setup has the
10704 same signature on all platforms.
10705
10706 * callproc.c (call_process_cleanup): Now static.
10707 (relocate_fd): Rename locals to avoid shadowing.
10708
107092011-03-22 Chong Yidong <cyd@stupidchicken.com>
10710
10711 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10712 not to be necessary, and produces flickering.
10713
107142011-03-20 Glenn Morris <rgm@gnu.org>
10715
10716 * config.in: Remove file.
10717
107182011-03-20 Juanma Barranquero <lekktu@gmail.com>
10719
10720 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10721 are now in src/globals.h.
10722 (syms_of_minibuf): Remove spurious & from previous change.
10723
107242011-03-20 Leo Liu <sdl.web@gmail.com>
10725
10726 * minibuf.c (completing-read-function): New variable.
10727 (completing-read-default): Rename from completing-read.
10728 (completing-read): Call completing-read-function.
10729
107302011-03-19 Juanma Barranquero <lekktu@gmail.com>
10731
10732 * xfaces.c (Fx_load_color_file):
10733 Read color file from absolute filename (bug#8250).
10734
107352011-03-19 Juanma Barranquero <lekktu@gmail.com>
10736
10737 * makefile.w32-in: Update dependencies.
10738
107392011-03-17 Eli Zaretskii <eliz@gnu.org>
10740
10741 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10742
107432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10744
10745 Fix more problems found by GCC 4.5.2's static checks.
10746
10747 * process.c (make_serial_process_unwind, send_process_trap):
10748 (sigchld_handler): Now static.
10749
10750 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10751 That way, the code declares only the vars that it needs.
10752 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10753 * s/cygwin.h (PTY_ITERATION): Likewise.
10754 * s/darwin.h (PTY_ITERATION): Likewise.
10755 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10756
10757 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10758 * process.c (allocate_pty): Don't declare stb unless it's needed.
10759
10760 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10761 (CONSTANTLIM): Remove; unused.
10762 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10763 Define only if needed.
10764
10765 * unexelf.c (unexec): Name an expression,
10766 to avoid gcc -Wbad-function-cast warning.
10767 Use a different way to cause a compilation error if anyone uses
10768 n rather than nn, a way that does not involve shadowing.
10769 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10770
10771 * deps.mk (unexalpha.o): Remove; unused.
10772
10773 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10774 * unexec.h: New file.
10775 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10776 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10777 Depend on unexec.h.
10778 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10779 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10780 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10781 Change as necessary to match prototype in unexec.h.
10782
10783 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10784 shadowing.
10785 (back_comment, skip_chars): Mark vars as initialized.
10786
10787 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10788 Rename locals to avoid shadowing.
10789
10790 * lread.c (read1): Rewrite so as not to use empty "else".
10791 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10792
10793 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10794
10795 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10796 warning when compiling print.c.
10797
10798 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10799 instead of using an uninitialized var.
10800 (font_sort_entities): Mark var as initialized.
10801
10802 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10803
10804 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10805 pointers to constants.
10806 (font_parse_fcname): Remove unused vars.
10807 (font_delete_unmatched): Now static.
10808 (font_get_spec): Remove; unused.
10809 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10810 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10811 Rename or move locals to avoid shadowing.
10812
10813 * fns.c (require_nesting_list, require_unwind): Now static.
10814 (Ffillarray): Rename locals to avoid shadowing.
10815
10816 * floatfns.c (domain_error2): Define only if needed.
10817 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10818
10819 * alloc.c (mark_backtrace): Move decl from here ...
10820 * lisp.h: ... to here, so that it can be checked.
10821
10822 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10823 (Fdefvar): Rewrite so as not to use empty "else".
10824 (lisp_indirect_variable): Name an expression,
10825 to avoid gcc -Wbad-function-cast warning.
10826 (Fdefvar): Rename locals to avoid shadowing.
10827
10828 * callint.c (quotify_arg, quotify_args): Now static.
10829 (Fcall_interactively): Rename locals to avoid shadowing.
10830 Use const pointer when appropriate.
10831
10832 * lisp.h (get_system_name, get_operating_system_release):
10833 Move decls here, to check interfaces.
10834 * process.c (get_operating_system_release): Move decl to lisp.h.
10835 * xrdb.c (get_system_name): Likewise.
10836 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10837 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10838 some of which prompt warnings from gcc -Wbad-function-cast.
10839 (Fformat_time_string, Fencode_time, Finsert_char):
10840 (Ftranslate_region_internal, Fformat):
10841 Rename or remove local vars to avoid shadowing.
10842 (Ftranslate_region_internal): Mark var as initialized.
10843
10844 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10845 avoid shadowing.
10846
10847 * lisp.h (eassert): Check that the argument compiles, even if
10848 ENABLE_CHECKING is not defined.
10849
10850 * data.c (Findirect_variable): Name an expression, to avoid
10851 gcc -Wbad-function-cast warning.
10852 (default_value, arithcompare, arith_driver, arith_error): Now static.
10853 (store_symval_forwarding): Rename local to avoid shadowing.
10854 (Fmake_variable_buffer_local, Fmake_local_variable):
10855 Mark variables as initialized.
10856 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10857
10858 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10859 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10860 Rename locals to avoid shadowing.
10861 (mark_stack): Move local variables into the #ifdef region where
10862 they're used.
10863 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10864 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10865 needed otherwise.
10866 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10867 (GC_STRING_CHARS): Remove; not used.
10868 (Fmemory_limit): Cast sbrk's returned value to char *.
10869
10870 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10871 avoids undefined behavior in theory.
10872
10873 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10874
10875 Use functions, not macros, for up- and down-casing (Bug#8254).
10876 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10877 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10878 to use the following functions instead of these macros.
10879 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10880 EMACS_INT, since callers assume the returned value fits in int.
10881 (upcase1): Likewise, for UPCASE_TABLE.
10882 (uppercasep, lowercasep, upcase): New static inline functions.
10883 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10884 the race-condition problem in the old DOWNCASE.
10885
10886 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10887 Rename locals to avoid shadowing.
10888 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10889 (regex_compile, re_search_2, re_match_2_internal):
10890 Remove unused local vars.
10891 (FREE_VAR): Rewrite so as not to use empty "else",
10892 which gcc can warn about.
10893 (regex_compile, re_match_2_internal): Mark locals as initialized.
10894 (RETALLOC_IF): Define only if needed.
10895 (WORDCHAR_P): Likewise. This one is never needed, but is used
10896 only in a comment talking about a compiler bug, so put inside
10897 the #if 0 of that comment.
10898 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10899 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10900 Remove; unused.
10901
10902 * search.c (boyer_moore): Rename locals to avoid shadowing.
10903 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10904 (PREV_CHAR_BOUNDARY): Likewise.
10905
10906 * search.c (simple_search): Remove unused var.
10907
10908 * dired.c (compile_pattern): Move decl from here ...
10909 * lisp.h: ... to here, so that it can be checked.
10910 (struct re_registers): New forward decl.
10911
10912 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10913
10914 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10915 All uses changed.
10916 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10917 Rename locals to avoid shadowing.
10918 (Fvertical_motion): Mark locals as initialized.
10919
10920 * casefiddle.c (casify_object, casify_region): Now static.
10921 (casify_region): Mark local as initialized.
10922
10923 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10924
10925 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10926 New macros, so that the caller can use some names other than
10927 gcpro1, gcpro2, etc.
10928 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10929 of the new macros.
10930 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10931 argument, for consistency with GCPRO2_VAR, etc: it is now the
10932 prefix of the variable, not the variable itself. All uses
10933 changed. 4740 changed.
10934 * dired.c (directory_files_internal, file_name_completion): 4741 (INTX): Remove.
10935 Rename locals to avoid shadowing. 4742 (mark_object): Use if, not #if, for GC_MARK_STACK.
10936 4743 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
10937 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254). 4744 (XSAVE_OBJECT): Now functions, not macros.
10938 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in 4745 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
10939 dired.c's scmp function, had undefined behavior. 4746 the constant was never used.
10940 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): 4747 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
10941 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ... 4748 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
10942 * buffer.h: ... to here, because these macros use current_buffer, 4749 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
10943 and the new implementation with inline functions needs to have 4750 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
10944 current_buffer in scope now, rather than later when the macros 4751 New constants.
10945 are used. 4752 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
10946 (downcase, upcase1): New static inline functions. 4753 type3 with a single member save_type. All uses changed.
10947 (DOWNCASE, UPCASE1): Reimplement using these functions. 4754 (save_type, set_save_pointer, set_save_integer): New functions.
10948 This avoids undefined behavior in expressions like 4755 * print.c (PRINTX): Remove.
10949 DOWNCASE (x) == DOWNCASE (y), which previously suffered 4756
10950 from race conditions in accessing the global variables 4757 * alloc.c: Remove redundant static declarations.
10951 case_temp1 and case_temp2. 4758
10952 * casetab.c (case_temp1, case_temp2): Remove; no longer needed. 47592013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
10953 * lisp.h (case_temp1, case_temp2): Remove their decls. 4760
10954 * character.h (ASCII_CHAR_P): Move from here ... 4761 * window.h (struct window): Convert left_col, top_line, total_lines
10955 * lisp.h: ... to here, so that the inline functions mentioned 4762 and total_cols from Lisp_Objects to integers. Adjust comments.
10956 above can use them. 4763 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
10957 4764 Remove.
10958 * dired.c (directory_files_internal_unwind): Now static. 4765 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
10959 4766 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
10960 * fileio.c (file_name_as_directory, directory_file_name): 4767 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
10961 (barf_or_query_if_file_exists, auto_save_error, auto_save_1): 4768 Adjust users where appropriate.
10962 Now static. 4769
10963 (file_name_as_directory): Use const pointers when appropriate. 47702013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
10964 (Fexpand_file_name): Likewise. In particular, newdir might 4771
10965 point at constant storage, so make it a const pointer. 4772 * frame.h (struct frame): Drop resx and resy because the same data is
10966 (Fmake_directory_internal, Fread_file_name): Remove unused vars. 4773 available from window system-specific output context. Adjust users.
10967 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer 4774 (default_pixels_per_inch_x, default_pixels_per_inch_y):
10968 signedness issues. 4775 New functions to provide defaults when no window system available.
10969 (Fset_file_times, Finsert_file_contents, auto_save_error): 4776 (FRAME_RES_X, FRAME_RES_Y): New macros.
10970 Rename locals to avoid shadowing. 4777 (NUMVAL): Move from xdisp.c.
10971 4778 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
10972 * minibuf.c (choose_minibuf_frame_1): Now static. 4779 (Ffont_face_attributes, Fopen_font):
10973 (Ftry_completion, Fall_completions): Rename or remove locals 4780 * image.c (gs_load):
10974 to avoid shadowing. 4781 * w32font.c (fill_in_logfont):
10975 4782 * xdisp.c (calc_pixel_width_or_height):
10976 * marker.c (bytepos_to_charpos): Remove; unused. 4783 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
10977 4784 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
10978 * lisp.h (verify_bytepos, count_markers): New decls,
10979 so that gcc does not warn that these functions aren't declared.
10980
10981 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10982 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10983 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10984 (copy_text): Remove unused local var.
10985
10986 * filelock.c (within_one_second): Now static.
10987 (lock_file_1): Rename local to avoid shadowing.
10988
10989 * buffer.c (fix_overlays_before): Mark locals as initialized.
10990 (fix_start_end_in_overlays): Likewise. This function should be
10991 simplified by using pointers-to-pointers, but that's a different
10992 matter.
10993 (switch_to_buffer_1): Now static.
10994 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10995 (report_overlay_modification): Rename locals to avoid shadowing.
10996
10997 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10998 Fix pointer signedness issue.
10999 (sys_subshell): Mark local as volatile if checking for lint,
11000 to suppress a gcc -Wclobbered warning that does not seem to be right.
11001 (MAXPATHLEN): Define only if needed.
11002
11003 * process.c (serial_open, serial_configure): Move decls from here ...
11004 * systty.h: ... to here, so that they can be checked.
11005
11006 * fns.c (get_random, seed_random): Move extern decls from here ...
11007 * lisp.h: ... to here, so that they can be checked.
11008
11009 * sysdep.c (reset_io): Now static.
11010 (wait_for_termination_signal): Remove; unused.
11011
11012 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11013 (copy_keymap_item, append_key, push_text_char_description):
11014 Now static.
11015 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11016 (DENSE_TABLE_SIZE): Remove; unused.
11017 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11018 (describe_map_tree):
11019 Rename locals to avoid shadowing.
11020
11021 * keyboard.c: Declare functions static if they are not used elsewhere.
11022 (echo_char, echo_dash, cmd_error, top_level_2):
11023 (poll_for_input, handle_async_input): Now static.
11024 (read_char, kbd_buffer_get_event, make_lispy_position):
11025 (make_lispy_event, make_lispy_movement, apply_modifiers):
11026 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11027 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11028 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11029 (read_key_sequence, read_char): Mark locals as initialized.
11030 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11031
11032 * keyboard.h (make_ctrl_char): New decl.
11033 (mark_kboards): Move decl here ...
11034 * alloc.c (mark_kboards): ... from here.
11035
11036 * lisp.h (force_auto_save_soon): New decl.
11037
11038 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11039 (DEFINE_DUMMY_FUNCTION): New macro.
11040 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11041 Use it.
11042 (main): Add casts to avoid warnings
11043 if GCC considers string literals to be constants.
11044
11045 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11046
11047 * dbusbind.c: Pointer signedness fixes.
11048 (xd_signature, xd_append_arg, xd_initialize):
11049 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11050 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11051 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11052 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11053
11054 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11055 if GCC considers string literals to be constants.
11056 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11057
110582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11059 4785
11060 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro. 47862013-03-20 Kenichi Handa <handa@gnu.org>
11061 (print_preprocess, print_object): New macro to fix last change.
11062 4787
11063 * print.c (print_preprocess): Don't forget font objects. 4788 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4789 to 1 (temporary workaround until a bug related to ASCII
4790 optimization is fixed).
11064 4791
110652011-03-16 Juanma Barranquero <lekktu@gmail.com> 47922013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
11066 4793
11067 * emacs.c (USAGE3): Doc fixes. 4794 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4795 Signal error if window is not internal. Adjust docstring.
4796 (delete_all_child_windows): Use combination_limit to save the buffer.
4797 (Fset_window_configuration): Adjust accordingly.
4798 * print.c (syms_of_print): Initialize debugging output not here...
4799 (init_print_once): ...but in a new function here.
4800 * lisp.h (init_print_once): Add prototype.
4801 * emacs.c (main): Add call to init_print_once. Adjust comments.
11068 4802
110692011-03-15 Andreas Schwab <schwab@linux-m68k.org> 48032013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
11070 4804
11071 * coding.c (detect_coding_iso_2022): Reorganize code to clarify 4805 * window.c (window_resize_check, window_resize_apply)
11072 structure. 4806 (window_from_coordinates, recombine_windows, set_window_buffer)
4807 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4808 (Fsplit_window_internal, Fdelete_window_internal)
4809 (freeze_window_starts): Use bool for booleans.
4810 * window.h (window_frame_coordinates, resize_frame_windows)
4811 (freeze_window_starts, set_window_buffer): Adjust prototypes.
11073 4812
110742011-03-14 Juanma Barranquero <lekktu@gmail.com> 48132013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
11075 4814
11076 * lisp.h (VWindow_system, Qfile_name_history): 4815 * dispnew.c (bitch_at_user): Use `user-error'.
11077 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11078 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11079 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11080 4816
11081 * w32select.c: Don't #include "keyboard.h". 48172013-03-17 Ken Brown <kbrown@cornell.edu>
11082 (run_protected): Add extern declaration for waiting_for_input.
11083 4818
11084 * w32.c (Qlocal, noninteractive1, inhibit_window_system): 4819 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
11085 * w32console.c (detect_input_pending, read_input_pending) 4820 as return type of image_background. (Bug#13981)
11086 (encode_terminal_code): 4821 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
11087 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11088 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11089 (w32_system_caret_y, Qfile_name_history):
11090 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11091 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11092 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11093 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11094 * w32proc.c (Qlocal, report_file_error):
11095 * w32term.c (Vwindow_system, updating_frame):
11096 * w32uniscribe.c (initialized, uniscribe_font_driver):
11097 Remove unneeded extern declarations.
11098 4822
110992011-03-14 Chong Yidong <cyd@stupidchicken.com> 48232013-03-16 Jan Djärv <jan.h.d@swipnet.se>
11100 4824
11101 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions. 4825 * nsterm.m (updateFrameSize:): Change resize increments if needed.
4826 (ns_select): Don't return with result uninitialized.
11102 4827
111032011-03-13 Chong Yidong <cyd@stupidchicken.com> 4828 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4829 and getDirectory.
11104 4830
11105 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT) 4831 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
11106 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219). 4832 New functions.
11107 These macros can no longer be used for assignment. 4833 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4834 directories. If filename is nil, get directory name (Bug#13932).
4835 Use getFilename and getDirectory.
4836 (getFilename, getDirectory): New methods for EmacsSavePanel and
4837 EmacsOpenPanel.
4838 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4839
48402013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4841
4842 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4843
48442013-03-15 Kenichi Handa <handa@gnu.org>
4845
4846 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4847 (adjust_after_replace): Make it back to static. Delete the third
4848 arg text_at_gap_tail. Cancel the code for handling it.
4849
4850 * coding.h (struct coding_system): New member eol_seen.
4851
4852 * coding.c (detect_ascii): New function.
4853 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4854 when the source bytes are actually scanned. On detecting for
4855 coding_category_utf_8_auto, call detect_ascii instead of scanning
4856 source bytes directly.
4857 (produce_chars): Call insert_from_gap with the new arg 0.
4858 (encode_coding): Likewise.
4859 (decode_coding_gap): Control ASCII optimization by the variable
4860 disable_ascii_optimization instead of #ifndef .. #endif.
4861 Deccode EOL format according to coding->eol_seen.
4862 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4863 variable.
11108 4864
11109 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): 4865 * lisp.h (adjust_after_replace): Cancel externing it.
11110 Assign struct members directly, instead of using BUF_BEGV etc. 4866 (insert_from_gap): Adjust prototype.
11111 (record_buffer_markers, fetch_buffer_markers): New functions for
11112 recording and fetching special buffer markers.
11113 (set_buffer_internal_1, set_buffer_temp): Use them.
11114
11115 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11116
11117 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11118
11119 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11120 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11121
11122 * xdisp.c (hscroll_window_tree):
11123 (reconsider_clip_changes): Use PT instead of BUF_PT.
11124 4867
111252011-03-13 Eli Zaretskii <eliz@gnu.org> 48682013-03-15 Eli Zaretskii <eliz@gnu.org>
11126 4869
11127 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on 4870 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
11128 $(EMACS_ROOT)/lib/intprops.h. 4871 FULLSCREEN_MAXIMIZED. (Bug#13935)
11129 4872
111302011-03-13 Paul Eggert <eggert@cs.ucla.edu> 48732013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
11131 4874
11132 Fix more problems found by GCC 4.5.2's static checks. 4875 * region-cache.c (find_cache_boundary, move_cache_gap)
4876 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4877 Simplify debugging check and convert to eassert. Adjust comment.
4878 (pp_cache): Put under ENABLE_CHECKING.
11133 4879
11134 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char * 48802013-03-14 Eli Zaretskii <eliz@gnu.org>
11135 to unsigned char * to avoid compiler diagnostic.
11136 (xg_free_frame_widgets): Make it clear that a local variable is
11137 needed only if USE_GTK_TOOLTIP.
11138 (gdk_window_get_screen): Make it clear that this macro is needed
11139 only if USE_GTK_TOOLTIP.
11140 (int_gtk_range_get_value): New function, which avoids a diagnostic
11141 from gcc -Wbad-function-cast.
11142 (xg_set_toolkit_scroll_bar_thumb): Use it.
11143 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11144 diagnostic from gcc -Wbad-function-cast.
11145 (get_utf8_string, xg_get_file_with_chooser):
11146 Rename locals to avoid shadowing.
11147 (create_dialog): Move locals to avoid shadowing.
11148 4881
11149 * xgselect.c (xg_select): Remove unused var. 4882 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4883 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4884 and WM_ACTIVATEAPP.
4885 (w32fullscreen_hook): If the frame is visible, reset
4886 f->want_fullscreen flag after changing the frame size. If the
4887 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4888 (Bug#13953)
11150 4889
11151 * image.c (four_corners_best): Mark locals as initialized. 48902013-03-13 Daniel Colascione <dancol@dancol.org>
11152 (gif_load): Initialize transparent_p to zero (Bug#8238).
11153 Mark another local as initialized.
11154 (my_png_error, my_error_exit): Mark with NO_RETURN.
11155 4891
11156 * image.c (clear_image_cache): Now static. 4892 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
11157 (DIM, HAVE_STDLIB_H_1): Remove unused macros. 4893 too so that these builds can use Cygwin's file conversion
11158 (xpm_load): Redo to avoid "discards qualifiers" gcc warning. 4894 functions. (We've been building and linking cygw32.o all along
11159 (x_edge_detection): Remove unnecessary cast that 4895 and just not using it.)
11160 gcc -Wbad-function-cast diagnoses.
11161 (gif_load): Fix pointer signedness.
11162 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11163 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11164 4896
111652011-03-12 Paul Eggert <eggert@cs.ucla.edu> 48972013-03-13 Paul Eggert <eggert@cs.ucla.edu>
11166 4898
11167 Improve quality of tests for time stamp overflow. 4899 File synchronization fixes (Bug#13944).
11168 For example, without this patch (encode-time 0 0 0 1 1 4900 * Makefile.in (LIB_FDATASYNC): New macro.
11169 1152921504606846976) returns the obviously-bogus value (-948597 4901 (LIBES): Use it.
11170 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly 4902 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
11171 reports time overflow. See 4903 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
11172 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>. 4904 Don't worry about HAVE_FSYNC, since a substitute fsync is
11173 * deps.mk (editfns.o): Depend on ../lib/intprops.h. 4905 available if the system lacks one.
11174 * editfns.c: Include limits.h and intprops.h. 4906 (Fwrite_regin): Retry fsync if interrupted.
11175 (TIME_T_MIN, TIME_T_MAX): New macros. 4907
11176 (time_overflow): Move earlier, to before first use. 49082013-03-13 Eli Zaretskii <eliz@gnu.org>
11177 (hi_time, lo_time): New functions, for an accurate test for 4909
11178 out-of-range times. 4910 * w32term.c (w32_read_socket): If the Emacs frame is being
11179 (Fcurrent_time, Fget_internal_run_time, make_time): Use them. 4911 activated, call w32fullscreen_hook, to make sure the new frame
11180 (Fget_internal_run_time): Don't assume time_t fits in int. 4912 dimensions are in effect. (Bug#13937)
11181 (make_time): Use list2 instead of Fcons twice. 4913
11182 (Fdecode_time): More accurate test for out-of-range times. 49142013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
11183 (check_tm_member): New function. 4915
11184 (Fencode_time): Use it, to test for out-of-range times. 4916 * xdisp.c (init_iterator): Simplify because both character and byte
11185 (lisp_time_argument): Don't rely on undefined left-shift and 4917 positions are either specified or -1. Add eassert. Adjust comment.
11186 right-shift behavior when checking for time stamp overflow. 4918 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
11187 4919 character and byte positions can be obtained from marker.
11188 * editfns.c (time_overflow): New function, refactoring common code. 4920
11189 (Fformat_time_string, Fdecode_time, Fencode_time): 49212013-03-13 Paul Eggert <eggert@cs.ucla.edu>
11190 (Fcurrent_time_string): Use it. 4922
11191 4923 Static checking by Sun C 5.12.
11192 Move 'make_time' to be next to its inverse 'lisp_time_argument'. 4924 * alloc.c (buffer_memory_full) [REL_ALLOC]:
11193 * dired.c (make_time): Move to ... 4925 * bytecode.c (exec_byte_code):
11194 * editfns.c (make_time): ... here. 4926 * dispnew.c (init_display):
11195 * systime.h: Note the move. 4927 * eval.c (error):
11196 4928 * fileio.c (Fsubstitute_in_file_name):
111972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> 4929 * keyboard.c (Fevent_convert_list):
11198 4930 * keymap.c (Fsingle_key_description):
11199 * fringe.c (update_window_fringes): Remove unused variables. 4931 * term.c (maybe_fatal, fatal):
11200 4932 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
11201 * unexmacosx.c (copy_data_segment): Also copy __got section. 4933 * xsmfns.c (Fhandle_save_session):
11202 (Bug#8223) 4934 Omit unreachable code.
11203 4935 * keymap.c (map_keymap_char_table_item): Cast void * to
112042011-03-12 Eli Zaretskii <eliz@gnu.org> 4936 a function pointer type; the C Standard requires this.
11205 4937
11206 * termcap.c [MSDOS]: Include "msdos.h". 4938 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
11207 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent): 4939 Include <sys/param.h> unconditionally, as that works elsewhere and
11208 Constify `char *' arguments and their references according to 4940 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
11209 prototypes in tparam.h. 4941 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
11210 4942 and FreeBSD now.
11211 * deps.mk (termcap.o): Depend on tparam.h and msdos.h. 4943
11212 4944See ChangeLog.12 for earlier changes.
11213 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11214 Adapt all references accordingly.
11215
11216 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11217
112182011-03-11 Tom Tromey <tromey@redhat.com>
11219
11220 * buffer.c (syms_of_buffer): Remove obsolete comment.
11221
112222011-03-11 Eli Zaretskii <eliz@gnu.org>
11223
11224 * termhooks.h (encode_terminal_code): Declare prototype.
11225
11226 * msdos.c (encode_terminal_code): Don't declare prototype.
11227
11228 * term.c (encode_terminal_code): Now external again, used by
11229 w32console.c and msdos.c.
11230
11231 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11232 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11233
112342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11235
11236 Fix some minor problems found by GCC 4.5.2's static checks.
11237
11238 * fringe.c (update_window_fringes): Mark locals as initialized
11239 (Bug#8227).
11240 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11241
11242 * alloc.c (mark_fringe_data): Move decl from here ...
11243 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11244 to check its interface.
11245 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11246
11247 * fontset.c (free_realized_fontset): Now static.
11248 (Fset_fontset_font): Rename local to avoid shadowing.
11249 (fontset_font): Mark local as initialized.
11250 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11251
11252 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11253
11254 * xselect.c (x_disown_buffer_selections): Remove; not used.
11255 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11256 (x_own_selection, Fx_disown_selection_internal): Rename locals
11257 to avoid shadowing.
11258 (x_handle_dnd_message): Remove local to avoid shadowing.
11259
11260 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11261 so that the caller can use some name other than gcpro1.
11262 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11263 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11264 (Fx_backspace_delete_keys_p):
11265 Use them to avoid shadowing, and rename vars to avoid shadowing.
11266 (x_decode_color, x_set_name, x_window): Now static.
11267 (Fx_create_frame): Add braces to silence GCC warning.
11268 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11269 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11270 Remove unused locals.
11271 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11272 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11273 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11274 macros.
11275
11276 * xterm.h (x_mouse_leave): New decl.
11277
11278 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11279 Remove unused functions.
11280 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11281 (x_calc_absolute_position): Now static.
11282 (XTread_socket): Don't define label "out" unless it's used.
11283 Don't declare local "event" unless it's used.
11284 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11285 unless they are used.
11286 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11287 (x_fatal_error_signal): Remove; not used.
11288 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11289 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11290 (x_error_catcher, x_connection_closed, x_error_handler):
11291 (x_error_quitter, xembed_send_message, x_iconify_frame):
11292 (my_log_handler): Rename locals to avoid shadowing.
11293 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11294 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11295
11296 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11297 Rename or move locals to avoid shadowing.
11298 (tty_defined_color, merge_face_heights): Now static.
11299 (free_realized_faces_for_fontset): Remove; not used.
11300 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11301 does not deduce is never used uninitialized.
11302 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11303 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11304
11305 * terminal.c (store_terminal_param): Now static.
11306
11307 * xmenu.c (menu_highlight_callback): Now static.
11308 (set_frame_menubar): Remove unused local.
11309 (xmenu_show): Rename parameter to avoid shadowing.
11310 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11311 since they might point to immutable storage.
11312 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11313 since it's unused otherwise.
11314
11315 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11316 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11317 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11318 avoids a gcc -Wuninitialized diagnostic.
11319 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11320 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11321 does not deduce are never used uninitialized.
11322
11323 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11324
11325 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11326 * window.c (window_loop, size_window):
11327 (run_window_configuration_change_hook, enlarge_window): Likewise.
11328
11329 * window.c (display_buffer): Now static.
11330 (size_window): Mark variables that gcc -Wuninitialized
11331 does not deduce are never used uninitialized.
11332 * window.h (check_all_windows): New decl, to forestall
11333 gcc -Wmissing-prototypes diagnostic.
11334 * dispextern.h (bidi_dump_cached_states): Likewise.
11335
11336 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11337 shadowing.
11338 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11339 Include <limits.h>.
11340 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11341 and to avoid gcc -Wuninitialized warning.
11342 (load_charset_map): Mark variables that gcc -Wuninitialized
11343 does not deduce are never used uninitialized.
11344 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11345
11346 * coding.c (coding_set_source, coding_set_destination):
11347 Use "else { /* comment */ }" rather than "else /* comment */;"
11348 for clarity, and to avoid gcc -Wempty-body warning.
11349 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11350 a block, when the outer 'i' will do.
11351 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11352 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11353 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11354 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11355 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11356 Rename locals to avoid shadowing.
11357 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11358 * coding.c (emacs_mule_char, encode_invocation_designation):
11359 Now static, since they're not used elsewhere.
11360 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11361 (decode_coding_object, encode_coding_object, detect_coding_system):
11362 (decode_coding_emacs_mule): Mark variables that gcc
11363 -Wuninitialized does not deduce are never used uninitialized.
11364 (detect_coding_iso_2022): Initialize a local variable that might
11365 be used uninitialized. Leave a FIXME because it's not clear that
11366 this initialization is needed. (Bug#8211)
11367 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11368 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11369 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11370 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11371 Remove unused macros.
11372
11373 * category.c (hash_get_category_set): Remove unused local var.
11374 (copy_category_table): Now static, since it's not used elsewhere.
11375 * character.c (string_count_byte8): Likewise.
11376
11377 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11378 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11379
11380 * chartab.c (copy_sub_char_table): Now static, since it's not used
11381 elsewhere.
11382 (sub_char_table_ref_and_range, char_table_ref_and_range):
11383 Rename locals to avoid shadowing.
11384 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11385
11386 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11387 (BIDI_BOB): Remove unused macro.
11388
11389 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11390 deduce are never used uninitialized.
11391 * term.c (encode_terminal_code): Likewise.
11392
11393 * term.c (encode_terminal_code): Now static. Remove unused local.
11394
11395 * tparam.h: New file.
11396 * term.c, tparam.h: Include it.
11397 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11398 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11399 Move these decls to tparam.h, and make them agree with what
11400 is actually in tparam.c. The previous trick of using incompatible
11401 decls in different modules does not conform to the C standard.
11402 All callers of tparam changed to use tparam's actual API.
11403 * tparam.c (tparam1, tparam, tgoto):
11404 Use const pointers where appropriate.
11405
11406 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11407 * cm.h (struct cm): Likewise.
11408 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11409 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11410 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11411 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11412 (turn_on_face, init_tty): Likewise.
11413 * termchar.h (struct tty_display_info): Likewise.
11414
11415 * term.c (term_mouse_position): Rename local to avoid shadowing.
11416
11417 * alloc.c (mark_ttys): Move decl from here ...
11418 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11419
114202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11421
11422 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11423
114242011-03-09 Juanma Barranquero <lekktu@gmail.com>
11425
11426 * search.c (compile_pattern_1): Remove argument regp, unused since
11427 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11428 (compile_pattern): Don't pass it.
11429
114302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11431
11432 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11433 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11434 for ! HAVE_GTK3.
11435 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11436
11437 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11438
11439 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11440 gdk_window_get_screen, gdk_window_get_geometry,
11441 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11442 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11443 (xg_get_pixbuf_from_pixmap): New function.
11444 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11445 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11446 Call xg_get_pixbuf_from_pixmap instead of
11447 gdk_pixbuf_get_from_drawable.
11448 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11449 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11450 (xg_check_special_colors): Use GtkStyleContext and its functions
11451 for HAVE_GTK3.
11452 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11453 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11454 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11455 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11456 Call gtk_widget_get_preferred_size.
11457 (xg_frame_resized): gdk_window_get_geometry only takes 5
11458 parameters.
11459 (xg_win_to_widget, xg_event_is_for_menubar):
11460 Call gdk_x11_window_lookup_for_display.
11461 (xg_set_widget_bg): New function.
11462 (delete_cb): New function.
11463 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11464 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11465 (xg_set_background_color): Call xg_set_widget_bg.
11466 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11467 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11468 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11469 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11470 if ! HAVE_GTK3.
11471 (update_frame_tool_bar): Call gtk_widget_hide.
11472 (xg_initialize): Use GDK_KEY_g.
11473
11474 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11475 if ! HAVE_GTK3
11476 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11477
11478 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11479 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11480 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11481
114822011-03-08 Juanma Barranquero <lekktu@gmail.com>
11483
11484 * w32xfns.c (select_palette): Check success of RealizePalette against
11485 GDI_ERROR, not zero.
11486
11487See ChangeLog.11 for earlier changes.
11488 4945
11489;; Local Variables: 4946;; Local Variables:
11490;; coding: utf-8 4947;; coding: utf-8
11491;; End: 4948;; End:
11492 4949
11493 Copyright (C) 2011-2012 Free Software Foundation, Inc. 4950 Copyright (C) 2011-2013 Free Software Foundation, Inc.
11494 4951
11495 This file is part of GNU Emacs. 4952 This file is part of GNU Emacs.
11496 4953