diff options
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/ChangeLog | 5 | ||||
| -rw-r--r-- | lisp/play/gamegrid.el | 20 |
2 files changed, 15 insertions, 10 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index d95c0e6d607..8848fe6d904 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,8 @@ | |||
| 1 | 2015-02-08 Ulrich Müller <ulm@gentoo.org> | ||
| 2 | |||
| 3 | * play/gamegrid.el: Update comment to reflect that the | ||
| 4 | 'update-game-score' helper program is now setgid by default. | ||
| 5 | |||
| 1 | 2015-02-08 David Kastrup <dak@gnu.org> | 6 | 2015-02-08 David Kastrup <dak@gnu.org> |
| 2 | 7 | ||
| 3 | * subr.el (apply-partially): Use lexical binding here. | 8 | * subr.el (apply-partially): Use lexical binding here. |
diff --git a/lisp/play/gamegrid.el b/lisp/play/gamegrid.el index b4c3c594731..df06d5a6ab2 100644 --- a/lisp/play/gamegrid.el +++ b/lisp/play/gamegrid.el | |||
| @@ -462,22 +462,22 @@ FILE is created there." | |||
| 462 | ;; `gamegrid-add-score' was supposed to be used in the past and | 462 | ;; `gamegrid-add-score' was supposed to be used in the past and |
| 463 | ;; is covered here for backward-compatibility. | 463 | ;; is covered here for backward-compatibility. |
| 464 | ;; | 464 | ;; |
| 465 | ;; 2. The helper program "update-game-score" is setuid and the | 465 | ;; 2. The helper program "update-game-score" is setgid or setuid |
| 466 | ;; file FILE does already exist in a system wide shared game | 466 | ;; and the file FILE does already exist in a system wide shared |
| 467 | ;; directory. This should be the normal case on POSIX systems, | 467 | ;; game directory. This should be the normal case on POSIX |
| 468 | ;; if the game was installed system wide. Use | 468 | ;; systems, if the game was installed system wide. Use |
| 469 | ;; "update-game-score" to add the score to the file in the | 469 | ;; "update-game-score" to add the score to the file in the |
| 470 | ;; shared game directory. | 470 | ;; shared game directory. |
| 471 | ;; | 471 | ;; |
| 472 | ;; 3. "update-game-score" is setuid, but the file FILE does *not* | 472 | ;; 3. "update-game-score" is setgid/setuid, but the file FILE does |
| 473 | ;; exist in the system wide shared game directory. Use | 473 | ;; *not* exist in the system wide shared game directory. Use |
| 474 | ;; `gamegrid-add-score-insecure' to create--if necessary--and | 474 | ;; `gamegrid-add-score-insecure' to create--if necessary--and |
| 475 | ;; update FILE. This is for the case that a user has installed | 475 | ;; update FILE. This is for the case that a user has installed |
| 476 | ;; a game on her own. | 476 | ;; a game on her own. |
| 477 | ;; | 477 | ;; |
| 478 | ;; 4. "update-game-score" is not setuid. Use it to create/update | 478 | ;; 4. "update-game-score" is not setgid/setuid. Use it to |
| 479 | ;; FILE in the user's home directory. There is presumably no | 479 | ;; create/update FILE in the user's home directory. There is |
| 480 | ;; shared game directory. | 480 | ;; presumably no shared game directory. |
| 481 | 481 | ||
| 482 | (defvar gamegrid-shared-game-dir) | 482 | (defvar gamegrid-shared-game-dir) |
| 483 | 483 | ||
| @@ -491,7 +491,7 @@ FILE is created there." | |||
| 491 | (gamegrid-add-score-insecure file score)) | 491 | (gamegrid-add-score-insecure file score)) |
| 492 | ((and gamegrid-shared-game-dir | 492 | ((and gamegrid-shared-game-dir |
| 493 | (file-exists-p (expand-file-name file shared-game-score-directory))) | 493 | (file-exists-p (expand-file-name file shared-game-score-directory))) |
| 494 | ;; Use the setuid (or setgid) "update-game-score" program | 494 | ;; Use the setgid (or setuid) "update-game-score" program |
| 495 | ;; to update a system-wide score file. | 495 | ;; to update a system-wide score file. |
| 496 | (gamegrid-add-score-with-update-game-score-1 file | 496 | (gamegrid-add-score-with-update-game-score-1 file |
| 497 | (expand-file-name file shared-game-score-directory) score)) | 497 | (expand-file-name file shared-game-score-directory) score)) |