* lisp/subr.el (dotimes): Deprecate RESULT field. (Bug#16206)

* doc/lispref/control.texi (Iteration):
* doc/misc/cl.texi (Iteration): Document deprecation of its use.
* doc/lispintro/emacs-lisp-intro.texi (dotimes):
* test/src/emacs-module-tests.el (multiply-string):
* test/lisp/filenotify-tests.el (file-notify-test07-many-events):
Place RESULT field after the form.

2 files changed, 9 insertions, 6 deletions

diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
index 219fa746119..56403f43092 100644
--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -1129,14 +1129,16 @@ delivered."
              ;; w32notify fires both `deleted' and `renamed' events.
              ((string-equal (file-notify--test-library) "w32notify")
               (let (r)
-                (dotimes (_i n r)
-                  (setq r (append '(deleted renamed) r)))))
+                (dotimes (_i n)
+                  (setq r (append '(deleted renamed) r)))
+                r))
              ;; cygwin fires `changed' and `deleted' events, sometimes
              ;; in random order.
              ((eq system-type 'cygwin)
               (let (r)
-                (dotimes (_i n (cons :random r))
-                  (setq r (append '(changed deleted) r)))))
+                (dotimes (_i n)
+                  (setq r (append '(changed deleted) r)))
+                (cons :random r)))
              (t (make-list n 'renamed)))
           (let ((source-file-list source-file-list)
                 (target-file-list target-file-list))
diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el
index 8b6328d35af..9ef5a47b159 100644
--- a/test/src/emacs-module-tests.el
+++ b/test/src/emacs-module-tests.el
@@ -138,8 +138,9 @@ changes."
 
 (defun multiply-string (s n)
   (let ((res ""))
-    (dotimes (i n res)
-      (setq res (concat res s)))))
+    (dotimes (i n)
+      (setq res (concat res s)))
+    res))
 
 (ert-deftest mod-test-globref-make-test ()
   (let ((mod-str (mod-test-globref-make))