Extend flymake's warning predicate to be a function. Test suite for flymake.

* lisp/progmodes/flymake.el (flymake-warning-predicate): New.
(flymake-parse-line): Use it.
(flymake-warning-re): Make obsolete alias to
`flymake-warning-predicate'.
* doc/misc/flymake.texi (Parsing the output, Customizable variables):
Add reference to `flymake-warning-predicate'.
* test/automated/flymake-tests.el:
* test/automated/flymake/warnpred/Makefile
* test/automated/flymake/warnpred/test.c
* test/automated/flymake/warnpred/test.pl: New files.

Fixes: debbugs:14217

5 files changed, 105 insertions, 0 deletions

diff --git a/test/ChangeLog b/test/ChangeLog
index 90ea593a012..73ce74a02ae 100644
--- a/test/ChangeLog
+++ b/test/ChangeLog
@@ -1,3 +1,11 @@
+2013-06-21  Eduard Wiebe  <usenet@pusto.de>
+
+        Test suite for flymake.
+        * automated/flymake-tests.el:
+        * automated/flymake/warnpred/Makefile
+        * automated/flymake/warnpred/test.c
+        * automated/flymake/warnpred/test.pl: New files.
+
 2013-06-12  Rüdiger Sonderfeld  <ruediger@c-plusplus.de>
 
         * automated/reftex-tests.el (reftex-parse-from-file-test): Fix test.
diff --git a/test/automated/flymake-tests.el b/test/automated/flymake-tests.el
new file mode 100644
index 00000000000..6b68a956db8
--- /dev/null
+++ b/test/automated/flymake-tests.el
@@ -0,0 +1,82 @@
+;;; flymake-tests.el --- Test suite for flymake
+
+;; Copyright (C) 2011-2013 Free Software Foundation, Inc.
+
+;; Author: Eduard Wiebe <usenet@pusto.de>
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+(require 'ert)
+(require 'flymake)
+
+(defgroup flymake-tests nil
+  "Test suite for flymake.")
+
+
+;; Warning predicate
+(defun flymake-tests--current-face (file predicate)
+  (let ((buffer (find-file-noselect file)))
+    (unwind-protect
+        (with-current-buffer (find-file-noselect file)
+          (setq-local flymake-warning-predicate predicate)
+          (goto-char (point-min))
+          (flymake-mode 1)
+          ;; XXX: is this reliable enough?
+          (sleep-for (+ 0.5 flymake-no-changes-timeout))
+          (flymake-goto-next-error)
+          (face-at-point))
+      (and buffer (kill-buffer buffer)))))
+
+(ert-deftest warnining-predicate-rx-gcc ()
+  "Test GCC warning via regexp predicate."
+  :expected-result (if (executable-find "gcc") :passed :failed)
+  (should (eq 'flymake-warnline
+              (flymake-tests--current-face
+               "flymake/warnpred/test.c"
+               "^[Ww]arning"))))
+
+(ert-deftest warning-predicate-function-gcc ()
+  "Test GCC warning via function predicate."
+  :expected-result (if (and (executable-find "gcc") (executable-find "make"))
+                       :passed
+                     :failed)
+  (should (eq 'flymake-warnline
+              (flymake-tests--current-face
+               "flymake/warnpred/test.c"
+               (lambda (msg) (string-match "^[Ww]arning" msg))))))
+
+(ert-deftest warning-predicate-rx-perl ()
+  "Test perl warning via regular expression predicate."
+  :expected-result (if (executable-find "perl") :passed :failed)
+  (should (eq 'flymake-warnline
+              (flymake-tests--current-face
+               "flymake/warnpred/test.pl"
+               "^Scalar value"))))
+
+(ert-deftest warning-predicate-function-perl ()
+  "Test perl warning via function predicate."
+  :expected-result (if (executable-find "perl") :passed :failed)
+  (should (eq 'flymake-warnline
+              (flymake-tests--current-face
+               "flymake/warnpred/test.pl"
+               (lambda (msg) (string-match "^Scalar value" msg))))))
+
+(provide 'flymake-tests)
+
+;;; flymake.el ends here
diff --git a/test/automated/flymake/warnpred/Makefile b/test/automated/flymake/warnpred/Makefile
new file mode 100644
index 00000000000..33af51c3337
--- /dev/null
+++ b/test/automated/flymake/warnpred/Makefile
@@ -0,0 +1,8 @@
+# Makefile for flymake tests
+
+CC_OPTS = -Wall
+
+check-syntax:
+        $(CC) $(CC_OPTS) ${CHK_SOURCES}
+
+# eof
diff --git a/test/automated/flymake/warnpred/test.c b/test/automated/flymake/warnpred/test.c
new file mode 100644
index 00000000000..3a3926131f5
--- /dev/null
+++ b/test/automated/flymake/warnpred/test.c
@@ -0,0 +1,5 @@
+int main()
+{
+  char c = 1000;
+  return c;
+}
diff --git a/test/automated/flymake/warnpred/test.pl b/test/automated/flymake/warnpred/test.pl
new file mode 100644
index 00000000000..2013b2e4434
--- /dev/null
+++ b/test/automated/flymake/warnpred/test.pl
@@ -0,0 +1,2 @@
+@arr = [1,2,3,4];
+@arr[1] = -1;