Some accept-process-output cleanups in Tramp

* lisp/net/tramp.el (tramp-action-out-of-band): Read process
output in a loop.
(tramp-accept-process-output): Return result.
(tramp-interrupt-process):
* lisp/net/tramp-adb.el (tramp-adb-parse-device-names):
* lisp/net/tramp-rclone.el (tramp-rclone-parse-device-names):
Remove FIXME.

* lisp/net/tramp-sh.el (tramp-local-coding-commands): Fix docstring.

* lisp/net/tramp-smb.el (tramp-smb-wait-for-output): Adapt docstring.
Simplify code.

* lisp/net/tramp-sudoedit.el (tramp-sudoedit-action-sudo):
Adapt docstring.  Read process output in a loop.

* test/lisp/net/tramp-tests.el (tramp-test43-asynchronous-requests):
Remove :unstable tag on emba.

1 files changed, 10 insertions, 4 deletions

diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index ff63dc18fbc..28935062864 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -405,7 +405,7 @@ handled properly.  BODY shall not contain a timeout."
         tramp-default-user-alist
         tramp-default-host-alist
         ;; Suppress check for multihops.
-        (tramp-cache-data  (make-hash-table :test 'equal))
+        (tramp-cache-data (make-hash-table :test 'equal))
         (tramp-connection-properties '((nil "login-program" t))))
     ;; Expand `tramp-default-user' and `tramp-default-host'.
     (should (string-equal
@@ -844,7 +844,7 @@ handled properly.  BODY shall not contain a timeout."
         tramp-default-user-alist
         tramp-default-host-alist
         ;; Suppress check for multihops.
-        (tramp-cache-data  (make-hash-table :test 'equal))
+        (tramp-cache-data (make-hash-table :test 'equal))
         (tramp-connection-properties '((nil "login-program" t)))
         (syntax tramp-syntax))
     (unwind-protect
@@ -1168,7 +1168,7 @@ handled properly.  BODY shall not contain a timeout."
         tramp-default-user-alist
         tramp-default-host-alist
         ;; Suppress check for multihops.
-        (tramp-cache-data  (make-hash-table :test 'equal))
+        (tramp-cache-data (make-hash-table :test 'equal))
         (tramp-connection-properties '((nil "login-program" t)))
         (syntax tramp-syntax))
     (unwind-protect
@@ -5212,7 +5212,13 @@ Use the `ls' command."
   "Check parallel asynchronous requests.
 Such requests could arrive from timers, process filters and
 process sentinels.  They shall not disturb each other."
-  :tags '(:expensive-test :unstable)
+  ;; The test fails from time to time, w/o a reproducible pattern.  So
+  ;; we mark it as unstable.
+  ;; Recent investigations have uncovered a race condition in
+  ;; `accept-process-output'.  Let's check on emba, whether this has
+  ;; been solved.
+  :tags
+  (if (getenv "EMACS_EMBA_CI") '(:expensive-test) '(:expensive-test :unstable))
   (skip-unless (tramp--test-enabled))
   (skip-unless (tramp--test-sh-p))