Finish implementation of set-file-times FLAG arg in Tramp

* lisp/net/tramp-adb.el (tramp-adb-handle-set-file-times):
Implement FLAG.
(tramp-adb-handle-copy-file): Adapt `set-file-times' call.

* lisp/net/tramp-compat.el (tramp-compat-set-file-times): New defalias.

* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-set-file-modes)
(tramp-gvfs-handle-set-file-times, tramp-gvfs-set-file-uid-gid):
Simplify `tramp-gvfs-url-file-name' call.

* lisp/net/tramp-sh.el (tramp-sh-handle-set-file-times): Implement FLAG.
(tramp-do-copy-or-rename-file-via-buffer)
(tramp-do-copy-or-rename-file-out-of-band): Add optional argument
OK-IF-ALREADY-EXISTS.  Adapt callees.
(tramp-do-copy-or-rename-file-via-buffer)
(tramp-do-copy-or-rename-file-directly)
(tramp-do-copy-or-rename-file-out-of-band): Adapt `set-file-times' call.

* lisp/net/tramp-smb.el (tramp-smb-handle-copy-directory)
(tramp-smb-handle-copy-file): Adapt `set-file-times' call.

* lisp/net/tramp-sudoedit.el (tramp-sudoedit-do-copy-or-rename-file):
Adapt `set-file-times' call.
(tramp-sudoedit-handle-set-file-times): Implement FLAG.

* test/lisp/net/tramp-tests.el (tramp-test22-file-times): Extend test.

1 files changed, 12 insertions, 3 deletions

diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index dcf376e70b4..e220420d8cf 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -3743,8 +3743,7 @@ This tests also `make-symbolic-link', `file-truename' and `add-name-to-file'."
                             (file-attributes tmp-name1))))
             ;; Skip the test, if the remote handler is not able to set
             ;; the correct time.
-            (skip-unless (set-file-times tmp-name1 (seconds-to-time 1)
-                                         'nofollow))
+            (skip-unless (set-file-times tmp-name1 (seconds-to-time 1)))
             ;; Dumb remote shells without perl(1) or stat(1) are not
             ;; able to return the date correctly.  They say "don't know".
             (unless (tramp-compat-time-equal-p
@@ -3761,7 +3760,17 @@ This tests also `make-symbolic-link', `file-truename' and `add-name-to-file'."
               (should (file-newer-than-file-p tmp-name2 tmp-name1))
               ;; `tmp-name3' does not exist.
               (should (file-newer-than-file-p tmp-name2 tmp-name3))
-              (should-not (file-newer-than-file-p tmp-name3 tmp-name1))))
+              (should-not (file-newer-than-file-p tmp-name3 tmp-name1))
+              ;; Check the NOFOLLOW arg.  It exists since Emacs 28.  For
+              ;; regular files, there shouldn't be a difference.
+              (when (tramp--test-emacs28-p)
+                (with-no-warnings
+                  (set-file-times tmp-name1 (seconds-to-time 1) 'nofollow)
+                  (should
+                   (tramp-compat-time-equal-p
+                    (tramp-compat-file-attribute-modification-time
+                     (file-attributes tmp-name1))
+                    (seconds-to-time 1)))))))
 
         ;; Cleanup.
         (ignore-errors