aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorPhilipp Stephani2017-10-09 16:08:15 +0200
committerPhilipp Stephani2017-10-09 16:08:15 +0200
commit6abff55b5514515c5a28397b34aee478926af232 (patch)
treec7d722049149ad0182c86dc1ac20d72df74f4f7f /test
parent2c39565dc046d428127735552db6e7814631d4d4 (diff)
downloademacs-6abff55b5514515c5a28397b34aee478926af232.tar.gz
emacs-6abff55b5514515c5a28397b34aee478926af232.zip
Revert "Raise an error when detecting old-style backquotes."
This reverts commit 9613690f6e51e2f2aa2bcbbede3e209d08cfaaad.
Diffstat (limited to 'test')
-rw-r--r--test/lisp/emacs-lisp/bytecomp-tests.el11
-rw-r--r--test/src/lread-tests.el10
2 files changed, 13 insertions, 8 deletions
diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el
index 1f85c269780..30d2a4753cf 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -534,18 +534,23 @@ literals (Bug#20852)."
534 534
535(ert-deftest bytecomp-tests--old-style-backquotes () 535(ert-deftest bytecomp-tests--old-style-backquotes ()
536 "Check that byte compiling warns about old-style backquotes." 536 "Check that byte compiling warns about old-style backquotes."
537 (should (boundp 'lread--old-style-backquotes))
537 (bytecomp-tests--with-temp-file source 538 (bytecomp-tests--with-temp-file source
538 (write-region "(` (a b))" nil source) 539 (write-region "(` (a b))" nil source)
539 (bytecomp-tests--with-temp-file destination 540 (bytecomp-tests--with-temp-file destination
540 (let* ((byte-compile-dest-file-function (lambda (_) destination)) 541 (let* ((byte-compile-dest-file-function (lambda (_) destination))
541 (byte-compile-debug t) 542 (byte-compile-error-on-warn t)
542 (err (should-error (byte-compile-file source)))) 543 (byte-compile-debug t)
544 (err (should-error (byte-compile-file source))))
543 (should (equal (cdr err) 545 (should (equal (cdr err)
544 '("Loading `nil': old-style backquotes detected!"))))))) 546 (list "!! The file uses old-style backquotes !!
547This functionality has been obsolete for more than 10 years already
548and will be removed soon. See (elisp)Backquote in the manual.")))))))
545 549
546 550
547(ert-deftest bytecomp-tests-function-put () 551(ert-deftest bytecomp-tests-function-put ()
548 "Check `function-put' operates during compilation." 552 "Check `function-put' operates during compilation."
553 (should (boundp 'lread--old-style-backquotes))
549 (bytecomp-tests--with-temp-file source 554 (bytecomp-tests--with-temp-file source
550 (dolist (form '((function-put 'bytecomp-tests--foo 'foo 1) 555 (dolist (form '((function-put 'bytecomp-tests--foo 'foo 1)
551 (function-put 'bytecomp-tests--foo 'bar 2) 556 (function-put 'bytecomp-tests--foo 'bar 2)
diff --git a/test/src/lread-tests.el b/test/src/lread-tests.el
index 3f41982eba1..ac730b4f005 100644
--- a/test/src/lread-tests.el
+++ b/test/src/lread-tests.el
@@ -173,13 +173,13 @@ literals (Bug#20852)."
173 (should (string-suffix-p "/somelib.el" (caar load-history))))) 173 (should (string-suffix-p "/somelib.el" (caar load-history)))))
174 174
175(ert-deftest lread-tests--old-style-backquotes () 175(ert-deftest lread-tests--old-style-backquotes ()
176 "Check that loading doesn't accept old-style backquotes." 176 "Check that loading warns about old-style backquotes."
177 (lread-tests--with-temp-file file-name 177 (lread-tests--with-temp-file file-name
178 (write-region "(` (a b))" nil file-name) 178 (write-region "(` (a b))" nil file-name)
179 (let ((data (should-error (load file-name nil :nomessage :nosuffix)))) 179 (should (equal (load file-name nil :nomessage :nosuffix) t))
180 (should (equal (cdr data) 180 (should (equal (lread-tests--last-message)
181 (list (concat (format-message "Loading `%s': " file-name) 181 (concat (format-message "Loading `%s': " file-name)
182 "old-style backquotes detected!"))))))) 182 "old-style backquotes detected!")))))
183 183
184(ert-deftest lread-lread--substitute-object-in-subtree () 184(ert-deftest lread-lread--substitute-object-in-subtree ()
185 (let ((x (cons 0 1))) 185 (let ((x (cons 0 1)))