diff options
| author | Noam Postavsky | 2018-03-10 21:01:24 -0500 |
|---|---|---|
| committer | Noam Postavsky | 2018-03-10 21:02:10 -0500 |
| commit | 60c4cf6311b84ed7ec007702a0cdd7881f9f647c (patch) | |
| tree | eb30df5fa9184ca2d993f233ae7520c8419ce4e3 /test | |
| parent | 864643929b7e241020c3a43b830d6ccf1c1726d8 (diff) | |
| download | emacs-60c4cf6311b84ed7ec007702a0cdd7881f9f647c.tar.gz emacs-60c4cf6311b84ed7ec007702a0cdd7881f9f647c.zip | |
; Revert "; Tracing for eieio-test random failure (Bug#24503)"
The tracing seems to prevent the bug from happening.
Diffstat (limited to 'test')
| -rw-r--r-- | test/Makefile.in | 1 | ||||
| -rw-r--r-- | test/lisp/emacs-lisp/eieio-tests/eieio-tests.el | 21 |
2 files changed, 1 insertions, 21 deletions
diff --git a/test/Makefile.in b/test/Makefile.in index 4024d0286fe..42d9880e66a 100644 --- a/test/Makefile.in +++ b/test/Makefile.in | |||
| @@ -152,7 +152,6 @@ endif | |||
| 152 | WRITE_LOG = > $@ 2>&1 || { STAT=$$?; cat $@; exit $$STAT; } | 152 | WRITE_LOG = > $@ 2>&1 || { STAT=$$?; cat $@; exit $$STAT; } |
| 153 | ifdef EMACS_HYDRA_CI | 153 | ifdef EMACS_HYDRA_CI |
| 154 | ## On Hydra, always show logs for certain problematic tests. | 154 | ## On Hydra, always show logs for certain problematic tests. |
| 155 | lisp/emacs-lisp/eieio-tests/eieio-tests.log \ | ||
| 156 | lisp/net/tramp-tests.log \ | 155 | lisp/net/tramp-tests.log \ |
| 157 | : WRITE_LOG = 2>&1 | tee $@ | 156 | : WRITE_LOG = 2>&1 | tee $@ |
| 158 | endif | 157 | endif |
diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el b/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el index 69dc16443f9..5ba094c0072 100644 --- a/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el +++ b/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el | |||
| @@ -887,34 +887,15 @@ Subclasses to override slot attributes.") | |||
| 887 | (should (= (length (eieio-build-class-alist 'opt-test1 nil)) 2)) | 887 | (should (= (length (eieio-build-class-alist 'opt-test1 nil)) 2)) |
| 888 | (should (= (length (eieio-build-class-alist 'opt-test1 t)) 1))) | 888 | (should (= (length (eieio-build-class-alist 'opt-test1 t)) 1))) |
| 889 | 889 | ||
| 890 | (mapatoms (lambda (a) | ||
| 891 | (when (and (fboundp a) | ||
| 892 | (string-match "\\`cl--?generic" | ||
| 893 | (symbol-name a))) | ||
| 894 | (trace-function-background a)))) | ||
| 895 | |||
| 896 | (defclass eieio--testing () ()) | 890 | (defclass eieio--testing () ()) |
| 897 | 891 | ||
| 898 | (defmethod constructor :static ((_x eieio--testing) newname &rest _args) | 892 | (defmethod constructor :static ((_x eieio--testing) newname &rest _args) |
| 899 | (list newname 2)) | 893 | (list newname 2)) |
| 900 | 894 | ||
| 901 | (defun eieio-test-dump-trace () | ||
| 902 | (message "%s" (with-current-buffer "*trace-output*" | ||
| 903 | (goto-char (point-min)) | ||
| 904 | (while (re-search-forward "[\0-\010\013-\037]" nil t) | ||
| 905 | (insert (prog1 (format "\\%03o" (char-before)) | ||
| 906 | (delete-char -1)))) | ||
| 907 | (buffer-string)))) | ||
| 908 | (eieio-test-dump-trace) | ||
| 909 | |||
| 910 | (ert-deftest eieio-test-37-obsolete-name-in-constructor () | 895 | (ert-deftest eieio-test-37-obsolete-name-in-constructor () |
| 911 | ;; FIXME repeated intermittent failures on hydra and elsewhere (bug#24503). | 896 | ;; FIXME repeated intermittent failures on hydra and elsewhere (bug#24503). |
| 912 | :tags '(:unstable) | 897 | :tags '(:unstable) |
| 913 | (with-current-buffer "*trace-output*" | 898 | (should (equal (eieio--testing "toto") '("toto" 2)))) |
| 914 | (erase-buffer)) | ||
| 915 | (unwind-protect | ||
| 916 | (should (equal (eieio--testing "toto") '("toto" 2))) | ||
| 917 | (eieio-test-dump-trace))) | ||
| 918 | 899 | ||
| 919 | (ert-deftest eieio-autoload () | 900 | (ert-deftest eieio-autoload () |
| 920 | "Tests to see whether reftex-auc has been autoloaded" | 901 | "Tests to see whether reftex-auc has been autoloaded" |