Write proper `write-region' message in Tramp backends

* lisp/net/tramp-adb.el (tramp-adb-handle-write-region):
* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-write-region):
* lisp/net/tramp-sh.el (tramp-sh-handle-write-region):
* lisp/net/tramp-smb.el (tramp-smb-handle-write-region):
Write proper message.

* lisp/net/tramp.el (tramp-message-show-message): Change default.

* test/lisp/net/tramp-tests.el (ert-x): Require it.
(tramp-test10-write-region): Extend test.

1 files changed, 18 insertions, 0 deletions

diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index d4aceb31b58..1688a166ca6 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -43,6 +43,7 @@
 
 (require 'dired)
 (require 'ert)
+(require 'ert-x)
 (require 'tramp)
 (require 'vc)
 (require 'vc-bzr)
@@ -1866,6 +1867,23 @@ This checks also `file-name-as-directory', `file-name-directory',
               (insert-file-contents tmp-name)
               (should (string-equal (buffer-string) "34")))
 
+            ;; Check message.
+            ;; Macro `ert-with-message-capture' was introduced in Emacs 26.1.
+            (with-no-warnings (when (symbol-plist 'ert-with-message-capture)
+              (let ((tramp-message-show-message t))
+                (dolist (noninteractive '(nil t))
+                  (dolist (visit '(nil t "string" no-message))
+                    (ert-with-message-capture tramp--test-messages
+                      (write-region "foo" nil tmp-name nil visit)
+                      ;; We must check the last line.  There could be
+                      ;; other messages from the progress reporter.
+                      (should
+                       (string-match
+                        (if (and (null noninteractive)
+                                 (or (eq visit t) (null visit) (stringp visit)))
+                            (format "^Wrote %s\n\\'" tmp-name) "^\\'")
+                        tramp--test-messages))))))))
+
             ;; Do not overwrite if excluded.
             (cl-letf (((symbol-function 'y-or-n-p) (lambda (_prompt) t)))
               (write-region "foo" nil tmp-name nil nil nil 'mustbenew))