diff options
| author | Roi Martin | 2025-03-06 20:26:46 +0100 |
|---|---|---|
| committer | Eli Zaretskii | 2025-05-03 10:31:04 +0300 |
| commit | d164116aa52b10bdfe8242dd1089406d4e557f32 (patch) | |
| tree | 8e75c18c48c3532cc6810c417dc013fe363a4338 /test | |
| parent | f180e4c9cb676e771acdaed7b0fd76c1c83dd485 (diff) | |
| download | emacs-d164116aa52b10bdfe8242dd1089406d4e557f32.tar.gz emacs-d164116aa52b10bdfe8242dd1089406d4e557f32.zip | |
Fix 'Skip' behavior in erts files (bug#76839)
* lisp/emacs-lisp/ert.el (ert-test--erts-test): Fix 'Skip'
behavior in erts files, so only the test case where it is
specified is skipped.
* test/lisp/emacs-lisp/ert-tests.el (ert-test-erts-skip-one)
(ert-test-erts-skip-last): Add test cases.
Diffstat (limited to 'test')
| -rw-r--r-- | test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts | 8 | ||||
| -rw-r--r-- | test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts | 16 | ||||
| -rw-r--r-- | test/lisp/emacs-lisp/ert-tests.el | 12 |
3 files changed, 36 insertions, 0 deletions
diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts new file mode 100644 index 00000000000..fd39efcaaa6 --- /dev/null +++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts | |||
| @@ -0,0 +1,8 @@ | |||
| 1 | Name: last | ||
| 2 | Skip: t | ||
| 3 | |||
| 4 | =-= | ||
| 5 | FOO | ||
| 6 | =-= | ||
| 7 | BAR | ||
| 8 | =-=-= | ||
diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts new file mode 100644 index 00000000000..3b35081c414 --- /dev/null +++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts | |||
| @@ -0,0 +1,16 @@ | |||
| 1 | Name: first | ||
| 2 | Skip: t | ||
| 3 | |||
| 4 | =-= | ||
| 5 | FOO | ||
| 6 | =-= | ||
| 7 | FOO | ||
| 8 | =-=-= | ||
| 9 | |||
| 10 | Name: second | ||
| 11 | |||
| 12 | =-= | ||
| 13 | FOO | ||
| 14 | =-= | ||
| 15 | BAR | ||
| 16 | =-=-= | ||
diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el index d138240b0f8..467d01fed9d 100644 --- a/test/lisp/emacs-lisp/ert-tests.el +++ b/test/lisp/emacs-lisp/ert-tests.el | |||
| @@ -28,6 +28,7 @@ | |||
| 28 | 28 | ||
| 29 | (require 'cl-lib) | 29 | (require 'cl-lib) |
| 30 | (require 'ert) | 30 | (require 'ert) |
| 31 | (require 'ert-x) | ||
| 31 | 32 | ||
| 32 | ;;; Self-test that doesn't rely on ERT, for bootstrapping. | 33 | ;;; Self-test that doesn't rely on ERT, for bootstrapping. |
| 33 | 34 | ||
| @@ -1029,6 +1030,17 @@ F failing-test | |||
| 1029 | (ert-with-test-buffer (:name "foo" :selected t) | 1030 | (ert-with-test-buffer (:name "foo" :selected t) |
| 1030 | (buffer-name))))) | 1031 | (buffer-name))))) |
| 1031 | 1032 | ||
| 1033 | (ert-deftest ert-test-erts-skip-one () | ||
| 1034 | "Test that Skip does not affect subsequent test cases (Bug#76839)." | ||
| 1035 | (should-error (ert-test-erts-file (ert-resource-file "erts-skip-one.erts") | ||
| 1036 | (lambda () ())) | ||
| 1037 | :type 'ert-test-failed)) | ||
| 1038 | |||
| 1039 | (ert-deftest ert-test-erts-skip-last () | ||
| 1040 | "Test that Skip does not fail on last test case (Bug#76839)." | ||
| 1041 | (ert-test-erts-file (ert-resource-file "erts-skip-last.erts") | ||
| 1042 | (lambda () ()))) | ||
| 1043 | |||
| 1032 | (provide 'ert-tests) | 1044 | (provide 'ert-tests) |
| 1033 | 1045 | ||
| 1034 | ;;; ert-tests.el ends here | 1046 | ;;; ert-tests.el ends here |