Warn about :reverse-video in defface

This attribute keyword has been non-working in defface for 14 years,
thus warning about it is both safe and decent.

* lisp/emacs-lisp/bytecomp.el (bytecomp--check-cus-face-spec):
Warn and suggest :inverse-video to be used instead.
* test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-test-defface-spec):
Add a test case.
* etc/NEWS: Notify the user.

1 files changed, 4 insertions, 0 deletions

diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el
index cce6b1221fc..39c3732581a 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -2001,6 +2001,10 @@ EXPECTED-POINT BINDINGS (MODES \\='\\='(ruby-mode js-mode python-mode)) \
      (rx "`:inverse' is not a valid face attribute keyword")
      (df '((t (:background "blue" :inverse t)))))  ; old attr list syntax
     (bytecomp--with-warning-test
+     (rx "Face attribute `:reverse-video' is obsolete;"
+         " use `:inverse-video' instead")
+     (df '((t :background "red" :reverse-video t))))
+    (bytecomp--with-warning-test
      (rx "Value for face attribute `:inherit' should not be quoted")
      (df '((t :inherit 'other))))
     (bytecomp--with-warning-test