aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorEli Zaretskii2022-12-14 16:53:29 +0200
committerEli Zaretskii2022-12-14 16:53:29 +0200
commit3b573f7d1f583d3c4169fa7d7dc1f4bcd22197c1 (patch)
treeece33f933e19959fe3b1d2a700a530f7b48d6998 /test
parente22a71443ac854ef58dbfdc6d2ee11969ff30607 (diff)
downloademacs-3b573f7d1f583d3c4169fa7d7dc1f4bcd22197c1.tar.gz
emacs-3b573f7d1f583d3c4169fa7d7dc1f4bcd22197c1.zip
Make proced-tests work on more systems
* test/lisp/proced-tests.el (proced-format-test) (proced-update-test, proced-revert-test, proced-color-test): Remove the 'skip-unless' condition, as it is unnecessary. (proced-refine-test, proced-refine-with-update-test): Use PID, not Args, as the column to test, as PID is more portable.
Diffstat (limited to 'test')
-rw-r--r--test/lisp/proced-tests.el28
1 files changed, 12 insertions, 16 deletions
diff --git a/test/lisp/proced-tests.el b/test/lisp/proced-tests.el
index 78d1b6aa400..3c1f5493e74 100644
--- a/test/lisp/proced-tests.el
+++ b/test/lisp/proced-tests.el
@@ -20,6 +20,7 @@
20;;; Code: 20;;; Code:
21(require 'ert) 21(require 'ert)
22(require 'proced) 22(require 'proced)
23(require 'thingatpt)
23 24
24(cl-defmacro proced--within-buffer (format filter &body body) 25(cl-defmacro proced--within-buffer (format filter &body body)
25 "Execute BODY within a proced buffer using format FORMAT and filter FILTER." 26 "Execute BODY within a proced buffer using format FORMAT and filter FILTER."
@@ -44,7 +45,6 @@
44 (move-to-column (string-match attribute proced-header-line))) 45 (move-to-column (string-match attribute proced-header-line)))
45 46
46(ert-deftest proced-format-test () 47(ert-deftest proced-format-test ()
47 (skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin)))
48 (dolist (format '(short medium long verbose)) 48 (dolist (format '(short medium long verbose))
49 (proced--within-buffer 49 (proced--within-buffer
50 format 50 format
@@ -52,7 +52,6 @@
52 (proced--assert-emacs-pid-in-buffer)))) 52 (proced--assert-emacs-pid-in-buffer))))
53 53
54(ert-deftest proced-update-test () 54(ert-deftest proced-update-test ()
55 (skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin)))
56 (proced--within-buffer 55 (proced--within-buffer
57 'short 56 'short
58 'user 57 'user
@@ -60,7 +59,6 @@
60 (proced--assert-emacs-pid-in-buffer))) 59 (proced--assert-emacs-pid-in-buffer)))
61 60
62(ert-deftest proced-revert-test () 61(ert-deftest proced-revert-test ()
63 (skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin)))
64 (proced--within-buffer 62 (proced--within-buffer
65 'short 63 'short
66 'user 64 'user
@@ -68,7 +66,6 @@
68 (proced--assert-emacs-pid-in-buffer))) 66 (proced--assert-emacs-pid-in-buffer)))
69 67
70(ert-deftest proced-color-test () 68(ert-deftest proced-color-test ()
71 (skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin)))
72 (let ((proced-enable-color-flag t)) 69 (let ((proced-enable-color-flag t))
73 (proced--within-buffer 70 (proced--within-buffer
74 'short 71 'short
@@ -76,33 +73,32 @@
76 (proced--assert-emacs-pid-in-buffer)))) 73 (proced--assert-emacs-pid-in-buffer))))
77 74
78(ert-deftest proced-refine-test () 75(ert-deftest proced-refine-test ()
79 (skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin))) 76 ;;(skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin)))
80 (proced--within-buffer 77 (proced--within-buffer
81 'medium 78 'medium
82 'user 79 'user
83 ;; When refining on Args for process A, a process is kept if and only 80 ;; When refining on PID for process A, a process is kept if and only
84 ;; if its args are the same as process A, which more or less guarentees 81 ;; if its PID are the same as process A, which more or less guarentees
85 ;; the refinement will remove some processes. 82 ;; the refinement will remove some processes.
86 (proced--move-to-column "Args") 83 (proced--move-to-column "PID")
87 (let ((args (buffer-substring-no-properties (point) (line-end-position)))) 84 (let ((pid (word-at-point)))
88 (proced-refine) 85 (proced-refine)
89 (while (not (eobp)) 86 (while (not (eobp))
90 (proced--move-to-column "Args") 87 (proced--move-to-column "PID")
91 (should (string= args (buffer-substring-no-properties (point) (line-end-position)))) 88 (should (string= pid (word-at-point)))
92 (forward-line))))) 89 (forward-line)))))
93 90
94(ert-deftest proced-refine-with-update-test () 91(ert-deftest proced-refine-with-update-test ()
95 (skip-unless (memq system-type '(gnu/linux gnu/kfreebsd darwin)))
96 (proced--within-buffer 92 (proced--within-buffer
97 'medium 93 'medium
98 'user 94 'user
99 (proced--move-to-column "Args") 95 (proced--move-to-column "PID")
100 (let ((args (buffer-substring-no-properties (point) (line-end-position)))) 96 (let ((pid (word-at-point)))
101 (proced-refine) 97 (proced-refine)
102 (proced-update t) 98 (proced-update t)
103 (while (not (eobp)) 99 (while (not (eobp))
104 (proced--move-to-column "Args") 100 (proced--move-to-column "PID")
105 (should (string= args (buffer-substring-no-properties (point) (line-end-position)))) 101 (should (string= pid (word-at-point)))
106 (forward-line))))) 102 (forward-line)))))
107 103
108(provide 'proced-tests) 104(provide 'proced-tests)