Ignore keymaps at point for positions outside the buffer

Correct a few edge cases where we used the keymaps at point when
looking up keymaps for an event position which is outside the
current buffer.  Namely:

- Clicking on a part of the mode line which is after the end of
  mode-line-format produces an event with non-nil posn-area but
  nil posn-string.

- Even if posn-string doesn't have a local keymap, we should
  still ignore the keymaps at point if posn-string is non-nil.

* src/keymap.c (Fcurrent_active_maps): Ignore keymaps at point
for more positions outside the buffer.  (bug#76620)

1 files changed, 27 insertions, 0 deletions

diff --git a/test/src/keymap-tests.el b/test/src/keymap-tests.el
index c605c3eb09d..950c741a6dd 100644
--- a/test/src/keymap-tests.el
+++ b/test/src/keymap-tests.el
@@ -509,6 +509,33 @@ g .. h		foo
     ;; From the parent this time/
     (should (equal (keymap-lookup map "u") #'undo))))
 
+(defun keymap-test--maps-for-posn (area string)
+  (current-active-maps
+   nil
+   ;; FIXME: This test would be better if this was a real position
+   ;; created by a real click.
+   `(,(selected-window) ,area (1 . 1) 0 (,string . 0) nil (1 . 1) nil (1 . 1) (1 . 1))))
+
+(ert-deftest keymap-test-keymaps-for-non-buffer-positions ()
+  "`current-active-maps' with non-buffer positions.  (bug#76620)"
+  (with-temp-buffer
+    (pop-to-buffer (current-buffer))
+    (let ((keymap (make-sparse-keymap "keymap-at-point")))
+      (insert (propertize "string" 'keymap keymap))
+      (goto-char (point-min))
+      (should (memq keymap (current-active-maps)))
+      (should-not (memq keymap (keymap-test--maps-for-posn 'mode-line nil)))
+      (should-not (memq keymap (keymap-test--maps-for-posn 'mode-line "s")))
+      (should-not (memq keymap (keymap-test--maps-for-posn nil "s")))
+      (should (memq keymap (keymap-test--maps-for-posn nil nil)))
+      (let* ((mode-line-keymap (make-sparse-keymap "keymap-in-mode-line"))
+             (s (propertize "string" 'keymap mode-line-keymap)))
+        ;; Respect `keymap' in the string clicked on.
+        (should-not (memq keymap (keymap-test--maps-for-posn nil s)))
+        (should-not (memq keymap (keymap-test--maps-for-posn 'mode-line s)))
+        (should (memq mode-line-keymap (keymap-test--maps-for-posn nil s)))
+        (should (memq mode-line-keymap (keymap-test--maps-for-posn 'mode-line s)))))))
+
 (provide 'keymap-tests)
 
 ;;; keymap-tests.el ends here