aboutsummaryrefslogtreecommitdiffstats
path: root/test/lisp
diff options
context:
space:
mode:
authorMichael Albinus2024-05-25 17:23:30 +0200
committerMichael Albinus2024-05-25 17:23:30 +0200
commit91509d5d2a2dc818830cff63f13d6efcb229dc0c (patch)
tree3e1a8e148117c1227894cddd634526d5468e1729 /test/lisp
parent129c6778e640f8ae9ba0eba9ad9ce81b4bf2328e (diff)
downloademacs-91509d5d2a2dc818830cff63f13d6efcb229dc0c.tar.gz
emacs-91509d5d2a2dc818830cff63f13d6efcb229dc0c.zip
Make Tramp's async processes more robust
* lisp/simple.el (shell-command-sentinel): Check process property `remote-command' first. * lisp/net/tramp.el (tramp-handle-make-process): * lisp/net/tramp-androidsu.el (tramp-androidsu-handle-make-process): Set sentinel `ignore'. (Bug#71049) * test/lisp/net/tramp-tests.el (tramp--test-deftest-direct-async-process): Don't suppress internal sentinel. (tramp-test32-shell-commanddirect-async): Don't tag it :unstable.
Diffstat (limited to 'test/lisp')
-rw-r--r--test/lisp/net/tramp-tests.el7
1 files changed, 2 insertions, 5 deletions
diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index 130f4a76ff5..2c61efb04d8 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -5390,10 +5390,7 @@ If UNSTABLE is non-nil, the test is tagged as `:unstable'."
5390 ;; We do expect an established connection already, 5390 ;; We do expect an established connection already,
5391 ;; `file-truename' does it by side-effect. Suppress 5391 ;; `file-truename' does it by side-effect. Suppress
5392 ;; `tramp--test-enabled', in order to keep the connection. 5392 ;; `tramp--test-enabled', in order to keep the connection.
5393 ;; Suppress "Process ... finished" messages. 5393 (cl-letf (((symbol-function #'tramp--test-enabled) #'tramp-compat-always))
5394 (cl-letf (((symbol-function #'tramp--test-enabled) #'tramp-compat-always)
5395 ((symbol-function #'internal-default-process-sentinel)
5396 #'ignore))
5397 (file-truename ert-remote-temporary-file-directory) 5394 (file-truename ert-remote-temporary-file-directory)
5398 (funcall (ert-test-body ert-test)))))) 5395 (funcall (ert-test-body ert-test))))))
5399 5396
@@ -5936,7 +5933,7 @@ INPUT, if non-nil, is a string sent to the process."
5936 (when (natnump cols) 5933 (when (natnump cols)
5937 (should (= cols async-shell-command-width)))))) 5934 (should (= cols async-shell-command-width))))))
5938 5935
5939(tramp--test-deftest-direct-async-process tramp-test32-shell-command 'unstable) 5936(tramp--test-deftest-direct-async-process tramp-test32-shell-command)
5940 5937
5941;; This test is inspired by Bug#39067. 5938;; This test is inspired by Bug#39067.
5942(ert-deftest tramp-test32-shell-command-dont-erase-buffer () 5939(ert-deftest tramp-test32-shell-command-dont-erase-buffer ()