aboutsummaryrefslogtreecommitdiffstats
path: root/test/lisp/progmodes
diff options
context:
space:
mode:
authorStephen Leake2019-04-11 14:00:02 -0700
committerStephen Leake2019-04-11 14:00:02 -0700
commit7ba7def5caf7ec9d9bebffff489f0a658229fbda (patch)
treee0cfcb59937ca0528fb81769d7d48a904a91f5dc /test/lisp/progmodes
parent7768581172e11be52b1fcd8224f4594e126bbdb7 (diff)
parentde238b39e335c6814283faa171b35145f124edf2 (diff)
downloademacs-7ba7def5caf7ec9d9bebffff489f0a658229fbda.tar.gz
emacs-7ba7def5caf7ec9d9bebffff489f0a658229fbda.zip
Merge commit 'de238b39e335c6814283faa171b35145f124edf2'
Diffstat (limited to 'test/lisp/progmodes')
-rw-r--r--test/lisp/progmodes/flymake-tests.el2
-rw-r--r--test/lisp/progmodes/python-tests.el10
2 files changed, 12 insertions, 0 deletions
diff --git a/test/lisp/progmodes/flymake-tests.el b/test/lisp/progmodes/flymake-tests.el
index 629cdf9a137..732193476dd 100644
--- a/test/lisp/progmodes/flymake-tests.el
+++ b/test/lisp/progmodes/flymake-tests.el
@@ -142,6 +142,8 @@ SEVERITY-PREDICATE is used to setup
142 142
143(ert-deftest different-diagnostic-types () 143(ert-deftest different-diagnostic-types ()
144 "Test GCC warning via function predicate." 144 "Test GCC warning via function predicate."
145 ;; http://lists.gnu.org/archive/html/emacs-devel/2019-03/msg01043.html
146 :expected-result (if (getenv "EMACS_HYDRA_CI") :failed :passed)
145 (skip-unless (and (executable-find "gcc") 147 (skip-unless (and (executable-find "gcc")
146 (version<= 148 (version<=
147 "5" (string-trim 149 "5" (string-trim
diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
index 94c846ecb16..999cf8dc7a3 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -5345,13 +5345,23 @@ class SomeClass:
5345(ert-deftest python-tests--python-nav-end-of-statement--infloop () 5345(ert-deftest python-tests--python-nav-end-of-statement--infloop ()
5346 "Checks that `python-nav-end-of-statement' doesn't infloop in a 5346 "Checks that `python-nav-end-of-statement' doesn't infloop in a
5347buffer with overlapping strings." 5347buffer with overlapping strings."
5348 ;; FIXME: The treatment of strings has changed in the mean time, and the
5349 ;; test below now neither signals an error nor inf-loops.
5350 ;; The description of the problem it's trying to catch is not clear enough
5351 ;; to be able to see if the underlying problem is really fixed, sadly.
5352 ;; E.g. I don't know what is meant by "overlap", really.
5353 (skip-unless nil)
5348 (python-tests-with-temp-buffer "''' '\n''' ' '\n" 5354 (python-tests-with-temp-buffer "''' '\n''' ' '\n"
5349 (syntax-propertize (point-max)) 5355 (syntax-propertize (point-max))
5350 ;; Create a situation where strings nominally overlap. This 5356 ;; Create a situation where strings nominally overlap. This
5351 ;; shouldn't happen in practice, but apparently it can happen when 5357 ;; shouldn't happen in practice, but apparently it can happen when
5352 ;; a package calls `syntax-ppss' in a narrowed buffer during JIT 5358 ;; a package calls `syntax-ppss' in a narrowed buffer during JIT
5353 ;; lock. 5359 ;; lock.
5360 ;; FIXME: 4-5 is the SPC right after the opening triple quotes: why
5361 ;; put a string-fence syntax on it?
5354 (put-text-property 4 5 'syntax-table (string-to-syntax "|")) 5362 (put-text-property 4 5 'syntax-table (string-to-syntax "|"))
5363 ;; FIXME: 8-9 is the middle quote in the closing triple quotes:
5364 ;; it shouldn't have any syntax-table property to remove anyway!
5355 (remove-text-properties 8 9 '(syntax-table nil)) 5365 (remove-text-properties 8 9 '(syntax-table nil))
5356 (goto-char 4) 5366 (goto-char 4)
5357 (setq-local syntax-propertize-function nil) 5367 (setq-local syntax-propertize-function nil)