diff options
| author | Michael Albinus | 2026-03-04 19:24:52 +0100 |
|---|---|---|
| committer | Michael Albinus | 2026-03-04 19:24:52 +0100 |
| commit | fedf45ca6337788717b2e7490fc4ef7b85195b61 (patch) | |
| tree | 765f8a124df0a278b61017ada27c338478ed48b5 /test/lisp/progmodes/python-tests.el | |
| parent | 8f8d28f6dc8ea6d5f35c08c7ca03f47596bc4aad (diff) | |
| download | emacs-fedf45ca6337788717b2e7490fc4ef7b85195b61.tar.gz emacs-fedf45ca6337788717b2e7490fc4ef7b85195b61.zip | |
Revert "Repair serious breakage in the batch tests."
This reverts commit feac53141577161c32a7a6dfe75399a5ae98a7c1.
This patch has deactivated 253 test cases without a sufficient reasoning.
Instead it speaks about a shotgun in its commite message.
The patch is reverted because
- It hasn't been discussed on emacs-devel. It should have, because it is
a serious change in our infrastructure (new official tag :nobatch). Any
documentation of this change, for example in test/README, is missing.
- The proper way to deactivate such tests would have been
(skip-when noninteractive)
Even better to skip for the respective reasons.
- There is no fault report. There is no information about how these tests
have failed. Since it hasn't been a problem so far for us, nobody will
work on a fix forever.
Diffstat (limited to 'test/lisp/progmodes/python-tests.el')
| -rw-r--r-- | test/lisp/progmodes/python-tests.el | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 25a721d9117..1c625d79ca2 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el | |||
| @@ -4984,9 +4984,7 @@ def foo(): | |||
| 4984 | (python-shell-interpreter "/some/path/to/bin/pypy")) | 4984 | (python-shell-interpreter "/some/path/to/bin/pypy")) |
| 4985 | (should (python-shell-completion-native-interpreter-disabled-p)))) | 4985 | (should (python-shell-completion-native-interpreter-disabled-p)))) |
| 4986 | 4986 | ||
| 4987 | ;; Fails in batch: signal | ||
| 4988 | (ert-deftest python-shell-completion-at-point-1 () | 4987 | (ert-deftest python-shell-completion-at-point-1 () |
| 4989 | :tags '(:nobatch) | ||
| 4990 | (python-tests-with-temp-buffer-with-shell-interpreter | 4988 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 4991 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 4989 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| 4992 | "" | 4990 | "" |
| @@ -5000,9 +4998,7 @@ def foo(): | |||
| 5000 | (end-of-line 0) | 4998 | (end-of-line 0) |
| 5001 | (should-not (nth 2 (python-shell-completion-at-point)))))) | 4999 | (should-not (nth 2 (python-shell-completion-at-point)))))) |
| 5002 | 5000 | ||
| 5003 | ;; Fails in batch: signal | ||
| 5004 | (ert-deftest python-shell-completion-at-point-native-1 () | 5001 | (ert-deftest python-shell-completion-at-point-native-1 () |
| 5005 | :tags '(:nobatch) | ||
| 5006 | (python-tests-with-temp-buffer-with-shell-interpreter | 5002 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5007 | nil | 5003 | nil |
| 5008 | "" | 5004 | "" |
| @@ -5087,9 +5083,7 @@ def foo(): | |||
| 5087 | (string-trim (buffer-string)) | 5083 | (string-trim (buffer-string)) |
| 5088 | "")))) | 5084 | "")))) |
| 5089 | 5085 | ||
| 5090 | ;; Fails in batch: json-parse-string | ||
| 5091 | (ert-deftest python-shell-completion-at-point-jedi-completer () | 5086 | (ert-deftest python-shell-completion-at-point-jedi-completer () |
| 5092 | :tags '(:nobatch) | ||
| 5093 | "Check if Python shell completion works when Jedi completer is used." | 5087 | "Check if Python shell completion works when Jedi completer is used." |
| 5094 | (python-tests-with-shell-interpreter | 5088 | (python-tests-with-shell-interpreter |
| 5095 | nil | 5089 | nil |
| @@ -5107,9 +5101,7 @@ def foo(): | |||
| 5107 | (python-tests--completion-parameters) | 5101 | (python-tests--completion-parameters) |
| 5108 | (python-tests--completion-extra-context)))))) | 5102 | (python-tests--completion-extra-context)))))) |
| 5109 | 5103 | ||
| 5110 | ;; Fails in batch: json-parse-string | ||
| 5111 | (ert-deftest python-shell-completion-at-point-ipython () | 5104 | (ert-deftest python-shell-completion-at-point-ipython () |
| 5112 | :tags '(:nobatch) | ||
| 5113 | "Check if Python shell completion works for IPython." | 5105 | "Check if Python shell completion works for IPython." |
| 5114 | (let ((python-shell-interpreter "ipython") | 5106 | (let ((python-shell-interpreter "ipython") |
| 5115 | (python-shell-interpreter-args "-i --simple-prompt")) | 5107 | (python-shell-interpreter-args "-i --simple-prompt")) |
| @@ -5148,9 +5140,7 @@ def foo(): | |||
| 5148 | (python-shell-accept-process-output (python-shell-get-process)) | 5140 | (python-shell-accept-process-output (python-shell-get-process)) |
| 5149 | (should (python-ffap-module-path "abc"))) | 5141 | (should (python-ffap-module-path "abc"))) |
| 5150 | 5142 | ||
| 5151 | ;; Fails in batch: json-parse-string | ||
| 5152 | (ert-deftest python-shell-pdb-1 () | 5143 | (ert-deftest python-shell-pdb-1 () |
| 5153 | :tags '(:nobatch) | ||
| 5154 | "Check if completion and ffap works in Pdb." | 5144 | "Check if completion and ffap works in Pdb." |
| 5155 | (ert-with-temp-directory dir | 5145 | (ert-with-temp-directory dir |
| 5156 | (let ((inhibit-message t) | 5146 | (let ((inhibit-message t) |
| @@ -5181,9 +5171,7 @@ from test1 import f1" | |||
| 5181 | 5171 | ||
| 5182 | ;;; Symbol completion | 5172 | ;;; Symbol completion |
| 5183 | 5173 | ||
| 5184 | ;; Fails in batch: json-parse-string | ||
| 5185 | (ert-deftest python-completion-at-point-1 () | 5174 | (ert-deftest python-completion-at-point-1 () |
| 5186 | :tags '(:nobatch) | ||
| 5187 | (python-tests-with-temp-buffer-with-shell-interpreter | 5175 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5188 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 5176 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| 5189 | " | 5177 | " |
| @@ -5200,9 +5188,7 @@ import abc | |||
| 5200 | (insert "A") | 5188 | (insert "A") |
| 5201 | (should (completion-at-point))))) | 5189 | (should (completion-at-point))))) |
| 5202 | 5190 | ||
| 5203 | ;; Fails in batch: json-parse-string | ||
| 5204 | (ert-deftest python-completion-at-point-2 () | 5191 | (ert-deftest python-completion-at-point-2 () |
| 5205 | :tags '(:nobatch) | ||
| 5206 | "Should work regardless of the point in the Shell buffer." | 5192 | "Should work regardless of the point in the Shell buffer." |
| 5207 | (python-tests-with-temp-buffer-with-shell-interpreter | 5193 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5208 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 5194 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| @@ -5256,9 +5242,7 @@ time.sleep(3) | |||
| 5256 | (insert "time.") | 5242 | (insert "time.") |
| 5257 | (should-not (with-timeout (1 t) (completion-at-point)))))) | 5243 | (should-not (with-timeout (1 t) (completion-at-point)))))) |
| 5258 | 5244 | ||
| 5259 | ;; Fails in batch: json-parse-string | ||
| 5260 | (ert-deftest python-completion-at-point-native-1 () | 5245 | (ert-deftest python-completion-at-point-native-1 () |
| 5261 | :tags '(:nobatch) | ||
| 5262 | (python-tests-with-temp-buffer-with-shell-interpreter | 5246 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5263 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 5247 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| 5264 | " | 5248 | " |
| @@ -5276,9 +5260,7 @@ import abc | |||
| 5276 | (insert "A") | 5260 | (insert "A") |
| 5277 | (should (completion-at-point))))) | 5261 | (should (completion-at-point))))) |
| 5278 | 5262 | ||
| 5279 | ;; Fails in batch: json-parse-string | ||
| 5280 | (ert-deftest python-completion-at-point-native-2 () | 5263 | (ert-deftest python-completion-at-point-native-2 () |
| 5281 | :tags '(:nobatch) | ||
| 5282 | "Should work regardless of the point in the Shell buffer." | 5264 | "Should work regardless of the point in the Shell buffer." |
| 5283 | (python-tests-with-temp-buffer-with-shell-interpreter | 5265 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5284 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 5266 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| @@ -5297,9 +5279,7 @@ import abc | |||
| 5297 | (insert "abc.") | 5279 | (insert "abc.") |
| 5298 | (should (completion-at-point))))) | 5280 | (should (completion-at-point))))) |
| 5299 | 5281 | ||
| 5300 | ;; Fails in batch: json-parse-string | ||
| 5301 | (ert-deftest python-completion-at-point-native-with-ffap-1 () | 5282 | (ert-deftest python-completion-at-point-native-with-ffap-1 () |
| 5302 | :tags '(:nobatch) | ||
| 5303 | (python-tests-with-temp-buffer-with-shell-interpreter | 5283 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5304 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 5284 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| 5305 | " | 5285 | " |
| @@ -5317,9 +5297,7 @@ import abc | |||
| 5317 | (python-ffap-module-path "abc.") | 5297 | (python-ffap-module-path "abc.") |
| 5318 | (should (completion-at-point))))) | 5298 | (should (completion-at-point))))) |
| 5319 | 5299 | ||
| 5320 | ;; Fails in batch: json-parse-string | ||
| 5321 | (ert-deftest python-completion-at-point-native-with-eldoc-1 () | 5300 | (ert-deftest python-completion-at-point-native-with-eldoc-1 () |
| 5322 | :tags '(:nobatch) | ||
| 5323 | (python-tests-with-temp-buffer-with-shell-interpreter | 5301 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5324 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) | 5302 | (when (eq system-type 'darwin) #'python-tests-interpreter-3-p) |
| 5325 | " | 5303 | " |
| @@ -5346,9 +5324,7 @@ import abc | |||
| 5346 | 5324 | ||
| 5347 | ;;; FFAP | 5325 | ;;; FFAP |
| 5348 | 5326 | ||
| 5349 | ;; Fails in batch: signal | ||
| 5350 | (ert-deftest python-ffap-module-path-1 () | 5327 | (ert-deftest python-ffap-module-path-1 () |
| 5351 | :tags '(:nobatch) | ||
| 5352 | (python-tests-with-temp-buffer-with-shell-interpreter | 5328 | (python-tests-with-temp-buffer-with-shell-interpreter |
| 5353 | nil | 5329 | nil |
| 5354 | " | 5330 | " |