Fix creation of Secret Service items in auth-source

* lisp/auth-source.el (auth-source-secrets-create): Use ´apply'.
(auth-source-secrets-saver): Handle `auth-source-save-behavior'
equal t.

* lisp/net/secrets.el (secrets-get-items): Do not call
`secrets-open-session' here ...
(top): ... but here.

* test/lisp/auth-source-tests.el
(auth-source-test-secrets-create-secret): Bind
`auth-source-save-behavior' to t.  Cleanup.

* test/lisp/net/secrets-tests.el (secrets-test00-availability):
After loading secets.el, a session is already opened.
(secrets-test02-collections, secrets-test03-items)
(secrets-test04-search): Open a new session.

1 files changed, 9 insertions, 2 deletions

diff --git a/test/lisp/net/secrets-tests.el b/test/lisp/net/secrets-tests.el
index fcc3a2d3e6e..9a61bca4351 100644
--- a/test/lisp/net/secrets-tests.el
+++ b/test/lisp/net/secrets-tests.el
@@ -31,8 +31,9 @@
   :expected-result (if secrets-enabled :passed :failed)
   (should secrets-enabled)
   (should (dbus-ping :session secrets-service))
-  ;; We do not test when there's an open session.
-  (should (secrets-empty-path secrets-session-path)))
+
+  ;; Exit.
+  (secrets--test-close-all-sessions))
 
 (defun secrets--test-get-all-sessions ()
   "Return all object paths for existing secrets sessions."
@@ -88,6 +89,8 @@
 
   (unwind-protect
       (progn
+        (should (secrets-open-session))
+
         ;; There must be at least the collections "Login" and "session".
         (should (member "Login" (secrets-list-collections)))
         (should (member "session" (secrets-list-collections)))
@@ -149,6 +152,8 @@
 
   (unwind-protect
       (let (item-path)
+        (should (secrets-open-session))
+
         ;; There shall be no items in the "session" collection.
         (should-not (secrets-list-items "session"))
         ;; There shall be items in the "Login" collection.
@@ -208,6 +213,8 @@
 
   (unwind-protect
       (progn
+        (should (secrets-open-session))
+
         ;; There shall be no items in the "session" collection.
         (should-not (secrets-list-items "session"))