aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAndreas Schwab2012-06-25 12:28:47 +0200
committerAndreas Schwab2012-06-25 12:28:47 +0200
commitfb7da12e7560ce31fc88f829cff94723c3bbc5fa (patch)
tree67210dc17bf5d1b9bff0df04d8043bf19d184dcc /src
parent75d5be5c60ec0f3d20a97812bf8858c38b6cba9f (diff)
downloademacs-fb7da12e7560ce31fc88f829cff94723c3bbc5fa.tar.gz
emacs-fb7da12e7560ce31fc88f829cff94723c3bbc5fa.zip
* keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
Avoid comma operator. * menu.c (push_submenu_start, push_submenu_end) (push_left_right_boundary, push_menu_pane): Likewise. * msdos.c (dos_rawgetc): Likewise.
Diffstat (limited to 'src')
-rw-r--r--src/ChangeLog8
-rw-r--r--src/keyboard.c22
-rw-r--r--src/menu.c18
-rw-r--r--src/msdos.c6
4 files changed, 36 insertions, 18 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index 1430c479c97..48eb04ca50d 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,11 @@
12012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2
3 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4 Avoid comma operator.
5 * menu.c (push_submenu_start, push_submenu_end)
6 (push_left_right_boundary, push_menu_pane): Likewise.
7 * msdos.c (dos_rawgetc): Likewise.
8
12012-06-25 Dmitry Antipov <dmantipov@yandex.ru> 92012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2 10
3 * xfns.c (xic_create_fontsetname): Remove redundant calls 11 * xfns.c (xic_create_fontsetname): Remove redundant calls
diff --git a/src/keyboard.c b/src/keyboard.c
index ae27920b181..3d128612028 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -7571,10 +7571,10 @@ menu_bar_items (Lisp_Object old)
7571 menu_bar_items_vector = 7571 menu_bar_items_vector =
7572 larger_vector (menu_bar_items_vector, 4, -1); 7572 larger_vector (menu_bar_items_vector, 4, -1);
7573 /* Add this item. */ 7573 /* Add this item. */
7574 ASET (menu_bar_items_vector, i, Qnil), i++; 7574 ASET (menu_bar_items_vector, i, Qnil); i++;
7575 ASET (menu_bar_items_vector, i, Qnil), i++; 7575 ASET (menu_bar_items_vector, i, Qnil); i++;
7576 ASET (menu_bar_items_vector, i, Qnil), i++; 7576 ASET (menu_bar_items_vector, i, Qnil); i++;
7577 ASET (menu_bar_items_vector, i, Qnil), i++; 7577 ASET (menu_bar_items_vector, i, Qnil); i++;
7578 menu_bar_items_index = i; 7578 menu_bar_items_index = i;
7579 } 7579 }
7580 7580
@@ -7642,11 +7642,11 @@ menu_bar_item (Lisp_Object key, Lisp_Object item, Lisp_Object dummy1, void *dumm
7642 if (i + 4 > ASIZE (menu_bar_items_vector)) 7642 if (i + 4 > ASIZE (menu_bar_items_vector))
7643 menu_bar_items_vector = larger_vector (menu_bar_items_vector, 4, -1); 7643 menu_bar_items_vector = larger_vector (menu_bar_items_vector, 4, -1);
7644 /* Add this item. */ 7644 /* Add this item. */
7645 ASET (menu_bar_items_vector, i, key), i++; 7645 ASET (menu_bar_items_vector, i, key); i++;
7646 ASET (menu_bar_items_vector, i, 7646 ASET (menu_bar_items_vector, i,
7647 AREF (item_properties, ITEM_PROPERTY_NAME)), i++; 7647 AREF (item_properties, ITEM_PROPERTY_NAME)); i++;
7648 ASET (menu_bar_items_vector, i, Fcons (item, Qnil)), i++; 7648 ASET (menu_bar_items_vector, i, Fcons (item, Qnil)); i++;
7649 ASET (menu_bar_items_vector, i, make_number (0)), i++; 7649 ASET (menu_bar_items_vector, i, make_number (0)); i++;
7650 menu_bar_items_index = i; 7650 menu_bar_items_index = i;
7651 } 7651 }
7652 /* We did find an item for this KEY. Add ITEM to its list of maps. */ 7652 /* We did find an item for this KEY. Add ITEM to its list of maps. */
@@ -9447,7 +9447,8 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt,
9447 && current_buffer != starting_buffer) 9447 && current_buffer != starting_buffer)
9448 { 9448 {
9449 GROW_RAW_KEYBUF; 9449 GROW_RAW_KEYBUF;
9450 ASET (raw_keybuf, raw_keybuf_count, key), raw_keybuf_count++; 9450 ASET (raw_keybuf, raw_keybuf_count, key);
9451 raw_keybuf_count++;
9451 keybuf[t++] = key; 9452 keybuf[t++] = key;
9452 mock_input = t; 9453 mock_input = t;
9453 Vquit_flag = Qnil; 9454 Vquit_flag = Qnil;
@@ -9525,7 +9526,8 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt,
9525 && BUFFERP (XWINDOW (window)->buffer) 9526 && BUFFERP (XWINDOW (window)->buffer)
9526 && XBUFFER (XWINDOW (window)->buffer) != current_buffer) 9527 && XBUFFER (XWINDOW (window)->buffer) != current_buffer)
9527 { 9528 {
9528 ASET (raw_keybuf, raw_keybuf_count, key), raw_keybuf_count++; 9529 ASET (raw_keybuf, raw_keybuf_count, key);
9530 raw_keybuf_count++;
9529 keybuf[t] = key; 9531 keybuf[t] = key;
9530 mock_input = t + 1; 9532 mock_input = t + 1;
9531 9533
diff --git a/src/menu.c b/src/menu.c
index ce0c7d6df68..e3677e62896 100644
--- a/src/menu.c
+++ b/src/menu.c
@@ -197,7 +197,8 @@ static void
197push_submenu_start (void) 197push_submenu_start (void)
198{ 198{
199 ensure_menu_items (1); 199 ensure_menu_items (1);
200 ASET (menu_items, menu_items_used, Qnil), menu_items_used++; 200 ASET (menu_items, menu_items_used, Qnil);
201 menu_items_used++;
201 menu_items_submenu_depth++; 202 menu_items_submenu_depth++;
202} 203}
203 204
@@ -207,7 +208,8 @@ static void
207push_submenu_end (void) 208push_submenu_end (void)
208{ 209{
209 ensure_menu_items (1); 210 ensure_menu_items (1);
210 ASET (menu_items, menu_items_used, Qlambda), menu_items_used++; 211 ASET (menu_items, menu_items_used, Qlambda);
212 menu_items_used++;
211 menu_items_submenu_depth--; 213 menu_items_submenu_depth--;
212} 214}
213 215
@@ -219,7 +221,8 @@ static void
219push_left_right_boundary (void) 221push_left_right_boundary (void)
220{ 222{
221 ensure_menu_items (1); 223 ensure_menu_items (1);
222 ASET (menu_items, menu_items_used, Qquote), menu_items_used++; 224 ASET (menu_items, menu_items_used, Qquote);
225 menu_items_used++;
223} 226}
224 227
225/* Start a new menu pane in menu_items. 228/* Start a new menu pane in menu_items.
@@ -231,9 +234,12 @@ push_menu_pane (Lisp_Object name, Lisp_Object prefix_vec)
231 ensure_menu_items (MENU_ITEMS_PANE_LENGTH); 234 ensure_menu_items (MENU_ITEMS_PANE_LENGTH);
232 if (menu_items_submenu_depth == 0) 235 if (menu_items_submenu_depth == 0)
233 menu_items_n_panes++; 236 menu_items_n_panes++;
234 ASET (menu_items, menu_items_used, Qt), menu_items_used++; 237 ASET (menu_items, menu_items_used, Qt);
235 ASET (menu_items, menu_items_used, name), menu_items_used++; 238 menu_items_used++;
236 ASET (menu_items, menu_items_used, prefix_vec), menu_items_used++; 239 ASET (menu_items, menu_items_used, name);
240 menu_items_used++;
241 ASET (menu_items, menu_items_used, prefix_vec);
242 menu_items_used++;
237} 243}
238 244
239/* Push one menu item into the current pane. NAME is the string to 245/* Push one menu item into the current pane. NAME is the string to
diff --git a/src/msdos.c b/src/msdos.c
index 66911098ce0..a79fad0ccd4 100644
--- a/src/msdos.c
+++ b/src/msdos.c
@@ -2466,10 +2466,12 @@ dos_rawgetc (void)
2466 sc = regs.h.ah; 2466 sc = regs.h.ah;
2467 2467
2468 total_doskeys += 2; 2468 total_doskeys += 2;
2469 ASET (recent_doskeys, recent_doskeys_index, make_number (c)), recent_doskeys_index++; 2469 ASET (recent_doskeys, recent_doskeys_index, make_number (c));
2470 recent_doskeys_index++;
2470 if (recent_doskeys_index == NUM_RECENT_DOSKEYS) 2471 if (recent_doskeys_index == NUM_RECENT_DOSKEYS)
2471 recent_doskeys_index = 0; 2472 recent_doskeys_index = 0;
2472 ASET (recent_doskeys, recent_doskeys_index, make_number (sc)), recent_doskeys_index++; 2473 ASET (recent_doskeys, recent_doskeys_index, make_number (sc));
2474 recent_doskeys_index++;
2473 if (recent_doskeys_index == NUM_RECENT_DOSKEYS) 2475 if (recent_doskeys_index == NUM_RECENT_DOSKEYS)
2474 recent_doskeys_index = 0; 2476 recent_doskeys_index = 0;
2475 2477