diff options
| author | Dmitry Antipov | 2013-07-31 16:50:59 +0400 |
|---|---|---|
| committer | Dmitry Antipov | 2013-07-31 16:50:59 +0400 |
| commit | f435830ea42db6073ed8714452dae302a3c855c5 (patch) | |
| tree | 439809f2d9947708019f4be567365f80e11e5598 /src | |
| parent | 2412ee1af63c6cc8f4a85919cc78e59cb6ec83e3 (diff) | |
| download | emacs-f435830ea42db6073ed8714452dae302a3c855c5.tar.gz emacs-f435830ea42db6073ed8714452dae302a3c855c5.zip | |
Drop unnecessary functions that deals with frame pixel size.
* frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
(x_pixel_height): Drop prototypes.
* msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
(x_pixel_height): Drop implementations.
* frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
which should be always valid for window frame.
(Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
* w32menu.c (Fx_popup_dialog):
* xmenu.c (Fx_popup_dialog): Likewise for both.
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 13 | ||||
| -rw-r--r-- | src/frame.c | 4 | ||||
| -rw-r--r-- | src/frame.h | 2 | ||||
| -rw-r--r-- | src/msdos.c | 12 | ||||
| -rw-r--r-- | src/msdos.h | 2 | ||||
| -rw-r--r-- | src/nsfns.m | 15 | ||||
| -rw-r--r-- | src/w32fns.c | 13 | ||||
| -rw-r--r-- | src/w32menu.c | 4 | ||||
| -rw-r--r-- | src/w32term.h | 2 | ||||
| -rw-r--r-- | src/xfns.c | 13 | ||||
| -rw-r--r-- | src/xmenu.c | 4 | ||||
| -rw-r--r-- | src/xterm.h | 2 |
12 files changed, 19 insertions, 67 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 1c4880e3356..76ef664ccd0 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,18 @@ | |||
| 1 | 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru> | 1 | 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru> |
| 2 | 2 | ||
| 3 | Drop unnecessary functions that deals with frame pixel size. | ||
| 4 | * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width) | ||
| 5 | (x_pixel_height): Drop prototypes. | ||
| 6 | * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width) | ||
| 7 | (x_pixel_height): Drop implementations. | ||
| 8 | * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT | ||
| 9 | which should be always valid for window frame. | ||
| 10 | (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH. | ||
| 11 | * w32menu.c (Fx_popup_dialog): | ||
| 12 | * xmenu.c (Fx_popup_dialog): Likewise for both. | ||
| 13 | |||
| 14 | 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru> | ||
| 15 | |||
| 3 | * frame.c (Fmake_terminal_frame): Use store_in_alist to setup | 16 | * frame.c (Fmake_terminal_frame): Use store_in_alist to setup |
| 4 | frame parameters and call to Fmodify_frame_parameters just once. | 17 | frame parameters and call to Fmodify_frame_parameters just once. |
| 5 | (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring. | 18 | (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring. |
diff --git a/src/frame.c b/src/frame.c index 271d99904c3..6e56a20f850 100644 --- a/src/frame.c +++ b/src/frame.c | |||
| @@ -2361,7 +2361,7 @@ to `frame-height'). */) | |||
| 2361 | 2361 | ||
| 2362 | #ifdef HAVE_WINDOW_SYSTEM | 2362 | #ifdef HAVE_WINDOW_SYSTEM |
| 2363 | if (FRAME_WINDOW_P (f)) | 2363 | if (FRAME_WINDOW_P (f)) |
| 2364 | return make_number (x_pixel_height (f)); | 2364 | return make_number (FRAME_PIXEL_HEIGHT (f)); |
| 2365 | else | 2365 | else |
| 2366 | #endif | 2366 | #endif |
| 2367 | return make_number (FRAME_LINES (f)); | 2367 | return make_number (FRAME_LINES (f)); |
| @@ -2378,7 +2378,7 @@ If FRAME is omitted or nil, the selected frame is used. */) | |||
| 2378 | 2378 | ||
| 2379 | #ifdef HAVE_WINDOW_SYSTEM | 2379 | #ifdef HAVE_WINDOW_SYSTEM |
| 2380 | if (FRAME_WINDOW_P (f)) | 2380 | if (FRAME_WINDOW_P (f)) |
| 2381 | return make_number (x_pixel_width (f)); | 2381 | return make_number (FRAME_PIXEL_WIDTH (f)); |
| 2382 | else | 2382 | else |
| 2383 | #endif | 2383 | #endif |
| 2384 | return make_number (FRAME_COLS (f)); | 2384 | return make_number (FRAME_COLS (f)); |
diff --git a/src/frame.h b/src/frame.h index 2e544770094..98cf54c13a4 100644 --- a/src/frame.h +++ b/src/frame.h | |||
| @@ -1264,8 +1264,6 @@ extern void x_set_mouse_pixel_position (struct frame *f, int pix_x, int pix_y); | |||
| 1264 | extern void x_make_frame_visible (struct frame *f); | 1264 | extern void x_make_frame_visible (struct frame *f); |
| 1265 | extern void x_make_frame_invisible (struct frame *f); | 1265 | extern void x_make_frame_invisible (struct frame *f); |
| 1266 | extern void x_iconify_frame (struct frame *f); | 1266 | extern void x_iconify_frame (struct frame *f); |
| 1267 | extern int x_pixel_width (struct frame *f); | ||
| 1268 | extern int x_pixel_height (struct frame *f); | ||
| 1269 | extern void x_set_frame_alpha (struct frame *f); | 1267 | extern void x_set_frame_alpha (struct frame *f); |
| 1270 | extern void x_set_menu_bar_lines (struct frame *, Lisp_Object, Lisp_Object); | 1268 | extern void x_set_menu_bar_lines (struct frame *, Lisp_Object, Lisp_Object); |
| 1271 | extern void x_set_tool_bar_lines (struct frame *f, | 1269 | extern void x_set_tool_bar_lines (struct frame *f, |
diff --git a/src/msdos.c b/src/msdos.c index a2bcc06ac17..16308d06c85 100644 --- a/src/msdos.c +++ b/src/msdos.c | |||
| @@ -3320,18 +3320,6 @@ XMenuDestroy (Display *foo, XMenu *menu) | |||
| 3320 | xfree (menu); | 3320 | xfree (menu); |
| 3321 | menu_help_message = prev_menu_help_message = NULL; | 3321 | menu_help_message = prev_menu_help_message = NULL; |
| 3322 | } | 3322 | } |
| 3323 | |||
| 3324 | int | ||
| 3325 | x_pixel_width (struct frame *f) | ||
| 3326 | { | ||
| 3327 | return FRAME_COLS (f); | ||
| 3328 | } | ||
| 3329 | |||
| 3330 | int | ||
| 3331 | x_pixel_height (struct frame *f) | ||
| 3332 | { | ||
| 3333 | return FRAME_LINES (f); | ||
| 3334 | } | ||
| 3335 | #endif /* !HAVE_X_WINDOWS */ | 3323 | #endif /* !HAVE_X_WINDOWS */ |
| 3336 | 3324 | ||
| 3337 | /* ----------------------- DOS / UNIX conversion --------------------- */ | 3325 | /* ----------------------- DOS / UNIX conversion --------------------- */ |
diff --git a/src/msdos.h b/src/msdos.h index ee0d49464ae..6a6fe349131 100644 --- a/src/msdos.h +++ b/src/msdos.h | |||
| @@ -74,8 +74,6 @@ struct window; | |||
| 74 | /* Defined in xfns.c; emulated on msdos.c */ | 74 | /* Defined in xfns.c; emulated on msdos.c */ |
| 75 | 75 | ||
| 76 | extern void x_set_menu_bar_lines (struct frame *, Lisp_Object, Lisp_Object); | 76 | extern void x_set_menu_bar_lines (struct frame *, Lisp_Object, Lisp_Object); |
| 77 | extern int x_pixel_width (struct frame *); | ||
| 78 | extern int x_pixel_height (struct frame *); | ||
| 79 | 77 | ||
| 80 | #define XFreeGC (void) | 78 | #define XFreeGC (void) |
| 81 | #define x_destroy_bitmap(p1,p2) | 79 | #define x_destroy_bitmap(p1,p2) |
diff --git a/src/nsfns.m b/src/nsfns.m index 71f971a9f5b..3a4d95360c4 100644 --- a/src/nsfns.m +++ b/src/nsfns.m | |||
| @@ -2231,21 +2231,6 @@ x_get_focus_frame (struct frame *frame) | |||
| 2231 | return nsfocus; | 2231 | return nsfocus; |
| 2232 | } | 2232 | } |
| 2233 | 2233 | ||
| 2234 | |||
| 2235 | int | ||
| 2236 | x_pixel_width (struct frame *f) | ||
| 2237 | { | ||
| 2238 | return FRAME_PIXEL_WIDTH (f); | ||
| 2239 | } | ||
| 2240 | |||
| 2241 | |||
| 2242 | int | ||
| 2243 | x_pixel_height (struct frame *f) | ||
| 2244 | { | ||
| 2245 | return FRAME_PIXEL_HEIGHT (f); | ||
| 2246 | } | ||
| 2247 | |||
| 2248 | |||
| 2249 | void | 2234 | void |
| 2250 | x_sync (struct frame *f) | 2235 | x_sync (struct frame *f) |
| 2251 | { | 2236 | { |
diff --git a/src/w32fns.c b/src/w32fns.c index 2b06936d119..e46608f9d72 100644 --- a/src/w32fns.c +++ b/src/w32fns.c | |||
| @@ -5139,19 +5139,6 @@ SOUND is nil to use the normal beep. */) | |||
| 5139 | return sound; | 5139 | return sound; |
| 5140 | } | 5140 | } |
| 5141 | 5141 | ||
| 5142 | |||
| 5143 | int | ||
| 5144 | x_pixel_width (register struct frame *f) | ||
| 5145 | { | ||
| 5146 | return FRAME_PIXEL_WIDTH (f); | ||
| 5147 | } | ||
| 5148 | |||
| 5149 | int | ||
| 5150 | x_pixel_height (register struct frame *f) | ||
| 5151 | { | ||
| 5152 | return FRAME_PIXEL_HEIGHT (f); | ||
| 5153 | } | ||
| 5154 | |||
| 5155 | int | 5142 | int |
| 5156 | x_screen_planes (register struct frame *f) | 5143 | x_screen_planes (register struct frame *f) |
| 5157 | { | 5144 | { |
diff --git a/src/w32menu.c b/src/w32menu.c index 346402b7c6b..aa13f26383f 100644 --- a/src/w32menu.c +++ b/src/w32menu.c | |||
| @@ -206,8 +206,8 @@ otherwise it is "Question". */) | |||
| 206 | in the middle of frame F. */ | 206 | in the middle of frame F. */ |
| 207 | Lisp_Object x, y, frame, newpos; | 207 | Lisp_Object x, y, frame, newpos; |
| 208 | XSETFRAME (frame, f); | 208 | XSETFRAME (frame, f); |
| 209 | XSETINT (x, x_pixel_width (f) / 2); | 209 | XSETINT (x, FRAME_PIXEL_WIDTH (f) / 2); |
| 210 | XSETINT (y, x_pixel_height (f) / 2); | 210 | XSETINT (y, FRAME_PIXEL_HEIGHT (f) / 2); |
| 211 | newpos = Fcons (Fcons (x, Fcons (y, Qnil)), Fcons (frame, Qnil)); | 211 | newpos = Fcons (Fcons (x, Fcons (y, Qnil)), Fcons (frame, Qnil)); |
| 212 | return Fx_popup_menu (newpos, | 212 | return Fx_popup_menu (newpos, |
| 213 | Fcons (Fcar (contents), Fcons (contents, Qnil))); | 213 | Fcons (Fcar (contents), Fcons (contents, Qnil))); |
diff --git a/src/w32term.h b/src/w32term.h index ace58758302..032047a2751 100644 --- a/src/w32term.h +++ b/src/w32term.h | |||
| @@ -218,8 +218,6 @@ extern void x_set_mouse_pixel_position (struct frame *f, int pix_x, int pix_y); | |||
| 218 | extern void x_make_frame_visible (struct frame *f); | 218 | extern void x_make_frame_visible (struct frame *f); |
| 219 | extern void x_make_frame_invisible (struct frame *f); | 219 | extern void x_make_frame_invisible (struct frame *f); |
| 220 | extern void x_iconify_frame (struct frame *f); | 220 | extern void x_iconify_frame (struct frame *f); |
| 221 | extern int x_pixel_width (struct frame *f); | ||
| 222 | extern int x_pixel_height (struct frame *f); | ||
| 223 | extern void x_set_frame_alpha (struct frame *f); | 221 | extern void x_set_frame_alpha (struct frame *f); |
| 224 | extern void x_set_menu_bar_lines (struct frame *, Lisp_Object, Lisp_Object); | 222 | extern void x_set_menu_bar_lines (struct frame *, Lisp_Object, Lisp_Object); |
| 225 | extern void x_set_tool_bar_lines (struct frame *f, | 223 | extern void x_set_tool_bar_lines (struct frame *f, |
diff --git a/src/xfns.c b/src/xfns.c index a4492a10fdb..e86f71fb711 100644 --- a/src/xfns.c +++ b/src/xfns.c | |||
| @@ -4325,19 +4325,6 @@ Internal use only, use `display-monitor-attributes-list' instead. */) | |||
| 4325 | return attributes_list; | 4325 | return attributes_list; |
| 4326 | } | 4326 | } |
| 4327 | 4327 | ||
| 4328 | |||
| 4329 | int | ||
| 4330 | x_pixel_width (register struct frame *f) | ||
| 4331 | { | ||
| 4332 | return FRAME_PIXEL_WIDTH (f); | ||
| 4333 | } | ||
| 4334 | |||
| 4335 | int | ||
| 4336 | x_pixel_height (register struct frame *f) | ||
| 4337 | { | ||
| 4338 | return FRAME_PIXEL_HEIGHT (f); | ||
| 4339 | } | ||
| 4340 | |||
| 4341 | /************************************************************************ | 4328 | /************************************************************************ |
| 4342 | X Displays | 4329 | X Displays |
| 4343 | ************************************************************************/ | 4330 | ************************************************************************/ |
diff --git a/src/xmenu.c b/src/xmenu.c index 5cc37842da9..1292e264ffb 100644 --- a/src/xmenu.c +++ b/src/xmenu.c | |||
| @@ -294,8 +294,8 @@ for instance using the window manager, then this produces a quit and | |||
| 294 | { | 294 | { |
| 295 | Lisp_Object x, y, frame, newpos; | 295 | Lisp_Object x, y, frame, newpos; |
| 296 | XSETFRAME (frame, f); | 296 | XSETFRAME (frame, f); |
| 297 | XSETINT (x, x_pixel_width (f) / 2); | 297 | XSETINT (x, FRAME_PIXEL_WIDTH (f) / 2); |
| 298 | XSETINT (y, x_pixel_height (f) / 2); | 298 | XSETINT (y, FRAME_PIXEL_HEIGHT (f) / 2); |
| 299 | newpos = list2 (list2 (x, y), frame); | 299 | newpos = list2 (list2 (x, y), frame); |
| 300 | 300 | ||
| 301 | return Fx_popup_menu (newpos, | 301 | return Fx_popup_menu (newpos, |
diff --git a/src/xterm.h b/src/xterm.h index 6bdc708220b..311b32c7930 100644 --- a/src/xterm.h +++ b/src/xterm.h | |||
| @@ -1031,8 +1031,6 @@ extern void destroy_frame_xic (struct frame *); | |||
| 1031 | extern void xic_set_preeditarea (struct window *, int, int); | 1031 | extern void xic_set_preeditarea (struct window *, int, int); |
| 1032 | extern void xic_set_statusarea (struct frame *); | 1032 | extern void xic_set_statusarea (struct frame *); |
| 1033 | extern void xic_set_xfontset (struct frame *, const char *); | 1033 | extern void xic_set_xfontset (struct frame *, const char *); |
| 1034 | extern int x_pixel_width (struct frame *); | ||
| 1035 | extern int x_pixel_height (struct frame *); | ||
| 1036 | extern bool x_defined_color (struct frame *, const char *, XColor *, bool); | 1034 | extern bool x_defined_color (struct frame *, const char *, XColor *, bool); |
| 1037 | #ifdef HAVE_X_I18N | 1035 | #ifdef HAVE_X_I18N |
| 1038 | extern void free_frame_xic (struct frame *); | 1036 | extern void free_frame_xic (struct frame *); |