update LISP_MAKE_RVALUE comment for union, non-gcc case

1 files changed, 5 insertions, 1 deletions

diff --git a/src/lisp.h b/src/lisp.h
index d8bb5bf08af..c179e8d04d2 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -235,7 +235,11 @@ LISP_MAKE_RVALUE (Lisp_Object o)
     return o;
 }
 #else
-#define LISP_MAKE_RVALUE(o) (o) /* XXX - keeps arg as rvalue.  */
+/* This isn't quite right - it keeps the argument as an lvalue.
+   Making it const via casting would help avoid code actually
+   modifying the location in question, but the casting could cover
+   other type-related bugs.  */
+#define LISP_MAKE_RVALUE(o) (o)
 #endif
 
 #endif /* NO_UNION_TYPE */