Remove bytecomp- prefix, plus misc changes.

* lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Make it work to
inline lexbind interpreted functions into lexbind code.
(bytedecomp-bytes): Not a dynamic var any more.
(disassemble-offset): Get the bytes via an argument instead.
(byte-decompile-bytecode-1): Use push.
* lisp/emacs-lisp/bytecomp.el: Remove the bytecomp- prefix now that we use
lexical-binding.
(byte-compile-outbuffer): Rename from bytecomp-outbuffer.
* lisp/emacs-lisp/cl-macs.el (load-time-value):
* lisp/emacs-lisp/cl.el (cl-compiling-file): Adjust to new name.
* lisp/emacs-lisp/pcase.el (pcase-mutually-exclusive-predicates):
Add byte-code-function-p.
(pcase--u1): Remove left-over code from early development.
Fix case of variable shadowing in guards and predicates.
(pcase--u1): Add a new `let' pattern.
* src/image.c (parse_image_spec): Use Ffunctionp.
* src/lisp.h: Declare Ffunctionp.

4 files changed, 13 insertions, 10 deletions

diff --git a/src/ChangeLog b/src/ChangeLog
index 00d8e4b8ee3..e34cd694321 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+        * image.c (parse_image_spec): Use Ffunctionp.
+        * lisp.h: Declare Ffunctionp.
+
 2011-03-13  Stefan Monnier  <monnier@iro.umontreal.ca>
 
         * eval.c (Ffunction): Use simpler format for closures.
diff --git a/src/bytecode.c b/src/bytecode.c
index b19f9687cdc..ba3c012bd1a 100644
--- a/src/bytecode.c
+++ b/src/bytecode.c
@@ -939,27 +939,27 @@ exec_byte_code (Lisp_Object bytestr, Lisp_Object vector, Lisp_Object maxdepth,
                                  save_restriction_save ());
           break;
 
-        case Bcatch:
+        case Bcatch:            /* FIXME: ill-suited for lexbind */
           {
             Lisp_Object v1;
             BEFORE_POTENTIAL_GC ();
             v1 = POP;
-            TOP = internal_catch (TOP, eval_sub, v1); /* FIXME: lexbind */
+            TOP = internal_catch (TOP, eval_sub, v1);
             AFTER_POTENTIAL_GC ();
             break;
           }
 
-        case Bunwind_protect:
-          record_unwind_protect (Fprogn, POP); /* FIXME: lexbind */
+        case Bunwind_protect:   /* FIXME: avoid closure for lexbind */
+          record_unwind_protect (Fprogn, POP);
           break;
 
-        case Bcondition_case:
+        case Bcondition_case:   /* FIXME: ill-suited for lexbind */
           {
             Lisp_Object handlers, body;
             handlers = POP;
             body = POP;
             BEFORE_POTENTIAL_GC ();
-            TOP = internal_lisp_condition_case (TOP, body, handlers); /* FIXME: lexbind */
+            TOP = internal_lisp_condition_case (TOP, body, handlers);
             AFTER_POTENTIAL_GC ();
             break;
           }
diff --git a/src/image.c b/src/image.c
index a7c6346f62c..73a45633f3b 100644
--- a/src/image.c
+++ b/src/image.c
@@ -835,10 +835,7 @@ parse_image_spec (Lisp_Object spec, struct image_keyword *keywords,
 
         case IMAGE_FUNCTION_VALUE:
           value = indirect_function (value);
-          /* FIXME: Shouldn't we use Ffunctionp here?  */
-          if (SUBRP (value)
-              || COMPILEDP (value)
-              || (CONSP (value) && EQ (XCAR (value), Qlambda)))
+          if (!NILP (Ffunctionp (value)))
             break;
           return 0;
 
diff --git a/src/lisp.h b/src/lisp.h
index ece96428253..e4788e63f5b 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -2864,6 +2864,7 @@ extern void xsignal2 (Lisp_Object, Lisp_Object, Lisp_Object) NO_RETURN;
 extern void xsignal3 (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object) NO_RETURN;
 extern void signal_error (const char *, Lisp_Object) NO_RETURN;
 EXFUN (Fcommandp, 2);
+EXFUN (Ffunctionp, 1);
 EXFUN (Feval, 2);
 extern Lisp_Object eval_sub (Lisp_Object form);
 EXFUN (Fapply, MANY);