Misc fixes, and use lexical-binding in more files.

* lisp/subr.el (letrec): New macro.
(with-wrapper-hook): Move from lisp/simple.el and don't use CL.
* simple.el (with-wrapper-hook): Move with-wrapper-hook to subr.el.
* lisp/help-fns.el (help-function-arglist): Handle subroutines as well.
(describe-variable): Use special-variable-p to filter completions.
* lisp/emacs-lisp/macroexp.el (macroexpand-all-1): Don't expand `declare'
in defmacros.
* lisp/emacs-lisp/cconv.el (cconv-convert, cconv-analyse-form):
Handle `declare'.
* lisp/emacs-lisp/cl.el (pushnew): Silence unfixable warning.
* lisp/emacs-lisp/cl-macs.el (defstruct, define-compiler-macro):
Mark unused arg as unused.
* lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode): Use memq.
* lisp/emacs-lisp/autoload.el (make-autoload): Don't assume the macro's
first sexp is a list.
(autoload-generate-file-autoloads): Improve error message.
* lisp/emacs-lisp/advice.el (ad-arglist): Use help-function-arglist
to understand the new byte-code arg format.
* lisp/vc/smerge-mode.el:
* lisp/vc/log-view.el:
* lisp/vc/log-edit.el:
* lisp/vc/cvs-status.el:
* lisp/uniquify.el:
* lisp/textmodes/css-mode.el:
* lisp/textmodes/bibtex-style.el:
* lisp/reveal.el:
* lisp/newcomment.el:
* lisp/emacs-lisp/smie.el:
* lisp/abbrev.el: Use lexical-binding.
* src/eval.c (Fprog1, Fprog2): Simplify and use XCDR/XCAR.
(Fdefvar): Remove redundant SYMBOLP check.
(Ffunctionp): Don't signal an error for undefined aliases.
* doc/lispref/variables.texi (Converting to Lexical Binding): New node.

2 files changed, 17 insertions, 14 deletions

diff --git a/src/ChangeLog b/src/ChangeLog
index e8b3c57fbd0..bbf7f99bb32 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2011-03-11  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+        * eval.c (Fprog1, Fprog2): Simplify and use XCDR/XCAR.
+        (Fdefvar): Remove redundant SYMBOLP check.
+        (Ffunctionp): Don't signal an error for undefined aliases.
+
 2011-03-06  Stefan Monnier  <monnier@iro.umontreal.ca>
 
         * bytecode.c (exec_byte_code): Remove old lexical binding slot handling
diff --git a/src/eval.c b/src/eval.c
index 1f6a5e4a1c6..36c63a5c8a7 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -371,13 +371,12 @@ usage: (prog1 FIRST BODY...)  */)
 
   do
     {
+      Lisp_Object tem = eval_sub (XCAR (args_left));
       if (!(argnum++))
-        val = eval_sub (Fcar (args_left));
-      else
-        eval_sub (Fcar (args_left));
-      args_left = Fcdr (args_left);
+        val = tem;
+      args_left = XCDR (args_left);
     }
-  while (!NILP(args_left));
+  while (CONSP (args_left));
 
   UNGCPRO;
   return val;
@@ -406,13 +405,12 @@ usage: (prog2 FORM1 FORM2 BODY...)  */)
 
   do
     {
+      Lisp_Object tem = eval_sub (XCAR (args_left));
       if (!(argnum++))
-        val = eval_sub (Fcar (args_left));
-      else
-        eval_sub (Fcar (args_left));
-      args_left = Fcdr (args_left);
+        val = tem;
+      args_left = XCDR (args_left);
     }
-  while (!NILP (args_left));
+  while (CONSP (args_left));
 
   UNGCPRO;
   return val;
@@ -791,9 +789,8 @@ usage: (defvar SYMBOL &optional INITVALUE DOCSTRING)  */)
   tem = Fdefault_boundp (sym);
   if (!NILP (tail))
     {
-      if (SYMBOLP (sym))
-        /* Do it before evaluating the initial value, for self-references.  */
-        XSYMBOL (sym)->declared_special = 1;
+      /* Do it before evaluating the initial value, for self-references.  */
+      XSYMBOL (sym)->declared_special = 1;
 
       if (SYMBOL_CONSTANT_P (sym))
         {
@@ -2873,7 +2870,7 @@ DEFUN ("functionp", Ffunctionp, Sfunctionp, 1, 1, 0,
 {
   if (SYMBOLP (object) && !NILP (Ffboundp (object)))
     {
-      object = Findirect_function (object, Qnil);
+      object = Findirect_function (object, Qt);
 
       if (CONSP (object) && EQ (XCAR (object), Qautoload))
         {