aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorKhaled Hosny2018-12-22 17:25:49 +0200
committerKhaled Hosny2018-12-22 17:25:49 +0200
commita8862800ed6d0460d882a88737e390a46ff65bc4 (patch)
tree7196a9750905806f97e2db5ef2562c7cb7fff53b /src
parent8e424aa961adc4e4ab75e9ffb91532e7f4aab835 (diff)
downloademacs-a8862800ed6d0460d882a88737e390a46ff65bc4.tar.gz
emacs-a8862800ed6d0460d882a88737e390a46ff65bc4.zip
Replace a FIXME with an expanded comment
Diffstat (limited to 'src')
-rw-r--r--src/ftfont.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/ftfont.c b/src/ftfont.c
index 179e4e17987..00e8237ea7e 100644
--- a/src/ftfont.c
+++ b/src/ftfont.c
@@ -2774,8 +2774,7 @@ get_hb_unicode_funcs (void)
2774{ 2774{
2775 /* Subclass HarfBuzz's default Unicode functions and override functions that 2775 /* Subclass HarfBuzz's default Unicode functions and override functions that
2776 * use data Emacs can provide. This way changing Emacs data is reflected in 2776 * use data Emacs can provide. This way changing Emacs data is reflected in
2777 * the shaped output. 2777 * the shaped output. */
2778 */
2779 hb_unicode_funcs_t *funcs = hb_unicode_funcs_create (hb_unicode_funcs_get_default ()); 2778 hb_unicode_funcs_t *funcs = hb_unicode_funcs_create (hb_unicode_funcs_get_default ());
2780 2779
2781 hb_unicode_funcs_set_combining_class_func (funcs, uni_combining, NULL, NULL); 2780 hb_unicode_funcs_set_combining_class_func (funcs, uni_combining, NULL, NULL);
@@ -2850,7 +2849,9 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font,
2850 if (glyph_len > LGSTRING_GLYPH_LEN (lgstring)) 2849 if (glyph_len > LGSTRING_GLYPH_LEN (lgstring))
2851 return Qnil; 2850 return Qnil;
2852 2851
2853 /* FIXME: Emacs wants the buffer reversed, WHY! */ 2852 /* Somewhere up the pipeline wants the glyphs in logical order, while keeping
2853 * clusters in visual order. I don't know where exactly, but lets satisfy
2854 * that. */
2854 if (HB_DIRECTION_IS_BACKWARD (hb_buffer_get_direction (hb_buffer))) 2855 if (HB_DIRECTION_IS_BACKWARD (hb_buffer_get_direction (hb_buffer)))
2855 hb_buffer_reverse_clusters (hb_buffer); 2856 hb_buffer_reverse_clusters (hb_buffer);
2856 2857