diff options
| author | Jan Djärv | 2014-06-30 20:44:56 +0200 |
|---|---|---|
| committer | Jan Djärv | 2014-06-30 20:44:56 +0200 |
| commit | 98bfa4f1e61907686e3d59453e1e3d03f5411638 (patch) | |
| tree | 904dbd22f50b1d994f622a531d33c36dc2630629 /src | |
| parent | 0224bf74b28fea8cc64e80390b0210e3909dd81b (diff) | |
| download | emacs-98bfa4f1e61907686e3d59453e1e3d03f5411638.tar.gz emacs-98bfa4f1e61907686e3d59453e1e3d03f5411638.zip | |
Fix use of deallocated memory.
* nsterm.h (EmacsScroller): Remove dealloc.
* nsterm.m (judge): EmacsScroller: Move dealloc code here.
(dealloc): Remove for EmacsScroller.
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 7 | ||||
| -rw-r--r-- | src/nsterm.h | 1 | ||||
| -rw-r--r-- | src/nsterm.m | 12 |
3 files changed, 10 insertions, 10 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index ad34152d1a3..17dbd106df3 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,10 @@ | |||
| 1 | 2014-06-30 Jan Djärv <jan.h.d@swipnet.se> | ||
| 2 | |||
| 3 | * nsterm.m (judge): EmacsScroller: Move dealloc code here. | ||
| 4 | (dealloc): Remove for EmacsScroller. | ||
| 5 | |||
| 6 | * nsterm.h (EmacsScroller): Remove dealloc. | ||
| 7 | |||
| 1 | 2014-06-30 Eli Zaretskii <eliz@gnu.org> | 8 | 2014-06-30 Eli Zaretskii <eliz@gnu.org> |
| 2 | 9 | ||
| 3 | * coding.c (MIN_CHARBUF_SIZE): Enlarge to 32. (Bug#17881) | 10 | * coding.c (MIN_CHARBUF_SIZE): Enlarge to 32. (Bug#17881) |
diff --git a/src/nsterm.h b/src/nsterm.h index e77aca3d50d..2619b710073 100644 --- a/src/nsterm.h +++ b/src/nsterm.h | |||
| @@ -412,7 +412,6 @@ typedef float EmacsCGFloat; | |||
| 412 | 412 | ||
| 413 | - initFrame: (NSRect )r window: (Lisp_Object)win; | 413 | - initFrame: (NSRect )r window: (Lisp_Object)win; |
| 414 | - (void)setFrame: (NSRect)r; | 414 | - (void)setFrame: (NSRect)r; |
| 415 | - (void)dealloc; | ||
| 416 | 415 | ||
| 417 | - setPosition: (int) position portion: (int) portion whole: (int) whole; | 416 | - setPosition: (int) position portion: (int) portion whole: (int) whole; |
| 418 | - (int) checkSamePosition: (int)position portion: (int)portion | 417 | - (int) checkSamePosition: (int)position portion: (int)portion |
diff --git a/src/nsterm.m b/src/nsterm.m index 69738ba924a..f2eeeda93bf 100644 --- a/src/nsterm.m +++ b/src/nsterm.m | |||
| @@ -7144,15 +7144,6 @@ if (cols > 0 && rows > 0) | |||
| 7144 | } | 7144 | } |
| 7145 | 7145 | ||
| 7146 | 7146 | ||
| 7147 | - (void)dealloc | ||
| 7148 | { | ||
| 7149 | NSTRACE (EmacsScroller_dealloc); | ||
| 7150 | if (!NILP (win)) | ||
| 7151 | wset_vertical_scroll_bar (XWINDOW (win), Qnil); | ||
| 7152 | [super dealloc]; | ||
| 7153 | } | ||
| 7154 | |||
| 7155 | |||
| 7156 | - condemn | 7147 | - condemn |
| 7157 | { | 7148 | { |
| 7158 | NSTRACE (condemn); | 7149 | NSTRACE (condemn); |
| @@ -7180,6 +7171,9 @@ if (cols > 0 && rows > 0) | |||
| 7180 | view = (EmacsView *)FRAME_NS_VIEW (frame); | 7171 | view = (EmacsView *)FRAME_NS_VIEW (frame); |
| 7181 | if (view != nil) | 7172 | if (view != nil) |
| 7182 | view->scrollbarsNeedingUpdate++; | 7173 | view->scrollbarsNeedingUpdate++; |
| 7174 | if (!NILP (win)) | ||
| 7175 | wset_vertical_scroll_bar (XWINDOW (win), Qnil); | ||
| 7176 | win = Qnil; | ||
| 7183 | [self removeFromSuperview]; | 7177 | [self removeFromSuperview]; |
| 7184 | [self release]; | 7178 | [self release]; |
| 7185 | unblock_input (); | 7179 | unblock_input (); |