diff options
| author | Paul Eggert | 2011-06-12 23:49:00 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-06-12 23:49:00 -0700 |
| commit | 96f53c6c3d6d31bc81187b5a5fdb3ec942cd6f51 (patch) | |
| tree | 739d32600e433069b546595b927a1adebdedde18 /src | |
| parent | 83c77d31ace0a54f6e0c0c384648f172f837c27b (diff) | |
| download | emacs-96f53c6c3d6d31bc81187b5a5fdb3ec942cd6f51.tar.gz emacs-96f53c6c3d6d31bc81187b5a5fdb3ec942cd6f51.zip | |
* sound.c (Fplay_sound_internal): Remove cast to unsigned long.
It's more likely to cause problems (due to unsigned overflow)
than to cure them.
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 4 | ||||
| -rw-r--r-- | src/sound.c | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 6562df06471..686c728f0a3 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,9 @@ | |||
| 1 | 2011-06-13 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-06-13 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | * sound.c (Fplay_sound_internal): Remove cast to unsigned long. | ||
| 4 | It's more likely to cause problems (due to unsigned overflow) | ||
| 5 | than to cure them. | ||
| 6 | |||
| 3 | * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts. | 7 | * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts. |
| 4 | 8 | ||
| 5 | * unexelf.c (unexec): Don't assume BSS addr fits in unsigned. | 9 | * unexelf.c (unexec): Don't assume BSS addr fits in unsigned. |
diff --git a/src/sound.c b/src/sound.c index 794c8e64e54..0e71e66352e 100644 --- a/src/sound.c +++ b/src/sound.c | |||
| @@ -1447,7 +1447,7 @@ Internal use only, use `play-sound' instead. */) | |||
| 1447 | } | 1447 | } |
| 1448 | else if (FLOATP (attrs[SOUND_VOLUME])) | 1448 | else if (FLOATP (attrs[SOUND_VOLUME])) |
| 1449 | { | 1449 | { |
| 1450 | ui_volume_tmp = (unsigned long) XFLOAT_DATA (attrs[SOUND_VOLUME]) * 100; | 1450 | ui_volume_tmp = XFLOAT_DATA (attrs[SOUND_VOLUME]) * 100; |
| 1451 | } | 1451 | } |
| 1452 | /* | 1452 | /* |
| 1453 | Based on some experiments I have conducted, a value of 100 or less | 1453 | Based on some experiments I have conducted, a value of 100 or less |