aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPaul Eggert2011-03-14 16:43:16 -0700
committerPaul Eggert2011-03-14 16:43:16 -0700
commit8f54f30aec0b3278cc1e370445ae2b3e5a115a46 (patch)
treebe33b4924c623fc332b46aa371d94888b0b79ca4 /src
parentc3bd59b510ddf8a9188a7dcd46b0a01a9b3f6172 (diff)
downloademacs-8f54f30aec0b3278cc1e370445ae2b3e5a115a46.tar.gz
emacs-8f54f30aec0b3278cc1e370445ae2b3e5a115a46.zip
* buffer.c: (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
(report_overlay_modification): Rename locals to avoid shadowing.
Diffstat (limited to 'src')
-rw-r--r--src/ChangeLog2
-rw-r--r--src/buffer.c86
2 files changed, 45 insertions, 43 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index 9bdfb18239f..2c0e951c8df 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,6 +1,8 @@
12011-03-14 Paul Eggert <eggert@cs.ucla.edu> 12011-03-14 Paul Eggert <eggert@cs.ucla.edu>
2 2
3 * buffer.c (switch_to_buffer_1): Now static. 3 * buffer.c (switch_to_buffer_1): Now static.
4 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5 (report_overlay_modification): Rename locals to avoid shadowing.
4 6
5 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing. 7 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6 Fix pointer signedness issue. 8 Fix pointer signedness issue.
diff --git a/src/buffer.c b/src/buffer.c
index 68253a261c4..99b4650bb60 100644
--- a/src/buffer.c
+++ b/src/buffer.c
@@ -1464,9 +1464,9 @@ with SIGHUP. */)
1464 don't re-kill them. */ 1464 don't re-kill them. */
1465 if (other->base_buffer == b && !NILP (BVAR (other, name))) 1465 if (other->base_buffer == b && !NILP (BVAR (other, name)))
1466 { 1466 {
1467 Lisp_Object buffer; 1467 Lisp_Object buf;
1468 XSETBUFFER (buffer, other); 1468 XSETBUFFER (buf, other);
1469 Fkill_buffer (buffer); 1469 Fkill_buffer (buf);
1470 } 1470 }
1471 1471
1472 UNGCPRO; 1472 UNGCPRO;
@@ -1527,9 +1527,9 @@ with SIGHUP. */)
1527 && BUF_SAVE_MODIFF (b) < BUF_MODIFF (b) 1527 && BUF_SAVE_MODIFF (b) < BUF_MODIFF (b)
1528 && NILP (Fsymbol_value (intern ("auto-save-visited-file-name")))) 1528 && NILP (Fsymbol_value (intern ("auto-save-visited-file-name"))))
1529 { 1529 {
1530 Lisp_Object tem; 1530 Lisp_Object delete;
1531 tem = Fsymbol_value (intern ("delete-auto-save-files")); 1531 delete = Fsymbol_value (intern ("delete-auto-save-files"));
1532 if (! NILP (tem)) 1532 if (! NILP (delete))
1533 internal_delete_file (BVAR (b, auto_save_file_name)); 1533 internal_delete_file (BVAR (b, auto_save_file_name));
1534 } 1534 }
1535 1535
@@ -1601,19 +1601,19 @@ with SIGHUP. */)
1601void 1601void
1602record_buffer (Lisp_Object buf) 1602record_buffer (Lisp_Object buf)
1603{ 1603{
1604 register Lisp_Object link, prev; 1604 register Lisp_Object list, prev;
1605 Lisp_Object frame; 1605 Lisp_Object frame;
1606 frame = selected_frame; 1606 frame = selected_frame;
1607 1607
1608 prev = Qnil; 1608 prev = Qnil;
1609 for (link = Vbuffer_alist; CONSP (link); link = XCDR (link)) 1609 for (list = Vbuffer_alist; CONSP (list); list = XCDR (list))
1610 { 1610 {
1611 if (EQ (XCDR (XCAR (link)), buf)) 1611 if (EQ (XCDR (XCAR (list)), buf))
1612 break; 1612 break;
1613 prev = link; 1613 prev = list;
1614 } 1614 }
1615 1615
1616 /* Effectively do Vbuffer_alist = Fdelq (link, Vbuffer_alist); 1616 /* Effectively do Vbuffer_alist = Fdelq (list, Vbuffer_alist);
1617 we cannot use Fdelq itself here because it allows quitting. */ 1617 we cannot use Fdelq itself here because it allows quitting. */
1618 1618
1619 if (NILP (prev)) 1619 if (NILP (prev))
@@ -1621,40 +1621,40 @@ record_buffer (Lisp_Object buf)
1621 else 1621 else
1622 XSETCDR (prev, XCDR (XCDR (prev))); 1622 XSETCDR (prev, XCDR (XCDR (prev)));
1623 1623
1624 XSETCDR (link, Vbuffer_alist); 1624 XSETCDR (list, Vbuffer_alist);
1625 Vbuffer_alist = link; 1625 Vbuffer_alist = list;
1626 1626
1627 /* Effectively do a delq on buried_buffer_list. */ 1627 /* Effectively do a delq on buried_buffer_list. */
1628 1628
1629 prev = Qnil; 1629 prev = Qnil;
1630 for (link = XFRAME (frame)->buried_buffer_list; CONSP (link); 1630 for (list = XFRAME (frame)->buried_buffer_list; CONSP (list);
1631 link = XCDR (link)) 1631 list = XCDR (list))
1632 { 1632 {
1633 if (EQ (XCAR (link), buf)) 1633 if (EQ (XCAR (list), buf))
1634 { 1634 {
1635 if (NILP (prev)) 1635 if (NILP (prev))
1636 XFRAME (frame)->buried_buffer_list = XCDR (link); 1636 XFRAME (frame)->buried_buffer_list = XCDR (list);
1637 else 1637 else
1638 XSETCDR (prev, XCDR (XCDR (prev))); 1638 XSETCDR (prev, XCDR (XCDR (prev)));
1639 break; 1639 break;
1640 } 1640 }
1641 prev = link; 1641 prev = list;
1642 } 1642 }
1643 1643
1644 /* Now move this buffer to the front of frame_buffer_list also. */ 1644 /* Now move this buffer to the front of frame_buffer_list also. */
1645 1645
1646 prev = Qnil; 1646 prev = Qnil;
1647 for (link = frame_buffer_list (frame); CONSP (link); 1647 for (list = frame_buffer_list (frame); CONSP (list);
1648 link = XCDR (link)) 1648 list = XCDR (list))
1649 { 1649 {
1650 if (EQ (XCAR (link), buf)) 1650 if (EQ (XCAR (list), buf))
1651 break; 1651 break;
1652 prev = link; 1652 prev = list;
1653 } 1653 }
1654 1654
1655 /* Effectively do delq. */ 1655 /* Effectively do delq. */
1656 1656
1657 if (CONSP (link)) 1657 if (CONSP (list))
1658 { 1658 {
1659 if (NILP (prev)) 1659 if (NILP (prev))
1660 set_frame_buffer_list (frame, 1660 set_frame_buffer_list (frame,
@@ -1662,8 +1662,8 @@ record_buffer (Lisp_Object buf)
1662 else 1662 else
1663 XSETCDR (prev, XCDR (XCDR (prev))); 1663 XSETCDR (prev, XCDR (XCDR (prev)));
1664 1664
1665 XSETCDR (link, frame_buffer_list (frame)); 1665 XSETCDR (list, frame_buffer_list (frame));
1666 set_frame_buffer_list (frame, link); 1666 set_frame_buffer_list (frame, list);
1667 } 1667 }
1668 else 1668 else
1669 set_frame_buffer_list (frame, Fcons (buf, frame_buffer_list (frame))); 1669 set_frame_buffer_list (frame, Fcons (buf, frame_buffer_list (frame)));
@@ -1984,13 +1984,13 @@ its frame, iconify that frame. */)
1984 buffer is killed. */ 1984 buffer is killed. */
1985 if (!NILP (BVAR (XBUFFER (buffer), name))) 1985 if (!NILP (BVAR (XBUFFER (buffer), name)))
1986 { 1986 {
1987 Lisp_Object aelt, link; 1987 Lisp_Object aelt, list;
1988 1988
1989 aelt = Frassq (buffer, Vbuffer_alist); 1989 aelt = Frassq (buffer, Vbuffer_alist);
1990 link = Fmemq (aelt, Vbuffer_alist); 1990 list = Fmemq (aelt, Vbuffer_alist);
1991 Vbuffer_alist = Fdelq (aelt, Vbuffer_alist); 1991 Vbuffer_alist = Fdelq (aelt, Vbuffer_alist);
1992 XSETCDR (link, Qnil); 1992 XSETCDR (list, Qnil);
1993 Vbuffer_alist = nconc2 (Vbuffer_alist, link); 1993 Vbuffer_alist = nconc2 (Vbuffer_alist, list);
1994 1994
1995 XFRAME (selected_frame)->buffer_list 1995 XFRAME (selected_frame)->buffer_list
1996 = Fdelq (buffer, XFRAME (selected_frame)->buffer_list); 1996 = Fdelq (buffer, XFRAME (selected_frame)->buffer_list);
@@ -2335,12 +2335,12 @@ current buffer is cleared. */)
2335 && GPT_BYTE > 1 && GPT_BYTE < Z_BYTE 2335 && GPT_BYTE > 1 && GPT_BYTE < Z_BYTE
2336 && ! CHAR_HEAD_P (*(GAP_END_ADDR))) 2336 && ! CHAR_HEAD_P (*(GAP_END_ADDR)))
2337 { 2337 {
2338 unsigned char *p = GPT_ADDR - 1; 2338 unsigned char *q = GPT_ADDR - 1;
2339 2339
2340 while (! CHAR_HEAD_P (*p) && p > BEG_ADDR) p--; 2340 while (! CHAR_HEAD_P (*q) && q > BEG_ADDR) q--;
2341 if (LEADING_CODE_P (*p)) 2341 if (LEADING_CODE_P (*q))
2342 { 2342 {
2343 EMACS_INT new_gpt = GPT_BYTE - (GPT_ADDR - p); 2343 EMACS_INT new_gpt = GPT_BYTE - (GPT_ADDR - q);
2344 2344
2345 move_gap_both (new_gpt, new_gpt); 2345 move_gap_both (new_gpt, new_gpt);
2346 } 2346 }
@@ -2424,14 +2424,14 @@ current buffer is cleared. */)
2424 ZV = chars_in_text (BEG_ADDR, ZV_BYTE - BEG_BYTE) + BEG; 2424 ZV = chars_in_text (BEG_ADDR, ZV_BYTE - BEG_BYTE) + BEG;
2425 2425
2426 { 2426 {
2427 EMACS_INT pt_byte = advance_to_char_boundary (PT_BYTE); 2427 EMACS_INT byte = advance_to_char_boundary (PT_BYTE);
2428 EMACS_INT pt; 2428 EMACS_INT position;
2429 2429
2430 if (pt_byte > GPT_BYTE) 2430 if (byte > GPT_BYTE)
2431 pt = chars_in_text (GAP_END_ADDR, pt_byte - GPT_BYTE) + GPT; 2431 position = chars_in_text (GAP_END_ADDR, byte - GPT_BYTE) + GPT;
2432 else 2432 else
2433 pt = chars_in_text (BEG_ADDR, pt_byte - BEG_BYTE) + BEG; 2433 position = chars_in_text (BEG_ADDR, byte - BEG_BYTE) + BEG;
2434 TEMP_SET_PT_BOTH (pt, pt_byte); 2434 TEMP_SET_PT_BOTH (position, byte);
2435 } 2435 }
2436 2436
2437 tail = markers = BUF_MARKERS (current_buffer); 2437 tail = markers = BUF_MARKERS (current_buffer);
@@ -4322,10 +4322,10 @@ report_overlay_modification (Lisp_Object start, Lisp_Object end, int after,
4322 4322
4323 for (i = 0; i < size;) 4323 for (i = 0; i < size;)
4324 { 4324 {
4325 Lisp_Object prop, overlay; 4325 Lisp_Object prop_i, overlay_i;
4326 prop = copy[i++]; 4326 prop_i = copy[i++];
4327 overlay = copy[i++]; 4327 overlay_i = copy[i++];
4328 call_overlay_mod_hooks (prop, overlay, after, arg1, arg2, arg3); 4328 call_overlay_mod_hooks (prop_i, overlay_i, after, arg1, arg2, arg3);
4329 } 4329 }
4330 } 4330 }
4331 UNGCPRO; 4331 UNGCPRO;