Port --enable-gcc-warnings to GCC 8

* configure.ac: Do not use GCC 8’s new -Wcast-align flag.
* lib-src/ebrowse.c (xmalloc):
* lib-src/emacsclient.c (xmalloc, xstrdup):
* lib-src/etags.c (xmalloc):
* lib-src/make-docfile.c (xmalloc):
* lib-src/movemail.c (xmalloc):
* src/dispnew.c (new_glyph_pool):
* src/regex.c (xmalloc):
* src/term.c (tty_menu_create):
* src/tparam.h (tparam):
Use ATTRIBUTE_MALLOC.  Also see GCC bug 85562.
* lib-src/emacsclient.c (fail):
Do not dereference a null pointer.
* src/frame.c (delete_frame):
Add a decl with UNINIT to work around GCC bug 85563.
* src/menu.h (finish_menu_items):
Do not use attribute const.
* src/regex.c (analyze_first): Use FALLTHROUGH, not a comment.

6 files changed, 7 insertions, 7 deletions

diff --git a/src/dispnew.c b/src/dispnew.c
index 324c05ddc4c..b854d179d51 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -1280,7 +1280,7 @@ row_equal_p (struct glyph_row *a, struct glyph_row *b, bool mouse_face_p)
    with zeros.  If GLYPH_DEBUG and ENABLE_CHECKING are in effect, the global
    variable glyph_pool_count is incremented for each pool allocated.  */
 
-static struct glyph_pool *
+static struct glyph_pool * ATTRIBUTE_MALLOC
 new_glyph_pool (void)
 {
   struct glyph_pool *result = xzalloc (sizeof *result);
diff --git a/src/frame.c b/src/frame.c
index 86caa32615d..da82621b8a0 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -1937,6 +1937,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
   if (f == sf)
     {
       Lisp_Object tail;
+      Lisp_Object frame1 UNINIT;  /* This line works around GCC bug 85563.  */
       eassume (CONSP (Vframe_list));
 
       /* Look for another visible frame on the same terminal.
diff --git a/src/menu.h b/src/menu.h
index 104f6dc81d2..fa32a86d1c8 100644
--- a/src/menu.h
+++ b/src/menu.h
@@ -30,7 +30,7 @@ enum {
 };
 
 extern void init_menu_items (void);
-extern void finish_menu_items (void) ATTRIBUTE_CONST;
+extern void finish_menu_items (void);
 extern void discard_menu_items (void);
 extern void save_menu_items (void);
 extern bool parse_single_submenu (Lisp_Object, Lisp_Object, Lisp_Object);
diff --git a/src/regex.c b/src/regex.c
index a4e6441cce3..85e63feea10 100644
--- a/src/regex.c
+++ b/src/regex.c
@@ -212,7 +212,7 @@
 
 /* When used in Emacs's lib-src, we need xmalloc and xrealloc. */
 
-static void *
+static ATTRIBUTE_MALLOC void *
 xmalloc (size_t size)
 {
   void *val = malloc (size);
@@ -4033,8 +4033,7 @@ analyze_first (re_char *p, re_char *pend, char *fastmap,
             };
           /* Keep `p1' to allow the `on_failure_jump' we are jumping to
              to jump back to "just after here".  */
-          /* Fallthrough */
-
+          FALLTHROUGH;
         case on_failure_jump:
         case on_failure_keep_string_jump:
         case on_failure_jump_nastyloop:
diff --git a/src/term.c b/src/term.c
index 8be5fb319b0..08d483f4fa0 100644
--- a/src/term.c
+++ b/src/term.c
@@ -2721,7 +2721,7 @@ typedef struct tty_menu_struct
 
 /* Create a brand new menu structure.  */
 
-static tty_menu *
+static tty_menu * ATTRIBUTE_MALLOC
 tty_menu_create (void)
 {
   return xzalloc (sizeof *tty_menu_create ());
diff --git a/src/tparam.h b/src/tparam.h
index 3a3cb52c178..79c55b94d2a 100644
--- a/src/tparam.h
+++ b/src/tparam.h
@@ -30,7 +30,7 @@ int tgetnum (const char *);
 char *tgetstr (const char *, char **);
 char *tgoto (const char *, int, int);
 
-char *tparam (const char *, char *, int, int, int, int, int);
+char *tparam (const char *, char *, int, int, int, int, int) ATTRIBUTE_MALLOC;
 
 extern char PC;
 extern char *BC;