upstream

5 files changed, 37 insertions, 18 deletions

diff --git a/src/ChangeLog b/src/ChangeLog
index 5c0e26760c7..04a6c353619 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,20 @@
+2013-04-16  Juanma Barranquero  <lekktu@gmail.com>
+
+        * minibuf.c (Ftest_completion): Silence compiler warning.
+
+2013-04-15  Eli Zaretskii  <eliz@gnu.org>
+
+        * w32fns.c (w32_wnd_proc): Add more assertions to investigate
+        bug#14062.
+
+        * frame.h (WINDOW_FRAME): Protect macro and its argument with
+        parentheses.
+
+        * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
+        (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
+        (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
+        parentheses where appropriate.
+
 2013-04-14  Paul Eggert  <eggert@cs.ucla.edu>
 
         * keyboard.c (timer_start_idle): Remove no-longer-used local.
@@ -1244,7 +1261,7 @@
         (Fcommand_execute): Remove, replace by an Elisp implementation.
         (syms_of_keyboard): Adjust accordingly.
 
-2013-02-19  Daniel Colascione <dancol@dancol.org>
+2013-02-19  Daniel Colascione  <dancol@dancol.org>
 
         * sheap.c (report_sheap_usage): Use message, not message1, so
         that we don't try to create a buffer while we're in the middle
@@ -12068,9 +12085,9 @@
         to denote vector blocks.  Adjust users (live_vector_p,
         mark_maybe_pointer, valid_lisp_object_p) accordingly.
         (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
-        (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
-        (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
-        (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
+        (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES)
+        (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX)
+        (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST)
         (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
         (roundup_size): New constant.
         (struct vector_block): New data type.
diff --git a/src/dispextern.h b/src/dispextern.h
index 0c35aff8285..70a5ba27b8d 100644
--- a/src/dispextern.h
+++ b/src/dispextern.h
@@ -1394,7 +1394,7 @@ struct glyph_string
       ? current_mode_line_height                                \
       : (MATRIX_MODE_LINE_HEIGHT ((W)->current_matrix)          \
          ? MATRIX_MODE_LINE_HEIGHT ((W)->current_matrix)        \
-         : estimate_mode_line_height (XFRAME (W->frame),        \
+         : estimate_mode_line_height (XFRAME ((W)->frame),      \
                                       CURRENT_MODE_LINE_FACE_ID (W))))
 
 /* Return the current height of the header line of window W.  If not
@@ -1407,7 +1407,7 @@ struct glyph_string
        ? current_header_line_height                             \
        : (MATRIX_HEADER_LINE_HEIGHT ((W)->current_matrix)       \
           ? MATRIX_HEADER_LINE_HEIGHT ((W)->current_matrix)     \
-          : estimate_mode_line_height (XFRAME (W->frame),\
+          : estimate_mode_line_height (XFRAME ((W)->frame),     \
                                        HEADER_LINE_FACE_ID)))
 
 /* Return the height of the desired mode line of window W.  */
@@ -1426,20 +1426,20 @@ struct glyph_string
   (!MINI_WINDOW_P ((W))                                         \
    && !(W)->pseudo_window_p                                     \
    && FRAME_WANTS_MODELINE_P (XFRAME (WINDOW_FRAME ((W))))      \
-   && BUFFERP (W->contents)                                     \
-   && !NILP (BVAR (XBUFFER (W->contents), mode_line_format))    \
+   && BUFFERP ((W)->contents)                                   \
+   && !NILP (BVAR (XBUFFER ((W)->contents), mode_line_format))  \
    && WINDOW_TOTAL_LINES (W) > 1)
 
 /* Value is true if window W wants a header line.  */
 
-#define WINDOW_WANTS_HEADER_LINE_P(W)                           \
-  (!MINI_WINDOW_P ((W))                                         \
-   && !(W)->pseudo_window_p                                     \
-   && FRAME_WANTS_MODELINE_P (XFRAME (WINDOW_FRAME ((W))))      \
-   && BUFFERP (W->contents)                                     \
-   && !NILP (BVAR (XBUFFER (W->contents), header_line_format))  \
-   && WINDOW_TOTAL_LINES (W) > 1                                \
-   + !NILP (BVAR (XBUFFER (W->contents), mode_line_format)))
+#define WINDOW_WANTS_HEADER_LINE_P(W)                                   \
+  (!MINI_WINDOW_P ((W))                                                 \
+   && !(W)->pseudo_window_p                                             \
+   && FRAME_WANTS_MODELINE_P (XFRAME (WINDOW_FRAME ((W))))              \
+   && BUFFERP ((W)->contents)                                           \
+   && !NILP (BVAR (XBUFFER ((W)->contents), header_line_format))        \
+   && WINDOW_TOTAL_LINES (W) > 1                                        \
+   + !NILP (BVAR (XBUFFER ((W)->contents), mode_line_format)))
 
 /* Return proper value to be used as baseline offset of font that has
    ASCENT and DESCENT to draw characters by the font at the vertical
diff --git a/src/frame.h b/src/frame.h
index b69f19b7ef8..fc0a1dc828b 100644
--- a/src/frame.h
+++ b/src/frame.h
@@ -598,7 +598,7 @@ typedef struct frame *FRAME_PTR;
 #define XSETFRAME(a, b) (XSETPSEUDOVECTOR (a, b, PVEC_FRAME))
 
 /* Given a window, return its frame as a Lisp_Object.  */
-#define WINDOW_FRAME(w) w->frame
+#define WINDOW_FRAME(w) ((w)->frame)
 
 /* Test a frame for particular kinds of display methods.  */
 #define FRAME_INITIAL_P(f) ((f)->output_method == output_initial)
diff --git a/src/minibuf.c b/src/minibuf.c
index 4cc1f8d435a..b96d27e0742 100644
--- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -1799,8 +1799,8 @@ the values STRING, PREDICATE and `lambda'.  */)
   else if (HASH_TABLE_P (collection))
     {
       struct Lisp_Hash_Table *h = XHASH_TABLE (collection);
-      i = hash_lookup (h, string, NULL);
       Lisp_Object key = Qnil;
+      i = hash_lookup (h, string, NULL);
       if (i >= 0)
         tem = HASH_KEY (h, i);
       else
diff --git a/src/w32fns.c b/src/w32fns.c
index 5d3a78f8b95..de52ff144e3 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -3123,6 +3123,8 @@ w32_wnd_proc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
 
 #ifdef ENABLE_CHECKING
           /* Temporary code to catch crashes in computing form.rcArea.top.  */
+          eassert (FRAMEP (w->frame));
+          eassert (BUFFERP (w->contents));
           {
             int wmbp = WINDOW_MENU_BAR_P (w);
             int wtbp = WINDOW_TOOL_BAR_P (w);