diff options
| author | Paul Eggert | 2013-11-05 14:41:57 -0800 |
|---|---|---|
| committer | Paul Eggert | 2013-11-05 14:41:57 -0800 |
| commit | 7544a9d393b426ffd99831ef93202b5bda444bfb (patch) | |
| tree | db4b397cbbeb83596b3458c914735eabf0d31697 /src | |
| parent | c923b188f48bb342b30870eda89ea8d79376b05d (diff) | |
| download | emacs-7544a9d393b426ffd99831ef93202b5bda444bfb.tar.gz emacs-7544a9d393b426ffd99831ef93202b5bda444bfb.zip | |
* keyboard.c (Fcommand_error_default_function): Fix pointer signedness
glitch. Eliminate 'sz' prefix; Hungarian notation is not helpful here.
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 5 | ||||
| -rw-r--r-- | src/keyboard.c | 6 |
2 files changed, 7 insertions, 4 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index fec1a12de8a..740a8f93505 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,8 @@ | |||
| 1 | 2013-11-05 Paul Eggert <eggert@cs.ucla.edu> | ||
| 2 | |||
| 3 | * keyboard.c (Fcommand_error_default_function): Fix pointer signedness | ||
| 4 | glitch. Eliminate 'sz' prefix; Hungarian notation is not helpful here. | ||
| 5 | |||
| 1 | 2013-11-05 Stefan Monnier <monnier@iro.umontreal.ca> | 6 | 2013-11-05 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2 | 7 | ||
| 3 | * keyboard.c (Fcommand_error_default_function): Rename from | 8 | * keyboard.c (Fcommand_error_default_function): Rename from |
diff --git a/src/keyboard.c b/src/keyboard.c index 574780e2004..9dba631986b 100644 --- a/src/keyboard.c +++ b/src/keyboard.c | |||
| @@ -1088,10 +1088,8 @@ Default value of `command-error-function'. */) | |||
| 1088 | (Lisp_Object data, Lisp_Object context, Lisp_Object signal) | 1088 | (Lisp_Object data, Lisp_Object context, Lisp_Object signal) |
| 1089 | { | 1089 | { |
| 1090 | struct frame *sf = SELECTED_FRAME (); | 1090 | struct frame *sf = SELECTED_FRAME (); |
| 1091 | const char *sz_context; | ||
| 1092 | 1091 | ||
| 1093 | CHECK_STRING (context); | 1092 | CHECK_STRING (context); |
| 1094 | sz_context = XSTRING (context)->data; | ||
| 1095 | 1093 | ||
| 1096 | /* If the window system or terminal frame hasn't been initialized | 1094 | /* If the window system or terminal frame hasn't been initialized |
| 1097 | yet, or we're not interactive, write the message to stderr and exit. */ | 1095 | yet, or we're not interactive, write the message to stderr and exit. */ |
| @@ -1110,7 +1108,7 @@ Default value of `command-error-function'. */) | |||
| 1110 | || noninteractive) | 1108 | || noninteractive) |
| 1111 | { | 1109 | { |
| 1112 | print_error_message (data, Qexternal_debugging_output, | 1110 | print_error_message (data, Qexternal_debugging_output, |
| 1113 | sz_context, signal); | 1111 | SSDATA (context), signal); |
| 1114 | Fterpri (Qexternal_debugging_output); | 1112 | Fterpri (Qexternal_debugging_output); |
| 1115 | Fkill_emacs (make_number (-1)); | 1113 | Fkill_emacs (make_number (-1)); |
| 1116 | } | 1114 | } |
| @@ -1121,7 +1119,7 @@ Default value of `command-error-function'. */) | |||
| 1121 | message_log_maybe_newline (); | 1119 | message_log_maybe_newline (); |
| 1122 | bitch_at_user (); | 1120 | bitch_at_user (); |
| 1123 | 1121 | ||
| 1124 | print_error_message (data, Qt, sz_context, signal); | 1122 | print_error_message (data, Qt, SSDATA (context), signal); |
| 1125 | } | 1123 | } |
| 1126 | return Qnil; | 1124 | return Qnil; |
| 1127 | } | 1125 | } |