aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPaul Eggert2011-07-08 23:28:40 -0700
committerPaul Eggert2011-07-08 23:28:40 -0700
commit5a9c433211c15e2538086321057ea04da8d6f9b9 (patch)
tree9ec0261e9364c394ea1657cd79e26ccd804f3d6f /src
parent2d43b8c9716af32033eb778d3fabb1a47dd44535 (diff)
downloademacs-5a9c433211c15e2538086321057ea04da8d6f9b9.tar.gz
emacs-5a9c433211c15e2538086321057ea04da8d6f9b9.zip
Fix minor problems found by static checking.
* chartab.c (char_table_set_range, map_sub_char_table) (uniprop_table_uncompress): Remove unused locals. (uniprop_table): Now static. * composite.c (_work_char): Remove unused static var. * gtkutil.c (qttip_cb): Remove stray no-effect statement.
Diffstat (limited to 'src')
-rw-r--r--src/ChangeLog7
-rw-r--r--src/chartab.c8
-rw-r--r--src/composite.c1
-rw-r--r--src/gtkutil.c1
4 files changed, 8 insertions, 9 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index 3cf90d10289..a71a48f3a81 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,12 @@
12011-07-08 Paul Eggert <eggert@cs.ucla.edu> 12011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2 2
3 Fix minor problems found by static checking.
4 * chartab.c (char_table_set_range, map_sub_char_table)
5 (uniprop_table_uncompress): Remove unused locals.
6 (uniprop_table): Now static.
7 * composite.c (_work_char): Remove unused static var.
8 * gtkutil.c (qttip_cb): Remove stray no-effect statement.
9
3 Use pthread_sigmask, not sigprocmask (Bug#9010). 10 Use pthread_sigmask, not sigprocmask (Bug#9010).
4 sigprocmask is portable only for single-threaded applications, and 11 sigprocmask is portable only for single-threaded applications, and
5 Emacs can be multi-threaded when it uses GTK. 12 Emacs can be multi-threaded when it uses GTK.
diff --git a/src/chartab.c b/src/chartab.c
index e900a3ae71f..efe23eca83f 100644
--- a/src/chartab.c
+++ b/src/chartab.c
@@ -485,7 +485,6 @@ Lisp_Object
485char_table_set_range (Lisp_Object table, int from, int to, Lisp_Object val) 485char_table_set_range (Lisp_Object table, int from, int to, Lisp_Object val)
486{ 486{
487 struct Lisp_Char_Table *tbl = XCHAR_TABLE (table); 487 struct Lisp_Char_Table *tbl = XCHAR_TABLE (table);
488 Lisp_Object *contents = tbl->contents;
489 488
490 if (from == to) 489 if (from == to)
491 char_table_set (table, from, val); 490 char_table_set (table, from, val);
@@ -759,8 +758,6 @@ map_sub_char_table (void (*c_function) (Lisp_Object, Lisp_Object, Lisp_Object),
759 Lisp_Object function, Lisp_Object table, Lisp_Object arg, Lisp_Object val, 758 Lisp_Object function, Lisp_Object table, Lisp_Object arg, Lisp_Object val,
760 Lisp_Object range, Lisp_Object top) 759 Lisp_Object range, Lisp_Object top)
761{ 760{
762 /* Pointer to the elements of TABLE. */
763 Lisp_Object *contents;
764 /* Depth of TABLE. */ 761 /* Depth of TABLE. */
765 int depth; 762 int depth;
766 /* Minimum and maxinum characters covered by TABLE. */ 763 /* Minimum and maxinum characters covered by TABLE. */
@@ -777,14 +774,12 @@ map_sub_char_table (void (*c_function) (Lisp_Object, Lisp_Object, Lisp_Object),
777 struct Lisp_Sub_Char_Table *tbl = XSUB_CHAR_TABLE (table); 774 struct Lisp_Sub_Char_Table *tbl = XSUB_CHAR_TABLE (table);
778 775
779 depth = XINT (tbl->depth); 776 depth = XINT (tbl->depth);
780 contents = tbl->contents;
781 min_char = XINT (tbl->min_char); 777 min_char = XINT (tbl->min_char);
782 max_char = min_char + chartab_chars[depth - 1] - 1; 778 max_char = min_char + chartab_chars[depth - 1] - 1;
783 } 779 }
784 else 780 else
785 { 781 {
786 depth = 0; 782 depth = 0;
787 contents = XCHAR_TABLE (table)->contents;
788 min_char = 0; 783 min_char = 0;
789 max_char = MAX_CHAR; 784 max_char = MAX_CHAR;
790 } 785 }
@@ -1143,7 +1138,6 @@ uniprop_table_uncompress (Lisp_Object table, int idx)
1143 Lisp_Object sub = make_sub_char_table (3, min_char, Qnil); 1138 Lisp_Object sub = make_sub_char_table (3, min_char, Qnil);
1144 struct Lisp_Sub_Char_Table *subtbl = XSUB_CHAR_TABLE (sub); 1139 struct Lisp_Sub_Char_Table *subtbl = XSUB_CHAR_TABLE (sub);
1145 const unsigned char *p, *pend; 1140 const unsigned char *p, *pend;
1146 int i;
1147 1141
1148 XSUB_CHAR_TABLE (table)->contents[idx] = sub; 1142 XSUB_CHAR_TABLE (table)->contents[idx] = sub;
1149 p = SDATA (val), pend = p + SBYTES (val); 1143 p = SDATA (val), pend = p + SBYTES (val);
@@ -1316,7 +1310,7 @@ uniprop_get_encoder (Lisp_Object table)
1316 function may load a Lisp file and thus may cause 1310 function may load a Lisp file and thus may cause
1317 garbage-collection. */ 1311 garbage-collection. */
1318 1312
1319Lisp_Object 1313static Lisp_Object
1320uniprop_table (Lisp_Object prop) 1314uniprop_table (Lisp_Object prop)
1321{ 1315{
1322 Lisp_Object val, table, result; 1316 Lisp_Object val, table, result;
diff --git a/src/composite.c b/src/composite.c
index cf1e053f027..d402d5ad0c4 100644
--- a/src/composite.c
+++ b/src/composite.c
@@ -967,7 +967,6 @@ autocmp_chars (Lisp_Object rule, EMACS_INT charpos, EMACS_INT bytepos, EMACS_INT
967} 967}
968 968
969static Lisp_Object _work_val; 969static Lisp_Object _work_val;
970static int _work_char;
971 970
972/* 1 iff the character C is composable. Characters of general 971/* 1 iff the character C is composable. Characters of general
973 category Z? or C? are not composable except for ZWNJ and ZWJ. */ 972 category Z? or C? are not composable except for ZWNJ and ZWJ. */
diff --git a/src/gtkutil.c b/src/gtkutil.c
index dfc5b63f375..35b366222de 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -647,7 +647,6 @@ qttip_cb (GtkWidget *widget,
647 /* Change stupid Gtk+ default line wrapping. */ 647 /* Change stupid Gtk+ default line wrapping. */
648 p = gtk_widget_get_parent (x->ttip_lbl); 648 p = gtk_widget_get_parent (x->ttip_lbl);
649 list = gtk_container_get_children (GTK_CONTAINER (p)); 649 list = gtk_container_get_children (GTK_CONTAINER (p));
650 iter;
651 for (iter = list; iter; iter = g_list_next (iter)) 650 for (iter = list; iter; iter = g_list_next (iter))
652 { 651 {
653 GtkWidget *w = GTK_WIDGET (iter->data); 652 GtkWidget *w = GTK_WIDGET (iter->data);