aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPaul Eggert2011-06-09 12:03:59 -0700
committerPaul Eggert2011-06-09 12:03:59 -0700
commit55daad71c7427e6ce811fa70f2ccdaf630e235e1 (patch)
treeb99f7b49441ab620376c2f5e4dd3ed2da0130879 /src
parent41cb286c61f5b5b317bf4038ff0cd43dafd9a21b (diff)
downloademacs-55daad71c7427e6ce811fa70f2ccdaf630e235e1.tar.gz
emacs-55daad71c7427e6ce811fa70f2ccdaf630e235e1.zip
* buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
The cast incorrectly truncated 64-bit byte offsets to 32 bits, and isn't needed on 32-bit machines.
Diffstat (limited to 'src')
-rw-r--r--src/ChangeLog4
-rw-r--r--src/buffer.h4
2 files changed, 5 insertions, 3 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index f4de3d991d9..1222c04d091 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -5,7 +5,9 @@
5 5
6 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals. 6 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7 7
8 * buffer.h (PTR_BYTE_POS): Don't assume a byte count fits in 'unsigned'. 8 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10 isn't needed on 32-bit machines.
9 11
10 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int. 12 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
11 (advance_to_char_boundary): Return EMACS_INT, not int. 13 (advance_to_char_boundary): Return EMACS_INT, not int.
diff --git a/src/buffer.h b/src/buffer.h
index ba48a8105a2..725e4edb638 100644
--- a/src/buffer.h
+++ b/src/buffer.h
@@ -337,7 +337,7 @@ while (0)
337 337
338#define PTR_BYTE_POS(ptr) \ 338#define PTR_BYTE_POS(ptr) \
339((ptr) - (current_buffer)->text->beg \ 339((ptr) - (current_buffer)->text->beg \
340 - (ptr - (current_buffer)->text->beg <= (size_t) (GPT_BYTE - BEG_BYTE) ? 0 : GAP_SIZE) \ 340 - (ptr - (current_buffer)->text->beg <= GPT_BYTE - BEG_BYTE ? 0 : GAP_SIZE) \
341 + BEG_BYTE) 341 + BEG_BYTE)
342 342
343/* Return character at byte position POS. */ 343/* Return character at byte position POS. */
@@ -396,7 +396,7 @@ extern unsigned char *_fetch_multibyte_char_p;
396 396
397#define BUF_PTR_BYTE_POS(buf, ptr) \ 397#define BUF_PTR_BYTE_POS(buf, ptr) \
398((ptr) - (buf)->text->beg \ 398((ptr) - (buf)->text->beg \
399 - (ptr - (buf)->text->beg <= (unsigned) (BUF_GPT_BYTE ((buf)) - BEG_BYTE)\ 399 - (ptr - (buf)->text->beg <= BUF_GPT_BYTE (buf) - BEG_BYTE \
400 ? 0 : BUF_GAP_SIZE ((buf))) \ 400 ? 0 : BUF_GAP_SIZE ((buf))) \
401 + BEG_BYTE) 401 + BEG_BYTE)
402 402