aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJuanma Barranquero2009-10-26 10:04:37 +0000
committerJuanma Barranquero2009-10-26 10:04:37 +0000
commit522d013a5958f604179681172b2dfb8cb432809d (patch)
treeec0c7bee95e39c69f120650197d999f342aef921 /src
parent293c24f9ad59130eb8ae53b3adbd61b5fb634084 (diff)
downloademacs-522d013a5958f604179681172b2dfb8cb432809d.tar.gz
emacs-522d013a5958f604179681172b2dfb8cb432809d.zip
* window.c (grow_mini_window): Comment out "delta >= 0" assertion.
For delta < 0, skip check that only makes sense when the mini-window is going to be enlarged. (Bug#4534)
Diffstat (limited to 'src')
-rw-r--r--src/ChangeLog9
-rw-r--r--src/window.c7
2 files changed, 12 insertions, 4 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index cbfee8f3f07..60cbcef8ca7 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
12009-10-26 Juanma Barranquero <lekktu@gmail.com>
2
3 * window.c (grow_mini_window): Comment out "delta >= 0" assertion.
4 For delta < 0, skip check that only makes sense when the mini-window
5 is going to be enlarged. (Bug#4534)
6
12009-10-25 Chong Yidong <cyd@stupidchicken.com> 72009-10-25 Chong Yidong <cyd@stupidchicken.com>
2 8
3 * keyboard.c (read_char_x_menu_prompt): Don't demand a prompt 9 * keyboard.c (read_char_x_menu_prompt): Don't demand a prompt
@@ -20,8 +26,7 @@
20 * lisp.h (FIXNUM_OVERFLOW_P): Fix last change to handle unsigned 26 * lisp.h (FIXNUM_OVERFLOW_P): Fix last change to handle unsigned
21 types again. 27 types again.
22 28
23 * sysdep.c (procfs_ttyname): Fix sprintf format to match argument 29 * sysdep.c (procfs_ttyname): Fix sprintf format to match argument type.
24 type.
25 (system_process_attributes): Likewise. 30 (system_process_attributes): Likewise.
26 31
272009-10-24 Dan Nicolaescu <dann@ics.uci.edu> 322009-10-24 Dan Nicolaescu <dann@ics.uci.edu>
diff --git a/src/window.c b/src/window.c
index 2c178a65d2a..26165e701b1 100644
--- a/src/window.c
+++ b/src/window.c
@@ -4648,12 +4648,15 @@ grow_mini_window (w, delta)
4648 struct window *root; 4648 struct window *root;
4649 4649
4650 xassert (MINI_WINDOW_P (w)); 4650 xassert (MINI_WINDOW_P (w));
4651 xassert (delta >= 0); 4651 /* Commenting out the following assertion goes against the stated interface
4652 of the function, but it currently does not seem to do anything useful.
4653 See discussion of this issue in the thread for bug#4534.
4654 xassert (delta >= 0); */
4652 4655
4653 /* Compute how much we can enlarge the mini-window without deleting 4656 /* Compute how much we can enlarge the mini-window without deleting
4654 other windows. */ 4657 other windows. */
4655 root = XWINDOW (FRAME_ROOT_WINDOW (f)); 4658 root = XWINDOW (FRAME_ROOT_WINDOW (f));
4656 if (delta) 4659 if (delta > 0)
4657 { 4660 {
4658 int min_height = window_min_size (root, 0, 0, 0, 0); 4661 int min_height = window_min_size (root, 0, 0, 0, 0);
4659 if (XFASTINT (root->total_lines) - delta < min_height) 4662 if (XFASTINT (root->total_lines) - delta < min_height)