Do not read uninitialized memory in conv_sockaddr_to_lisp

2 files changed, 22 insertions, 4 deletions

diff --git a/src/ChangeLog b/src/ChangeLog
index 59e39614af8..94b48f64de3 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2014-03-22  Daniel Colascione  <dancol@dancol.org>
+
+        * process.c (conv_sockaddr_to_lisp): When extracting the string
+        names of AF_LOCAL sockets, stop before reading uninitialized
+        memory.
+
 2014-03-21  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
 
         Fix regression introduced by patch for Bug#10500.
diff --git a/src/process.c b/src/process.c
index 187627dd85a..10a2984a053 100644
--- a/src/process.c
+++ b/src/process.c
@@ -2010,10 +2010,22 @@ conv_sockaddr_to_lisp (struct sockaddr *sa, int len)
     case AF_LOCAL:
       {
         struct sockaddr_un *sockun = (struct sockaddr_un *) sa;
-        for (i = 0; i < sizeof (sockun->sun_path); i++)
-          if (sockun->sun_path[i] == 0)
-            break;
-        return make_unibyte_string (sockun->sun_path, i);
+        ptrdiff_t name_length = len - offsetof (struct sockaddr_un, sun_path);
+        /* If the first byte is NUL, the name is a Linux abstract
+           socket name, and the name can contain embedded NULs.  If
+           it's not, we have a NUL-terminated string.  Be careful not
+           to walk past the end of the object looking for the name
+           terminator, however.  */
+        if (name_length > 0 && sockun->sun_path[0] != '\0')
+          {
+            const char* terminator =
+              memchr (sockun->sun_path, '\0', name_length);
+
+            if (terminator)
+              name_length = terminator - (const char*) sockun->sun_path;
+          }
+
+        return make_unibyte_string (sockun->sun_path, name_length);
       }
 #endif
     default: