aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPhilipp Stephani2017-07-02 13:15:52 +0200
committerPhilipp Stephani2017-07-02 13:15:52 +0200
commit3bab927884c4b795f8545b632328b5d3b632eed3 (patch)
tree5920a77491236dda44e7eb8d20aaeec227a59c54 /src
parent95343daa79efecdb32302fa3420a7b838d66d6bb (diff)
downloademacs-3bab927884c4b795f8545b632328b5d3b632eed3.tar.gz
emacs-3bab927884c4b795f8545b632328b5d3b632eed3.zip
Remove FIXME comments about sentinel values
These FIXMEs can't be addressed because they would require breaking changes to the module API. Furthermore, other module functions don't return sentinel values as well, so users generally have to call non_local_exit_check anyway. * src/emacs-module.c (module_set_user_ptr) (module_set_user_finalizer, module_vec_set, module_vec_size): Remove FIXME comments.
Diffstat (limited to 'src')
-rw-r--r--src/emacs-module.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/emacs-module.c b/src/emacs-module.c
index 9e072029cc1..7b1a402eeff 100644
--- a/src/emacs-module.c
+++ b/src/emacs-module.c
@@ -601,7 +601,6 @@ module_get_user_ptr (emacs_env *env, emacs_value uptr)
601static void 601static void
602module_set_user_ptr (emacs_env *env, emacs_value uptr, void *ptr) 602module_set_user_ptr (emacs_env *env, emacs_value uptr, void *ptr)
603{ 603{
604 /* FIXME: This function should return bool because it can fail. */
605 MODULE_FUNCTION_BEGIN (); 604 MODULE_FUNCTION_BEGIN ();
606 Lisp_Object lisp = value_to_lisp (uptr); 605 Lisp_Object lisp = value_to_lisp (uptr);
607 CHECK_USER_PTR (lisp); 606 CHECK_USER_PTR (lisp);
@@ -621,7 +620,6 @@ static void
621module_set_user_finalizer (emacs_env *env, emacs_value uptr, 620module_set_user_finalizer (emacs_env *env, emacs_value uptr,
622 emacs_finalizer_function fin) 621 emacs_finalizer_function fin)
623{ 622{
624 /* FIXME: This function should return bool because it can fail. */
625 MODULE_FUNCTION_BEGIN (); 623 MODULE_FUNCTION_BEGIN ();
626 Lisp_Object lisp = value_to_lisp (uptr); 624 Lisp_Object lisp = value_to_lisp (uptr);
627 CHECK_USER_PTR (lisp); 625 CHECK_USER_PTR (lisp);
@@ -640,7 +638,6 @@ check_vec_index (Lisp_Object lvec, ptrdiff_t i)
640static void 638static void
641module_vec_set (emacs_env *env, emacs_value vec, ptrdiff_t i, emacs_value val) 639module_vec_set (emacs_env *env, emacs_value vec, ptrdiff_t i, emacs_value val)
642{ 640{
643 /* FIXME: This function should return bool because it can fail. */
644 MODULE_FUNCTION_BEGIN (); 641 MODULE_FUNCTION_BEGIN ();
645 Lisp_Object lvec = value_to_lisp (vec); 642 Lisp_Object lvec = value_to_lisp (vec);
646 check_vec_index (lvec, i); 643 check_vec_index (lvec, i);
@@ -659,7 +656,6 @@ module_vec_get (emacs_env *env, emacs_value vec, ptrdiff_t i)
659static ptrdiff_t 656static ptrdiff_t
660module_vec_size (emacs_env *env, emacs_value vec) 657module_vec_size (emacs_env *env, emacs_value vec)
661{ 658{
662 /* FIXME: Return a sentinel value (e.g., -1) on error. */
663 MODULE_FUNCTION_BEGIN (0); 659 MODULE_FUNCTION_BEGIN (0);
664 Lisp_Object lvec = value_to_lisp (vec); 660 Lisp_Object lvec = value_to_lisp (vec);
665 CHECK_VECTOR (lvec); 661 CHECK_VECTOR (lvec);