diff options
| author | Philipp Stephani | 2017-07-02 13:15:52 +0200 |
|---|---|---|
| committer | Philipp Stephani | 2017-07-02 13:15:52 +0200 |
| commit | 3bab927884c4b795f8545b632328b5d3b632eed3 (patch) | |
| tree | 5920a77491236dda44e7eb8d20aaeec227a59c54 /src | |
| parent | 95343daa79efecdb32302fa3420a7b838d66d6bb (diff) | |
| download | emacs-3bab927884c4b795f8545b632328b5d3b632eed3.tar.gz emacs-3bab927884c4b795f8545b632328b5d3b632eed3.zip | |
Remove FIXME comments about sentinel values
These FIXMEs can't be addressed because they would require breaking
changes to the module API. Furthermore, other module functions don't
return sentinel values as well, so users generally have to call
non_local_exit_check anyway.
* src/emacs-module.c (module_set_user_ptr)
(module_set_user_finalizer, module_vec_set, module_vec_size): Remove
FIXME comments.
Diffstat (limited to 'src')
| -rw-r--r-- | src/emacs-module.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/emacs-module.c b/src/emacs-module.c index 9e072029cc1..7b1a402eeff 100644 --- a/src/emacs-module.c +++ b/src/emacs-module.c | |||
| @@ -601,7 +601,6 @@ module_get_user_ptr (emacs_env *env, emacs_value uptr) | |||
| 601 | static void | 601 | static void |
| 602 | module_set_user_ptr (emacs_env *env, emacs_value uptr, void *ptr) | 602 | module_set_user_ptr (emacs_env *env, emacs_value uptr, void *ptr) |
| 603 | { | 603 | { |
| 604 | /* FIXME: This function should return bool because it can fail. */ | ||
| 605 | MODULE_FUNCTION_BEGIN (); | 604 | MODULE_FUNCTION_BEGIN (); |
| 606 | Lisp_Object lisp = value_to_lisp (uptr); | 605 | Lisp_Object lisp = value_to_lisp (uptr); |
| 607 | CHECK_USER_PTR (lisp); | 606 | CHECK_USER_PTR (lisp); |
| @@ -621,7 +620,6 @@ static void | |||
| 621 | module_set_user_finalizer (emacs_env *env, emacs_value uptr, | 620 | module_set_user_finalizer (emacs_env *env, emacs_value uptr, |
| 622 | emacs_finalizer_function fin) | 621 | emacs_finalizer_function fin) |
| 623 | { | 622 | { |
| 624 | /* FIXME: This function should return bool because it can fail. */ | ||
| 625 | MODULE_FUNCTION_BEGIN (); | 623 | MODULE_FUNCTION_BEGIN (); |
| 626 | Lisp_Object lisp = value_to_lisp (uptr); | 624 | Lisp_Object lisp = value_to_lisp (uptr); |
| 627 | CHECK_USER_PTR (lisp); | 625 | CHECK_USER_PTR (lisp); |
| @@ -640,7 +638,6 @@ check_vec_index (Lisp_Object lvec, ptrdiff_t i) | |||
| 640 | static void | 638 | static void |
| 641 | module_vec_set (emacs_env *env, emacs_value vec, ptrdiff_t i, emacs_value val) | 639 | module_vec_set (emacs_env *env, emacs_value vec, ptrdiff_t i, emacs_value val) |
| 642 | { | 640 | { |
| 643 | /* FIXME: This function should return bool because it can fail. */ | ||
| 644 | MODULE_FUNCTION_BEGIN (); | 641 | MODULE_FUNCTION_BEGIN (); |
| 645 | Lisp_Object lvec = value_to_lisp (vec); | 642 | Lisp_Object lvec = value_to_lisp (vec); |
| 646 | check_vec_index (lvec, i); | 643 | check_vec_index (lvec, i); |
| @@ -659,7 +656,6 @@ module_vec_get (emacs_env *env, emacs_value vec, ptrdiff_t i) | |||
| 659 | static ptrdiff_t | 656 | static ptrdiff_t |
| 660 | module_vec_size (emacs_env *env, emacs_value vec) | 657 | module_vec_size (emacs_env *env, emacs_value vec) |
| 661 | { | 658 | { |
| 662 | /* FIXME: Return a sentinel value (e.g., -1) on error. */ | ||
| 663 | MODULE_FUNCTION_BEGIN (0); | 659 | MODULE_FUNCTION_BEGIN (0); |
| 664 | Lisp_Object lvec = value_to_lisp (vec); | 660 | Lisp_Object lvec = value_to_lisp (vec); |
| 665 | CHECK_VECTOR (lvec); | 661 | CHECK_VECTOR (lvec); |