diff options
| author | Paul Eggert | 2011-06-19 11:40:02 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-06-19 11:40:02 -0700 |
| commit | 35016e9a4e2fe3b60cbadd94a1a2feaed8aa1484 (patch) | |
| tree | 6472af38a1e3de1508ac14f8714db688561d91e5 /src | |
| parent | 3d1e65a18ae5d6e0496f70712c693ae692749918 (diff) | |
| download | emacs-35016e9a4e2fe3b60cbadd94a1a2feaed8aa1484.tar.gz emacs-35016e9a4e2fe3b60cbadd94a1a2feaed8aa1484.zip | |
* callproc.c (child_setup): Rewrite to avoid two strlen calls.
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 2 | ||||
| -rw-r--r-- | src/callproc.c | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index b843dfc6965..bcf40a4e470 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,7 @@ | |||
| 1 | 2011-06-19 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-06-19 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | * callproc.c (child_setup): Rewrite to avoid two strlen calls. | ||
| 4 | |||
| 3 | * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT. | 5 | * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT. |
| 4 | We prefer signed integers, even for size calculations. | 6 | We prefer signed integers, even for size calculations. |
| 5 | 7 | ||
diff --git a/src/callproc.c b/src/callproc.c index fae47b7a699..12621c90db5 100644 --- a/src/callproc.c +++ b/src/callproc.c | |||
| @@ -1230,8 +1230,7 @@ child_setup (int in, int out, int err, register char **new_argv, int set_pgrp, L | |||
| 1230 | 1230 | ||
| 1231 | if (STRINGP (display)) | 1231 | if (STRINGP (display)) |
| 1232 | { | 1232 | { |
| 1233 | int vlen = strlen ("DISPLAY=") + strlen (SSDATA (display)) + 1; | 1233 | char *vdata = (char *) alloca (sizeof "DISPLAY=" + SBYTES (display)); |
| 1234 | char *vdata = (char *) alloca (vlen); | ||
| 1235 | strcpy (vdata, "DISPLAY="); | 1234 | strcpy (vdata, "DISPLAY="); |
| 1236 | strcat (vdata, SSDATA (display)); | 1235 | strcat (vdata, SSDATA (display)); |
| 1237 | new_env = add_env (env, new_env, vdata); | 1236 | new_env = add_env (env, new_env, vdata); |